516 Commits

Author SHA1 Message Date
Kaushik Iska
d8604b1700
[fuchsia] Remove log dumping to prevent timeouts (#18409)
See: https://github.com/flutter/flutter/issues/57273
2020-05-14 21:10:49 -07:00
Kaushik Iska
fe7d6e06d9
Add ocmock to iOS unit tests xcode project (#18396) 2020-05-14 19:42:02 -07:00
godofredoc
ee2c9df4cf
Disable flow tests. (#18405)
seems like flow tests are leaving devices in a bad state.
2020-05-14 19:04:10 -07:00
godofredoc
aaf9e79f1d
Re-enable Fuchsia tests (#18392)
This reverts commit ae2222f47e788070c09020311b573542b9706a78.
2020-05-14 14:56:14 -07:00
Jason Simmons
dc93db5ab8
Move FlutterLoader disk I/O to a background thread to comply with Android strict mode (#18241) 2020-05-13 14:17:03 -07:00
Emmanuel Garcia
480d8e458f
Fix scenario platform view tests on Android (#18332) 2020-05-13 13:33:38 -07:00
Kaushik Iska
ae2222f47e
Revert "Re-enable Fuchsia tests (#18342)" (#18345)
This reverts commit efdc0994a064160d4331c5ec89e24e5ac4a7f641.
2020-05-13 10:21:25 -07:00
Kaushik Iska
efdc0994a0
Re-enable Fuchsia tests (#18342)
Co-authored-by: Kaushik Iska <kaushikiska@google.com>
2020-05-13 09:21:34 -07:00
Kaushik Iska
2f8495a5e6
Completely disable paving the device on Fuchsia (#18340) 2020-05-13 07:42:22 -07:00
Kaushik Iska
f6d3e7f21c
Disable all fuchsia tests temporarily (#18326) 2020-05-12 17:31:50 -07:00
Kaushik Iska
a6baef146d
Disable flow tests on Fuchsia (#18323) 2020-05-12 16:36:42 -07:00
Kaushik Iska
6689481c4e
Temporarily disabling the fuchsia shell, runtime tests (#18319)
see: https://github.com/flutter/flutter/issues/57061
2020-05-12 15:57:36 -07:00
Marcus Tomlinson
d96f962ca2
Add new FlutterEngineAOTData argument to FlutterProjectArgs (#18146)
Added a new `FlutterEngineAOTData` argument to `FlutterProjectArgs`. Embedders can instantiate and destroy this object via the new `FlutterEngineCreateAOTData` and `FlutterEngineCollectAOTData` methods provided.

If an embedder provides more than one source of AOT data to `FlutterEngineInitialize` or `FlutterEngineRun` (e.g. snapshots as well as `FlutterEngineAOTData`), the engine will error out.

Resolves: https://github.com/flutter/flutter/issues/50778
2020-05-10 10:24:56 -07:00
Emmanuel Garcia
a59f0bdabe
Add support for screenshot testing in the scenario app on Android (#18115) 2020-05-09 10:34:55 -07:00
liyuqian
28d99854a6
Reland again "Remove layer integral offset snapping #17112" (#18160)
This reverts commit a7a25d3b57f2066798ef8cd43600588e4697c9cd and relands our reland https://github.com/flutter/engine/pull/17915.

Additionally, we fixed the cull rect logic in `OpacityLayer::Preroll` which is  the root cause of https://github.com/flutter/flutter/issues/56298. We've always had that root problem before but it did not trigger performance issues because we were using the OpacityLayer's `paint_bounds`, instead of its child's `paint_bounds` for preparing the layer raster cache. A correct handling of the cull rect should allow us to cull at any level.

It also turns out that our ios32 (iPhone4s) performacne can regress a lot
without snapping. My theory is that although the picture has a
fractional top left corner, many drawing operations inside the picture
have integral coordinations. In older hardwares, keeping those
coordinates integral seems to be performance critical.

To avoid flutter/flutter#41654, the snapping
will still be disabled if the matrix has non-scale-translation
transformations.
2020-05-07 17:19:30 -07:00
Robert Ancell
805a8874cb
Add first Linux shell tests (#18159) 2020-05-06 15:33:11 +12:00
liyuqian
a7a25d3b57
Revert again "Remove layer integral offset snapping" (#18132) 2020-05-04 16:39:03 -07:00
liyuqian
4e2973633d
Reland "Remove layer integral offset snapping" (#17915)
This reverts commit b5aedb3 and relands #17712.

Fixes flutter/flutter#53288 and flutter/flutter#41654.

Together with #17791, this reland addresses some of Jim's concerns in the original PR #17712.

The major part of this PR is still the same as the original PR, and the performance / golden image impacts should be the same.
2020-05-01 15:01:42 -07:00
Emmanuel Garcia
7d9bd5ce5a
Populate window.locale in Dart (#18043) 2020-04-29 19:24:16 -07:00
xster
bd5234780e
skip TextSemanticsFocusTest for flake (#18015) 2020-04-28 16:00:37 -07:00
gaaclarke
103c9c78fc
Bumped up the timeout for testAccessibilityFocusOnTextSemanticsProducesCorrectIosViews (#17988)
* Bumped up the timeout for testAccessibilityFocusOnTextSemanticsProducesCorrectIosViews

* ran formatter

* made an alternative version of the assertion

* removed log statements, seems to mess with the buildbot's xcpretty
2020-04-27 23:53:22 -07:00
godofredoc
027eff8b19
Reenable flutter scenic test to identify crashes and follow up on fixes. (#17979) 2020-04-27 15:14:04 -07:00
Emmanuel Garcia
eed05dd00d
Add initial unit tests for the android embedding (#17921) 2020-04-26 20:45:28 -07:00
xster
2589d07ee9
Fix accessibility focus loss when first focusing on text field (#17803) 2020-04-24 15:44:54 -07:00
godofredoc
e83f30c590
Pass amber-files directory to tests. (#17815)
* Pass amber-files directory to tests.

Bug:
  https://github.com/flutter/flutter/issues/50249
  https://github.com/flutter/flutter/issues/55165

* Redirect tar stdout to dev/null and fix param name.

* Keep scenic tests disabled.
2020-04-21 18:54:21 -07:00
Gary Qian
8dc91229b4
PlatformResolvedLocale localization message channel (#17755) 2020-04-21 15:34:44 -07:00
Brian Osman
68800a2700
Remove legacy version of SkCanvas::didConcat44 (#17828)
Builds flags have been switched, so the old versions aren't needed any
longer.
2020-04-21 08:46:57 -04:00
Brian Osman
fb208b486e
Convert semantics_node from SkMatrix44 to SkM44 (#17763)
* Convert semantics_node from SkMatrix44 to SkM44
2020-04-17 07:24:40 -04:00
Brian Osman
1cf1a5882d
Guard canvas virtuals so we can remove legacy didConcat44 (#17756)
* Guard canvas virtuals so we can remove legacy didConcat44

SkMatrix44 is also deprecated, so start transitioning to SkM44.

* Fix formatting
2020-04-16 13:40:22 -04:00
gaaclarke
3791f0bc8c
Added some tests after the fact for #17499 (#17714) 2020-04-15 11:52:52 -07:00
godofredoc
7720ae7dd7
Updates to use predefined keys. (#17716)
* Updates to use predefined keys.

It starts using:
  * timeouts for paving.
  * timeouts for ssh commands.
  * timeouts for tests.

https://github.com/flutter/flutter/issues/54416

* Update key location and autogenerate public key.

* Use ssh-keygen instead of openssl.

* Fix typo on test name.
2020-04-14 18:29:13 -07:00
Alexander Aprelev
053da38449
In tests run dart code on ui(rather than on platform) thread. (#17686) 2020-04-13 16:50:11 -07:00
gaaclarke
61ec840edd
Made it so unit tests can be written against all ios engine code. (#17624) 2020-04-13 12:34:54 -07:00
liyuqian
a8af96da66
Read SkSLs from asset (#17601)
Fixes https://github.com/flutter/flutter/issues/53117

Test added:
- ShellTest.CanLoadSkSLsFromAsset
2020-04-10 00:16:33 -07:00
gaaclarke
1c6934eaad
Enabled hiding the home indicator with SystemChrome.setEnabledSystemUIOverlays (#17574) 2020-04-09 09:43:38 -07:00
Dan Field
0726621bfa
set -e on assemble_apk.sh (#17588)
* set -e on assemble_apk.sh

* build the necessary artifacts
2020-04-08 14:52:14 -07:00
godofredoc
e7e4633613
Add logs between fuchsia test steps. (#17584)
* Add logs between fuchsia test steps.

Adding logs and date time in between steps will simplify finding the
steps that are failing during the fuchsia tests.

https://github.com/flutter/flutter/issues/54253

* Use date command instead of DATE..

* Remove extra log line.

* Same spacer lenght for all the log lines.
2020-04-08 12:50:17 -07:00
Emmanuel Garcia
1b48463bf3
Change the directory to the scenario app (#17583) 2020-04-08 08:40:04 -07:00
LongCatIsLooong
e59543708d
iOS UITextInput autocorrection prompt (#13959) 2020-04-07 14:45:59 -07:00
stuartmorgan
08ae3bb63e
Remove JSON codec from C++ client wrapper (#17312)
The JSON codec is awkward to use in the wrapper (since the client has to build and link one of the JSON libraries to do so). Since it would be very cumbersome to wrap in a C API, and there's essentially no reason to use it instead of the standard codec, this removes it from the wrapper entirely.

Since some system channels (internal to the engine) still use it, it's moved into common/cpp instead of being eliminated entirely. Internally we always use RapidJSON though, so the jsoncpp implementation is removed. Also adds some unit test coverage, since there wasn't any.

Fixes #30669
2020-04-02 14:57:46 -07:00
Dan Field
ff62dec5c9
Roll to clang11, mark 4 (#17483)
* "Reland Clang 11, roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c, take 4 (#17467)" (#17482)"

This reverts commit 8166a91bca11b83c16fba8f8fd407e937a2ac89c.

* format code

* Roll buildroot to 3a27de1c5bb0f50be7d3efe3e00de4f6068c9f30
2020-04-02 13:04:49 -07:00
Dan Field
3002e25eb4
Initialize locale from FlutterEngine (#17473)
* Initialize locale from FlutterEngine
2020-04-02 10:06:06 -07:00
Dan Field
8166a91bca
Revert "Reland Clang 11, roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c, take 3 (#17467)" (#17482)
This reverts commit 39b77188c5425925a72fe0a64d246dbc0b3cdadc.
2020-04-02 10:01:26 -07:00
Dan Field
39b77188c5
Reland Clang 11, roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c, take 3 (#17467)
* Reland Clang 11, Roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c (#17457)" (#17464)

This reverts commit 9eacd028cdba5c6efef327342dc53fab61474462.

* Skip more image tests, use newer dsymutil, add missing symbols
2020-04-01 20:55:27 -07:00
liyuqian
a82343befa
Add build_and_test_linux_release presubmit test (#17073) 2020-04-01 18:46:04 -07:00
Dan Field
9eacd028cd
Revert "Reland Clang 11, Roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c (#17457)" (#17464)
This reverts commit a4026cc9f16a93fbce6c94af3ddaf971d363c195.
2020-04-01 17:50:57 -07:00
Dan Field
a4026cc9f1
Reland Clang 11, Roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c (#17457)
* Reland "Roll Clang to v11, roll buildroot to fe13f79dce4ce9aab3209f11988d825dcf580b4a, allow newly exported symbols (#17440)" (#17451)"

This reverts commit a870bc533c5bce9526563c3d2f40370e450b85f6.

* skip golden that is different on macos

* buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c
2020-04-01 16:32:13 -07:00
Dan Field
a870bc533c
Revert "Roll Clang to v11, roll buildroot to fe13f79dce4ce9aab3209f11988d825dcf580b4a, allow newly exported symbols (#17440)" (#17451)
This reverts commit 8d723aeb0a428df2ff7950723ca615fdf9acdf1d.
2020-04-01 11:06:07 -07:00
Dan Field
8d723aeb0a
Roll Clang to v11, roll buildroot to fe13f79dce4ce9aab3209f11988d825dcf580b4a, allow newly exported symbols (#17440)
* Buildroot to fe13f79dce4ce9aab3209f11988d825dcf580b4a

* whitelist more symbols
2020-04-01 10:49:24 -07:00
Brian Osman
c9506cb8e9
Finish removing deprecated SkCanvas virtuals (#17445)
API staging is complete - these defines have been removed.
2020-04-01 10:27:50 -04:00