20828 Commits

Author SHA1 Message Date
Michael Goderbauer
c545a799d2 Remove unnecessary null checks (flutter/engine#39113) 2023-01-25 10:15:02 -08:00
skia-flutter-autoroll
a5500ec179 Roll Fuchsia Linux SDK from E9m-Gk382PkB7_Nbp... to pGX7tanT1okL8XCg-... (flutter/engine#39130)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-25 17:01:10 +00:00
Zachary Anderson
daeb8316d7 Only build analyze_snapshot on Linux host (flutter/engine#39129) 2023-01-25 08:35:57 -08:00
skia-flutter-autoroll
d15e4fe71f Roll Skia from da5034f9d117 to c4b171fe5668 (1 revision) (flutter/engine#39127)
https://skia.googlesource.com/skia.git/+log/da5034f9d117..c4b171fe5668

2023-01-25 ccameron@chromium.org Add SkJpegGainmapEncoder::EncodeJpegR and EncodeHDRGM

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC nicolettep@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-25 15:47:02 +00:00
Jonah Williams
6347667c37 [web] use a render target instead of a new surface for Picture.toImage (flutter/engine#38573)
* [web] use a render target instead of a new surface for Picture.toImage

* setup grcontext if missing

* ++

* dispose

* Add unit test for MakeRenderTarget

* ++

* ++

* ++

* ++

* ++

* ++

* ++
2023-01-25 15:09:01 +00:00
skia-flutter-autoroll
a891ed0e8a Roll Skia from 8ffd5c20d634 to da5034f9d117 (4 revisions) (flutter/engine#39123)
https://skia.googlesource.com/skia.git/+log/8ffd5c20d634..da5034f9d117

2023-01-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 9a72a98eb94f to 660e4a7c0d4f (4 revisions)
2023-01-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from c744a23d77d5 to bb0229002db5 (5 revisions)
2023-01-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d7a3d7db7fde to 8666a7bf5e4a (8 revisions)
2023-01-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ab6fd1e74de0 to 71bd1907ea2f (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC nicolettep@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-25 11:07:20 +00:00
skia-flutter-autoroll
e83ee7ac4d Roll Skia from b72fececbdcc to 8ffd5c20d634 (3 revisions) (flutter/engine#39114)
https://skia.googlesource.com/skia.git/+log/b72fececbdcc..8ffd5c20d634

2023-01-24 armansito@google.com [sksl][wgsl] Support for trivial ternary expressions
2023-01-24 johnstiles@google.com Create a BranchCtx for Raster Pipeline branch ops.
2023-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from f0d8edecee77 to c744a23d77d5 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC nicolettep@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-25 01:53:11 +00:00
Brandon DeRosier
b0f65d819f [Impeller] Linear sample atlas glyphs when the CTM isn't translation/scale only (flutter/engine#39112) 2023-01-24 17:27:44 -08:00
Loïc Sharma
6de1c715fb Manually roll ANGLE, vulkan-deps, SwiftShader (flutter/engine#38650) 2023-01-25 00:53:25 +00:00
Brandon DeRosier
bc595eefcf [Impeller] Switch to nearest sampling for the text atlas (flutter/engine#39104) 2023-01-24 16:00:37 -08:00
skia-flutter-autoroll
de54114b00 Roll Skia from 1bc48bcb1201 to b72fececbdcc (14 revisions) (flutter/engine#39108)
https://skia.googlesource.com/skia.git/+log/1bc48bcb1201..b72fececbdcc

2023-01-24 nicolettep@google.com Roll Dawn from 6c8aa8aff9d1 to f0d8edecee77 (6 revisions)
2023-01-24 jmbetancourt@google.com remove skottie from Android.bp
2023-01-24 jlavrova@google.com Reland "Correct ParagraphBuilder::getText() behavior"
2023-01-24 bungeman@google.com Allow SK_TRIVIAL_ABI to be configured
2023-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a2f348c2039f to ab6fd1e74de0 (4 revisions)
2023-01-24 nicolettep@google.com Roll Dawn from ffe356d558bc to 6c8aa8aff9d1 (12 revisions)
2023-01-24 jlavrova@google.com Reland "Add setters for providing client info to SkParagraphBuilder"
2023-01-24 kyslov@google.com jpegr codec: Implement scanline decoding and sampling
2023-01-24 herb@google.com Rename SkAutoFree -> UniqueVoidPtr and move to private
2023-01-24 robertphillips@google.com [graphite] Add unit test for makeColorTypeAndColorSpace
2023-01-24 ccameron@chromium.org SkJpegSegmentScanner: Use state-machine based scan
2023-01-24 jcgregorio@google.com Add recovery steps for scaling and disabling cpu cores.
2023-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f93afca731ce to a2f348c2039f (3 revisions)
2023-01-24 stililiev@gmail.com Fix correctness issue with SkImageImageFilter and unpremul images

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC nicolettep@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-24 23:59:12 +00:00
skia-flutter-autoroll
26b1f891bf Roll Fuchsia Linux SDK from dWbkAZchFHtZE9Wt_... to E9m-Gk382PkB7_Nbp... (flutter/engine#39107)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-24 23:36:54 +00:00
Loïc Sharma
3119b5c02b Improve crashes if messenger APIs are used incorrectly (flutter/engine#39041)
* Clarify messenger APIs

* Feedback
2023-01-24 23:22:51 +00:00
Chinmay Garde
69e8c2abf9 [Impeller] Add and reorder FAQ entries. (flutter/engine#39106)
* [Impeller] Add and reorder FAQ entries.

* Update impeller/docs/faq.md

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2023-01-24 22:40:24 +00:00
Harry Terkelsen
3447ce87ad [web] Remove dependency on 'profiling' subfolder of canvaskit. (flutter/engine#38169) 2023-01-24 14:23:20 -08:00
Jonah Williams
5f37ffb20d [Impeller] drawAtlas blend mode. (flutter/engine#38335)
* fill out drawAtlas

* ++

* add drawVertices uage

* ++

* test fixes

* dont double divide

* CI cleanups

* some texture coordinates work

* ++

* basic texture coordiantes work

* ++

* ++

* ++

* Delete color blending

* back out vertices change

* ++

* ++

* ++

* remove atlas_fill from licenses

* blending cleanup

* Use sub-contents

* fix opacity for pipeline blends

* use alpha in snapshot to avoid extra pass

* ++

* ++

* fix order
2023-01-24 22:01:24 +00:00
skia-flutter-autoroll
3892826c2a Roll Skia from 90fda2e72314 to 1bc48bcb1201 (4 revisions) (flutter/engine#39100)
https://skia.googlesource.com/skia.git/+log/90fda2e72314..1bc48bcb1201

2023-01-24 brianosman@google.com Actually fail when we get conflicting marker counts in JPEG
2023-01-24 jvanverth@google.com Add Stan I to AUTHORS and sort list.
2023-01-24 herb@google.com Remove unused method: findOrCreateTextStrike
2023-01-24 bungeman@google.com Roll FreeType from ebe7e912 to 82ce1726 (15 commits)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC nicolettep@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-24 19:28:09 +00:00
Ahmed Ashour
51c0a9ec65 Remove superfluous words from comments (flutter/engine#39068)
* Remove superfluous words.

* Format

* Duplicate in consecutive lines.
2023-01-24 09:54:19 -08:00
Daco Harkes
59ca77bd1e Migrate @FfiNative to @Native (flutter/engine#39034) 2023-01-24 11:39:19 +00:00
Martin Kustermann
a607bb8bce Add mmap dependency to flutter_frontend_server (flutter/engine#39090)
In a follow-up change in Dart SDK, package:compiler (a dependency of
flutter_frontend_server) will start using package:mmap
2023-01-24 09:35:05 +01:00
skia-flutter-autoroll
4ff7444e15 Roll Skia from 50d78376d30c to 90fda2e72314 (4 revisions) (flutter/engine#39089)
https://skia.googlesource.com/skia.git/+log/50d78376d30c..90fda2e72314

2023-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3b27647cb9f8 to 9a72a98eb94f (8 revisions)
2023-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 38d1dfe4578d to d7a3d7db7fde (4 revisions)
2023-01-24 armansito@google.com [sksl][wgsl] Global GL-style uniforms
2023-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ada6bd70c604 to f93afca731ce (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC kaushikiska@google.com,nicolettep@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-24 07:47:23 +00:00
skia-flutter-autoroll
4df46fc0fe Roll Skia from 0328e12ab195 to 50d78376d30c (3 revisions) (flutter/engine#39086)
https://skia.googlesource.com/skia.git/+log/0328e12ab195..50d78376d30c

2023-01-24 armansito@google.com [sksl] Prevent assignments to pipeline input variables
2023-01-24 bungeman@google.com Improve Serialization_Typeface error message
2023-01-23 johnstiles@google.com Add RP codegen support for matrix-op-scalar.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC kaushikiska@google.com,nicolettep@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-24 04:17:32 +00:00
Michael Goderbauer
92873c01f0 Fix doc analyzer breakage (flutter/engine#39082) 2023-01-24 02:46:24 +00:00
Constantine Shablya
a38bdae396 [embedder] Fix getting vkGetInstanceProcAddr (flutter/engine#39051) 2023-01-24 01:22:38 +00:00
skia-flutter-autoroll
1e2b091c78 Roll Skia from 1ccf2093cfa9 to 0328e12ab195 (59 revisions) (flutter/engine#39078)
https://skia.googlesource.com/skia.git/+log/1ccf2093cfa9..0328e12ab195

2023-01-23 johnstiles@google.com Fix errors with non-square matrix multiplication.
2023-01-23 herb@google.com Move traits to .cpp for SkStrikeCache
2023-01-23 johnstiles@google.com Revert "Add workaround for Android roll."
2023-01-23 johnstiles@google.com Add matrix-multiply support to RP codegen.
2023-01-23 herb@google.com Rename fMu -> FStrikeLock
2023-01-23 ccameron@chromium.org SkJpegCodec: Add HDRGM support
2023-01-23 herb@google.com Remove accessor to the scalerContext on SkStrike
2023-01-23 jvanverth@google.com Add SkMatrixPriv::NearlyAffine.
2023-01-23 jvanverth@google.com Remove SK_LEGACY_MATRIX_MATH_ORDER
2023-01-23 johnstiles@google.com Replace push_literal(0) with push_zeros in the instruction stream.
2023-01-23 robertphillips@google.com [graphite] Implement Graphite-specific onMakeColorTypeAndColorSpace methods
2023-01-23 kjlubick@google.com Reland "[base] Make Bazel target and enforce IWYU"
2023-01-23 brianosman@google.com Replace bespoke 'saturate' with 'std::min'
2023-01-23 herb@google.com Move dump and stats to SkStrike
2023-01-23 brianosman@google.com For testing, support file and memory streams of files
2023-01-23 johnstiles@google.com Fix errors on tree.
2023-01-23 lehoangquyen@chromium.org [graphite-dawn] Correctly calculate num textures for pipeline's layout
2023-01-23 armansito@google.com [graphite] Fix assignment to pipeline inputs in AnalyticRRectRenderStep
2023-01-23 johnstiles@google.com Optimize pushing duplicates of 0.
2023-01-23 johnstiles@google.com Simplify masked stores when the execution mask is known.
2023-01-23 johnstiles@google.com Simplify branches when the execution mask is known.
2023-01-23 johnstiles@google.com Track the state of the execution mask in Builder.
2023-01-23 robertphillips@google.com [graphite] Update some GMs to work w/ Graphite
2023-01-23 kjlubick@google.com Roll Dawn from 785ccde2f588 to ffe356d558bc (15 revisions)
2023-01-23 johnstiles@google.com Add support for intrinsic radians()/degrees() in RP codegen.
2023-01-23 michaelludwig@google.com [graphite] Enable AnalyticRRectRenderStep for all rects and fill/hairline rrects
2023-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 2ef45d764ab2 to 38d1dfe4578d
2023-01-23 armansito@google.com [sksl][wgsl] Struct type and global variable declarations
2023-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 920ae225a641 to 38d1dfe4578d (1 revision)
2023-01-23 johnstiles@google.com Add workaround for Android roll.
2023-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from fabf70586d95 to ada6bd70c604 (10 revisions)
2023-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c98a413c3ea7 to 3b27647cb9f8 (8 revisions)
2023-01-21 fmalita@chromium.org Manual revert "[base] Make Bazel target and enforce IWYU"
2023-01-20 herb@google.com Merge SkScalerCache into SkStrike
2023-01-20 kjlubick@google.com Extract the double-precision cubic and quad solving code to base.
2023-01-20 jvanverth@google.com [graphite] Enable contextOptions flag for readPixels during testing Dawn
2023-01-20 kjlubick@google.com Add tests for SkDCubic::chopAt
2023-01-20 johnstiles@google.com Allow sqrt() to have a small margin of error.
2023-01-20 lovisolo@google.com Update IntelIris540 tasks to target GPU driver version 31.0.101.2115.
2023-01-20 johnstiles@google.com Add peephole optimizations to constant assignment.
2023-01-20 johnstiles@google.com Combine contiguous zero_slot_unmasked slot ranges.
2023-01-20 kjlubick@google.com [config] Make SK_API configurable from SkUserConfig
2023-01-20 johnstiles@google.com Add support for sqrt() to RP codegen.
2023-01-20 michaelludwig@google.com [graphite] Support hairlines/subpixel fills/strokes in AnalyticRoundRectRenderStep
2023-01-20 brianosman@google.com In legacy 8888 sprite blitters, use saturating adds
2023-01-20 kjlubick@google.com [base] Make Bazel target and enforce IWYU
2023-01-20 johnstiles@google.com Add RP codegen support for sin/cos/tan.
2023-01-20 johnstiles@google.com Add RP builder support for sin/cos/tan/sqrt.
2023-01-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 37a74218c401 to fabf70586d95 (4 revisions)
2023-01-20 johnstiles@google.com Use a return mask only where it is required.
2023-01-20 johnstiles@google.com Migrate GetReturnComplexity out of Inliner and into Analysis.
2023-01-20 robertphillips@google.com [graphite] Plumb new Graphite-specific version of two SkImage APIs
2023-01-20 herb@google.com Have SkStrikeCache.h load the SkUserConfig.h
2023-01-20 johnstiles@google.com Implement boolean-logic ops in RP codegen.
2023-01-20 ccameron@chromium.org ColorSpaceXformColorFilter: Fix leak
2023-01-20 kjlubick@google.com Replace SkDCubeRoot with std::cbrt
2023-01-20 ccameron@chromium.org SkGainmapShader: Use makeRawShader
2023-01-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e960355a9a22 to c98a413c3ea7 (5 revisions)
2023-01-20 jvanverth@google.com Add perspective text GM.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC kaushikiska@google.com,nicolettep@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-24 00:48:24 +00:00
Justin McCandless
68a06f0764 Ability to disable browser context menu (flutter/engine#38682)
Adds platform channel methods that disable/enable the context menu on web.
2023-01-23 16:11:13 -08:00
Jonah Williams
ce8689639f [Impeller] uniform offsets account for size (flutter/engine#39077)
* uniform offsets account for size

* re-arrange fixtures
2023-01-23 22:24:33 +00:00
skia-flutter-autoroll
3bcf86d2aa Roll Skia from f6a5c806294d to 1ccf2093cfa9 (2 revisions) (flutter/engine#39028)
https://skia.googlesource.com/skia.git/+log/f6a5c806294d..1ccf2093cfa9

2023-01-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d27950c1863f to 920ae225a641 (7 revisions)
2023-01-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 7e02157df528 to 785ccde2f588 (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC fmalita@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-23 14:49:29 -06:00
Michael Goderbauer
bc1c7e6cfa Remove unnecessary null checks in doc snippet (flutter/engine#39071) 2023-01-23 20:43:22 +00:00
Mouad Debbar
105bb9ab43 [web] Build multiple CanvasKit variants (using toolchain_args) (flutter/engine#38448)
* [web] New gn for building CanvasKit

* Use toolchain_args to override CanvasKit gn args

* Use correct path for the generated canvaskit files

* Put toolchain close to target

* remove extra toolchains

* remove extra import

* add canvaskit_lite to archive

* fix local canvaskit path in tests

* add some guards using visibility and asserts

* renames

* formatting

* rename mistake

* Add github issue to the TODO

* Update buildroot sha

* clang-tidy error

* skip canvaskit targets when not needed
2023-01-23 20:37:18 +00:00
dependabot[bot]
e5a84c1c94 Bump github/codeql-action from 2.1.38 to 2.1.39 (flutter/engine#39065)
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.38 to 2.1.39.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](515828d974...a34ca99b46)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-01-23 09:33:34 +00:00
Todd Volkert
2363e70858 Add more flexible image loading API (flutter/engine#38905)
* Add more flexible image loading API

This adds a new `instantiateImageCodecWithSize` method, which can be
used to decode an image into a size, where the target size isn't known
until the caller is allowed to inspect the image descriptor.

This enables the use case of loading an image whose aspect ratio isn't
known at load time, and which needs to be resized to fit within a
bounding box while also maintaining its original aspect ratio.

https://github.com/flutter/flutter/issues/118543

* Add test

* Fixed test failure

* Update

* Respond to review comments

* Add web implementation

* Fixed typo

* Review comments

Also changed the TargetImageSizeCallback to just take intrinsic
width & height, rather than the full image descriptor.

* Forgot to remove the _SizeOnlyImageDescriptor class - it's no longer needed

* Forgot to update test
2023-01-23 01:48:24 +00:00
skia-flutter-autoroll
22fd738b28 Roll Fuchsia Linux SDK from S6wQW1tLFe-YnReaZ... to l3c_b-vRr-o6ZFX_M... (flutter/engine#39055)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-22 05:40:24 +00:00
skia-flutter-autoroll
c85bac08f9 Roll Fuchsia Linux SDK from rPo4_TYHCtkoOfRup... to S6wQW1tLFe-YnReaZ... (flutter/engine#39048)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-21 10:06:18 +00:00
Chris Yang
353f0b5b32 [ios_platform_view] MaskView pool to reuse maskViews. (flutter/engine#38989)
* reuse maskView

reuse mask view

format

format

draft

draft

fixes

test

* comments

* fix comment

* test for releasing maskView

* updates

* fix
2023-01-21 04:26:04 +00:00
Jonah Williams
c2fc005e0f [impeller] correct input order in ColorFilterContents::MakeBlend (flutter/engine#39038) 2023-01-20 22:22:17 +00:00
skia-flutter-autoroll
2f075746f0 Roll Dart SDK from ac4c63168ff2 to 03d35455a8d8 (1 revision) (flutter/engine#39036)
https://dart.googlesource.com/sdk.git/+log/ac4c63168ff2..03d35455a8d8

2023-01-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-147.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-20 20:13:22 +00:00
Ben Konyi
002fce29e0 Revert "Remove references to Observatory (#38919)" (flutter/engine#39035)
Reason for revert: breaking Flutter -> plugins roll

This reverts commit 1f603711c7b7afe52dff3872a5035789e3ddba02.
2023-01-20 12:33:40 -05:00
Bruno Leroux
258cde6cd2 [macos] Synthesize modifier keys events on pointer events (flutter/engine#37870)
* [macos] Synthesize modifier keys events on pointer events

* Move test to FlutterViewControllerTest

* Simplify by using 'for in'

Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
2023-01-20 10:43:16 +00:00
skia-flutter-autoroll
ed344b85d5 Roll Dart SDK from ddf70a598f27 to fbbfc122dba6 (9 revisions) (flutter/engine#39029)
https://dart.googlesource.com/sdk.git/+log/ddf70a598f27..fbbfc122dba6

2023-01-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-145.0.dev
2023-01-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-144.0.dev
2023-01-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-143.0.dev
2023-01-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-142.0.dev
2023-01-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-141.0.dev
2023-01-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-140.0.dev
2023-01-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-139.0.dev
2023-01-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-138.0.dev
2023-01-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-137.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-20 09:57:27 +00:00
skia-flutter-autoroll
e0888e2c75 Roll Skia from 1b3aa8b6e1cc to f6a5c806294d (11 revisions) (flutter/engine#39027)
https://skia.googlesource.com/skia.git/+log/1b3aa8b6e1cc..f6a5c806294d

2023-01-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 3e5659852fc3 to dddaffde005d
2023-01-20 herb@google.com Remove getUnderlyingStrike
2023-01-20 michaelludwig@google.com [graphite] Enable AnalyticRRectRenderStep for fills
2023-01-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 823d1a0d7c30 to 37a74218c401 (10 revisions)
2023-01-20 johnstiles@google.com Build all outputs when skia_compile_sksl_tests is enabled.
2023-01-20 herb@google.com Remove SkAutoSTArray and SkAutoSTMalloc
2023-01-20 herb@google.com Rename SkAutoSTArray -> AutoSTArray and move to skia_private
2023-01-20 ccameron@chromium.org Add SkGainmapShader
2023-01-20 weiyuhuang@google.com Fix line formatting when maxWidth == INF && align == kJustify && textDirection == kLtr
2023-01-20 johnstiles@google.com Eliminate unnecessary return-mask operations.
2023-01-20 ccameron@chromium.org Change SkSRGBGammaColorFilter to SkColorSpaceXformColorFilter

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC fmalita@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-20 06:57:23 +00:00
Chris Bracken
1dd1f02bc4 Extract WideToUTF16String/UTF16StringToWide to FML (flutter/engine#39020) 2023-01-19 22:55:47 -08:00
skia-flutter-autoroll
1193c711f4 Roll Skia from aedfc8695954 to 1b3aa8b6e1cc (43 revisions) (flutter/engine#39024)
https://skia.googlesource.com/skia.git/+log/aedfc8695954..1b3aa8b6e1cc

2023-01-19 kjlubick@google.com [base] Move more files into base
2023-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from bf5a007afc1f to e960355a9a22 (7 revisions)
2023-01-19 robertphillips@google.com Manual Dawn roll from e1ad5c39e1d7 to 7e02157df528 (9 revisions)
2023-01-19 fmalita@google.com Revert "Add setters for providing client info to SkParagraphBuilder"
2023-01-19 jlavrova@google.com Revert "Correct ParagraphBuilder::getText() behavior"
2023-01-19 kjlubick@google.com Make SK_API visible to user config file
2023-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bd5634fbaca7 to 823d1a0d7c30 (9 revisions)
2023-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 5d1ac2e0d5f6 to bf5a007afc1f (10 revisions)
2023-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from a42938f058cb to d27950c1863f (4 revisions)
2023-01-18 jsimmons@google.com Fix an off-by-one in the max index passed to glDrawRangeElements by DrawMeshOp
2023-01-18 bungeman@google.com Allow SkUserConfig.h to override SkAttributes.h
2023-01-18 jlavrova@google.com Correct ParagraphBuilder::getText() behavior
2023-01-18 jvanverth@google.com [graphite] Have onMakeSubset and onMakeTextureImage share code
2023-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 61e7733b455d to bd5634fbaca7 (9 revisions)
2023-01-18 nscobie@google.com Move SK_CODEC_DECODES_JPEG_GAINMAPS from defines to public_defines
2023-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 9f0f02bea4b2 to 3e5659852fc3
2023-01-18 mdebbar@google.com Add setters for providing client info to SkParagraphBuilder
2023-01-18 johnstiles@google.com Add RP codegen support for out/inout parameters.
2023-01-18 herb@google.com Very small clean up in SkScalerCache
2023-01-18 johnstiles@google.com Simplify redundant pop-push pairs.
2023-01-18 johnstiles@google.com Fix stack-rewind test.
2023-01-18 kjlubick@google.com [base] Move more files into base
2023-01-18 kjlubick@google.com Remove SkMath.h from the public API
2023-01-18 johnstiles@google.com Coalesce adjacent calls to copy_stack_from_slots.
2023-01-18 johnstiles@google.com Coalesce adjacent calls to push_uniforms.
2023-01-18 johnstiles@google.com Coalesce adjacent calls to push_slots.
2023-01-18 johnstiles@google.com Eliminate pushes that are immediately discarded.
2023-01-18 jvanverth@google.com [graphite] Fix onMakeSubset optimization
2023-01-18 jlavrova@google.com Breaking down Copy ReorderVisuals (4)
2023-01-18 vichang@google.com Avoid exporting libandroidicu headers
2023-01-18 ccameron@chromium.org SkJpegCodec: Add JpegR gainmap extraction support
2023-01-18 johnstiles@google.com Generate SkRP golden outputs from test files.
2023-01-18 johnstiles@google.com Disable MatrixEquality test on Tegra3.
2023-01-18 ccameron@chromium.org SkJpegCodec: Fix compound metadata index validation
2023-01-18 bsalomon@google.com Remove SK_DISABLE_RASTER_PIPELINE_SAMPLING_FIXES
2023-01-18 johnstiles@google.com Remove dependency on SkRasterPipeline from SkOpts.
2023-01-18 kyslov@google.com jpegr codec: create color profile from ICCProfile data
2023-01-18 herb@google.com Rename SkAutoTArray -> AutoTArray and move to skia_private
2023-01-18 cmumford@google.com bazel: Add script to obtain the MacSDK symlink directory.
2023-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 685cc71cd840 to 61e7733b455d (5 revisions)
2023-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 734cf7ce212f to 5d1ac2e0d5f6 (8 revisions)
2023-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from dc43f9a8e874 to a42938f058cb (6 revisions)
2023-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from cd6104d0f0a1 to e1ad5c39e1d7 (13 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC fmalita@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-20 05:05:59 +00:00
Brandon DeRosier
c20568ed3e [Impeller] Check the correct stencil coverage when deciding whether to elide a restore (flutter/engine#39023) 2023-01-20 02:54:00 +00:00
godofredoc
aa2afcdeb5 Revert "Extract WideToUTF16String/UTF16StringToWide to FML (#39006)" (flutter/engine#39019)
This reverts commit d96d942ddc22af628e00ab958ec9860e338ce17f.
2023-01-20 00:45:58 +00:00
Chris Bracken
d96d942ddc Extract WideToUTF16String/UTF16StringToWide to FML (flutter/engine#39006)
* Extract WideToUTF16String/UTF16StringToWide to FML

In third_party/accessibility, for string conversion, we use a mix of:
* FML
* third_party/accessibility base string utility functions
* static functions local to the translation unit itself

This moves all conversions between UTF16 and wide strings to FML. Note
that this implementation is only safe on platforms where:
  * the size of wchar_t and char16_t are the same
  * the encoding of wchar_t and char16_t are both UTF-16
which is the case for Windows, hence why these functions are implemented
in a Windows-specific translation unit (wstring_conversion).

Issue: https://github.com/flutter/flutter/issues/118811

* Migrate UTF16ToWide as well
2023-01-19 23:46:59 +00:00
skia-flutter-autoroll
028e373e8d Roll Skia from 69d8378097df to aedfc8695954 (4 revisions) (flutter/engine#38966)
https://skia.googlesource.com/skia.git/+log/69d8378097df..aedfc8695954

2023-01-17 lehoangquyen@chromium.org [graphite] Fix Dawn validation error due to hasDynamicOffset=true.
2023-01-17 lehoangquyen@chromium.org [graphite] Enable depth & stencil formats' support in DawnCaps
2023-01-17 jvanverth@google.com [graphite] Create graphite::Image_Base
2023-01-17 jzern@google.com update libwebp to 1.3.0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC fmalita@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-19 23:07:12 +00:00
Robert Ancell
3b47df5adf Fix invalid Unix locale to Flutter locale (BCP-47) mapping (flutter/engine#36512)
Flutter locales use the BCP-47 format
(https://www.rfc-editor.org/rfc/bcp/bcp47.txt), and Unix locales use a POSIX
format. There is not a perfect mapping between them, see
https://wiki.openoffice.org/wiki/LocaleMapping

The current implementation is not correctly setting the appropriate optional
fields, so remove that.

There are likely some Unix locales that should set these fields, but these are
best fixed by adding special cases for them as they are discovered.

Fixes: https://github.com/flutter/flutter/issues/111341
2023-01-19 22:53:59 +00:00
Nayuta403
0626a035ce Remove unused variables and import (flutter/engine#38971) 2023-01-19 21:06:53 +00:00
Brandon DeRosier
81bc7866c9 [Impeller] Account for the transform in DLVerticesGeometry coverage (flutter/engine#38998) 2023-01-19 21:06:50 +00:00