1531 Commits

Author SHA1 Message Date
sjindel-google
c39a23f1b6 Ensure debug-mode apps are always attached on iOS. (flutter/engine#10186) 2019-08-06 01:07:33 +02:00
Nathan Rogers
436b76d9fe Use Fuchsia trace macros when targeting Fuchsia SDK (flutter/engine#10634)
When |OS_FUCHSIA| is defined (even when |FUCHSIA_SDK| is defined as
well), use the Fuchsia SDK trace macros rather than the Dart timeline.

Reasons for doing this include:

Fuchsia's trace macros support categories.  This allows one to
distinguish between (e.g.) "flutter" and "skia" trace events for trace
recording and trace visualization.

Fuchsia has existing in tree benchmarks that depend on finding certain
events under category "flutter".

See the Fuchsia performance mailing list discussion for more context.
2019-08-05 12:52:36 -07:00
Chinmay Garde
5a28c68b3c Fix threading and re-enable resource cache shell unit-tests. (flutter/engine#10636)
The rasterizer may only be accessed safely on the GPU task runner. The test was accessing the same on a non-engine known task runner instead (i.e the tests main task runner).

Crashes previously reproducible on all platforms with the following filters: `--gtest_filter="*ShellTest.SetResourceCacheSize*" --gtest_repeat=-1 --gtest_shuffle --gtest_random_seed=1988` at run ~400.

Fixes https://github.com/flutter/flutter/issues/37629
2019-08-05 12:47:30 -07:00
Kaushik Iska
fcfa19d97a [fuchsia] CloneChannelFromFD fix for system.cc (flutter/engine#10635)
This is a utils method currently not exposed from fuchsia.
Ported over from [garnet
fd.cc](https://fuchsia.googlesource.com/fuchsia/+/master/garnet/public/lib/fsl/io/fd.cc).
2019-08-05 12:05:20 -07:00
Dan Field
e9f8f66f82 skip flaky tests (flutter/engine#10633) 2019-08-05 10:22:43 -07:00
Dan Field
06e7030b0f Reland Skia Caching improvements (flutter/engine#10434) 2019-08-02 19:31:57 -07:00
Chris Bracken
5fa8fd302a Add #else, #endif condition comments (flutter/engine#10477)
Adds a few missing condition hints on some preprocessor conditionals.
2019-08-02 15:45:07 -07:00
Jason Simmons
1bc372a594 Fix deprecation warnings in the Android embedding (flutter/engine#10424) 2019-08-01 18:13:27 -07:00
Kaushik Iska
7523d23275 Make kernel compiler use host toolchain (flutter/engine#10419) 2019-08-01 12:57:03 -07:00
Kaushik Iska
527e254893 [fuchsia] Kernel compiler is now ready (flutter/engine#10309)
Also fixes the architecture of the bundled SO files.
2019-07-31 20:41:11 -07:00
Francisco Magdaleno
a05057aede [glfw] Enables replies on binary messenger in glfw embedder (flutter/engine#9948) 2019-07-31 14:27:46 -07:00
Francisco Magdaleno
85882e1bad [macos] Reland function refactor (flutter/engine#10189)
* [macos] Reland function refactor

* Fix bug
2019-07-31 10:57:02 -07:00
Dan Field
cd18c5ef0b Remove get engine (flutter/engine#9747) 2019-07-30 17:11:04 -07:00
Matt Carroll
c70c811ea2 Android Embedding Refactor 38: Removed AssetManager from DartEntrypoint. (flutter/engine#10250) 2019-07-30 12:57:01 -07:00
Kaushik Iska
1872c78afc [fuchsia] Start building dart_patched_sdk (flutter/engine#10246)
* [fuchsia] Start building dart_patched_sdk

* fix path
2019-07-30 09:57:58 -07:00
Matt Carroll
e1e57a2d94 Android Embedding PR37: Separated FlutterActivity and FlutterFragment via FlutterActivityAndFragmentDelegate (flutter/engine#9895) 2019-07-29 17:40:25 -07:00
Michael Klimushyn
efeba40734 Deprecate FlutterView#enableTransparentBackground (flutter/engine#10235)
The API breaks accessibility highlighting because of
SurfaceView#setZOrderOnTop. Deprecate it since the underlying issue is
an Android SDK one that can't be worked around from within a
SurfaceView.
2019-07-29 12:46:26 -07:00
Michael Klimushyn
0f980e5e01 Add better CIPD docs. (flutter/engine#10185)
Also commits cipd.yaml to source.
2019-07-26 15:39:48 -07:00
Kaushik Iska
92f9dac0f7 [dart_runner] dart jit runner and dart jit product runner (flutter/engine#10179)
We now build dart runner as well
2019-07-26 13:29:46 -07:00
Jonah Williams
addbc5d4cb add suggested changes from flutter roll (flutter/engine#10176) 2019-07-26 12:56:08 -07:00
Kaushik Iska
7c3360e4bf [fuchsia] Add support for aot mode in flutter runner (flutter/engine#10171)
* [fuchsia] Add support for aot mode in flutter runner

* [fuchsia] Bundle observatory with not product runners
2019-07-26 10:19:13 -07:00
Kaushik Iska
af07c640f7 [dart_runner] Rename dart to dart runner (flutter/engine#10172) 2019-07-26 10:15:08 -07:00
Kaushik Iska
e20083819a [fuchsia] Push CMX to fars and add product mode support (flutter/engine#10144)
* Capture stderr for ninja command

* br

* [fuchsia] Push CMX to fars and add product mode support.

* fix shit

* fix GN format
2019-07-25 15:09:04 -07:00
Francisco Magdaleno
3d070e1376 Revert "[macos] Revert check on FlutterCodecs and refactor message function] (#10009)" (flutter/engine#10141)
This reverts commit 471657f667d1489274fe7a414a8523e1429e4bd7.
2019-07-25 13:47:29 -07:00
gaaclarke
c3c32a1e2f ios: Fixed the callback for the first frame so that it isn't predicated on having a splash screen. (flutter/engine#9952) 2019-07-25 12:37:38 -07:00
gaaclarke
8d52ae8514 Revert "[fuchsia] Use the patched sdk to generate the flutter jit runner far (#10122)" (flutter/engine#10140)
This reverts commit 2c7cabdff9c346ac28b49044726c551c93132f3d.
2019-07-25 10:52:27 -07:00
Kaushik Iska
2c7cabdff9 [fuchsia] Use the patched sdk to generate the flutter jit runner far (flutter/engine#10122) 2019-07-24 17:10:48 -07:00
gaaclarke
60c57dbb11 Fixed memory leak with engine registrars. (flutter/engine#10068) 2019-07-24 15:43:39 -07:00
Kaushik Iska
7f9170be1f [fuchsia] Use manifest file to better replicate the existing build (flutter/engine#10102)
* Use manifest file to better replicate the existing build

Also fix app/bin error

* Add remaining shit

* patch in the remaining stuff

* Update BUILD.gn
2019-07-24 13:57:46 -07:00
Kaushik Iska
2117168f17 [fuchsia] Add sysroot and clang libs to package (flutter/engine#10082)
* [fuchsia] Add sysroot deps

* bundle in clang stuff too

* fix host_os
2019-07-23 21:08:25 -07:00
Kaushik Iska
602771c7d4 [fuchsia] Add support for libs in packages (flutter/engine#10081) 2019-07-23 19:22:42 -07:00
Kaushik Iska
99a3e1a60f One more luci fix (flutter/engine#10078)
* Missing icu data from the far

* One more place to change the artifact name

* real name
2019-07-23 17:56:49 -07:00
Kaushik Iska
27f1cc9865 Basic structure for flutter_jit_runner far (flutter/engine#10073)
* Basic structure for flutter_jit_runner far

- Added a package_dir gni that copies the dir structure.
- Doesn't support a lot of the existing functionality.
- Added a script to copy paths.

* pick libdart based on flutter mode

* fix licenses
2019-07-23 16:51:50 -07:00
Francisco Magdaleno
471657f667 [macos] Revert check on FlutterCodecs and refactor message function] (flutter/engine#10009)
* [macos] Revert check on FlutterCodecs and refactor message function]

* Remove duplicated code

* Move FlutterPlatformMessage initialization
2019-07-23 15:22:38 -07:00
adazh
6f7e34fbb8 Added a DartExecutor API for querying # of pending channel callbacks (flutter/engine#10021) 2019-07-23 13:11:03 -07:00
Michael Klimushyn
603d401fc2 Add working Robolectric tests (flutter/engine#9954)
`gclient sync` now grabs Robolectric, JUnit, and their transitive
runtime dependencies. They're being stored in a new CIPD package,
`flutter/android/robolectric_bundle`.

`shell/platform/android/BUILD.gn` has a new target for building the
tests, `robolectric_tests`. `testing/run_tests.py` has been extended to
build and run the new target. Runs the android tests under
"build_and_test_android" on CI.

This also adds some very simple sample tests to start with and a README
to the java tests directory.
2019-07-23 09:06:19 -07:00
Justin McCandless
1b87854bf5 Add support for Android's visible password input type (flutter/engine#9999)
For framework PR https://github.com/flutter/flutter/issues/31738
2019-07-23 07:57:39 -07:00
stuartmorgan
1299da0e74 Add a macro for prefixing embedder.h symbols (flutter/engine#9851)
embedder.h is a C API, so has no namespace, and only uses 'Flutter' as a
prefix for most symbol names. This creates potential collisions with
other code; for instance, FlutterEngine is the name of a type in
embedder.h, but also an ObjC class in the iOS Flutter API.

This adds a macro that can be set to prefix symbol names, allowing
clients (notably, the macOS embedding) to adjust the names used by the
embedding API internally without breaking ABI or API compatibility for
the standard engine build.

Currently the macro is only applied to FlutterEngine, since that's the
symbol that is currently at issue, but it can be expanded to other
symbols in the future.
2019-07-23 05:48:48 -07:00
Matt Carroll
342ba41f9c Android Embedding Refactor PR36: Add splash screen support. (flutter/engine#9525) 2019-07-22 14:01:34 -07:00
Jason Simmons
8be5805dff Exit flutter_tester with an error code on an unhandled exception (flutter/engine#9932) 2019-07-22 12:06:34 -07:00
Jason Simmons
b48ddc3d9c Declare a copy of the enable_bitcode flag within the Flutter build scripts for use in Fuchsia builds (flutter/engine#10003)
enable_bitcode is defined in build/toolchain/clang.gni, which exists in the
Flutter buildroot but not in the Fuchsia source tree.
2019-07-22 12:06:16 -07:00
Francisco Magdaleno
4833061af2 [macos] Add reply to binary messenger (flutter/engine#9953)
* Add reply to binary messenger

* Address comments

* Formatting

* Address comments
2019-07-22 11:08:08 -07:00
Matt Carroll
532ed38c87 Added hasRenderedFirstFrame() to old FlutterView for Espresso (#36211). (flutter/engine#9939) 2019-07-19 16:46:02 -07:00
Matt Carroll
4046164120 Removed PlatformViewsController if-statements from TextInputPlugin (#34286). (flutter/engine#9938) 2019-07-19 13:52:45 -07:00
gaaclarke
e7720142ef Removed logic from FlutterAppDelegate into FlutterPluginAppLifeCycleDelegate (flutter/engine#9893)
Removed logic from FlutterAppDelegate into
FlutterPluginAppLifeCycleDelegate.  This is a better place for
add-to-app since it doesn't require them to use our app delegate.
2019-07-19 10:58:39 -07:00
gaaclarke
9bc02314b0 Split out lifecycle protocol (flutter/engine#9922)
Split out lifecycle calls to plugins to their own protocol to clean up
FlutterPlugin and make the API slightly closer to Android.
2019-07-19 10:17:48 -07:00
Chris Yang
bd2335aea6 [platform view] do not make clipping view and interceptor view clipToBounds (flutter/engine#9937) 2019-07-19 09:00:43 -07:00
stuartmorgan
934901b4e8 Don't try to use unset assets_dir setting (flutter/engine#9924)
Debug builds log invalid file errors on launch of anything using the
embedding API due to an unconditional use of assets_dir, even though
only one of assets_dir or assets_path needs to be set (and the embedding
API currently uses the latter). This checks that the FD has been set
before trying to use it to create an asset resolver.

Also eliminates a duplicate code path in embedder.cc, where it was
calling RunConfiguration::InferFromSettings, then running exactly the
same asset manager creation code again locally.
2019-07-18 14:07:13 -07:00
gaaclarke
8ef2e3aa28 Removed unused method. (flutter/engine#9919) 2019-07-18 11:28:41 -07:00
gaaclarke
02ba481921 Made the persistent cache's directory a const pointer. (flutter/engine#9815) 2019-07-18 08:57:50 -07:00