1566 Commits

Author SHA1 Message Date
Ian Hickson
1a010de89f
Make Container always clip a decoration if it has a clip edge (#64840)
This allows us to rationalize the nullability of some of our APIs.
Prior to this we'd end up in a situation where Container assumed that
getClipPath would be non-null but Decoration was ok with return null.
2020-09-08 12:06:28 -07:00
chunhtai
9cb2d4d65c
Fixed the sliver appbar to have a fixed traversal order (#65049) 2020-09-08 12:05:02 -07:00
Ian Hickson
e10bdbbd9d
Fix RangeMaintainingScrollPhysics (#65135) 2020-09-07 11:40:03 -07:00
Kate Lovett
20936eeac4
Allow for arbitrary placement in SliverGrid (#64750) 2020-09-03 11:20:04 -07:00
Sahand Akbarzadeh
33c619c9ac
fix Container.clipBehaviour, clips the shadow in decoration (#64362) 2020-09-03 10:40:03 -07:00
Jonah Williams
7aa8c2ab99
[null-safety] remove mockito from scrollbar test (#64493)
More work towards #62886
2020-08-31 13:27:12 -07:00
Chris Bracken
c0ea00ed3f
Prefer moreOrLessEquals over closeTo (#64915)
Flutter's `moreOrLessEquals` has a few advantages over `closeTo` from
the `matcher` package:

   * It emits the epsilon value in the test result on failure.
   * It uses a named parameter for epsilon, which improves readability
     at the call site.
   * It has a reasonable default for epsilon in cases where something
     more specific isn't required.

Using it also has the nice property that it aids in its own discovery
when when people go looking for such functionality in new tests.

This change also includes a couple unrelated whitespace formatting cleanups.
2020-08-30 22:20:16 -07:00
LongCatIsLooong
fe55dc2b13
Reland "Prevent viewport.showOnScreen from scrolling the viewport if the specified Rect is already visible. (#56413)" reverted in #64091 (#64513) 2020-08-28 22:13:04 -07:00
gaowanqiu
619eccd2e3
Fix negative usableCrossAxisExtent in release mode (#64441) 2020-08-28 16:13:05 -07:00
xubaolin
a3fe33af65
The OverscrollIndicator should not overflow the scrollable view's edge (#64239) 2020-08-28 10:38:05 -07:00
Justin McCandless
8f370dff65
SelectableText long press on iOS (#63994) 2020-08-28 10:33:05 -07:00
chunhtai
fbc15384bb
Fixes router to not report route information when it is already up to… (#64596) 2020-08-27 16:43:05 -07:00
Ian Hickson
8a6a76a334
migrate rendering to nullsafety (#64621) 2020-08-27 16:38:10 -07:00
Mouad Debbar
e7a35a67ce
[web] Enable word boundary tests (#64570) 2020-08-26 21:23:03 -07:00
Alexander Brusher
39e7eeaed1
Disables tests failing due to new semantics flag. (#63595) 2020-08-26 20:38:05 -07:00
LongCatIsLooong
6536f65048
Revert "Warns when single line text fields overflow (#63639)" (#64573)
This reverts commit 0ab5ecc86b1f13854ecc0cb4a89fbdc9938c5212.
2020-08-25 11:11:15 -07:00
Mouad Debbar
707f995de3
[web] Fix and enable editable_text_test.dart (#64516) 2020-08-25 04:51:03 -07:00
LongCatIsLooong
0ab5ecc86b
Warns when single line text fields overflow (#63639) 2020-08-24 18:16:05 -07:00
Alex Li
2c3652b8fb
[EditableText] Fix TextField crashed with composing and maxLength set (#63754) 2020-08-24 12:16:05 -07:00
Dan Field
eef4220a87
Make large jumpTo recommend deferred loading (#64271) 2020-08-20 17:46:07 -07:00
Todd Volkert
4d8934af48
Re-apply "(insert|move|remove)ChildRenderObject Deprecation: Step 1 (#64189)" (#64254)
This reverts commit ce40de69b7b4f89c66d19c8dbd3bd86ae30f1bc6.

(this re-applies #64189 by reverting #64249)
2020-08-20 08:19:34 -07:00
Mehmet Fidanboylu
ce40de69b7
Revert "(insert|move|remove)ChildRenderObject Deprecation: Step 1 (#64189)" (#64249)
This reverts commit 21cfed34d478d6a1c0223557a7935b69b15613bb.
2020-08-20 07:31:50 -07:00
Tong Mu
fb0b982324
Change MouseTracker's interface for clarity. Simplify MouseRegion's implementation. (#64119)
* Redesigns the interface between MouseTracker and RendererBinding&RenderView.
* Simplifies the structure of RenderMouseRegion.
* Extracts the common utility code between mouse_tracker_test and mouse_tracker_cursor_test.
2020-08-19 18:51:56 -07:00
Todd Volkert
21cfed34d4
(insert|move|remove)ChildRenderObject Deprecation: Step 1 (#64189)
* (insert|move|remove)ChildRenderObject Deprecation: Step 1

This deprecates the following methods:

* RenderObjectElement.insertChildRenderObject
* RenderObjectElement.moveChildRenderObject
* RenderObjectElement.removeChildRenderObject

...and replaces them with the following methods:

* RenderObjectElement.insertRenderObjectChild
* RenderObjectElement.moveRenderObjectChild
* RenderObjectElement.removeRenderObjectChild

The reason for the deprecation is to provide the `oldSlot` argument to
the `moveRenderObjectChild` method (such an argument was missing from
the now-deprecated `moveChildRenderObject` method) and the `slot`
argument to the `removeRenderObjectChild` method (such an argument was
missing from the now-deprecated `removeChildRenderObject` method). While
no argument was added to `insertRenderObjectChild`, the name change (and
corresponding deprecation) was made to maintain naming parity with the
other two methods.

This initial step does not update or remove any of the `slotToChild`
patterns that exist in the framework. This work is being separated
into two commits in case something needs to be reverted to minimize
the scope of each commit.

See https://github.com/flutter/flutter/issues/63269 for more info
2020-08-19 17:39:07 -07:00
Justin McCandless
ec24a819ea
ClipboardStatusNotifier should handle errors in Clipboard.getData (#64012) 2020-08-19 14:36:08 -07:00
Mouad Debbar
2b67846aab
Make SelectableText work better on web (#63786) 2020-08-19 13:31:06 -07:00
Greg Spencer
d1eff0b413
Hook up soft keyboard "next" and "previous" buttons so that they move the focus by default (#63592)
Focus will be moved automatically if onEditingComplete is not specified, but must
by moved manually if onEditingComplete is specified.
2020-08-18 16:46:58 -07:00
Mehmet Fidanboylu
bd6252eb3a
Revert "Prevent viewport.showOnScreen from scrolling the viewport if the specified Rect is already visible. (#56413)" (#64091)
This reverts commit 64d76f2fb7ed5eb785c660084b18ed5a51fd926b.
2020-08-18 13:55:33 -07:00
Andre
9e0ad9b6b5
Fix FittedBox BoxFit.scaleDown sizing (#63668) 2020-08-17 22:36:02 -07:00
Ian Hickson
8f3805f5af
Build routes even less. (#62588) 2020-08-17 15:16:06 -07:00
Ming Lyu (CareF)
c2368bdd6f
bug fix for pointer id in test gestures (#63816) 2020-08-15 10:41:02 -07:00
LongCatIsLooong
64d76f2fb7
Prevent viewport.showOnScreen from scrolling the viewport if the specified Rect is already visible. (#56413) 2020-08-14 16:41:03 -07:00
Declan Woods
03dcd1bd5a
Fix SafeArea and SliverSafeArea debug flag properties (#63455) 2020-08-14 12:01:05 -07:00
Yuqian Li
3ff76f47fb
Add clipBehavior to ListView, GridView, PageView (#63147)
These widgets are missing from
https://github.com/flutter/flutter/pull/59364

With this change, developers can use clipBehavior for
https://github.com/flutter/flutter/issues/59424
2020-08-13 15:01:41 -07:00
Michael Goderbauer
39a46bedad
Remove decommission from RestorationBuckets (#63687) 2020-08-13 15:01:04 -07:00
renyou
32ee00849c
Revert "Fix RangeMaintainingScrollPhysics" (#63611) 2020-08-13 14:46:04 -07:00
Justin McCandless
441d7f3fb8
InteractiveViewer scale interpretation improvement (#63543) 2020-08-12 15:31:09 -07:00
Jonah Williams
04bc6123a9
[null-safety] update to several framework test cases/APIs for null assertions (#62946) 2020-08-12 13:41:09 -07:00
LongCatIsLooong
cea055ef00
Make Scrollable's free scroll initial velocity matches that of iOS (#60501) 2020-08-12 13:31:05 -07:00
Ian Hickson
e3c7fb5bef
Fix RangeMaintainingScrollPhysics (#63146)
It now uses the scroll metrics as they stood at the end of the last frame.

It previously used a weird combination of the old extents and the newish position, which led to some weird effects when the position had been changed in expectation of a viewport or content dimension change.
2020-08-11 08:59:20 -07:00
Ian Hickson
d7883e3fb0
Clean up some test formatting and comments (#63306) 2020-08-11 06:16:03 -07:00
Michael Goderbauer
25de941927
Make Scrollables restorable (#63131) 2020-08-10 21:01:10 -07:00
Ian Hickson
a49ba95af8
Some minor improvements to the AsyncSnapshot API (#63347) 2020-08-10 11:11:02 -07:00
xubaolin
ba92cbedd8
fix SingleChildScrollView clip bug (#63054) 2020-08-10 10:46:04 -07:00
Ian Hickson
5d91d0484c
Unskip a widget inspector test that doesn't seem flaky anymore. (#62824) 2020-08-08 15:31:04 -07:00
creativecreatorormaybenot
96b6aafb49
Add onTertiaryTap* to TapGestureRecognizer and GestureDetector (#62788) 2020-08-08 15:21:02 -07:00
Jonah Williams
c2e85e67c9
[null-safety] remove more usage of mockito from the framework tests (#62936) 2020-08-07 20:31:08 -07:00
chunhtai
f9fd71bc78
Implement Router widget and widgets app api (#60299) 2020-08-07 20:26:05 -07:00
Pascal Welsch
12b8d9db80
Reduce iOS scroll damping for lists with differently sized items (#59623) 2020-08-07 20:21:07 -07:00
Kate Lovett
79146fd0a6
Fix SliverList scrollOffsetCorrection 0 case (#62615) 2020-08-06 16:11:16 -07:00