Mitchell Goodwin
57ed724177
Update dialog tests for Material3 ( #135775 )
...
Separates the tests for the Material dialog into Material3 and Material2 versions.
More info in #127064
2023-10-02 11:03:18 +00:00
Kostia Sokolovskyi
fdde24195f
DraggableScrollableController should dispatch creation in constructor. ( #135423 )
2023-09-29 17:45:35 -07:00
Taha Tesser
ebaf160391
Update Drawer tests for M2/M3 ( #135752 )
...
Updated unit tests for `Drawer` to have M2 and M3 versions.
More info in #127064
2023-09-29 18:15:53 +00:00
Bruno Leroux
e61f9e0ce5
Fix TabBarView.viewportFraction change is ignored ( #135590 )
...
## Description
This PR updates `_TabBarViewState.didUpdateWidget` in order to react to `TabBarView.viewportFraction`change.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/135557 .
## Tests
Adds 1 test.
2023-09-28 19:56:15 +00:00
Matheus Kirchesch
9fdb167183
Added option to disable [NavigationDestination]s ([NavigationBar] destination widget) ( #132361 )
...
This PR adds a new option in the NavigationDestination api (the destination widget for the NavigationBar) allowing it to be disabled.
As the issue states this PR is the NavigationBar's version of these two PRs (https://github.com/flutter/flutter/pull/132349 and https://github.com/flutter/flutter/pull/127113 )
* https://github.com/flutter/flutter/issues/132359
2023-09-28 18:41:18 +00:00
Alex Li
4ed9ab8b23
🚀 Add more fields to RefreshProgressIndicator ( #135207 )
...
Resolves #134494
2023-09-28 18:21:58 +00:00
Taha Tesser
d134345f8c
Fix RangeSlider throws an exception in a ListView ( #135667 )
...
fixes [[RangeSlider] [Flutter 3.10] LateInitializationError: Field '_startThumbCenter@280317193' has not been initialized.](https://github.com/flutter/flutter/issues/126648 )
### Code sample (Run it on iOS)
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return const MaterialApp(
debugShowCheckedModeBanner: false,
home: Example(),
);
}
}
class Example extends StatelessWidget {
const Example({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
body: ListView(
children: <Widget>[
const SizedBox(
height: 1000,
child: Placeholder(),
),
RangeSlider(
values: const RangeValues(0.25, 0.75),
onChanged: (value) {},
),
],
),
);
}
}
```
</details>
2023-09-28 16:06:53 +00:00
Renzo Olivares
21ad7122a1
Implement SelectionArea single click/tap gestures ( #132682 )
...
This change collapses the selection at the clicked/tapped location on single click down for desktop platforms, and on single click/tap up for mobile platforms to match native.
This is a change from how `SelectionArea` previously worked. Before this change a single click down would clear the selection. From observing a native browser it looks like when tapping on static text the selection is not cleared but collapsed. A user can still attain the selection from static text using the `window.getSelection` API.
https://jsfiddle.net/juepasn3/11/ You can try this demo out here to observe this behavior yourself. When clicking on static text the selection will change.
This change also allows `Paragraph.selections` to return selections that are collapsed. This for testing purposes to confirm where the selection has been collapsed.
Partially fixes : #129583
2023-09-28 01:42:16 +00:00
Taha Tesser
433bca5edb
Fix SearchAnchor's search view isn't updated when the theme changes & widgets inside the search view do not inherit local themes ( #132749 )
...
fixes [SearchAnchor (search view) UI glitch on platform brightness changes](https://github.com/flutter/flutter/issues/131835 )
fixes [Search view widgets cannot inherit local themes](https://github.com/flutter/flutter/issues/132741 )
### Description
- This fixes an issue where the `SearchAnchor`'s search view isn't updated when the platform brightness changes.
- Fixes an issue where widgets inside the search view cannot use local themes
### Actual Results
`SearchAnchor` currently passed both global and local themes on the search view popup pushing and it uses anchor. button's context to look up the theme.
As a result, when the platform changes and the search view is rebuilt, it cannot use the updated theme.
https://github.com/flutter/flutter/assets/48603081/2f1ebe74-e7d5-4ef3-b97c-a741c3d68964
### Expected Results
Similar to `PopupMenuButton`, the theme should be located in the search view so that when the platform brightness is updated and the search view is rebuilt it can use the updated theme.
https://github.com/flutter/flutter/assets/48603081/d8d85982-c661-4cac-83e8-0488b1d93daf
However, the search view's context cannot access local themes so I added support for `InheritedTheme`, which fixes the local. theme issue for both the search view and widgets inside the search view.
### When using local themes for the `SearchAnchor`'s search view and widgets inside the view.
### Before
### After
2023-09-27 17:02:17 +00:00
Renzo Olivares
d81c8aa88b
SelectionArea long press selection overlay behavior should match native ( #133967 )
...
During a long press, on native iOS the context menu does not show until the long press has ended. The handles are shown immediately when the long press begins. This is true for static and editable text.
For static text on Android, the context menu appears when the long press is initiated, but the handles do not appear until the long press has ended. For editable text on Android, the context menu does not appear until the long press ended, and the handles also do not appear until the end.
For both platforms in editable/static contexts the context menu does not show while doing a long press drag.
I think the behavior where the context menu is not shown until the long press ends makes the most sense even though Android varies in this depending on the context. The user is not able to react to the context menu until the long press has ended.
Other details:
On a windows touch screen device the context menu does not show up until the long press ends in editable/static text contexts. On a long press hold it selects the word on drag start as well as popping up the selection handles (static text).
2023-09-26 22:06:15 +00:00
Polina Cherkasova
49e16867a3
TabController should dispatch creation in constructor. ( #133952 )
2023-09-22 15:27:05 -07:00
Polina Cherkasova
99ac6b8164
_RenderChip should not create OpacityLayer without disposing. ( #134708 )
2023-09-22 13:44:04 -07:00
Matheus Kirchesch
801a1c9304
Added option to disable [NavigationDrawerDestination]s ( #132349 )
...
This PR adds a new option in the NavigationDrawerDestination api allowing it to be disabled, this is very useful for role based access control, especially in the navigation drawer which is used to lay out all the app destinations
* https://github.com/flutter/flutter/issues/132348
2023-09-22 08:03:02 +00:00
Qun Cheng
09f7d7c560
Remove extra padding if a dropdown menu entry also has a leading icon ( #135004 )
...
Fixes #131350
This PR is to remove the extra padding in `DropdownMenuEntry` if both the text field and the dropdown menu entry have leading icons.
**After** fix:
<img width="300" alt="Screenshot 2023-09-19 at 4 35 24 PM" src="https://github.com/flutter/flutter/assets/36861262/ed7d92a5-3f96-4106-a03e-09258ea3709f ">
**Before** fix:
<img width="300" alt="Screenshot 2023-09-19 at 4 37 58 PM" src="https://github.com/flutter/flutter/assets/36861262/fdbfef54-6c93-48fb-bd64-41fa31dde531 ">
2023-09-22 07:34:06 +00:00
hangyu
528a281a5c
Update alwaysNeedsCompositing in RenderParagraph ( #135076 )
...
fix #111370
According to
5b47fef613/packages/flutter/lib/src/rendering/box.dart (L1259)https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-21 14:53:22 -07:00
Bruno Leroux
de44daf1f8
Add a parameter to configure InputDecorator hint fade animations duration ( #135211 )
...
## Description
This PR adds a parameter to configure the input decorator hint fade transition duration.
This animation is not part of the Material specification.
Removing it was considered but it breaks internal tests (see https://github.com/flutter/flutter/pull/107406 ).
I also considered several ways to avoid the fade animation (setting duration to 0, removing the hint text, etc) but it breaks many existing tests that assumes the hint text to be visible.
To mitigate the issue in a non disruptive way, I set the default duration to 20ms (an arbitrary short value).
## Related Issue
Fixes https://github.com/flutter/flutter/issues/20283 .
## Tests
Adds 3 tests, updates 3 tests.
2023-09-21 17:37:07 +00:00
Polina Cherkasova
77718845dd
Handle breaking changes in leak_tracker. ( #135185 )
2023-09-21 10:06:21 -07:00
Bruno Leroux
07cc3f7a61
Form fields onChange callback should be called on reset ( #134295 )
...
## Description
This PR fixes form fields in order to call the `onChange` callback when the form is reset.
This change is based on the work done in https://github.com/flutter/flutter/pull/123108 .
I considered adding the `onChange` callback to the `FormField` superclass but it would break existing code because two of the three subclasses defines the `onChange` callback with `ValueChanged<String>?` type and the third one defines it with `ValueChanged<String?>?`.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/123009 .
## Tests
Adds 3 tests.
2023-09-21 05:54:19 +00:00
Michael Goderbauer
b0a90aee17
Enable strict-inference ( #135043 )
...
Avoids that dynamic accidentally sneaks in, see https://dart.dev/tools/analysis#enabling-additional-type-checks
2023-09-20 19:59:08 +00:00
Polina Cherkasova
ab66f55728
Reland Resolve breaking change of adding a method to ChangeNotifier. ( #134983 )
2023-09-18 20:31:54 -07:00
Polina Cherkasova
658710b6f9
Cover more tests with leak tracking. ( #134805 )
2023-09-18 13:45:38 -07:00
Kostia Sokolovskyi
56cbf3e1d9
Cover more test/widgets tests with leak tracking #5 ( #134869 )
2023-09-18 13:44:55 -07:00
Polina Cherkasova
f629dc8771
Dispose layers in test. ( #134802 )
2023-09-15 12:53:51 -07:00
Polina Cherkasova
72b69f9449
Date picker dialog state should dispose members. ( #134804 )
2023-09-15 08:55:50 -07:00
Bruno Leroux
2a7ad01e55
Fix navigation rail hover misplaced when direction is RTL and extended is true ( #134815 )
...
## Description
This PR fixes `NavigationRail` hover position when text direction is set to RTL and `NavigationRail.extended` is true.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/134361 .
## Tests
Adds 1 test.
2023-09-15 15:15:06 +00:00
Alex Li
5c09ccad39
🐛 Setup color tween for RefreshIndicator in a better way ( #134492 )
...
Fixes https://github.com/flutter/flutter/issues/134489 .
2023-09-14 18:29:18 +00:00
Bruno Leroux
9fa09ea4d3
Fix NavigationRail hover misplaced when using large icons ( #134719 )
...
## Description
This PR fixes `NavigationRail` hover position when using enlarged icons whose size is specified using `NavigationRailThemeData.selectedIconTheme` and `NavigationRailThemeData.unselectedIconTheme`.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/133799 .
## Tests
Adds 1 test, updates 1 test (to replace some magic numbers).
2023-09-14 17:03:40 +00:00
hangyu
ab1b865e58
Dispose routes in navigator when throwing exception ( #134596 )
...
fixes : #133695
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-13 12:36:51 -07:00
hangyu
6c7ddb859d
Update BottomSheetTest ( #134562 )
2023-09-12 18:52:41 -07:00
Polina Cherkasova
cef737c412
_YearPicker should dispose ScrollController and MaterialSatesController. ( #134393 )
2023-09-12 17:44:18 -07:00
Bruno Leroux
083ac65c51
Fix TabBarView desynchronized after animation interruption ( #132748 )
2023-09-12 18:09:26 -05:00
Kate Lovett
4e7a07af88
Remove chip tooltip deprecations ( #134486 )
...
Part of https://github.com/flutter/flutter/issues/133171
These deprecations were introduced in https://github.com/flutter/flutter/pull/96174
The replacement is to use `deleteButtonTooltipMessage`.
This migration is supported by dart fix. â
2023-09-12 18:23:52 +00:00
chunhtai
5900c4baa7
Revert "Adds a parent scope TraversalEdgeBehavior and fixes modal rou… ( #134550 )
...
…te to no… (#130841 )"
This reverts commit 0f3bd90d9b108904cc0390e899c2b3c6ee2e76e0.
Internal test needs migration
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-12 09:18:40 -07:00
Polina Cherkasova
0844726ab3
Mark leak: instances of OpacityLayer, created by _RenderChip, should be disposed. ( #134395 )
2023-09-11 17:12:02 +00:00
Polina Cherkasova
219efce7f1
Cover more tests with leak tracking. ( #134363 )
2023-09-11 09:42:27 -07:00
Polina Cherkasova
5555836712
Day picker should dispose created MaterialStatesController's. ( #133884 )
...
Fixes https://github.com/flutter/flutter/issues/133862
2023-09-09 08:45:27 -07:00
Kostia Sokolovskyi
5d5da38810
Fix memory leak in _DraggableScrollableSheetState ( #134212 )
2023-09-08 15:06:26 -07:00
Renzo Olivares
97cdc0ec07
InputDecoration.error should activate error state ( #134001 )
...
When passed an `error` widget, `InputDecoration` should activate its error state. Before this change the `errorBorder` would only activate if an `errorText` was provided. This change solves this issue by accounting for a provided `error` widget.
2023-09-08 22:01:50 +00:00
Polina Cherkasova
3ff0beb5fa
_TabBarViewState should dispose created instances of PageController. ( #134091 )
2023-09-07 17:50:45 -07:00
Polina Cherkasova
237ddcc339
Remove non needed controllers in SegmentedButton. ( #134064 )
2023-09-07 17:50:23 -07:00
Polina Cherkasova
cc95ace32c
CupertinoAlertDialog should not create ScrollController on every build, if null values are passed in constructor. ( #134075 )
...
Relanding of https://github.com/flutter/flutter/pull/134071
Verified failed tests succeeded now:
2023-09-07 23:59:58 +00:00
Polina Cherkasova
1c0b4ad53a
_SearchBarState should dispose FocusNode, if it created it. ( #134076 )
...
Relanding of revert: https://github.com/flutter/flutter/pull/134072
Verified failed tests succeeded now:
2023-09-07 23:27:12 +00:00
Taha Tesser
30234a00ee
Fix ExpansionTile properties cannot be updated with setState ( #134218 )
...
fixes [`ExpansionTile` properties aren't updated with `setState`](https://github.com/flutter/flutter/issues/24493 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return const MaterialApp(
debugShowCheckedModeBanner: false,
home: Example(),
);
}
}
class Example extends StatefulWidget {
const Example({super.key});
@override
State<Example> createState() => _ExampleState();
}
class _ExampleState extends State<Example> {
ShapeBorder collapsedShape = const RoundedRectangleBorder(
borderRadius: BorderRadius.all(Radius.circular(4)),
);
Color collapsedTextColor = const Color(0xffffffff);
Color collapsedBackgroundColor = const Color(0xffff0000);
Color collapsedIconColor = const Color(0xffffffff);
ShapeBorder shape = const RoundedRectangleBorder(
borderRadius: BorderRadius.all(Radius.circular(16)),
);
Color backgroundColor = const Color(0xffff0000);
Color textColor = const Color(0xffffffff);
Color iconColor = const Color(0xffffffff);
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: Padding(
padding: const EdgeInsets.symmetric(horizontal: 16.0),
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: [
ExpansionTile(
shape: shape,
backgroundColor: backgroundColor,
textColor: textColor,
iconColor: iconColor,
collapsedShape: collapsedShape,
collapsedTextColor: collapsedTextColor,
collapsedBackgroundColor: collapsedBackgroundColor,
collapsedIconColor: collapsedIconColor,
title: const Text('Collapsed ExpansionTile'),
children: const [
ListTile(
title: Text('Revealed!'),
),
],
),
const SizedBox(height: 16),
ExpansionTile(
shape: shape,
backgroundColor: backgroundColor,
textColor: textColor,
iconColor: iconColor,
initiallyExpanded: true,
title: const Text('Expanded ExpansionTile'),
children: const [
ListTile(
title: Text('Revealed!'),
),
],
),
const SizedBox(height: 16),
FilledButton(
onPressed: () {
setState(() {
collapsedShape = const RoundedRectangleBorder(
borderRadius: BorderRadius.all(Radius.circular(50)),
);
collapsedTextColor = const Color(0xfff00000);
collapsedBackgroundColor = const Color(0xffffff00);
collapsedIconColor = const Color(0xfff00000);
shape = const RoundedRectangleBorder();
backgroundColor = const Color(0xfffff000);
textColor = const Color(0xfff00000);
iconColor = const Color(0xfff00000);
});
},
child: const Text('Update properties'),
),
],
),
),
),
);
}
}
```
</details>
### Before
https://github.com/flutter/flutter/assets/48603081/b29aed98-38ff-40a3-9ed3-c4342ada35b6
### After
https://github.com/flutter/flutter/assets/48603081/5e0b6a34-c577-40ed-8456-7ef55caa277b
2023-09-07 21:55:32 +00:00
Polina Cherkasova
12e6ff2c54
DropdownRoutePage should dispose the created ScrollController. ( #133941 )
2023-09-07 11:30:43 -07:00
Polina Cherkasova
0d198c7ba6
SearchDelegate should dispose resources. ( #133948 )
2023-09-07 11:13:55 -07:00
Matheus Kirchesch
2867b31f5e
Fixed [NavigationRailDestination]'s label opacity while disabled not being coherent with the icon ( #132345 )
...
Fixing the opacity of the NavigationRailDestination widget label while
it is disabled, right now it doesn't get affected by the disabled
attribute, which doesn't match the icon that gets affected
* https://github.com/flutter/flutter/issues/132344
I believe this PR should be marked as [test-exempt]
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
2023-09-07 10:21:52 -07:00
Taha Tesser
f5355af4a3
Fix TabBar doesn't use labelStyle & unselectedLabelStyle color ( #133989 )
...
Fixes [TabBar labelStyle.color and unselectedLabelStyle.color does not take effect](https://github.com/flutter/flutter/issues/109484 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
/// Flutter code sample for [TabBar].
const Color labelColor = Color(0xFFFF0000);
const Color unselectedLabelColor = Color(0x95FF0000);
const TextStyle labelStyle = TextStyle(
color: Color(0xff0000ff),
fontWeight: FontWeight.bold,
);
const TextStyle unselectedLabelStyle = TextStyle(
color: Color(0x950000ff),
fontStyle: FontStyle.italic,
);
void main() => runApp(const TabBarApp());
class TabBarApp extends StatelessWidget {
const TabBarApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
theme: ThemeData(useMaterial3: true),
home: const TabBarExample(),
);
}
}
class TabBarExample extends StatelessWidget {
const TabBarExample({super.key});
@override
Widget build(BuildContext context) {
return DefaultTabController(
initialIndex: 1,
length: 3,
child: Scaffold(
appBar: AppBar(
title: const Text('TabBar Sample'),
bottom: const TabBar(
// labelColor: labelColor,
// unselectedLabelColor: unselectedLabelColor,
labelStyle: labelStyle,
unselectedLabelStyle: unselectedLabelStyle,
tabs: <Widget>[
Tab(
icon: Icon(Icons.cloud_outlined),
text: 'Cloudy',
),
Tab(
icon: Icon(Icons.beach_access_sharp),
text: 'Sunny',
),
Tab(
icon: Icon(Icons.brightness_5_sharp),
text: 'Rainy',
),
],
),
),
body: const TabBarView(
children: <Widget>[
Center(
child: Text("It's cloudy here"),
),
Center(
child: Text("It's rainy here"),
),
Center(
child: Text("It's sunny here"),
),
],
),
),
);
}
}
```
</details>
#### When `labelStyle` and `unselectedLabelStyle` are specified with a color.
### Before
### After
2023-09-07 09:19:05 +00:00
Taha Tesser
75797a8a7e
Fix DataTable's headingTextStyle & dataTextStyle are not merged with default text style ( #134138 )
...
fixes [Inconsistent text color on DataTable in different platforms](https://github.com/flutter/flutter/issues/114470 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
/// Flutter code sample for [DataTable].
void main() => runApp(const DataTableExampleApp());
class DataTableExampleApp extends StatelessWidget {
const DataTableExampleApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
themeMode: ThemeMode.dark,
theme: ThemeData(),
darkTheme: ThemeData.dark(),
home: Scaffold(
appBar: AppBar(title: const Text('DataTable Sample')),
body: const DataTableExample(),
),
);
}
}
class DataTableExample extends StatelessWidget {
const DataTableExample({super.key});
@override
Widget build(BuildContext context) {
return DataTable(
headingTextStyle: const TextStyle(),
dataTextStyle: const TextStyle(),
columns: const <DataColumn>[
DataColumn(
label: Expanded(
child: Text(
'Name',
style: TextStyle(fontStyle: FontStyle.italic),
),
),
),
DataColumn(
label: Expanded(
child: Text(
'Age',
style: TextStyle(fontStyle: FontStyle.italic),
),
),
),
DataColumn(
label: Expanded(
child: Text(
'Role',
style: TextStyle(fontStyle: FontStyle.italic),
),
),
),
],
rows: const <DataRow>[
DataRow(
cells: <DataCell>[
DataCell(Text('Sarah')),
DataCell(Text('19')),
DataCell(Text('Student')),
],
),
DataRow(
cells: <DataCell>[
DataCell(Text('Janine')),
DataCell(Text('43')),
DataCell(Text('Professor')),
],
),
DataRow(
cells: <DataCell>[
DataCell(Text('William')),
DataCell(Text('27')),
DataCell(Text('Associate Professor')),
],
),
],
);
}
}
```
</details>
### Before
| Desktop | Mobile |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/19c3908d-6b6a-4408-9c6b-da83c8efaa4a " /> | <img src="https://github.com/flutter/flutter/assets/48603081/efda08fb-05f9-437e-be5c-6b6861babe19 " width="350" /> |
### After
| Desktop | Mobile |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/6bd3433f-d61f-4f35-8a2a-f7539a74f93e " /> | <img src="https://github.com/flutter/flutter/assets/48603081/5123a79b-6c2a-4bea-9fbc-64ed3e599826 " width="350" /> |
2023-09-07 08:55:53 +00:00
Taha Tesser
ded8b8e31c
Reland "Fix Chip.shape's side is not used when provided in Material 3" ( #133856 )
...
fixes [Chip border side color not working in Material3](https://github.com/flutter/flutter/issues/132922 )
Relands https://github.com/flutter/flutter/pull/132941 with an updated fix and a regression test.
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(useMaterial3: true),
home: const Example(),
);
}
}
class Example extends StatelessWidget {
const Example({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: const Text('Chips'),
),
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
const RawChip(
shape: RoundedRectangleBorder(
side: BorderSide(color: Colors.amber),
),
side: BorderSide(color: Colors.red),
label: Text('RawChip'),
),
const Chip(
shape: RoundedRectangleBorder(
side: BorderSide(color: Colors.amber),
),
side: BorderSide(color: Colors.red),
label: Text('Chip'),
),
ActionChip(
shape: const RoundedRectangleBorder(
side: BorderSide(color: Colors.amber),
),
side: const BorderSide(color: Colors.red),
label: const Text('ActionChip'),
onPressed: () {},
),
FilterChip(
shape: const RoundedRectangleBorder(
side: BorderSide(color: Colors.amber),
),
side: const BorderSide(color: Colors.red),
label: const Text('FilterChip'),
onSelected: (value) {},
),
ChoiceChip(
shape: const RoundedRectangleBorder(
side: BorderSide(color: Colors.amber),
),
side: const BorderSide(color: Colors.red),
label: const Text('ChoiceChip'),
selected: false,
onSelected: (value) {},
),
InputChip(
shape: const RoundedRectangleBorder(
side: BorderSide(color: Colors.amber),
),
side: const BorderSide(color: Colors.red),
label: const Text('InputChip'),
onSelected: (value) {},
),
],
),
),
);
}
}
```
</details>
<img src="https://github.com/flutter/flutter/assets/48603081/f713fd84-cf9a-4e52-8cdb-5faba63d8e91 " height="450" /> <img src="https://github.com/flutter/flutter/assets/48603081/a142efc7-041e-4e6e-87cf-e6c4ebe735f3 " height="450" />
<img src="https://github.com/flutter/flutter/assets/48603081/377df55b-499f-403f-96c5-0be0334795dc " height="450" /> <img src="https://github.com/flutter/flutter/assets/48603081/731a2752-7822-4605-8e9c-db0a71dd6f08 " height="450" />
2023-09-07 07:58:00 +00:00
Polina Cherkasova
1f0730e67a
DraggableScrollableActuator should dispose notifier. ( #133917 )
2023-09-06 22:07:07 +00:00
