20087 Commits

Author SHA1 Message Date
Matt Perry
465846c37d Sky: Move iframe geometry updates to FrameView::updateLayout instead of
RenderView::invalidateTree.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/737523002
2014-11-17 15:49:40 -05:00
Adam Barth
70604d6c23 Add a simple scheduler for animation frames
This CL adds a simple scheduler for animation frames that holds a given interval
in a given phase.  The scheduler can be told the estimated duration of the
BeginFrame callback and can adjust the callback to hit a given vsync interval.

This CL also makes ganesh_app use this scheduler to animate.

R=jamesr@chromium.org, ernstm@chromium.org

Review URL: https://codereview.chromium.org/731893002
2014-11-17 11:24:07 -08:00
Matt Perry
eee39ec5ad Sky: update the HTMLIFrameElement's geometry during paint invalidation rather
than layout.

This ends up being much smoother and only triggers once per layout cycle.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/730653002
2014-11-17 14:20:17 -05:00
Eric Seidel
38981ef393 Remove DEPS from sky
Also taught PRESUBMIT.py how to ignore DEPS for sky/
since gn check already covers everything we were using DEPS for.

R=abarth@chromium.org, jamesr@chromium.org

Review URL: https://codereview.chromium.org/737493002
2014-11-17 11:16:44 -08:00
Eric Seidel
a2798ccebd Add a little script for resurrecting pre-fork Blink files
Since Sky is checked directly into mojo and does not contain
Blink history, I knew of no easy way to resurrect Blink files.

In making the V8 debugger work, I had to bring back a ton
of files and thus wrote a script to help me do so.

Maybe others will find this useful.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/732193002
2014-11-17 11:08:49 -08:00
Eric Seidel
9ec75d67ce Use root-relative V8 includes
TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/726133002
2014-11-14 16:02:21 -08:00
Elliott Sprehn
8409c0e386 Add a version of flights that's made of components.
Also add a test, this checks nested Shadow DOM and <content> with
and without select.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/725763003
2014-11-14 15:00:12 -08:00
Hixie
2a1e17eeb3 Specs: hit testing (and some cleanup)
Review URL: https://codereview.chromium.org/727993002
2014-11-14 14:35:55 -08:00
Ojan Vafai
052cb893ad Add a basic img test.
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/732763002
2014-11-14 13:58:19 -08:00
Ojan Vafai
7ba5f7bec8 Only write test baselines next to the test.
We don't have platforms, so we never want to create a
platform directory for test baselines.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/729573004
2014-11-14 13:56:49 -08:00
Elliott Sprehn
9ea3c3648b Remove sizes attr.
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/732813002
2014-11-14 13:52:02 -08:00
Eric Seidel
73365743da Remove more bits of the Oilpan tracing system
TBR=esprehn@chromium.org

Review URL: https://codereview.chromium.org/729733002
2014-11-14 13:17:21 -08:00
Eric Seidel
92b3ef9e73 Remove FINAL macro to make chromium presubmit happy
TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/727933002
2014-11-14 12:55:21 -08:00
Benjamin Lerman
e1311d656d Change mojo application name to {name}.mojo
Also remove obsolete reference to gyp files.

R=abarth@chromium.org, brettw@chromium.org, aa@chromium.org

Review URL: https://codereview.chromium.org/713513002
2014-11-14 21:49:31 +01:00
Hixie
d91f4a7231 Specs: note one of the big problems with the current style system: that rule order isn't maintained
Review URL: https://codereview.chromium.org/730603003
2014-11-14 10:22:41 -08:00
Hixie
620087ab17 Specs: add a way to give layout managers alternative sets of properties so that they can make configurable layout-time decisions
Review URL: https://codereview.chromium.org/727873002
2014-11-14 10:20:00 -08:00
James Robinson
e6a599f95f Update from https://crrev.com/304121
Includes DEPS updates and port of
https://codereview.chromium.org/665223004 to accomodate skia API change
on android.

Review URL: https://codereview.chromium.org/723343002
2014-11-13 17:05:42 -08:00
Elliott Sprehn
42d362ff6b Remove tons of OILPAN.
This removes ::trace, traceAfterDispatch and finalizeGarbageCollectedObject.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/723253004
2014-11-13 16:56:13 -08:00
Matt Perry
037ca1b039 Rename RenderRemote to RenderIFrame.
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/723143003
2014-11-13 18:19:28 -05:00
Hixie
5d20dd7eab Specs: Start documenting debug mode
Review URL: https://codereview.chromium.org/720333003
2014-11-13 14:10:16 -08:00
Hixie
096a10336d Specs: Make even the application scripts get 'module' as their local object, rather than 'application'
BUG=https://github.com/domokit/mojo/issues/23

Review URL: https://codereview.chromium.org/724093003
2014-11-13 14:08:06 -08:00
Hixie
618c00350b Specs: add a best practices document for framework authors
Review URL: https://codereview.chromium.org/726723002
2014-11-13 14:05:26 -08:00
Hixie
24b06d8998 Specs: Initial hack at extensible style/layout
Review URL: https://codereview.chromium.org/716013002
2014-11-13 14:00:46 -08:00
Elliott Sprehn
586849aed1 Remove some unused methods from Node and ContainerNode.
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/722313002
2014-11-13 12:50:29 -08:00
Benjamin Lerman
9894ef82e0 Revert "Add a version of flights that's made of components."
This reverts commit e8fdb90bca3120d1c991256a2adf83a8315bf867.

This CL breaks the linux bots:
https://chromegw.corp.google.com/i/client.mojo/builders/Mojo%20Linux/builds/216/steps/mojob%20test/logs/stdio

TBR=esprehn@chromium.org

Review URL: https://codereview.chromium.org/722103002
2014-11-13 09:59:26 +01:00
Elliott Sprehn
b9a6e48dcb Add a version of flights that's made of components.
Also add a test, this checks nested Shadow DOM and <content> with
and without select.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/724613002
2014-11-12 18:42:24 -08:00
Rafael Weinstein
f5bed9da06 Remove moar composited scrolling from sky
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/722063002
2014-11-12 18:14:51 -08:00
Adam Barth
88a6505c93 Re-enable the editing tests
Now that we have event sender, we can test editing again.

R=rafaelw@chromium.org

Review URL: https://codereview.chromium.org/723863002
2014-11-12 17:01:14 -08:00
Viet-Trung Luu
f04532944e Make test_sky output to (e.g.) out/Debug/layout-test-results instead of webkit/Debug/layout-test-results.
Also remove webkit/{Debug,Release} from the .gitignore.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/722913002
2014-11-12 16:55:42 -08:00
Rafael Weinstein
c1e4c67c23 Remove WebScroll*
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/720713003
2014-11-12 16:41:12 -08:00
Matt Perry
14311469fc Fix iframe.sky layout test failure.
Added extra newline.

R=sky@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/723643004
2014-11-12 17:38:21 -05:00
Adam Barth
b75be5c88b Fix contenteditable
You can now make elements editable using the contenteditable attribute.

R=rafaelw@chromium.org

Review URL: https://codereview.chromium.org/716223003
2014-11-12 14:37:41 -08:00
Eric Seidel
276829db22 Replace (unused) FontPlatformData.* with harfbuzz variants.
R=ojan@chromium.org, abarth@chromium.org

Review URL: https://codereview.chromium.org/717343002
2014-11-12 14:22:55 -08:00
Eric Seidel
97f80336f9 Bring back ScriptDebugServer and associated machinery
Eventually all of this should be moved out of Sky
and instead sit on top of Sky as just a mojo v8 debug service
but for now I'm just bringing back what we had in Blink
so I can make it work with our new inspector backend
and then we can move it out.

I also sorted gn lists and fixed two .idl files
which were in the wrong sources list in core.gni.

R=abarth@chromium.org, yurys@chromium.org

Review URL: https://codereview.chromium.org/723773002
2014-11-12 14:21:44 -08:00
Matt Perry
5907fa183a Sky: Add a test for the <iframe> element.
Had to disable a DCHECK for now. Scott will investigate why the DCHECK is hit.

BUG=432658
R=sky@chromium.org

Review URL: https://codereview.chromium.org/722713003
2014-11-12 16:50:34 -05:00
Dan Albert
e8b4a1b78a am dc81fbad: am 69d4fba2: Move frameworks/minikin over to libc++.
* commit 'dc81fbad809f08564199c8f08df7e7f72310961a':
  Move frameworks/minikin over to libc++.
2014-11-12 21:31:35 +00:00
Adam Barth
5192329f25 Script-based imports should basically work
This CL adds the beginning of a new module loading system that matches the
conceptual module in the spec. I've writed it up to the import API on
AbstractModule. In a future CL, I'll replace the old module loading system with
this one.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/720903002
2014-11-12 13:29:14 -08:00
Dan Albert
dc81fbad80 am 69d4fba2: Move frameworks/minikin over to libc++.
* commit '69d4fba2f2b7bb2c248cc0e78cf277a6e44665f8':
  Move frameworks/minikin over to libc++.
2014-11-12 21:28:22 +00:00
Adam Barth
a8cf7c7b43 Remove dynamic cast from DocumentPaser interface
This CL cleans up the DocumentParser interface to match what's actually needed
by clients. As part of this cleanup, I've removed the asHTMLDocumentParser
dynamic cast and just exposed virtual functions for the state folks were
accessing via the dynamic cast.

R=ojan@chromium.org, eseidel@chromium.org

Review URL: https://codereview.chromium.org/722743002
2014-11-12 13:23:50 -08:00
Adam Barth
79ae83b21f Make the parser an implementation detail of the Document
This CL removes the parser accessors from the document to prevent folks from
grabbing at it.

R=ojan@chromium.org, eseidel@chromium.org

Review URL: https://codereview.chromium.org/723583002
2014-11-12 13:22:45 -08:00
Elliott Sprehn
0ae7b5288f Improve SkyElement.
- Don't stamp the template repeatedly when attaching.
- Don't use __proto__
- Store the template in an external map instead of a property on the prototype.
- Add a created() callback.
- Allow creating a SkyElement with no associated <template> or ShadowRoot.

R=rafaelw@chromium.org

Review URL: https://codereview.chromium.org/715203002
2014-11-12 12:32:39 -08:00
Eric Seidel
5bdc6515b9 Re-land 714393002 after fixing android build.
Original CL:
https://codereview.chromium.org/714393002

Reverted in:
https://codereview.chromium.org/719063002

One fix was to use static_assert instead
of _Static_assert in COMPILE_ASSERT.

_Static_assert is C11, static_assert is C++11
and Android's stdlib doesn't have C11 support,
but we don't care since we never use COMPILE_ASSERT
in plain C code.

The second fix was also for the android STL
and was adding back the nullptr_t type
definition in NullPtr.h for old versions of STL.

I compile this locally for android to verify
that it works
mojo/tools/mojob.py build --android

TBR=jamesr@chromium.org,qsr@chromium.org

Review URL: https://codereview.chromium.org/722723003
2014-11-12 12:16:05 -08:00
Eric Seidel
11c0649769 Add headers to gn/gni files for all of sky/engine
Also sorted the sources.

This stops sky/tools/missing_from_gn from complaining
about our headers being missing.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/715163002
2014-11-12 11:36:37 -08:00
Adam Barth
295f292722 Implement event sender service for testing
This service lets us send Mojo events during testing.

R=eseidel@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/716043002
2014-11-12 10:46:35 -08:00
Adam Barth
411a9113b8 Input events are broken in skydb
When we removed Aura from the build, we broke event targeting. This CL hacks
around the issue by blindly forwarding events from the root view to the content
view in skydb. Once we have proper event targeting, we should rip out this code.

R=erg@chromium.org

Review URL: https://codereview.chromium.org/714213003
2014-11-12 10:32:54 -08:00
Benjamin Lerman
59f42240ba Revert "Remove support for MSVC"
This reverts commit d9cfbefcfe8710f1cb190ae817757853c8058797.

This CL broke android build:
http://build.chromium.org/p/client.mojo/builders/Mojo%20Android%20Builder%20%28dbg%29/builds/248

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/719063002
2014-11-12 13:31:10 +01:00
Dan Albert
69d4fba2f2 Move frameworks/minikin over to libc++.
Bug: 15193147
Change-Id: I5e15c95415c39515340e2663acd5fd26666db720
2014-11-11 19:32:48 -08:00
Eric Seidel
4ab80f640b Remove support for MSVC
I also removed COMPILER_SUPPORTS since
all of the checks were for old versions of
GCC which we no longer support.

Mojo requires GCC 4.8 or later.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/714393002
2014-11-11 16:59:04 -08:00
Ojan Vafai
ec084dc47a Make paddingBoxRect less dumb.
It was calling contentWidth, which did clientWidth - padding,
and then adding the padding back in.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/715053004
2014-11-11 16:58:33 -08:00
Rafael Weinstein
c1a54c9be7 Fix typo-breakage
TBR=ojan

Review URL: https://codereview.chromium.org/715873005
2014-11-11 16:53:08 -08:00