This is a port of
f61746083f
.
This patch eliminates the tag "[0708/123945:INFO:builtin_natives.cc(86)]
CONSOLE" prefixing each message in sky log Android output by
implementing the Android logging directly, ie. without base LOG macros.
The log message is now written directly to stdout on Android as well as
on Linux and iOS, and is also written to android logcat tagged as
"chromium", which is the tag we use to pick up native LOG messages from
the logcat when running on unrooted device.
A user running `mojo_shell.py --sky` on a rooted device will now see:
hello
instead of
[0715/174636:INFO:builtin_natives.cc(86)] CONSOLE: hello
A user running `mojo_shell.py --sky` on unrooted device will now see:
I/chromium(29585): hello
instead of
I/chromium(26587): [0715/174636:INFO:builtin_natives.cc(86)] CONSOLE: hello
Fixes#317.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1237403002 .
Previously, the standard C tolower() function was used, which
didn't support any characters beyond the basic ASCII letters.
Bug: 22506121
Change-Id: Ibb81121caa29be44fbb59aa98891e9faafc57592
Drawer uses this when you fling it.
I refactored Timeline to be based on AnimatedSimulation. When playing normally,
we use a TweenSimulation, which just gives values linearly in a range. You can
optionally replace this simulation with one of your choice (in Drawer's case, a
SpringSimulation).
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1233653003 .
- Instead of using a ColorFilter or an Opacity widget to colorize the Icons,
add a ColorFilter parameter it the image classes. This avoids needing to
call saveLayer for each DrawerItem.
- Ask Android for unbuffered input events to avoid bad synchronization with
vsync.
R=ianh@google.com
Review URL: https://codereview.chromium.org/1236043004 .
This adds various hyphen-like characters missed in the previous
patch, that should disallow automatic hyphenation of words containing
them.
Bug: 22484266
Change-Id: Ie972cb50384dbe0aa1ab5ec50286b75f9877953a
Also updated the createDefaultScrollSimulation()
springConstant and drag parameters to make
non-overscroll fling scrolls slowdown faster and
overscrolls snap back into place a little more
snappily.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1241733002 .
Previously, the scrollable classes were adding a material, which created a
background that obscured the menu background. This CL removes that background
and improves the animation parameters for the popup menu.
R=ianh@google.com
Review URL: https://codereview.chromium.org/1235233004 .
Previously, automatic hyphenation blindly took almost every line
breaking opportunity as a word break, so words like "low-budget" were
treated as two separate words, "low-", and "budget", each
automatically hyphenated.
This patch makes sure the subwords in already-hyphenated phrases are
not passed to the automatic hyphenator, while keeping the possibility
of a potential line break where a hyphen already exists.
Bug: 22484266
Bug: 22287425
Change-Id: Ie46dbdd70e993d64a9b9cf44b4ae93b21459dbc2
Rather than using a controller, the PopupMenu now takes input via its
constructor. I'm not 100% happy with PopupMenuStatusChangedCallback, but we can
continue to iterate.
Also, fix the positioning of the menu to be correct.
R=jackson@google.com
Review URL: https://codereview.chromium.org/1234063003 .
There's four hooks: one draws a teal box around the size, one draws a
green line and an orange line at the alphabetic and ideographic
baselines, and one clips at the paintBounds.
I also implemented Rect.shift() and Rect.inflate() to adjust Rects in
various ways that were helpful while developing this.
The baseline logic now lets you ask for the baseline _without_ the
no-baseline adjustment, in case you only care about the baseline when
there is a real one.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1233623007 .