20087 Commits

Author SHA1 Message Date
Adam Barth
1a3a35e23c Merge pull request #1507 from abarth/image_decoding
NetworkImage occasionally does not grab the image
2015-10-06 10:51:21 -07:00
Viktor Lidholt
6c78e664e1 Merge pull request #1508 from vlidholt/master
Improvements to sprite physics
2015-10-06 10:44:47 -07:00
Viktor Lidholt
8863bacbc2 Forwards physics body properties to box2d in sprite physics 2015-10-06 10:39:26 -07:00
Adam Barth
3905b95985 NetworkImage occasionally does not grab the image
I haven't been able to reproduce this bug consistently, but my theory is that
the ImageDecoder was being garbage collected before it called its completion
callback. This patch prevents that by keeping a reference to the image decoder
while the callback is in flight.

Fixes #801
2015-10-06 10:37:55 -07:00
Adam Barth
398400a3bc Merge pull request #1503 from abarth/simplify_scaffold
Simplify Scaffold
2015-10-06 10:09:35 -07:00
Adam Barth
7d5412eb60 Merge pull request #1504 from abarth/tab_shadow
ToolBar with a TabBar shouldn't have a shadow
2015-10-06 10:08:11 -07:00
Adam Barth
6601b5dfa9 Simplify Scaffold
Rather than using a custom render object, we can just use a Stack.
2015-10-06 10:06:17 -07:00
Viktor Lidholt
64fd2b192d Adds forwarding of properties to box2d in sprite physics 2015-10-06 09:59:16 -07:00
Viktor Lidholt
eb2709eafe Merge pull request #1506 from vlidholt/master
Fixes to demo game
2015-10-06 09:57:21 -07:00
Adam Barth
ed041a2971 Merge pull request #1501 from abarth/initial_page
PageableList should take initialPage instead of initialScrollOffset
2015-10-06 09:51:35 -07:00
Adam Barth
35662d03bd Rev pub package 2015-10-06 09:51:00 -07:00
Adam Barth
87960ec1c2 Rev pub package 2015-10-06 09:45:20 -07:00
Adam Barth
1b70ffadda Make MimicableState public again
This state object has a public API.
2015-10-06 09:33:33 -07:00
Viktor Lidholt
bf4342fa9a Adds default text style 2015-10-06 09:28:05 -07:00
Adam Barth
8e1583af38 ToolBar with a TabBar shouldn't have a shadow
This patch makes the level of the ToolBar configurable. I've also cleaned up
the Tab code slightly.

For some reason, there's still a hairline between the ToolBar and the TabBar.
We might need to rethink how we draw the background a bit here.

Fixes #1454
2015-10-05 23:41:14 -07:00
Adam Barth
ab3035037e Merge pull request #1502 from abarth/private_state
Mark most State subclasses private
2015-10-05 22:27:28 -07:00
Adam Barth
3ccef40ca2 Mark most State subclasses private
In the vast majority of cases, folks should be interacting with the Widget
rather than its State.

Fixes #267
2015-10-05 21:54:33 -07:00
Adam Barth
06e49c0942 PageableList should take initialPage instead of initialScrollOffset
Fixes #900
2015-10-05 21:36:23 -07:00
Adam Barth
1710c20d0d Merge pull request #1499 from abarth/rm_animated_component
Delete AnimatedComponent
2015-10-05 21:32:28 -07:00
Adam Barth
d9c44f2e45 Delete AnimatedComponent
This class has no clients.
2015-10-05 17:35:51 -07:00
Ian Hickson
6f82b1c903 Merge pull request #1496 from Hixie/focus
Fix Focus
2015-10-05 17:32:52 -07:00
Adam Barth
27f1359728 Merge pull request #1484 from abarth/snackbar_route
Use Navigator to drive SnackBar
2015-10-05 17:32:47 -07:00
Adam Barth
57002a4ab5 Merge pull request #1497 from abarth/create_performance_earlier
Create the Performance for a Route earlier
2015-10-05 17:32:41 -07:00
Adam Barth
5a1cf0b791 Create the Performance for a Route earlier
Instead of waiting until build(), we now create the performance for a route in
its constructor.
2015-10-05 17:20:08 -07:00
Adam Barth
a5907c6f12 Use Navigator to drive SnackBar
Now SnackBar is an ephemeral route that uses a Placeholder to put itself into
the Scaffold.

Fixes #673
2015-10-05 17:12:50 -07:00
Hixie
9f2429550c Fix Focus
Focus.at() and company should be on Focus, not FocusState.

_notifyDescendants() was using the wrong runtimeType.

Let InheritedWidget update the descendants during build.

When you setState() during build, assert that you're not
markNeedsBuild()ing someone who isn't a descendant.

Typo in Widget.toString().
2015-10-05 16:41:50 -07:00
Viktor Lidholt
4599f809dc Makes physics bodies fixture elements settable 2015-10-05 16:13:32 -07:00
Kris Giesing
2b6acbb4dd Merge remote-tracking branch 'upstream/master' 2015-10-05 15:07:03 -07:00
Ian Hickson
74f85c7ae5 Merge pull request #1490 from Hixie/navigator-ensure-pop
Handle a route being dismissed before being popped
2015-10-05 13:59:59 -07:00
Ian Hickson
7be4dc4d63 Merge pull request #1489 from Hixie/cleanup
Add more debugging information to Widgets.
2015-10-05 13:59:56 -07:00
Ian Hickson
fa37693a0a Merge pull request #1488 from Hixie/RouteArguments
Simplify the usage of Navigator's routes argument
2015-10-05 13:59:45 -07:00
Hixie
3467f32a1f Simplify the usage of Navigator's routes argument
(These are changes cherry-picked from in-flight branches since they are
more independent and could be helpful even without those changes.)

- Change RouteBuilder's signature to take a single argument in which the
  other fields are placed, so that we can keep iterating on those
  arguments without having to break compatibility each time. Also, this
  makes defining route builders much simpler (only one argument to
  ignore rather than a variable number).

- Expose the next performance to RouteBuilders, since sometimes the
  route itself might not be where it's used.

- Allow BuildContext to be used to walk children, just like it can for
  ancestors

- Allow BuildContext to be used to get the Widget of the current
  BuildContext

- Allow StatefulComponentElement to be referenced with a type
  specialisation so that you don't have to cast when you know what the
  type you're dealing with actually is.
2015-10-05 13:59:30 -07:00
Viktor Lidholt
ad130b3ef9 Merge pull request #1492 from vlidholt/master
Handle removal of sprite physics bodies during the physics simulation
2015-10-05 13:51:55 -07:00
Viktor Lidholt
d97a07c94c Handle removal of sprite physics bodies during the physics simulation 2015-10-05 13:47:51 -07:00
Hixie
01887db498 Handle a route being dismissed before being popped
Ensure that if a route's performance is dismissed before the route is
popped, that we pop the route.
2015-10-05 13:38:07 -07:00
Hixie
940d896456 Add more debugging information to Widgets.
Also, fix comment mentioning syncConstructorArguments.
2015-10-05 13:18:06 -07:00
Adam Barth
575a0dea5d Merge pull request #1487 from abarth/merge_curve_into_interval
Give Interval a Curve to apply between start and end
2015-10-05 12:43:44 -07:00
Adam Barth
80d1218487 Give Interval a Curve to apply between start and end
This patch simplifies AnimationTiming and all the AnimatedValue base classes.
Also, make PopupMenu a stateless component because it has no state.

Fixes #1168
2015-10-05 12:10:48 -07:00
Viktor Lidholt
74f8e53209 Merge pull request #1486 from vlidholt/master
Prevents sprite update methods to be called before the sprite box has…
2015-10-05 11:58:09 -07:00
Viktor Lidholt
f3b2cbba74 Prevents sprite update methods to be called before the sprite box has been property intialized 2015-10-05 11:24:59 -07:00
Adam Barth
ed821009a7 Merge pull request #1485 from abarth/animation_renames
Improves names of animation classes
2015-10-05 10:57:07 -07:00
Adam Barth
bcb0fe2fed Improves names of animation classes
Fixes #1170
2015-10-05 10:51:43 -07:00
Chinmay Garde
7ec9e44f96 Merge pull request #1462 from chinmaygarde/master
Allow displaying compositor statistics via a widget
2015-10-05 10:31:38 -07:00
Chinmay Garde
171b3b5ce3 Allow displaying compositor statistics via a widget
Example:
  import 'package:sky/widgets.dart';
  void main() => runApp(new Center(child:
      new StatisticsOverlay.allEnabled()));
2015-10-05 10:30:19 -07:00
Adam Barth
4d7da9cfa0 Merge pull request #1483 from abarth/drawer_fail
Convert Drawer to using navigator
2015-10-05 10:27:53 -07:00
Adam Barth
84620c1584 Merge pull request #1480 from abarth/rm_animated_simulation
Remove AnimatedSimulation
2015-10-05 10:24:44 -07:00
Adam Barth
ec890ace01 Convert Drawer to using navigator
This patch converts drawer to using the "openDialog" pattern for managing its
state. Currently, the drawer entrance and exit animation aren't integrated with
the navigator's animation system because the drawer's animations can be stopped
and reversed, which the navigator can't yet understand. That means dismissing
the drawer via the system back button causes the drawer to be removed
instanteously.

Fixes #715
Fixes #1187
2015-10-05 10:24:19 -07:00
Adam Barth
6cb793e37e Remove AnimatedSimulation
This patch folds the functionality from AnimatedSimulation into Timeline.
2015-10-05 10:13:11 -07:00
Adam Barth
14cf4a1748 Merge pull request #1479 from mdakin/simplfy_digger
Simplfy resetting board and mine generation.
2015-10-04 15:21:53 -07:00
Adam Barth
647aba8f4a Merge pull request #1478 from abarth/simplify_animation
Simplify animation
2015-10-03 14:55:43 -07:00