DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
20,087 Commits 882 Branches 1,069 Tags
Commit Graph

25 Commits

Author SHA1 Message Date
Chris Bracken
c449c8ee50
Eliminate FLUTTER_NOLINT where possible (#21904) 
This removes most of the remaining FLUTTER_NOLINT comments and opts
these files back into linter enforcement.

I've filed https://github.com/flutter/flutter/issues/68273 to require
that all FLUTTER_NOLINT comments be followed by a GitHub issue URL
describing the problem to be fixed.
 2020-10-16 12:44:49 -07:00
Chris Bracken
2cd1753c6c
[darwin] Header #import hygiene (#21193) 
This patch applies the following changes:

* Rename a stray .cc file to .mm (connection_collection.cc).
* Migrate Objective-C #includes to #import as per the style guide.
* #include/#import order updated to reflect the style guide order:
  associated header, system/standard library headers, library headers,
  platform-specific includes.
* Include cstring where we're using strlen.
* Add a missing copyright header in SemanticsObjectTest.mm.

Bugs: https://github.com/flutter/flutter/issues/60025
 2020-09-15 18:44:09 -07:00
gaaclarke
21efd7325e
Made the linter print out more information in its output and fixed bugs (#19895) 2020-07-22 15:38:09 -07:00
gaaclarke
41c503cc23
Changed iOS channels to start cleaning up the accessibility handler when the bridge is deleted (#19556) 
Started cleaning up the accessibility handler when the bridge is
deleted and made nilling out channels safer by making sure they don't
overwrite newly setup handlers.
 2020-07-08 13:26:29 -07:00
gaaclarke
8f6590cbbc
Added "unrecognized-selector" errors to match g3 builds (#17566) 
Added "unrecognized-selector" errors to match g3 builds, added
"overriding-method-mismatch" to catch a common error.
 2020-04-07 13:28:42 -07:00
Chris Bracken
b2cc00f078
Revert "Added errors to match g3 builds and simple errors (#17536)" (#17564) 
Test failure:

    [ RUN      ] FlutterStringCodec.CanEncodeAndDecodeNil
    2020-04-07 10:21:25.091 flutter_channels_unittests[26965:163315] *** Assertion failure in -[FlutterStringCodec encode:], ../../flutter/shell/platform/darwin/common/framework/Source/FlutterCodecs.mm:36
    2020-04-07 10:21:25.118 flutter_channels_unittests[26965:163315] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: ''
    *** First throw call stack:
    (
    	0   CoreFoundation                      0x00007fff2ccabcf9 __exceptionPreprocess + 256
    	1   libobjc.A.dylib                     0x00007fff5785ea17 objc_exception_throw + 48
    	2   CoreFoundation                      0x00007fff2ccc6a16 +[NSException raise:format:arguments:] + 98
    	3   Foundation                          0x00007fff2ef58e11 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 194
    	4   flutter_channels_unittests          0x0000000105f1cce2 -[FlutterStringCodec encode:] + 290
    	5   flutter_channels_unittests          0x0000000105f01bbb _ZN45FlutterStringCodec_CanEncodeAndDecodeNil_Test8TestBodyEv + 107
    	6   flutter_channels_unittests          0x00000001081d1732 _ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS4_FS3_vEPKc + 146
    	7   flutter_channels_unittests          0x00000001081a76b0 _ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS4_FS3_vEPKc + 128
    	8   flutter_channels_unittests          0x00000001081a75c1 _ZN7testing4Test3RunEv + 209
    	9   flutter_channels_unittests          0x00000001081a8415 _ZN7testing8TestInfo3RunEv + 229
    	10  flutter_channels_unittests          0x00000001081a95aa _ZN7testing9TestSuite3RunEv + 266
    	11  flutter_channels_unittests          0x00000001081b4e43 _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 995
    	12  flutter_channels_unittests          0x00000001081d8572 _ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc + 146
    	13  flutter_channels_unittests          0x00000001081b49b3 _ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc + 131
    	14  flutter_channels_unittests          0x00000001081b4835 _ZN7testing8UnitTest3RunEv + 197
    	15  flutter_channels_unittests          0x0000000105f22e73 _Z13RUN_ALL_TESTSv + 35
    	16  flutter_channels_unittests          0x0000000105f22d79 main + 553
    	17  libdyld.dylib                       0x00007fff5908c3d5 start + 1
    )
    libc++abi.dylib: terminating with uncaught exception of type NSException
    [ERROR:flutter/fml/backtrace.cc(110)] Caught signal SIGABRT during program execution.
    Frame 0: 0x7fff591316a6 abort
    Frame 1: 0x7fff560ea641 __cxa_bad_cast
    Frame 2: 0x7fff560ea7df default_unexpected_handler()�
    Frame 3: 0x7fff57860ee3 _objc_terminate()�
    Frame 4: 0x7fff560f619e std::__terminate(void (*)())�
    Frame 5: 0x7fff560f5f86 __cxa_get_exception_ptr
    Frame 6: 0x7fff560e8f99 __cxa_get_globals
    Frame 7: 0x7fff5785eb51 objc_exception_throw
    Frame 8: 0x7fff2ccc6a16 +[NSException raise:format:arguments:]
    Frame 9: 0x7fff2ef58e11 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:]
    Frame 10: 0x105f1cce2 -[FlutterStringCodec encode:]
    Frame 11: 0x105f01bbb FlutterStringCodec_CanEncodeAndDecodeNil_Test::TestBody()�
    Frame 12: 0x1081d1732 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)�
    Frame 13: 0x1081a76b0 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)�
    Frame 14: 0x1081a75c1 testing::Test::Run()�
    Frame 15: 0x1081a8415 testing::TestInfo::Run()�
    Frame 16: 0x1081a95aa testing::TestSuite::Run()�
    Frame 17: 0x1081b4e43 testing::internal::UnitTestImpl::RunAllTests()�
    Frame 18: 0x1081d8572 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)�
    Frame 19: 0x1081b49b3 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)�
    Frame 20: 0x1081b4835 testing::UnitTest::Run()�
    Frame 21: 0x105f22e73 RUN_ALL_TESTS()�
    Frame 22: 0x105f22d79 main
    Frame 23: 0x7fff5908c3d5 start

This reverts commit d1c90b4284282f9745ecd7c65aa72c612df671c1.
 2020-04-07 10:32:38 -07:00
gaaclarke
d1c90b4284
Added errors to match g3 builds and simple errors (#17536) 
"unrecognized-selector" and "overriding-method-mismatch" added as errors.
 2020-04-07 10:03:49 -07:00
liyuqian
b3075b3091
Rename GPU thread to raster thread in code comments (#17329) 
1. Simple "GPU thread" to "raster thread" replacement.

2. Regex replace "GPU([\n\r\s]+//+ thread)" with "raster$1".

3. Regex replace "// gpu$" with "// raster".

4. Simple test change.

5. Run ci/format.sh
 2020-03-25 22:49:59 -07:00
Chinmay Garde
cedddb7075
Document texture registry threading requirements. (#17149) 2020-03-13 18:55:58 -07:00
gaaclarke
d323bace5f
doxygen tooling updates and doxygen for FlutterCodecs.h (#16947) 
- added tools to help us document Flutter.framework for iOS
- filled in FlutterCodecs.h's missing documentation
 2020-03-06 16:06:06 -08:00
gaaclarke
c15f239c1e
documented fluttertexture.h (#16950) 2020-03-06 14:28:56 -08:00
CloudWebRTC
0f9d88c7b6 Add texture support for macOS shell. (#8507) 2019-10-09 20:35:09 -07:00
gaaclarke
e9c2102373
Expanded channel buffer resize to method channels. (#12725) 
* Expanded channel buffer resize to method channels.
 2019-10-02 17:59:59 -07:00
gaaclarke
f407e06970
Resize channel buffers (#12402) 
Made it so you can resize channel buffers by sending messages to them.
 2019-10-01 10:31:25 -07:00
gaaclarke
669cbba088
Cleanup: Made a macro to assert ARC is enabled. (#12701) 
Cleanup: Made a macro to assert ARC is enabled (and its inverse).
 2019-09-30 14:47:54 -07:00
gaaclarke
933f83e303
Added unit tests for method channels. (#12373) 
Added unit tests for method channels.
 2019-09-20 14:25:56 -07:00
Francisco Magdaleno
ef26c460ab
Finish plumbing message responses on method channels (#11877) 2019-09-04 16:17:10 -07:00
Francisco Magdaleno
cfa6c7c72b
[macos] Reland function refactor (#10189) 
* [macos] Reland function refactor

* Fix bug
 2019-07-31 10:57:02 -07:00
Francisco Magdaleno
330b0f023c
Revert "[macos] Revert check on FlutterCodecs and refactor message function] (#10009)" (#10141) 
This reverts commit bd3870219a1a7f6e18c94430ead9e0f8375b03b1.
 2019-07-25 13:47:29 -07:00
Francisco Magdaleno
bd3870219a
[macos] Revert check on FlutterCodecs and refactor message function] (#10009) 
* [macos] Revert check on FlutterCodecs and refactor message function]

* Remove duplicated code

* Move FlutterPlatformMessage initialization
 2019-07-23 15:22:38 -07:00
Francisco Magdaleno
6f3a2eb131
[macos] Add reply to binary messenger (#9953) 
* Add reply to binary messenger

* Address comments

* Formatting

* Address comments
 2019-07-22 11:08:08 -07:00
gaaclarke
7a0bbf9355
Fixed memory leak by way of accidental retain on implicit self (#9329) 
Fixed memory leak by way of accidental retain on implicit self.
 2019-06-28 10:22:51 -07:00
gaaclarke
54f88ab5da
Revert "Surrogate binary messenger (#9347)" (#9375) 
This reverts commit 2f36285bc8d486a584e0ea917fae90245f2c5168.

This was crashing the integration test `- (void)testDualFlutterView`.
 2019-06-19 12:29:08 -07:00
gaaclarke
2f36285bc8
Surrogate binary messenger (#9347) 
Created FlutterSurrogateBinaryMessenger to make sure that channels are
holding onto engines and not viewcontrollers.  This doesn't change the
public API but makes clients do what we want them to be doing, using
Engine for FlutterBinaryMessenger.
 2019-06-18 17:58:45 -07:00
stuartmorgan
e00ac47f49
Reorganize darwin for shared ios/macOS (#9255) 
When the macOS framework was initially landed, it included some iOS code
using a localized hack. This reorganizes the code structure to clearly
indicate which files are shared between iOS and macOS, vs. those that
are platform-specific.
 2019-06-17 11:24:41 -07:00