207 Commits

Author SHA1 Message Date
Ian Hickson
bef10d5a70 Implement i18n features in the a11y API. (flutter/engine#4029) 2017-08-28 16:12:39 -07:00
Jason Simmons
e4cc8f5e41 Rebase the libtxt integration by @GaryQian onto the current engine head (flutter/engine#4022)
See https://github.com/flutter/engine/pull/3964
2017-08-28 13:01:15 -07:00
Carlo Bernaschina
f3aaa23f74 Remove dependency from VM isolate name convention (flutter/engine#4007)
Dart_DebugName should be used just to make debug outputs more readable.

We remove the dependency from this API and form the UIDartState debug
name in the engine using the predefined format:
<script_uri>$main-<main_port>

This will allow the engine to change the format of the isolate name
without breaking the engine.
Related https://codereview.chromium.org/3004563003/
2017-08-25 11:11:52 -07:00
mikejurka
3bf835e3cd Fix crash when removing stories. (flutter/engine#4003)
Ensure that a Mozart EntityNode (that corresponds
to an ExportNode) is always released on the
Rasterizer thread.

MZ-259
2017-08-23 17:32:19 -07:00
Ian Hickson
066f1b719a Revert "Pass TextDirection to ParagraphBuilder. (#4001)" (flutter/engine#4004)
This reverts commit 515f72380cfd477ae08c04772dbfbe60cff384b9.
2017-08-23 11:14:26 -07:00
Ian Hickson
515f72380c Pass TextDirection to ParagraphBuilder. (flutter/engine#4001) 2017-08-23 10:34:57 -07:00
Ian McKellar
294cb8fa86 Update to new Dart FIDL bindings API. (flutter/engine#3988)
* Update to new Dart FIDL bindings API.
2017-08-22 13:32:46 -07:00
Jason Simmons
bd7ae44737 Allow infinity values in the Dart wrappers for Skia Canvas (flutter/engine#3985)
Fixes https://github.com/flutter/flutter/issues/11586
2017-08-16 16:21:52 -07:00
Zachary Anderson
1cf8c8f32e Fixes for gypi -> gni change in Dart (flutter/engine#3977) 2017-08-15 07:44:27 -07:00
Jason Simmons
22e8ceec69 Allow infinite cull rectangles on a Canvas (flutter/engine#3975) 2017-08-10 17:20:59 -07:00
Jason Simmons
89d9d751f9 Apply antialiasing in calls to SkCanvas::clipRect (flutter/engine#3973)
Without this, the cull rect calculated by an SkPicture may be truncated
to integer pixel coordinates.  The raster cache relies on a precise cull
rect in logical coordinates.

See https://bugs.chromium.org/p/skia/issues/detail?id=6954
2017-08-10 13:23:35 -07:00
Jason Simmons
d26681b396 Assert checks for NaN/infinite values in Skia canvas Dart wrappers (flutter/engine#3967) 2017-08-08 15:49:51 -07:00
Vyacheslav Egorov
e2889dacca hide Symbol exported from dart:_internal (flutter/engine#3861)
Both dart:core and dart:_internal export Symbol. 

This is silently ignored by the VM but some tools (e.g. fasta) report a warning when processing dart:ui sources.

See https://github.com/dart-lang/sdk/issues/30127 for more details.
2017-08-02 16:55:10 -07:00
xster
62ee1c8b95 Extend iOS's drawing time to viewWillAppear <-> viewDidDisappear (flutter/engine#3934)
* fix (with squashed debug stuff)

* clean up
2017-07-31 15:12:32 -07:00
Ian Hickson
a802c739ee More documentation, mainly around saveLayer. (flutter/engine#3932) 2017-07-28 14:38:42 -07:00
Ian McKellar
4ab42e4358 Use the tonic::HandleTable (flutter/engine#3924) 2017-07-26 12:19:34 -07:00
Jeff Brown
adef60fe5a Use metrics provided by scene events. (flutter/engine#3922)
Compute the necessary texture resolution using more accurate scaling
information provided by Mozart scene node metrics events instead of the
device pixel ratio provided by the Mozart view properties (which we
might remove in the future).

This allows us to allocate smaller textures when a Flutter view is
being scaled down.
2017-07-24 19:17:55 -07:00
Jason Simmons
2afa2eefd9 Incorporate the device pixel ratio when drawing shadows (flutter/engine#3919) 2017-07-24 12:01:43 -07:00
Alexander Aprelev
5bc3ac48a3 Update Flutter engine kernel-loading logic. (flutter/engine#3886)
* Fix Flutter loading from dill files.

* Remove disable of causal async stacks.

* Include mirrors patch files as they are needed for release/profile gen_snapshot

* Free the bytes

* Add FTL_DCHECK
2017-07-24 09:47:23 -07:00
Jason Simmons
7d72fbe1c5 Add an RRect.isRect property (flutter/engine#3908) 2017-07-19 17:30:31 -07:00
Chinmay Garde
79a8d775b6 Visualize image decoding and texture upload using trace flows. (flutter/engine#3907) 2017-07-19 16:22:06 -07:00
Ian Hickson
eb44210a77 Cleaner RRect.toString (flutter/engine#3906)
Will make debugging layer trees with PhysicalLayers easier.
2017-07-19 14:41:07 -07:00
Chinmay Garde
f7b67119d3 Update the content handler to use the Mozart session API. (flutter/engine#3887) 2017-07-18 15:40:18 -07:00
Brian Osman
1a126078de Revert "Revert "Reland "Run Flutter on iOS and Android with color correct Skia (#3826)" (#3878)" (flutter/engine#3895)
This reverts commit 849b700434fdcd3fc24f05640582b127654aa7d8.
2017-07-18 15:58:35 -04:00
Jason Simmons
29bacddb69 Accumulate a batch of Skia objects that will be destructed later on the IO thread (flutter/engine#3888)
See https://github.com/dart-lang/sdk/issues/29971
2017-07-18 11:45:34 -07:00
Collin Jackson
849b700434 Revert "Reland "Run Flutter on iOS and Android with color correct Skia (#3826)" (flutter/engine#3878)
This reverts commit 3cfb2821b9aa7f288d6aedd9f90c51b11bf451ad.

Fixes a regression with semitransparent images (flutter/flutter#11169)
2017-07-13 14:22:25 -07:00
Michael Goderbauer
e1232ee771 a11y: Add SemanticsAction "showOnScreen" (flutter/engine#3856)
This action is triggered when the user swipes (in accessibility mode) to the last visible item of a scrollable list to bring that item fully on screen.

iOS implementation to follow.
2017-07-12 15:52:30 -07:00
Ryan Macnak
5d12e39001 GN: Use a depfile when generating the core snapshot. (flutter/engine#3844)
Roll Dart to f445c318184b30b3db997ac27f357bcb5d45670a.

Fuchsia issue TO-365
2017-06-30 13:06:35 -07:00
Jason Simmons
3d24038b4c Report size estimates to Dart for Image/Picture/Paragraph objects (flutter/engine#3840)
Fixes https://github.com/flutter/flutter/issues/11007
2017-06-29 14:14:33 -07:00
Alexander Aprelev
f9f75ee26e Fix target name for flutter_patched_sdk so it doesn't conflict with patched_sdk target name, doesn't confuse ninja with depfile defined as .d (flutter/engine#3834) 2017-06-27 17:19:20 -07:00
Brian Osman
3cfb2821b9 Reland "Run Flutter on iOS and Android with color correct Skia (flutter/engine#3826)
* Revert "Revert "Reland "Run Flutter on iOS and Android with color correct Skia" (#3818)" (#3823)"

This reverts commit fdaab5c38fa82de669347508817b377285733946.

* Fix test code to match internal API change
2017-06-27 13:30:10 -04:00
Alexander Aprelev
e68386fee6 Generate flutter-flavoured dart patched sdk and platform.dill (flutter/engine#3814)
* Build Flutter patched-sdk with kernel artifacts

* Switch to new dart_host_toolchain argument mechanism to let dart patch_sdk know of host_toolchain.

* Update dart dependency

* Updated licenses

* Rename dart dependencies tag so they have just 'dart_'-prefixed dart's names.

* Fix indentation and line breaks for newly added deps.

* Add toolchain for windows host

* Update dart revision

* Licenses

* Update licenses

* Revert changes to licenses_third_party
2017-06-27 02:44:04 +00:00
Yegor
3efe108866 preserve Window callback zones (flutter/engine#3817)
* preserve Window callback zones

Run Window callbacks in the zone they are registered in. This is consistent with how other native API work, such as `scheduleMicrotask`, `Timer`, and `dart:io`. This also enables the developers to use the `Zone` API to capture and log unhandled Dart errors.

* refactor wrapping

* new line

* fewer if checks; group getters/setters/fields

* inline _invokeOnPointerDataPacket
2017-06-26 15:08:43 -07:00
Brian Osman
fdaab5c38f Revert "Reland "Run Flutter on iOS and Android with color correct Skia" (#3818)" (flutter/engine#3823)
This reverts commit cadd2d3fca1103ea0cbfb9f23dbc54907acac759.
2017-06-23 20:28:24 -04:00
Brian Osman
cadd2d3fca Reland "Run Flutter on iOS and Android with color correct Skia" (flutter/engine#3818)
* Revert "Revert "Run Flutter on iOS and Android with color correct Skia (#3743)" (#3775)"

This reverts commit c49f348d7c4238d653e7f3bbb8ce7cfab0996ad1.

* Enable sRGB on IO thread, too

* Add 4444 as a fallback rendering mode

* Use bare ptr to SkColorSpace (not sk_sp) in PrerollContext
2017-06-23 20:21:29 -04:00
Ian Hickson
f18a6da7d7 Throw exceptions rather than crashing when Canvas API is misused. (flutter/engine#3811)
This attempts to make the Canvas API and some related features more
likely to throw a Dart exception than crash when exposed to bad input.

Depends on rolling tonic to
https://fuchsia-review.googlesource.com/c/35742/ which this patch does
not yet do, but I wanted to put it up for review to see if it was even
a reasonable approach.
2017-06-22 17:06:59 -07:00
P.Y. Laligand
27b214136e Only add Fuchsia-specific stuff when the current OS is Fuchsia. (flutter/engine#3809)
This allows the shell to be built normally for a Fuchsia host.
2017-06-21 15:40:50 -07:00
Chris Bracken
1fd2bd9850 Revert libtxt integration (flutter/engine#3802)
* Revert "Fix licenses_lib golden file (#3798)"

This reverts commit d8ac43c3c9123fead15af3004d1e445834115bbd.

* Revert "Remove ParagraphConstriants (#3796)"

This reverts commit 2358613f9b6e3f3eee70f1cbfd2af92d3c049475.

* Revert "Reland "Initial integration of libtxt with Flutter alongside Blink." (#3793)"

This reverts commit d9bc2f5604e5cfef7deef2f813751e0cd46a515d.
2017-06-20 09:59:56 -07:00
Chris Bracken
22674ba9e6 Eliminate ASL stdout forwarding on iOS (flutter/engine#3797)
ASL was deprecated in iOS 10 and started causing SIGPIPE issues in iOS
10.3. Under the iOS 8 SDK, syslog() stopped working as of iOS 10.3
devices, with the result that ASL stdout/stderr forwarding was the only
means of logging. The engine now builds against the iOS 10 SDK, with
deployment target of iOS 8. Under this SDK, syslog() works correctly
across all supported OS versions.

NOTE: This is a temporary fix to get developers unblocked. While this
does fix the SIGPIPE issue and put iOS logging on par with the Android
solution, the intent is to move to a dedicated communication channel
with flutter_tools that isn't log-based.
2017-06-19 18:10:30 -07:00
Gary Qian
2358613f9b Remove ParagraphConstriants (flutter/engine#3796) 2017-06-19 17:12:54 -07:00
Gary Qian
d9bc2f5604 Reland "Initial integration of libtxt with Flutter alongside Blink." (flutter/engine#3793)
* Transition to Hybrid lib/txt and blink text system.
2017-06-19 15:21:41 -07:00
Ryan Macnak
bbc94b95a5 [fuchsia] core-jit (flutter/engine#3753) 2017-06-19 12:12:18 -07:00
Ian Hickson
aefd77ae94 Allow infinite cull rects. (flutter/engine#3787) 2017-06-16 23:43:12 -07:00
Ian McKellar
756341be6e Revert "Initial integration of libtxt with Flutter alongside Blink." (flutter/engine#3785)
* Revert "Enable line join styles and miter limit. (#3777)"

This reverts commit cafd4b93a06b6d327f1bc59e296bf2c618eb34e4.

* Revert "Revert "Update switches to use StringView." (#3784)"

This reverts commit 5ffa5ef3a6b2c8689c7d12cd67b6823ba25783a5.

* Revert "Initial integration of libtxt with Flutter alongside Blink. (#3771)"

This reverts commit b4a9f9c6d5008f677400826dfa3a0ab30de3db23.
2017-06-16 15:15:48 -07:00
gspencergoog
cafd4b93a0 Enable line join styles and miter limit. (flutter/engine#3777)
* Add support for join types and miter limits.

* Fix miter limit data type.

* Adding some clearer documentation to painting.dart

* Clarifying more documentation.

* Code review changes

* Fixed debug printing of stroke width and miter limit

* Adding missing periods at the ends of sentences.
2017-06-16 14:48:16 -07:00
Gary Qian
b4a9f9c6d5 Initial integration of libtxt with Flutter alongside Blink. (flutter/engine#3771) 2017-06-16 14:15:53 -07:00
Michael Goderbauer
c49f348d7c Revert "Run Flutter on iOS and Android with color correct Skia (#3743)" (flutter/engine#3775)
This reverts commit bac6502d62a3ab3157147b3d53776c3f16000a31.
2017-06-14 16:26:20 -07:00
Michael Goderbauer
89ab65beea Adding SemanticsFlag.isSelected (flutter/engine#3764)
* Adding SemanticsFlag.isSelected

* typo
2017-06-09 15:58:30 -07:00
mattsarett
bac6502d62 Run Flutter on iOS and Android with color correct Skia (flutter/engine#3743)
* Run Flutter on iOS and Android with color correct Skia (#3716)

***Turns on color correct rendering for Android and iOS
***Communicates dst color space to raster cache
***Turns on color space aware image decoding

Test:
***color_testing_demo on Pixel XL
***flutter_gallery on iPad Mini and iPad Pro (haven't figured out how to run manual_tests on iOS)

TODO:
I needed to split up this CL somewhere. These are follow-up tasks.
***Make desktop backends color correct
***Make debugging tools (ex: encoding frames to png) preserve color space
***Investigate using UIKit API to allow iOS to fine tune color space of rendered content
2017-06-09 08:39:21 -04:00
Ryan Macnak
aa1c5cb32f Plumbing for a core snapshot with code (currently empty). (flutter/engine#3749) 2017-06-07 09:57:24 -07:00