Devon Carew
e9a24510bd
fast fail update-packages
2016-04-05 10:22:36 -07:00
krisgiesing
5e3d8cf2d3
Merge pull request #3106 from krisgiesing/remove_getters
...
Remove public accessor for paint dirty state
2016-04-05 09:52:26 -07:00
Adam Barth
3665866fba
Add some sensible defaults to FixedColumnCountGrid and MaxTileWidthGrid
...
If we use null for these values, the implementations will later assert.
Fixes #3102
2016-04-04 20:47:05 -07:00
Tony Gentilcore
003d55db3f
Roll engine to 893425d96046e413e643d5de380dfaa2cc5725ed
...
This picks up a change which causes ChildViews to jank instead of flicker during resize.
2016-04-04 17:35:40 -07:00
Ian Hickson
70053fff07
Handle tables that don't have decorations.
2016-04-04 17:10:31 -07:00
Yegor
19e624ccfe
[driver] give the timeline data some structure
...
Fixes https://github.com/flutter/flutter/issues/2713
2016-04-04 17:07:16 -07:00
Ian Hickson
6ea7ab89ff
Add a row decoration to RenderTable
...
This will let us draw in-row bottom borders and row-wide backgrounds,
both of which are necessary for Material data tables.
2016-04-04 16:53:38 -07:00
Ian Hickson
d748186c51
Use callbacks for sending messages up the app
...
Using .of() to call mutating setters is not great practice since it ties
parts of the app together in ways that prevent reuse and composition.
Since people are now using the gallery app to copy from, let's use the
better practice of using callbacks.
2016-04-04 15:25:06 -07:00
Hans Muller
08bb332cbb
Merge pull request #3081 from HansMuller/gallery_tweaks
...
Gallery Tweaks
2016-04-04 14:26:23 -07:00
Devon Carew
653566dd23
simplify toolchain setup
2016-04-04 13:10:56 -07:00
Adam Barth
73bee3ae29
Document progress indicators
...
Specifically, explain how to create both determinate and indeterminate progress
indicators.
Fixes #3055
2016-04-04 12:32:37 -07:00
Ian Hickson
5291b37fc7
Track how many public Flutter members lack docs
...
* Enable the lint require documentation.
* Track how many public Flutter members lack docs
* Rename the .analysis_options file
This makes Atom happier in the flutter_tools package.
2016-04-04 12:18:13 -07:00
Adam Barth
767ce82646
Add support for discrete material sliders
...
Fixes #1541
2016-04-04 11:14:12 -07:00
Ian Hickson
daa0d2dfb3
Document newton more.
2016-04-03 23:33:34 -07:00
Ian Hickson
79cfe1e092
Make a variety of private State members actually private.
2016-04-03 13:08:00 -07:00
Ian Hickson
7f2efb2cfd
Further improve error reporting by wrapping messages.
2016-04-03 12:00:01 -07:00
Ian Hickson
ee703da9de
Rationalise all our exception handling.
...
- Create a FlutterErrorDetails struct-like class that describes an
exception along with more details that aren't in the exception, like
where it was caught and what was going on when it was caught.
- Provide a FlutterError static API for handling these objects:
- FlutterError.onError which is called whenever Flutter catches an
error.
- FlutterError.reportError() which handles an error.
- FlutterError.dumpErrorToConsole() which is the default behavior
for onError.
- Removes all the existing exception handler callbacks.
- Replaces all the existing places that described exceptions using
debugPrint with calls to FlutterError.reportError().
- Extend lockState() to also catch exceptions, so that we catch
exceptions that happen during finalizers.
- Make the test framework catch errors and treat them as failures.
- Provide a mechanism to override this behavior in the test framework.
- Make the tests that used to depend on the exception handler
callbacks use this new mechanism.
- Make pump() also support the phase argument.
- Improve some tests using these new features.
Fixes #2356 , #2988 , #2985 , #2220 .
2016-04-02 10:24:12 -07:00
Ian Hickson
3cd58547cd
Clean up and document icon button color logic
2016-04-01 21:23:01 -07:00
Ian Hickson
285c696f14
Column->Block, uppercase BUTTON captions
2016-04-01 21:22:55 -07:00
Adam Barth
665ac49b57
Add support for backdrop filters
...
For example, to implement backdrop blur effects.
2016-04-01 21:15:43 -07:00
Yegor
055fd00dc1
Merge pull request #3058 from yjbanov/timeline-summary
...
[driver] utility for extracting and saving timeline summary
2016-04-01 17:48:25 -07:00
Ian Hickson
71e689f450
Have a default default text style.
...
This way, widgets that try to use the DefaultTextStyle don't have to
handle the case where there isn't an explicit default.
2016-04-01 16:10:27 -07:00
Ian Hickson
6d58770499
Fix the fixed height card demo
...
Turns out card_collection had all kinds of bugs.
2016-04-01 16:10:22 -07:00
Viktor Lidholt
794b705133
Merge pull request #3052 from vlidholt/linedrawing
...
Initial version of complex layout performance test
2016-04-01 15:25:51 -07:00
Ian Hickson
b4e4c70375
Bring the hamburger menu back to card_collection
2016-04-01 14:55:20 -07:00
Ian Hickson
902391b048
Realign the slow mode banner to not overflow.
2016-04-01 14:54:58 -07:00
Ian Hickson
a05909e3a7
Merge pull request #3049 from Hixie/gallery
...
Tweak the typography demo to match the spec more
2016-04-01 14:36:01 -07:00
Adam Barth
ca4b5cf497
Polish drop-down padding
...
Previously we weren't padding the top and the bottom of drop-down menus but the
spec says these should have 8.0 pixel of padding, the same as popup menus.
Fixes #2683
2016-04-01 12:58:19 -07:00
Jason Simmons
379c563b62
Merge pull request #3034 from jason-simmons/gradle_flx_refresh
...
Support "flutter refresh" in the Gradle-based sample project
2016-04-01 12:39:04 -07:00
Devon Carew
f7e6100b08
sort imports
...
* sort imports
2016-04-01 11:32:02 -07:00
Adam Barth
c1440e2261
Merge pull request #3022 from abarth/polish_selection_controls
...
Polish selection controls
2016-04-01 11:14:04 -07:00
Andrew Wilson
d61f7809c8
Merge pull request #3012 from apwilson/leave
...
Leave all entered targets when finishing.
2016-04-01 10:47:49 -07:00
Andrew P. Wilson
f516dbcc2e
Leave all entered targets when finishing.
2016-04-01 09:45:28 -07:00
Devon Carew
d8155347c8
Merge pull request #3041 from devoncarew/pubspec_changes
...
pubspec normalization; remove den
2016-04-01 08:51:40 -07:00
Devon Carew
18d29583d0
pubspec normalization; remove den
2016-04-01 08:33:22 -07:00
Adam Barth
4cc9416bf2
Merge pull request #3026 from abarth/capture_closure
...
Capture closures around megamorphic dispatches
2016-04-01 08:30:18 -07:00
Adam Barth
622bec43be
Capture closures around megamorphic dispatches
...
The performLayout and build callsite are highly megamorphic because they
dispatch into a large number of clients. However, for a given caller, the
callee is always of the same type, which means the megamorphic lookup exactly
factors by the caller. We can speed up the dispatch by capturing a closure at
initialization and then monomorphically dispatching through the closure.
2016-04-01 08:19:37 -07:00
Adam Barth
fca2ac1189
Merge pull request #3023 from abarth/add_test
...
Add a scrolling test now that it passes
2016-04-01 08:16:35 -07:00
Collin Jackson
0be7a33b14
Merge pull request #3040 from collinjackson/update_engine_version
...
Update engine version
2016-04-01 07:42:51 -07:00
Adam Barth
f3d95b6f28
Merge pull request #3039 from abarth/more_snack_bar
...
Don't delay between dismissing a snack bar and the next snack bar
2016-04-01 07:30:43 -07:00
Collin Jackson
1c4c7deac4
Update engine version
2016-04-01 07:28:16 -07:00
Collin Jackson
b57004ea2b
Merge pull request #3038 from collinjackson/update_engine_version
...
Update engine
2016-04-01 01:01:45 -07:00
Adam Barth
884ec65c9e
Don't delay between dismissing a snack bar and the next snack bar
...
Previously, the Dismissable widget was animating down to zero width off
screen. Now, we tell it to skip the resize animation.
Fixes #3030
2016-03-31 23:25:03 -07:00
Adam Barth
c51d3914b7
Merge pull request #3035 from abarth/doc_updates
...
Add review feedback to dartdocs
2016-03-31 23:17:48 -07:00
Adam Barth
35d5b73ab5
Add review feedback to dartdocs
2016-03-31 23:06:11 -07:00
Collin Jackson
30d0767f77
Update engine
2016-03-31 18:28:51 -07:00
Adam Barth
cf80b90507
Merge pull request #3025 from abarth/fix_docs
...
Fix broken link in the docs
2016-03-31 17:32:42 -07:00
Adam Barth
c0842205ca
Merge pull request #3027 from abarth/drop_down
...
Drop is a separate word than down
2016-03-31 17:28:35 -07:00
Adam Barth
dbb7c2e850
Add a scrolling test now that it passes
...
We fixed this issue a different way but the test is still valuable.
2016-03-31 17:28:20 -07:00
Yegor
0b5b345134
Merge pull request #3019 from yjbanov/pause-event-workaround
...
[driver] switch to different pause event workaround
2016-03-31 16:56:24 -07:00