6580 Commits

Author SHA1 Message Date
Chinmay Garde
1a5ca2f675 Fix failing tooltip_test.dart by avoiding floating point comparisons. (#4781) 2016-06-28 12:49:11 -07:00
Chinmay Garde
b8bcd62e54 Remove counters used to tag variables and symbols in the solver for debugging purposes. (#4780) 2016-06-28 11:58:24 -07:00
Hans Muller
77cd8ee40e Reproduce the Shrine home page portrait grid layout (#4779) 2016-06-28 11:05:18 -07:00
Adam Barth
41d6303570 Improve test coverage for material.dart (#4776)
Previously these widget had zero test coverage. Also, improve the
coverage tooling Mac.
2016-06-28 08:48:48 -07:00
Adam Barth
14f42a6a48 Improve test coverage in rendering.dart (#4775) 2016-06-27 17:38:53 -07:00
Adam Barth
bb0c41f2a6 Improve test coverage for gestures.dart (#4773)
This patch adds tests for some code paths we weren't hitting before and removes
some dead code that couldn't be tested because it was unreachable.
2016-06-27 14:42:41 -07:00
Adam Barth
2898768dde Add some missing docs (#4772)
These docs complete the dartdocs for their respective libraries.
2016-06-27 14:42:25 -07:00
Adam Barth
2af668f832 Change how navigator prevents redundant operations (#4769)
* Change how navigator prevents redundant operations

Instead of requiring transactions, we now cancel all active pointers that are
interacting with the navigator and absorb future pointers until we get a chance
to build. This approach isn't perfect (e.g., events that trigger off the
cancelled pointers could still interact with the navigator), but it should be
better than the current transaction-based approach.

Fixes #4716

* Remove openTransaction

* test

* fixup
2016-06-27 13:07:47 -07:00
Hans Muller
08bf1b6bce Scrollable dropdown, dropdown underline cosmetics (#4766) 2016-06-27 10:28:20 -07:00
Adam Barth
5fc04dab74 Document State (#4762)
This patch documents State in detail because it's a very common class
for developers to work with and it has a number of subtles.
2016-06-26 16:22:20 -07:00
Kaiyuan Wang
ccf87bd083 Fix the issue that flutter driver does not close _peer (#4755)
* Fix the issue that flutter driver does not close _peer when
driver.close() is invoked.  The problem introduces the following
unexpected behavior:

  1. Launch an app using "flutter run ..." command
  2. Run the flutter driver test using "dart flutter_test.dart"

The test will not exit after running.  The problem will be solved
if _peer is closed.

* Fix formatting issue
2016-06-25 12:58:46 -07:00
Adam Barth
2fa6a709c9 Improve documentation for framework.dart (#4758) 2016-06-25 12:22:14 -07:00
Adam Barth
9c0c0225a6 Add a test for GridPaper (#4754)
Previously this widget was completely untested.
2016-06-24 20:46:17 -07:00
Hans Muller
0a4f96e2b6 Gallery about box: state Flutter's status and link to our website (#4746) 2016-06-24 17:54:21 -07:00
Chinmay Garde
ae835f08df Document the public members of the Cassowary package. (#4744) 2016-06-24 17:31:47 -07:00
Adam Barth
9850fe1861 Test all but one line in animation.dart (#4751)
The one line we don't test is the private constructor for the Curves class,
which exists to ensure that no one constructs the Curves class.
2016-06-24 16:33:04 -07:00
Adam Barth
b00efda7fc Improve change notifier (#4747)
This patch improves some subtle behaviors about the change notifier.
2016-06-24 15:53:48 -07:00
Chinmay Garde
490622b4da Add a wrapper for accessing the URL launcher service. (#4688) 2016-06-24 14:51:03 -07:00
Chinmay Garde
e41527a898 Update the engine to pull in changes related to url_launcher.mojom. (#4745) 2016-06-24 12:26:05 -07:00
Devon Carew
6cdfd86ad1 send the reload source command for ios simulators (#4731)
* send the reload source command for ios simulators

* review changes

* rewrite w/ a completer
2016-06-24 10:26:43 -07:00
Devon Carew
aa364a082d don't rewrite the console in non-ansi mode (#4735) 2016-06-24 09:56:04 -07:00
Adam Barth
46da9e8498 Add a simple way of merging coverage data (#4726)
`flutter test` now has a `--merge-coverage` flag that can be used to merge
coverage data from previous runs, enabling faster iteration cycles.
2016-06-23 18:02:55 -07:00
Devon Carew
4dd48882ef Update CONTRIBUTING.md (#4730) 2016-06-23 17:47:03 -07:00
Adam Barth
10931af0d3 Simplify coverage workflow (#4725)
We now download the base coverage file automatically.
2016-06-23 16:31:25 -07:00
Adam Barth
f20546a1d7 Remove drudge spam (#4724)
Stop spamming the console about drudge by pinning an earlier version of
json_scheme that doesn't spam.
2016-06-23 15:37:51 -07:00
Adam Barth
7b99ecff35 Use relative paths in lcov.info (#4722)
Using relative paths makes it easier to share lcov.info files across machines.
2016-06-23 15:29:54 -07:00
Hans Muller
68efa6a3fc Correct scrolling tabbar tab indicator size (#4723) 2016-06-23 15:17:17 -07:00
Adam Barth
05eef4a9b2 Get to 100% test coverage for src/animation/animations.dart (#4721) 2016-06-23 15:15:31 -07:00
Ian Hickson
8409526433 Update README.md 2016-06-23 14:03:26 -07:00
Ian Hickson
e53d3c2648 Update README.md 2016-06-23 14:02:56 -07:00
Adam Barth
56039c0e64 Improve test coverage for animation.dart (#4718)
We now have 100% coverage of animation.dart and animation_controller.dart.
Also, add some basic tools for working with lcov files. These tools need much
more polish.
2016-06-23 13:43:42 -07:00
Adam Barth
74761265bc Add dartdoc for tabs and text selection handles (#4715) 2016-06-23 13:43:16 -07:00
Adam Barth
4be730ac9a Only download cloud SDK if we need it on Travis 2016-06-23 11:56:20 -07:00
Hans Muller
c12c179a72 Make DataTable readable with the dark theme (#4717) 2016-06-23 10:59:07 -07:00
Ian Hickson
e5fb2fb0d3 An API for tracking software licenses. (#4711) 2016-06-23 10:34:11 -07:00
Adam Barth
bbf31cd3b7 Upload lcov.info to Google Storage (#4712)
Uploading the coverage data file to Google Storage will make it easier
for folks to get current coverage data quickly.
2016-06-23 10:23:13 -07:00
Phil Quitslund
55b51ee549 Merge pull request #4697 from pq/analyzer_0.27.4-alpha.14
Update to latest analyzer (0.27.4-alpha.14) and misc. analysis fixes.
2016-06-23 10:03:49 -07:00
pq
1cad4f4705 Fallback to a standard SDK if no embedders are found. 2016-06-22 19:30:46 -07:00
Adam Barth
4f133a6775 Don't run coverage on pull requests (#4710)
It's not reliable enough yet.
2016-06-22 17:52:08 -07:00
Adam Barth
73cd70f776 Add test coverage for lastElapsedDuration (#4705)
Also, fix the bug where apps would assert when you change the time dilation.
Use that mechanism to fix the animation controller tests.
2016-06-22 17:14:55 -07:00
Todd Volkert
e91f3eef46 Don't uninstall before installing in flutter run (#4699)
#4672
2016-06-22 15:43:57 -07:00
pq
b2fed16454 _BuildFunction => WidgetBuilder 2016-06-22 15:39:27 -07:00
pq
dcc7b144af Updated closure trampolines. 2016-06-22 15:25:25 -07:00
Hans Muller
bb2e7b5250 Add AppBar iconTheme parameter (#4693) 2016-06-22 15:19:31 -07:00
Adam Barth
e5eabf24fa Add Coveralls badge to README.md (#4700) 2016-06-22 15:11:24 -07:00
Adam Barth
ed2c24ba2b Add coveralls support to Travis (#4690)
This patch causes us to upload a coverage report to coveralls.io.
2016-06-22 14:47:41 -07:00
pq
352e2f573b Update to latest analyzer (0.27.4-alpha.14) and misc. analysis fixes.
* brings in analyzer version (`0.27.4-alpha.14`) corresponding to current Dart SDK (`1.18.0-dev.2.0`).
* updates analysis to use prefered API for embedder URI resolution
* adds trampolines to `State` and `StatelessWidget` to allow for warning-free within-library @protected access (needed since we closed off access to @protected closures from outside subclasses).
* turns off cache dependency tracking for analysis (in DDC this amounted to a 10% speed improvement).
2016-06-22 14:34:30 -07:00
Todd Volkert
0f2c3dc07f Fix multi-line colors on Linux (#4691) 2016-06-22 12:53:07 -07:00
Adam Barth
b094fa6dd3 Add support for --coverage to flutter test (#4679)
We need https://github.com/dart-lang/coverage/issues/100 to be fixed before
this will be useful.

Fixes #2342
2016-06-22 12:22:01 -07:00
Phil Quitslund
6c0b88aad6 Merge pull request #4683 from pq/1.18.0-dev.2.0
Bump Dart SDK to `1.18.0-dev.2.0`.
2016-06-22 11:32:47 -07:00