2592 Commits

Author SHA1 Message Date
Adam Barth
6e530ea862 Make pesto demo scroll fast (#4443)
We can viewport the content using a ScrollableGrid. Also, we can use the
padding mechanisms of the grid to avoid extra padding widgets.
2016-06-07 19:52:03 -07:00
Adam Barth
35ea6a1cef Improve gallery visuals on iOS (#4437)
1. Use the primary color brightness to determine the color of the status bar.
    The status bar overlaps the toolbar, which has the primary color.
 2. Use Roboto for text.
2016-06-07 16:32:14 -07:00
Adam Barth
7d9f8d903d Introduce TapDownDetails and TapUpDetails (#4431)
We have these details objects for the same reason we now have drag details
objects: future extensibility.
2016-06-07 16:16:53 -07:00
Adam Barth
cd23ca1242 Add more data to MediaQueryData.toString (#4426)
Fixes #4421
2016-06-07 16:16:47 -07:00
Ian Hickson
68f92d4f34 Provide UI to paginate PaginatedDataTable (#4382)
Also:
* Make PaginatedDataTable able to scroll itself horizontally.
* Make drop down buttons support having an explicit text style and icon
  size given.
* Fix a bug with drop-down buttons asserting when opened partly
  off-screen.
* Make sure to pop the drop-down button's route if the drop-down button
  is discarded while the route is up.
* Remove extraneous padding on drop-down buttons. (Couldn't figure out
  why it was there, and it breaks alignment when a drop-down is mixed
  with other text.)
* Some docs improvements.
* Add Route.isActive
* Add a setState() method to ModalRoutes.
2016-06-07 16:11:30 -07:00
Alhaad Gokhale
a880ced67d Fix adding child views to container after changes to dart bindings.
@abarth
2016-06-07 15:00:55 -07:00
Todd Volkert
7ac0ce7938 Add API for specifying the system overlay style. (#4422)
Fixes 3544
2016-06-07 14:39:15 -07:00
Adam Barth
69ce7f6984 runApp inside onPressed throws an exception (#4419)
We were trying to unregister the pointer route twice. Now we only unregister it
once.

Fixes #4341
2016-06-07 13:45:06 -07:00
Adam Barth
313c17faf8 Complete dartdoc for scrollable widgets (#4415) 2016-06-07 08:47:06 -07:00
Adam Barth
130f77177d Make Shrine scroll fast (#4408)
This fix isn't completely statisfying because it has a scaling limit. The ideal
fix would actually viewport the tiles in the grid. However, this fix is much
easier at the moment.

Fixes #4395
2016-06-06 20:23:40 -07:00
Matt Perry
5de581c6c8 Fix text selection painting to draw what the engine tells us. (#4397)
BUG=https://github.com/flutter/flutter/issues/4321
BUG=https://github.com/flutter/flutter/issues/4349
2016-06-06 18:29:54 -04:00
Adam Barth
48ed80b3be Simplify integration with Scrollable (#4394)
This patch exposes a convenience function on Scrollable that helps with
updating the scroll extents and ports several clients over to using it.
2016-06-06 14:51:31 -07:00
Adam Barth
b96d1dfc24 Tab labels incorrectly fade out (#4391)
Assigning to `size` called our intrinsic sizing functions re-entrantly, which
is a destructive operation on TextPainter. Ideally we'd made that a
non-destructive operation, but in the meantime we can fix the tab fading issue
by grabbing the text size before assigning to `size`.

Fixes #4365
2016-06-06 14:00:57 -07:00
Adam Barth
d9916bbb33 Complete the dartdoc for servics.dart (#4383)
Also, add more dartdoc to widgets.dart.
2016-06-05 23:58:38 -07:00
Adam Barth
daa0e7fa52 Fix DragUpdateDetails docs (#4350)
I changed the behavior late in the code review but didn't update this dartdoc.
2016-06-03 10:20:43 -07:00
Adam Barth
f2ea70d93e Add dartdoc to basic.dart (#4345)
This patch starts working through the missing dartdocs in widgets.dart.
2016-06-02 23:59:48 -07:00
Adam Barth
2d4acb8041 Convert drag gestures to use details objects (#4343)
Previously we supplied individual parameters to the various drag and pan
callbacks. However, that approach isn't extensible because each new
parameter is a breaking change to the API.

This patch makes a one-time breaking change to the API to provide a
"details" object that we can extend over time as we need to expose more
information. The first planned extension is adding enough information to
accurately produce an overscroll glow on Android.
2016-06-02 23:45:49 -07:00
Ian Hickson
5245d3889d Clean up the way RenderIntrinsicWidth works (#4340)
The old code had gotten crufty with all the refactors. This simplifies
it down to what it really means.

Also, add a bunch of tests.
2016-06-02 19:09:29 -07:00
Ian Hickson
d8283d1c62 RenderPadding's intrinsic should clamp child dims (#4329)
We used to rely on BoxConstraints.deflate's clamping, but now we have to
roll our own.
2016-06-02 17:29:28 -07:00
Hans Muller
309b9f8010 Version 0.0 of a gallery demo of the Material Design "Shrine" app (#4327) 2016-06-02 14:23:20 -07:00
Adam Barth
a464052191 Improve docs for paintImage (#4317)
We now describe what each parameter does.

Fixes #4256
2016-06-02 14:04:08 -07:00
Adam Barth
8ec26f02da Complete dartdocs for rendering.dart (#4316)
All of the public APIs in rendering.dart now have dartdocs.
2016-06-02 11:34:52 -07:00
Adam Barth
1ff7109b02 Mark State.setState as protected (#4295)
This required refactoring some cases where we weren't following the rules for
the protected annotation.
2016-06-02 10:46:12 -07:00
Adam Barth
6d4fd85054 Improve float action button transitions (#4309)
Previously the floating action button would disappear during transitions. Now
we animate properly. I've also centralized the animation in Scaffold instead of
spreading it across the Scaffold and the FloatingActionButton.

Fixes #1718
2016-06-01 17:00:55 -07:00
Ian Hickson
0618da7ca2 PaginatedDataTable (part 1) (#4306)
This introduces the key parts of a paginated data table, not including
the built-in pagination features.

* Provide more data for the data table demo, so there's data to page.

* Introduce a ChangeNotifier class which abstracts out
  addListener/removeListener/notifyListeners. We might be able to use
  this to simplify existing classes as well, though this patch doesn't
  do that.

* Introduce DataTableSource, a delegate for getting data for data
  tables. This will also be used by ScrollingDataTable in due course.

* Introduce PaginatedDataTable, a widget that wraps DataTable and only
  shows N rows at a time, fed by a DataTableSource.
2016-06-01 16:13:40 -07:00
Ian Hickson
bf6ae3ee76 Reenable the gallery smoke test (#4303)
...and fix some grid and table intrinsic issues it uncovered.
2016-06-01 15:34:48 -07:00
Ian Hickson
2d32f1f1a7 Fix fallout from intrinsics changes (#4299)
* Fix fallout from intrinsics changes

* Move away from isInfinite in favor of isFinite
2016-06-01 13:36:06 -07:00
Adam Barth
020b068896 Use protected and mustCallSuper in more places (#4291) 2016-06-01 08:27:19 -07:00
Adam Barth
887e339641 Start using protected annotation (#4288)
There are many more places we can use this annotation. This patch starts out
small to test the waters.
2016-05-31 17:41:34 -07:00
Adam Barth
a0e7cdba10 Deploy mustCallSuper (#4285)
This patch starts using the mustCallSuper annotation for several of the key
lifecycle callbacks in the framework. I haven't added it to didUpdateConfig
because there are a large number of non-compliant overrides. We should discuss
whether we want to use it there.
2016-05-31 17:05:46 -07:00
Adam Barth
b8fb46e425 Improve tooltip behavior (#4284)
As requested by the material design team.

Fixes #4182
2016-05-31 15:03:57 -07:00
Ian Hickson
787fb3be7d Simplify intrinsic dimension APIs (#4283) 2016-05-31 14:59:48 -07:00
Adam Barth
7de84709cf Address review comments on prior patch (#4270)
I pulled the trigger to land the previous patch too quickly and missed a
number of comments.
2016-05-30 14:47:49 -07:00
Adam Barth
7cf4c694b1 Complete docs for RenderObject (#4266) 2016-05-29 22:31:27 -07:00
Adam Barth
76772608e2 Remove OverlayPainter mechanism (#4264)
We used to use this mechanism to paint scrollbars, but it's awkward. The
new approach to scrollbars is much cleaner. This mechanism has no other
clients, so we should remove it.
2016-05-29 16:37:29 -07:00
Adam Barth
d1cb026a65 Update engine and Mojo usage (#4258)
The new mojom.dart code makes mocking services a bit tricky. I've filed
https://github.com/domokit/mojo/issues/786 about improving that.
2016-05-28 18:28:21 -07:00
Adam Barth
0c0a866c79 Add the ability to create global pointer routes (#4239)
We'll use this functionality to implement some subtle behaviors for tooltips.
2016-05-27 12:42:12 -07:00
Hans Muller
1a05b696d7 Doc update (#4234) 2016-05-27 10:13:15 -07:00
Adam Barth
6f3382aa57 Add more dartdoc to rendering.dart (#4232)
There are still many more left before rendering.dart is complete.
2016-05-27 08:59:04 -07:00
Adam Barth
6da0429375 Add more dartdoc to PaintingContext (#4229)
We now explain what coordinate system each argument is expected to be in.

Fixes #4205
2016-05-26 16:51:46 -07:00
Hans Muller
502f734dee Rename FractionallySizedBox box size factor parameters (#4212) 2016-05-26 12:43:25 -07:00
Adam Barth
21fa2753d8 Switch thumb decorations don't load (#4209)
We weren't listening to the decorations to see when they loaded.

Fixes #4185
2016-05-26 11:26:11 -07:00
Adam Barth
fde55a6f6a Update vector_math (#4201)
The new version has an API change. Also, up our SDK requirements to be a
bit more realistic.
2016-05-26 09:49:09 -07:00
Adam Barth
474ff67556 Polish sliders (#4176)
Address feedback from material design team.

Fixes #4144
Fixes #4145
Fixes #4146
2016-05-24 17:53:23 -07:00
Adam Barth
b1b6271683 Use "call" instead of "invoke" (#4177)
For consistency.

Fixes #4142
2016-05-24 17:53:04 -07:00
Adam Barth
d97df402b8 ImageCache should handle images that fail to decode (#4118) 2016-05-24 16:53:14 -07:00
Adam Barth
f012a0fdfb Document that State#build(BuildContext context) is always the same as State#context (#4116)
Fixes #4114
2016-05-24 16:34:51 -07:00
Hans Muller
bacd3d2cb0 Revised Drawer Header (#4160) 2016-05-24 12:31:42 -07:00
Hans Muller
ff1d3b8190 Clamp AppBar scroll notifications when ClampOverscrolls is true (#4152) 2016-05-24 09:37:19 -07:00
Ian Hickson
3b3db78f8a Teach LayoutBuilder about Inherited widgets. (#4140) 2016-05-23 16:44:05 -07:00