2592 Commits

Author SHA1 Message Date
Ian Hickson
71e689f450 Have a default default text style.
This way, widgets that try to use the DefaultTextStyle don't have to

handle the case where there isn't an explicit default.
2016-04-01 16:10:27 -07:00
Ian Hickson
902391b048 Realign the slow mode banner to not overflow. 2016-04-01 14:54:58 -07:00
Adam Barth
ca4b5cf497 Polish drop-down padding
Previously we weren't padding the top and the bottom of drop-down menus but the

spec says these should have 8.0 pixel of padding, the same as popup menus.



Fixes #2683
2016-04-01 12:58:19 -07:00
Adam Barth
c1440e2261 Merge pull request #3022 from abarth/polish_selection_controls
Polish selection controls
2016-04-01 11:14:04 -07:00
Andrew P. Wilson
f516dbcc2e Leave all entered targets when finishing. 2016-04-01 09:45:28 -07:00
Adam Barth
622bec43be Capture closures around megamorphic dispatches
The performLayout and build callsite are highly megamorphic because they
dispatch into a large number of clients. However, for a given caller, the
callee is always of the same type, which means the megamorphic lookup exactly
factors by the caller. We can speed up the dispatch by capturing a closure at
initialization and then monomorphically dispatching through the closure.
2016-04-01 08:19:37 -07:00
Adam Barth
884ec65c9e Don't delay between dismissing a snack bar and the next snack bar
Previously, the Dismissable widget was animating down to zero width off
screen. Now, we tell it to skip the resize animation.

Fixes #3030
2016-03-31 23:25:03 -07:00
Adam Barth
35d5b73ab5 Add review feedback to dartdocs 2016-03-31 23:06:11 -07:00
Adam Barth
cf80b90507 Merge pull request #3025 from abarth/fix_docs
Fix broken link in the docs
2016-03-31 17:32:42 -07:00
Adam Barth
c0842205ca Merge pull request #3027 from abarth/drop_down
Drop is a separate word than down
2016-03-31 17:28:35 -07:00
krisgiesing
b0e6f14dc0 Merge pull request #3028 from krisgiesing/fix
Fix spinning_mixed widget example, plus minor style fix
2016-03-31 14:54:50 -07:00
Adam Barth
bfc3532525 Improve setState-after-dispose error message
We now explicitly mention the possibility of a memory leak.

Fixes #2978
2016-03-31 14:30:21 -07:00
Kris Giesing
ed03e96b68 Fix spinning_mixed widget example, plus minor style fix 2016-03-31 12:56:14 -07:00
Adam Barth
d99432ca1a Drop is a separate word than down
Therefore, we use _ between them in the file name.
2016-03-31 12:52:09 -07:00
Adam Barth
a71231a554 Fix broken link in the docs 2016-03-31 12:06:39 -07:00
krisgiesing
243960d741 Merge pull request #3010 from krisgiesing/offscreen_layout
Part 2 of independent layout pipelines
2016-03-31 11:11:22 -07:00
Kris Giesing
9dfd5d4021 Part 2 of independent layout pipelines
Adds BuildOwner to manage the dirty list and build processing for
widgets/elements, and adds a widget unit test to make sure separation
is enforced.

Fixes #2723
2016-03-31 11:02:00 -07:00
Adam Barth
2bc08720e4 Document which widgets require a Material ancestor
Also, fill out other documentation for these widgets.

Fixes #967
2016-03-31 07:39:13 -07:00
Adam Barth
dca4e4aaa4 Polish selection controls
The touch ripple now starts at the touch location instead of being
centered on the widget.

Fixes #2652
2016-03-30 23:58:21 -07:00
Adam Barth
db9a92e59f Merge pull request #3011 from abarth/slider_polish
Polish Slider implementation
2016-03-30 18:06:08 -07:00
Adam Barth
c68494eb2a Merge pull request #3015 from abarth/snackbar_fade
Snackbar opacity animation shouldn't trigger on reverse
2016-03-30 17:26:11 -07:00
Adam Barth
d4b0c66bbe Polish Slider implementation
Based on feedback from the material design team.

Fixes #1613
2016-03-30 17:22:29 -07:00
Adam Barth
da987ed217 Snackbar opacity animation shouldn't trigger on reverse
Fixes #617
2016-03-30 17:14:38 -07:00
Hans Muller
3098abf749 Tab updates 2016-03-30 16:50:52 -07:00
Adam Barth
febfdf69f9 Merge pull request #3014 from abarth/update_mojo
Update engine
2016-03-30 16:02:24 -07:00
Adam Barth
d4febd085d Make it possible to dismiss a snackbar manually
Fixes #463
2016-03-30 15:42:51 -07:00
Adam Barth
04adf211d7 Update engine
This patch updates our use of Mozart to the latest version of the protocol.
2016-03-30 15:39:54 -07:00
Hans Muller
e76759953a Merge pull request #3002 from flutter/date_picker
DatePicker et al updates
2016-03-30 12:29:45 -07:00
Adam Barth
4fae8dfb7f Merge pull request #3008 from abarth/rm_text_height
These height values are incorrect
2016-03-30 12:20:50 -07:00
Adam Barth
bf31cf1e10 These height values are incorrect
They're actually leading values rather than line height values, which means
they're operative between paragraphs not within a given paragraph.
2016-03-30 12:08:19 -07:00
Hans Muller
c2366f3318 DatePicker et al updates 2016-03-30 12:04:51 -07:00
Adam Barth
15393b4990 Improve docs for TextStyle#height
Fixes #2918
2016-03-30 10:56:18 -07:00
Adam Barth
89076c95f0 Update engine
Also, pass font information to ui.ParagraphStyle.
2016-03-30 09:41:05 -07:00
Adam Barth
7da44d2d60 Merge pull request #2994 from abarth/faster_checked_mode
The intrinsic size checks were very slow
2016-03-29 19:13:53 -07:00
Adam Barth
9157c16421 The intrinsic size checks were very slow
Now we run them once per render object.

Fixes #2487
2016-03-29 16:35:33 -07:00
Adam Barth
243a49f7d0 Merge pull request #2992 from abarth/reactive_build
Reactivating a StatefulElement should imply a build
2016-03-29 16:12:01 -07:00
Adam Barth
b841e868f1 Reactivating a StatefulElement should imply a build
Fixes #2901
2016-03-29 16:02:10 -07:00
Ian Hickson
663164339d Merge pull request #2984 from Hixie/table
More table fixes
2016-03-29 15:54:57 -07:00
Hans Muller
992fc76e8e Merge pull request #2986 from flutter/gallery
Animate TwoLevelList leading icon color
2016-03-29 14:33:27 -07:00
Andrew Wilson
fad5df4c5e Merge pull request #2948 from apwilson/image
Add keys to ResourceImages.
2016-03-29 14:16:18 -07:00
Hixie
bdfeaaa47a More table fixes 2016-03-29 14:10:17 -07:00
Hans Muller
08edc0a928 Animate TwoLevelList leading icon color 2016-03-29 14:05:35 -07:00
Andrew Wilson
ed00f3ed5c Add keys to ResourceImages. 2016-03-29 14:02:49 -07:00
Hans Muller
04e020590d Use _ScaffoldLayout to position scrollable appbars 2016-03-29 13:27:37 -07:00
Hixie
baf06515e5 Table widget
- Add x and y to the parent data, in case it's useful. In point of fact,
  I ended up not needing it.

- Make columnWidths settable rather than having a setter so that the
  code in the widgets layer is more idiomatic.

- Teach setFlatChildren about avoiding unnecessary drop/adopt loops.

- Assert that the child list length is correct more aggressively so that
  we catch the dumb bug I had more quickly next time.

- Improve the toString() to handle empty tables better.

- Resort the imports in framework.dart.

- Introduce a LocalKey for cases where you don't want to allow use of
  GlobalKey.

- Make inflateWidget and deactivateChild public for subclass use.

- Table widget.

- Cell widget.

- TableRow fake widget.
2016-03-29 12:43:19 -07:00
Andrew Wilson
8ff1982776 Allow Draggables to drop through DragTargets that don't accept them to one that does. 2016-03-29 10:31:04 -07:00
Ian Hickson
d5deea491e Merge pull request #2942 from Hixie/layout-asserts
More elaborate exceptions.
2016-03-28 23:35:28 -07:00
Ian Hickson
962a33f85c AnimatedOpacity
This provides an easy way to do implicit opacity transitions.
2016-03-28 23:16:53 -07:00
Ian Hickson
aedf41bfa7 More elaborate exceptions.
The elaboration will continue until morale improves.

Specific exceptions considered here:

 - size setter checking when you set the size
 - layout verifying that you do set the size
 - hitTest verifying that you aren't dirty and have a size
 - flex complaining about canFlex
2016-03-28 23:14:15 -07:00
Adam Barth
d312c9dc12 Merge pull request #2970 from abarth/align_popup
Adds constants for FractionalOffsets
2016-03-28 23:12:17 -07:00