If a line is right justified, then remove any trailing whitespace from the
text range given to Minikin. Right justification shifts the line's glyphs
by the layout advance computed by Minikin, and this advance should exclude
whitespace so that the last visible character will be flush with the right
margin.
Also exclude trailing whitespace from center justified lines.
Fixes https://github.com/flutter/flutter/issues/17502
Fixes https://github.com/flutter/flutter/issues/16333
If the range passed to GetRectsForRange includes a newline character, then
the framework expects to see a rectangle representing the newline so it knows
where to position the cursor at the end of the line.
If the range covers other non-printing characters but not the newline, then
GetRectsForRange should not produce a rectangle for the line.
The mobile shells all use the same isolate snapshot. This is also the snapshot used by the service isolate. This works towards a world where the isolate snapshot is no longer a member variable of the DartVM instance. Instead, all snapshots must be specified in the run configuration. For now, the new `Shell::Create` overload will only be used by Fuchsia till I refactor `dart_vm.cc`.
There are no API updates to the mobile shells.
If a line is right justified, then remove any trailing whitespace from the
text range given to Minikin. Right justification shifts the line's glyphs
by the layout advance computed by Minikin, and this advance should exclude
whitespace so that the last visible character will be flush with the right
margin.
See https://github.com/flutter/flutter/issues/16333
* Revert "Roll dart sdk to e6d7d67f4b35556805dd083fed15bf3ed41f7e33. (#5165)"
This reverts commit 75b94b4ea5307c723c6003b9d7a786ac3f22bce1.
* Revert "Enables system chrome customization on Android M/O and greater (#5112)"
This reverts commit f4136be0d552a5b7f1f8bfafc3c5da4a70dda190.
* Roll dart sdk to e6d7d67f4b35556805dd083fed15bf3ed41f7e33.
Changes since last dart roll:
```
e6d7d67f4b Revert 4f18af12c7c6d53f02cf32cb9b5ea848b86e1d77 as it causes test breakages.
4877587346 [GN] Uses dart_action.gni instead of compiled_action.gni.
4b89ba24fb Meta CHANGELOG markdown cleanup.
3d688deba7 Bump analysis server version to 1.20.2
0dc81ae4eb Publish package:meta 1.1.5
7e54844fe7 [vm] Fix build for gcc 7.3.0.
9d10a6ad4a Issue 33034. Fix statement completion with missing condition right parenthesis.
3fd2d5fb05 [vm] Use compiler warnings to insist callers check for errors from Dart_Invoke*/Load*/Compile*.
afb490adbc [dart:io] Provide modern Dart-styled constants
2929b71aa2 [kernel/vm] Address follow-up review comments for bytecode generation
73768a5342 General TypeInfo and IdentifierContext cleanup
e93b2ee250 Improve typedef identifier recovery
46a9ed0617 Added example about calling a tear-off with a wrong-shape argument list
0c839cf3f8 [fasta] Add 'as' expressions to the Forest API
16f6ce2fee [release] Prepare changelog for 2.0.0-dev.53.0
d13bf49870 Check type-variable bounds on generic methods
794fe1e14f Add stacktrace tests for synchronous async
fb779df11c [frontend-server] Disable depfile test on Windows.
```
* Adjust gn-scripts to accommodate 487758734695e7a701325b80178465ebbd0fafdd refactoring.
* Roll dart to b298fc6d8f6a0e1aa841dbbdda26663d6012a79a.
Changes since last roll:
```
b298fc6d8f Revert "[kernel] Change dill representation of doubles"
9a7e1f64a2 Revert "Revert "Fix incorrect handling of NSM forwarders and pull all logic into CFE.""
cbca4006f8 fix#30907, add library constants for all SDK libraries
61c226b4ea Only create Goma's analyzer on Linux.
24dd9b4176 Revert "Fix incorrect handling of NSM forwarders and pull all logic into CFE."
bed71b7776 Migrate and clean up the prefix negative tests.
1fcd896ed9 [VM] Avoid deadlock by allowing us to run kernel isolate from a script snapshot, fixes all dartk-sim* builders
0bc6e7217a Update expression compilation expectations.
9038b8f45f CFE support for compiling individual expressions in a context.
7d5025e814 Fix incorrect handling of NSM forwarders and pull all logic into CFE.
e2247e5e00 Put the '@' outside the revision variables.
9381424204 Fix presubmit on Windows. Dart executable is not called .bat
2a8c3515b2 Avoid strong+checked mode: strong mode supersedes checked mode
b7698dcbce Update status for Windows
8baa82413b [infra] Remove --no-preview-dart-2 flag from gardening tools
47e9039512 Don't encode strings up front; don't toString uris
4a0ac85cc3 Update co19 status
ce7329849d Fix build breakages - use platform independent path specification is test so that it works on windows - skip test for precompiled and dartk builds as the test uses spawnUri which is not supported in these modes
ee6351a147 [VM] Set up package config value when invoking the front end for compilation, this should fix issue 32950 "(Isolate.spawnUri() ignores packageConfig argument in Dart 2 mode.'
d1286a367e Strong mode update for swarm
fd27cc3435 Don't store bytes in the file cache.
73abd61304 Re-land "Clean up the use of deprecated API in the analyzer_plugin package".
607f4f5769 [vm] Get more helpful errors from Dart_SetVMFlags and Dart_MakeIsolateRunnable.
f044637c8b [infra] Upgrade checked in SDKs to 2.0.0-dev.52.0
dcf10816aa [infra] Add script that updates checked in SDKs
f8bea2a7e6 dart2js: Register inlined native methods for dump info
7fe8659613 dump-info: Use relative paths for library canonicalUri...
dcf4886500 [frontend-server] Add verbose option.
5087ffa481 [release] Move DDC sync-async flip to correct section in the release notes
fe7056ebaa [release] Update changelog for 2.0.0-dev.52.0
```
* Pick up another revert to fix https://github.com/flutter/flutter/issues/17214 and few more dart commits landed since:
```
4c9b712052 Revert "Don't encode strings up front; don't toString uris"
a1fbf62742 [build] Place 'extern "C"' before __attribute__, as required by gcc.
258c5172df [vm] Remove dart_mirrors_api.h.
384c55c29e Update dartdoc & dependencies to v0.19.0.
```
* fix licenses
* Roll Dart to 011676641a8b4b77bb372384c712709cbf037675.
Reverts cb86a973a7c96bddf304f611b963064133a5cc8c and uses Dart_NewExternalTypedDataWithFinalizer.
* update license goldens
* Enable sweep gradients
* Use _matrix4IsValid
* Add assert for startAngle < endAngle
* Use radians for startAngle and endAngle
* Update AUTHORS
* Better assert on matrix4IsValid
This is helpful for some Material Design widgets, which are specified as a semi-transparent color over top of a "material". In some cases, the resulting alpha-blended color can be used instead of compositing an additional shape with an opacity.
This new Color.alphaBlend function mimics the alpha blending function, and creates the resulting combined color. The optimization only works for solid color shapes that have the same geometry, of course.
The APKAssetProvider will hold a reference to its Java peer
(see c2b081e229)
After dropping this reference, the UI thread must detach from JNI before exiting.
PlatformMessageResponseDart will wrap large responses in Dart external typed
data objects in order to avoid copying the data into a new buffer.
Previously these objects were created with the Dart_TypedData_kByteData type.
A weak persistent handle is then associated with the ByteData to provide a
finalizer that deletes the raw buffer. However, the Dart VM could call
finalizer on the ByteData even if references still existed to the Dart ByteBuffer
object backing the ByteData. The ByteBuffer would then be referencing a deleted
raw buffer.
This PR prevents that scenario by creating a Dart_TypedData_kUint8 object,
attaching the finalizer to that object, and then wrapping it in a ByteData.
Previously libtxt was applying right justification during line layout based on
the line width returned by the Minikin line breaker. However, this width does
not include the width of leading or trailing whitespace.
So in a right justified line the starting offset of the first glyph would not
account for the advance of the leading whitespace, resulting in text being
clipped.
This PR applies line justification after the glyphs are laid out and the full
advance of the text is known.
Fixes https://github.com/flutter/flutter/issues/16333
* add path measure
* fix typo
* getBound and addPathWithMatrix
* Add myself to Authors, add PathOps
* fix linting issues
* update licenses_flutter to add new files
* Use matrix4 instead of matrix3 for consistency/interop
* put pubspec back
* fix bug in getSegment
* fix typo
* Add return value for PathOp
* refactoring from review
* refactoring from review - still TBD on computeMetrics()
* add doc
* lint issue
* fix computeMetrics, add Path.from
* add missing wireup for clone
* change PathMetrics to iterable, fix bug with angle on Tangent
* prefer std::make_unique
* cleanup docs
* add path measure
* fix typo
* getBound and addPathWithMatrix
* Add myself to Authors, add PathOps
* fix linting issues
* update licenses_flutter to add new files
* Use matrix4 instead of matrix3 for consistency/interop
* put pubspec back
* fix bug in getSegment
* fix typo
* Add return value for PathOp
* refactoring from review
* refactoring from review - still TBD on computeMetrics()
* add doc
* lint issue
* fix computeMetrics, add Path.from
* add missing wireup for clone
* change PathMetrics to iterable, fix bug with angle on Tangent
* prefer std::make_unique
* cleanup docs
* fix iterator bug
* remove unnecessary clone for computeMetrics
* fix some doc issues
* fix PathMeasure iterator, extendWithPath, isClosed, and pubspec.lock
* get rid of orElse; use StateException
* StateError, not StateException
* doc improvements and nits
* add unit tests, fix bugs found during testing
* fix two uncommited doc changes
* one more
* change sign of tangent angle, update docs
* update unit tests for inverted angle
* update tangent to include vector
* Doc fixes
* Fix MSVC compilation and unit test
* Added handleEventsForBackgroundURLSession and
performFetchWithCompletionHandler handlers in FlutterAppDelegate to
allow for plugins to perform background downloads and fetch small
amounts of data opportunistically.
Platform messages are only support in the UI isolate. Secondary isolates
do not have a window that can receive incoming messages, and outgoing messages
are not tagged with a destination isolate and thus will always be dispatched
to the UI isolate.
Fixes https://github.com/flutter/flutter/issues/16846
