1075 Commits

Author SHA1 Message Date
Francisco Magdaleno
e0ebaea590
Revert "Re-land: Use os_log instead of syslog on Apple platforms (#16549)" (#16558)
This reverts commit 6aacf5e76755feb8e0f791fa619cbd99a3bd5885.
2020-02-12 12:40:31 -08:00
Nurhan Turgut
44e80fd619
skiping tests in Safari. LUCI recipe for Mac is ready. this is the only step left for stopping us running unit tests in Safari (#16550) 2020-02-11 15:31:57 -08:00
Chris Bracken
6aacf5e767
Re-land: Use os_log instead of syslog on Apple platforms (#16549)
Migrates to using os_log for app logging on iOS 13 and above, macOS
10.11 and above. On older platform, fall back to syslog(), which is what
we used previously.

This re-lands commit 78a8909725bbaeec80870f498d01ea6e56932a3a with a fix.
That commit was reverted in a61dbf2f66b97e85f4d8bf0cfb29a8b3c2640c09.
2020-02-11 15:11:46 -08:00
Chris Bracken
a61dbf2f66
Revert "Use os_log instead of syslog on Apple platforms (#13487)" (#16546)
Looks like somehow the fix to move to static_cast didn't get merged.

This reverts commit 78a8909725bbaeec80870f498d01ea6e56932a3a.
2020-02-11 13:20:52 -08:00
Jenn Magder
78a8909725
Use os_log instead of syslog on Apple platforms (#13487)
Migrates to using os_log for app logging on iOS 13 and above, macOS
10.11 and above. On older platform, fall back to syslog(), which is what
we used previously.
2020-02-11 10:23:44 -08:00
Harry Terkelsen
a662579f7c
Clear frame references at the end of every CanvasKit frame (#16525) 2020-02-10 15:30:24 -08:00
chunhtai
7e869faf52
Adds new route annoucement method. (#16523) 2020-02-10 13:59:02 -08:00
Yegor
1daba53187
Partially fix canvas vs text paint order when running on Blink/Webkit browsers (#16483)
fix canvas vs text paint order in Blink/Webkit
2020-02-10 13:41:50 -08:00
Harry Terkelsen
acc26a2f1c
Use Skia to determine "actual" font name in CanvasKit backend (#16504)
* Use Skia to determine "actual" font name.

This way, we don't need to hard-code a mapping of Flutter names
to actual names, we can compute it when the font is registered.

* Refactor to only have loaded and unloaded fonts
2020-02-10 13:06:30 -08:00
Michael Goderbauer
e4f46f32f1
Doc fixes in BoxHeightStyle (#16424) 2020-02-07 13:41:50 -08:00
sjindel-google
c9322145f4
Ensure fields of Rect and OffsetBase classes are optimized as non-null. (#16465)
* Ensure fields of Rect and OffsetBase classes are optimized as non-null.

* Update web_ui and formatting
2020-02-07 19:06:20 +01:00
Harry Terkelsen
00904dd967
Various fixes in CanvasKit (#16433)
- Enable dynamically loaded fonts
- Fix addOval
- Fix getBoxesForRange for negative ranges
2020-02-06 14:51:12 -08:00
Ferhat
f3ce90e938
Reset width/height before deallocation for Safari allocation bug. (#16469) 2020-02-06 12:30:27 -08:00
Mouad Debbar
41d50c220b
Reland #16206: "[web] Correct getPositionForOffset for multi-line paragraphs" (#16365) 2020-02-05 19:53:03 -08:00
Yegor
07f25c51ee
fix bad reference to maxDiffRatePercent (#16440)
* fix bad reference to maxDiffRatePercent

* back to 10%
2020-02-05 18:49:10 -08:00
Yegor
f34bc65bee
use percent for golden diff rates; tighten the values (#16430) 2020-02-05 15:53:45 -08:00
Ferhat
8f89bac4b7
[web] Fixes incorrect transform when context save and transforms are deferred. (#16412)
* Fix transform order in clipStack replay
2020-02-05 15:02:34 -08:00
Gary Qian
b98a39e0bb
Add docs (#16368) 2020-02-04 13:53:02 -08:00
vsmenon
8c6cc65cd0
Fix runtime type errors when running with canvaskit (#16312)
* fix runtime type errors when running with canvaskit
2020-02-04 10:32:51 -08:00
Mouad Debbar
036ddbb0ee
[web][felt] If full dart-sdk isn't available, install it (#16341) 2020-02-03 15:06:24 -08:00
Chinmay Garde
f7b78e001d
Remove all uses of the redundant flutter_root variable. (#16311)
This was only necessary when the Engine had to build in multiple buildroots
where the sources where checked out at different paths relative to the
buildroot. This is no longer the case and there are already cases GN rules
have been written that mix and match variable usage with the direct
specification of the path to the Flutter sources relative to the sole buildroot.
2020-01-31 21:49:48 -08:00
Yegor
804dca62a1
Use bundled Roboto in all tests (#16218)
* Use bundled Roboto in all tests
2020-01-30 17:31:32 -08:00
Jason Simmons
1370c9d520
Revert "[web] Correct getPositionForOffset for multi-line paragraphs (#16206)" (#16268)
This reverts commit 4ac82f663170a8740c3d983c97fee42d2f3425d2.

This caused a regression in a framework test (material/text_field_splash_test.dart)
2020-01-30 16:06:35 -08:00
Kaushik Iska
74930e4212
[fuchsia] Fix the import for dart_api.h (#16269) 2020-01-30 14:55:15 -08:00
Kaushik Iska
9361ee5e6b
[fuchsia] SceneHostBindings are no longer thread locals (#16262)
Prior to this change SceneHostBindinds was a ThreadLocal but the
intention was for it to be IsolateLocal. Given that dart
could collect this map on a non-UI thread this caused
use-after-free issues.

This change fixes it by making it keyed on isolate and koid
this is not the ideal solution, this would exist on
dart isolate group data struct. Given that Fuchsia is moving
to use the embedder API, the decision to use this temporary
work around was made.

fixes https://github.com/flutter/flutter/issues/49738
2020-01-30 14:36:36 -08:00
Mouad Debbar
4ac82f6631
[web] Correct getPositionForOffset for multi-line paragraphs (#16206) 2020-01-30 10:21:15 -08:00
Gary Qian
ee297aa699
Reland "Engine/LibTxt/dart:ui impl of TextHeightBehavior #15087" (#16155) 2020-01-29 10:52:24 -08:00
Mouad Debbar
379295626d
[web] Text width should never exceed constraint width (#16152) 2020-01-28 16:23:04 -08:00
Dan Field
53baa7aee5
Revert breaking PRs (#16148)
* Revert "Web PargraphStyle TextHeightBehavior integration (#16075)"

This reverts commit 86682a2d09e7d111a5c4fd2156b9971bd65fb693.

* Revert "Engine/LibTxt/dart:ui impl of TextHeightBehavior (#15087)"

This reverts commit cbf4536d158e25e372469c242e326c48cc730de7.
2020-01-28 10:40:05 -08:00
Gary Qian
86682a2d09
Web PargraphStyle TextHeightBehavior integration (#16075) 2020-01-27 17:35:40 -08:00
Gary Qian
cbf4536d15
Engine/LibTxt/dart:ui impl of TextHeightBehavior (#15087) 2020-01-27 13:37:11 -08:00
Chinmay Garde
276481c4d3
Move tonic into //flutter/third_party. (#15895)
Tonic used to be used by multiple consumers outside of Flutter Engine. Due to
this, it has an unnecessary abstraction layer as well as utilities duplicated in
FML and other engine subsystems. The sole user of Tonic is now the Flutter
Engine. It is intended that the Flutter Engine team now owns this subsystem,
remove unnecessary utilities and document the headers. This is the first step in
the transition. No history is being imported as the initial history was already
lost in the transition of this component to fuchsia.googlesource. As this
component was unmaintained there, I could see no additional value in importing
the history of the patches there.

No functional change. Just moved the repo from //third_party to
//flutter/third_party and updates GN refs.
2020-01-25 17:01:56 -08:00
Ferhat
f30ff4fcbf
Use 2d matrix for transform to work around Safari clipping bug (#15976) 2020-01-24 20:40:12 -08:00
Nurhan Turgut
2415e9654b
updating the versions of the browsers for flutter web engine unit tests (#15977) 2020-01-24 16:28:21 -08:00
Nurhan Turgut
08d1f2af9f
[web] Calling platform message callback after copy (#15950)
* Calling platform message callback after copy

* addressing pr comments

* adding unit tests to clipbpard.dart
2020-01-24 15:35:03 -08:00
Yegor
f43097215c
Cache computed window.physicalSize in a FrameReference (#15955) 2020-01-24 13:21:16 -08:00
Dan Field
89f3471fa7
the the fix (#15973) 2020-01-24 12:43:32 -08:00
Ferhat
b22821a542
Optimize drawRRect to use dom_canvas (#15970) 2020-01-24 11:03:19 -08:00
Ferhat
2ce15cf956
Remove paint apply in draw image (#15969)
https://github.com/flutter/flutter/issues/49132
2020-01-24 10:39:54 -08:00
Ferhat
3d5bbb4371
Implement Canvas drawPoints API for Html backend (#15870) 2020-01-21 16:37:41 -08:00
Ferhat
79f898e61d
Fix RRect hittest optimization to handle malformed corner radius (#15859) 2020-01-21 12:12:14 -08:00
Nurhan Turgut
f38f6a09be
windpws batch script for running felt. it does not have snapshot option (#15746) 2020-01-21 09:30:57 -08:00
Ferhat
8eebf82c74
Fix path.contains failure when devicepixelratio != 1.0 (#15743)
* Fix path contains failure due to devicepixelratio
2020-01-17 21:48:51 -08:00
Ferhat
55f022fc9c
Fix Color API, move toCss to helper functions (#15740)
* Fix Color API, move toCss to helper functions
* Move colorToCssString to engine
2020-01-17 16:05:08 -08:00
Ferhat
98c1aeaa3b
Clipping path fix for browsers that don't use correct units when applying clip-path css using svg (#15712) 2020-01-17 10:41:02 -08:00
Dan Field
5554fe1f3a
fix typo, update path metrics docs (#15715) 2020-01-17 10:02:59 -08:00
Dan Field
1970c0624d
implicit casts and add missing docs (#15698) 2020-01-16 17:03:33 -08:00
chunhtai
1f4c593032 loadfontfromlist should send fontchange message to framework (#14805) 2020-01-16 17:03:04 -08:00
Dan Field
85a8ac4255
Make internal cache vars private (#15699) 2020-01-16 16:10:25 -08:00
Nurhan Turgut
76b36e0512
[web] edge launcher for windows (#15690)
* edge launcher for windows

* addressing PR comments

* url mistake

* remove uncessary import

* initialization error fix

* format
2020-01-16 14:48:13 -08:00