Originally I wanted to update to 3f443830bd52d3aa5fab3c1aa2b6d0848bb5039d.
However, that change had a problem with a misspelled build target which
I also had to fix.
But, that fix turned out to be infeasible on its own, and led to a
bugfix in `gn`.
Fixes:
- Updates gn to commit 0153d369bbccc908f4da4993b1ba82728055926a to take
in the fix at https://gn-review.googlesource.com/c/gn/+/12220 which
prevented the correct treatment of target refactoring.
- Updates ICU to commit 2b50fa94b07b601293d7c1f791e853bba8ffbb84 to
correct the target naming, which should now work thanks to the
previous update to gn. See
https://gn-review.googlesource.com/c/gn/+/12220 for the details of
that bug.
- Fixed the visibility declaration in `//flutter/third_party/accessibility:accessibility_config`
which used to not be enforced due to a bug in `gn` which was fixed in
https://gn.googlesource.com/gn/+/46b572ce4ceedfe57f4f84051bd7da624c98bf01,
a revision which we took in by updating `gn` in the first bullet.
Fun times.
See: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3163524
Please see the linked issue for details about why this update.
In order to enable all the currently-passing Windows UWP unit tests and
prevent any regressions, I've disabled currently-failing tests so we can
enable the passing unit tests as part of presubmit.
Most of the failures fall into one of the following categories:
* threading issues (accessing an object from the wrong thread)
* filesystem sandboxing issues (trying to access a path outside the sandbox)
* network issues (trying to connect to sandboxed vm service)
Fixes the following lints:
```
Analyzing web_ui...
info - lib/src/engine/canvaskit/surface_factory.dart:8:8 - The import of '../util.dart' is unnecessary as all of the used elements are also provided by the import of '../../engine.dart'. Try removing the import directive. - unnecessary_import
info - lib/src/engine/canvaskit/surface_factory.dart:9:8 - The import of 'embedded_views.dart' is unnecessary as all of the used elements are also provided by the import of '../../engine.dart'. Try removing the import directive. - unnecessary_import
info - lib/src/engine/canvaskit/surface_factory.dart:10:8 - The import of 'surface.dart' is unnecessary as all of the used elements are also provided by the import of '../../engine.dart'. Try removing the import directive. - unnecessary_import
```
