skia-flutter-autoroll
b6cebe9c92
Roll Skia from a01d9bb9d4b3 to 9c3b296f7b58 (1 revision) ( flutter/engine#52872 )
...
https://skia.googlesource.com/skia.git/+log/a01d9bb9d4b3..9c3b296f7b58
2024-05-16 bungeman@google.com Test effect of sbix originOffset fields
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-16 08:28:07 +00:00
skia-flutter-autoroll
f73d4a934f
Roll Skia from 91527e447923 to 5a9402854577 (1 revision) ( flutter/engine#52869 )
...
https://skia.googlesource.com/skia.git/+log/91527e447923..5a9402854577
2024-05-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from c8e24928e2f9 to e9be917b1b0d (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-16 06:01:28 +00:00
Matan Lurey
b0e791fce3
et generates {out}/{buildName} if missing on et {build|test|query} (flutter/engine#52866 )
...
Closes https://github.com/flutter/flutter/issues/148442 .
This restores functionality that existed prior in https://github.com/flutter/engine/pull/52832 :
- Splits `runGn` to `ensureBuildDir`, which is in practice what it does.
2024-05-16 04:03:21 +00:00
auto-submit[bot]
d810c59879
Reverts "Revamp the engine style guide, remove always_specify_types. ( #52859 )" ( flutter/engine#52867 )
...
Reverts: flutter/engine#52859
Initiated by: zanderso
Reason for reverting: This sort of change *is* in scope for a discussion at the Dash forum.
Original PR Author: matanlurey
Reviewed By: {cbracken, gaaclarke, johnmccutchan}
This change reverts the following previous change:
Based on the (internal) discussion around converging on using the official Dart style guide, with the exception of the code that gets published under `dart:ui`, as that is user-facing, and we'd like to evolve the code style in conjunction with the framework.
I also took the opportunity to specify more about our style guide use in general, mostly to make it easier to understand our conventions, and also call out known problem areas (notably, our over-use of `shared_ptr` and `auto` in some cases). I am happy to split those up, but it was easier to make the markdown changes at once.
I also took @cbracken and folks advice and clarified directly that explicit types in Dart are _not_ bad (with examples).
2024-05-16 02:51:50 +00:00
Matan Lurey
eafc52c37d
Include stdout on a failed gn desc call, and test for it. ( flutter/engine#52863 )
...
Fixes https://github.com/flutter/flutter/issues/148431 , in that full error output is now shown.
I also filed an additional issue for how we could do better: https://github.com/flutter/flutter/issues/148442 .
2024-05-16 01:09:13 +00:00
Matan Lurey
706817bd67
Revamp the engine style guide, remove always_specify_types. ( flutter/engine#52859 )
...
Based on the (internal) discussion around converging on using the official Dart style guide, with the exception of the code that gets published under `dart:ui`, as that is user-facing, and we'd like to evolve the code style in conjunction with the framework.
I also took the opportunity to specify more about our style guide use in general, mostly to make it easier to understand our conventions, and also call out known problem areas (notably, our over-use of `shared_ptr` and `auto` in some cases). I am happy to split those up, but it was easier to make the markdown changes at once.
I also took @cbracken and folks advice and clarified directly that explicit types in Dart are _not_ bad (with examples).
2024-05-16 01:07:17 +00:00
skia-flutter-autoroll
56a25633d8
Roll Skia from bbe06eb4a8e9 to 91527e447923 (1 revision) ( flutter/engine#52864 )
...
https://skia.googlesource.com/skia.git/+log/bbe06eb4a8e9..91527e447923
2024-05-15 ccameron@chromium.org Reland 2: Add ISO 21496-1 gainmap parsing
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-16 01:01:33 +00:00
skia-flutter-autoroll
1468c42281
Roll Skia from 2d0d1f7833bb to bbe06eb4a8e9 (1 revision) ( flutter/engine#52862 )
...
https://skia.googlesource.com/skia.git/+log/2d0d1f7833bb..bbe06eb4a8e9
2024-05-15 sunnyps@chromium.org Reland "graphite: Do not call virtual setBackendLabel in Resource constructor"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 23:59:05 +00:00
skia-flutter-autoroll
e6a093d286
Roll Dart SDK from f773d45634ed to a9651de827d8 (1 revision) ( flutter/engine#52861 )
...
https://dart.googlesource.com/sdk.git/+log/f773d45634ed..a9651de827d8
2024-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-159.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 22:02:54 +00:00
skia-flutter-autoroll
31b463c760
Roll Skia from 0f737206b709 to 2d0d1f7833bb (1 revision) ( flutter/engine#52860 )
...
https://skia.googlesource.com/skia.git/+log/0f737206b709..2d0d1f7833bb
2024-05-15 brianosman@google.com Revert "SkJpegEncoder: Specify metadata segments explicitly"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 21:48:24 +00:00
skia-flutter-autoroll
253f91bd76
Roll Skia from b9a304eb05d2 to 0f737206b709 (3 revisions) ( flutter/engine#52858 )
...
https://skia.googlesource.com/skia.git/+log/b9a304eb05d2..0f737206b709
2024-05-15 jvanverth@google.com [graphite] Add caching to ComputePathAtlas.
2024-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e127b96b4799 to 48e47a7bb90c (2 revisions)
2024-05-15 nathanasanchez@google.com Made a change.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 20:40:20 +00:00
Matan Lurey
cb19eac08e
Short-circuit crawling all targets in et {build|test|query} ( flutter/engine#52832 )
...
Closes https://github.com/flutter/flutter/issues/147666 .
This is a large change, I'd be happy to either review synchronously or
change commands one at a time, but I think this is overall the right
approach. I also didn't see any reason to reuse the `BuildRunner` code
for these commands, the flow is basically:
```mermaid
graph LR
A[et targetsOrPatterns] --> B[gn desc --format=json]
B --> C[existing code that runs ninja/workers]
```
Quick summary of changes:
- Introduced a [`Label` and `TargetPattern`][1] type to avoid awkward
string parsing/manipulation all over
- Replaced `gn_utils` (i.e. `targetsFromCommandLine` and friends) with
[an invocation of `gn desc`][2]
- Some tests were brittle in terms of expected output, I mostly left
them alone and wrote TODOs where applicable
Here is the fun part, results (and some manual integration tests):
```sh
# build, previously was 10-15s, is now ~3s
flutter % time et build -c host_debug_unopt_arm64 //flutter/impeller:impeller_unittests
[2024-05-14T19:05:55.163][macos/host_debug_unopt_arm64: GN]: OK
[2024-05-14T19:05:56.119][macos/host_debug_unopt_arm64: RBE startup]: Proxy started successfully.
[macos/host_debug_unopt_arm64: ninja] 0.0% (0/1) Regenerating ninja files[2024-05-14T19:05:57.309][macos/host_debug_unopt_arm64: ninja]: OK
[2024-05-14T19:05:57.573][macos/host_debug_unopt_arm64: RBE shutdown]: Actions completed: 0
$ENGINE/flutter/bin/et build -c host_debug_unopt_arm64 3.20s user 0.87s system 107% cpu 3.776 total
# test, also benefits from speedup, but I didn't time it
flutter % et test -c host_debug_unopt_arm64 //flutter/fml:fml_unittests
[2024-05-14T19:07:01.843][macos/host_debug_unopt_arm64: GN]: OK
[2024-05-14T19:07:02.707][macos/host_debug_unopt_arm64: RBE startup]: Proxy started successfully.
[2024-05-14T19:07:07.400][macos/host_debug_unopt_arm64: ninja]: 100.0% (3/3) LINK ./fml_unittests
[2024-05-14T19:07:07.404][macos/host_debug_unopt_arm64: ninja]: OK
[2024-05-14T19:07:07.748][macos/host_debug_unopt_arm64: RBE shutdown]: Actions completed: 1 (1 racing local)
OKAY: 7s.95ms //flutter/fml:fml_unittests
# query, also benefits from speedup
flutter % time et query targets -c host_debug_unopt_arm64
//flutter/display_list:display_list_benchmarks
//flutter/display_list:display_list_builder_benchmarks
# ... many targets omitted ...
$ENGINE/flutter/bin/et query targets -c host_debug_unopt_arm64 1.27s user 0.18s system 147% cpu 0.978 total
```
In other words, ~5x improvement on `et build` and `et query` is _much_
faster as well.
[1]:
https://github.com/flutter/engine/compare/main...matanlurey:engine:gn-label?expand=1#diff-ac008475ce9e209f4ecf6594b0cd48d12d86a1ffa0aa7d555375ff43b983eb2b
[2]:
https://github.com/flutter/engine/compare/main...matanlurey:engine:gn-label?expand=1#diff-ad116b8504dd0a500bf758a327c7052e5733a2b465d3295e35b74458d483276f
2024-05-15 12:57:02 -07:00
skia-flutter-autoroll
33592ed533
Roll Skia from 475559da107d to b9a304eb05d2 (1 revision) ( flutter/engine#52857 )
...
https://skia.googlesource.com/skia.git/+log/475559da107d..b9a304eb05d2
2024-05-15 ccameron@chromium.org SkJpegEncoder: Specify metadata segments explicitly
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 19:26:23 +00:00
Jenn Magder
bae1009cd1
Migrate TextInputSemanticsObject to ARC ( flutter/engine#52785 )
...
1. Migrate TextInputSemanticsObject to ARC
2. Rename the Objective-C-only `accessibility_text_entry.*` files to `TextInputSemanticsObject.*`
3. Move `FlutterInactiveTextInput` interface from the header file into the implementation, the only place it's used.
Blocked on `SemanticsObject` ARC migration https://github.com/flutter/engine/pull/52824
Part of https://github.com/flutter/flutter/issues/137801 .
2024-05-15 19:10:24 +00:00
skia-flutter-autoroll
9e404f6bd7
Roll Fuchsia Linux SDK from NbCi2ETfLHPLLB-JV... to Ftw7GopnudHydGS1y... ( flutter/engine#52853 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 18:03:58 +00:00
skia-flutter-autoroll
f2d50e7941
Roll Dart SDK from 7d9de0c0b231 to f773d45634ed (2 revisions) ( flutter/engine#52854 )
...
https://dart.googlesource.com/sdk.git/+log/7d9de0c0b231..f773d45634ed
2024-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-158.0.dev
2024-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-157.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 18:00:40 +00:00
skia-flutter-autoroll
062a439821
Roll Skia from 4a7419d662d5 to 475559da107d (5 revisions) ( flutter/engine#52848 )
...
https://skia.googlesource.com/skia.git/+log/4a7419d662d5..475559da107d
2024-05-15 egdaniel@google.com [Graphite] Don't set DawnTexture label if we only have a view.
2024-05-15 kjlubick@google.com Update Windows P400s to Windows 22H2 and latest driver
2024-05-15 armansito@google.com Revert "Reland: Add ISO 21496-1 gainmap parsing"
2024-05-15 armansito@google.com Revert "graphite: Do not call virtual setBackendLabel in Resource constructor"
2024-05-15 kjlubick@google.com [bazel] Add target for svg_writer
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 15:43:04 +00:00
skia-flutter-autoroll
a3b2d046b0
Roll Skia from a9ba7411d4b2 to 4a7419d662d5 (1 revision) ( flutter/engine#52844 )
...
https://skia.googlesource.com/skia.git/+log/a9ba7411d4b2..4a7419d662d5
2024-05-15 robertphillips@google.com [graphite] Make MatrixConvolutionImageFilter stably keyed (take 2)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 13:47:24 +00:00
skia-flutter-autoroll
774167c78d
Roll Skia from b3aadd56d187 to a9ba7411d4b2 (1 revision) ( flutter/engine#52839 )
...
https://skia.googlesource.com/skia.git/+log/b3aadd56d187..a9ba7411d4b2
2024-05-15 ccameron@chromium.org Reland: Add ISO 21496-1 gainmap parsing
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 08:42:10 +00:00
skia-flutter-autoroll
ea8caf4958
Roll Skia from c0caf10486ce to b3aadd56d187 (3 revisions) ( flutter/engine#52837 )
...
https://skia.googlesource.com/skia.git/+log/c0caf10486ce..b3aadd56d187
2024-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 724dbf0e90cb to e127b96b4799 (6 revisions)
2024-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from c8e24928e2f9 to a21a77992dab
2024-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b43af3a7d497 to c8e24928e2f9 (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 07:08:34 +00:00
Jenn Magder
a4dc4d92ba
Migrate SemanticsObject and FlutterSemanticsScrollView to ARC ( flutter/engine#52824 )
...
On top of the `SemanticsObject` refactor https://github.com/flutter/engine/pull/52729 migrate `SemanticsObject` and `FlutterSemanticsScrollView` to ARC.
Part of https://github.com/flutter/flutter/issues/137801 .
2024-05-15 04:23:25 +00:00
skia-flutter-autoroll
91a74353b4
Roll Dart SDK from 0b77fbab8cf5 to 1eec9de2f9c6 (1 revision) ( flutter/engine#52833 )
...
https://dart.googlesource.com/sdk.git/+log/0b77fbab8cf5..1eec9de2f9c6
2024-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-155.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 03:09:23 +00:00
skia-flutter-autoroll
da5f8f0ac9
Roll Skia from d0d87c26b489 to fad584324d85 (1 revision) ( flutter/engine#52831 )
...
https://skia.googlesource.com/skia.git/+log/d0d87c26b489..fad584324d85
2024-05-15 sunnyps@chromium.org graphite: Do not call virtual setBackendLabel in Resource constructor
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 02:06:26 +00:00
Matan Lurey
8ef64aea97
Re-add MipFilter::kBase, but keep kNearest as the default. ( flutter/engine#52779 )
...
Closes https://github.com/flutter/flutter/issues/147259 .
Changes:
- Make sure the default of `kNearest` is used consistently
- Partial revert of https://github.com/flutter/engine/pull/40491 , re-adding `kBase`
- Added some documentation about relevant enums, and why the default is `kNearest`
- Wired up `kBase` in the Metal, Vulkan, and OpenGLES backends
Expecting an update to the `dart_ui_filter_quality_none` golden file:
> 
For breadcrumbs around the mapping, see https://github.com/flutter/flutter/issues/148253 .
2024-05-15 01:38:05 +00:00
Jonah Williams
3be5ba1920
[Impeller] make default glyph atlas size much bigger. ( flutter/engine#52787 )
...
Now that we no longer have a full CPU copy of the glyph atlas, it should be cheaper to make a larger initial atlas to reduce churn from resizing seen in applications like https://github.com/flutter/flutter/issues/138798
Requires https://github.com/flutter/engine/pull/52746
2024-05-15 01:22:04 +00:00
Jonah Williams
b322ce3a58
[Impeller] immediately encode blit commands for Vulkan. ( flutter/engine#52794 )
...
No reason to defer encoding. Just like cmd buffers, we can immediately encode this. Reduce heap allocation of command objects, which were additionally stored in unique ptrs for extra memory inefficiency.
2024-05-14 23:50:09 +00:00
Gray Mackall
b6bb39ad2d
Fix non-vd android platform view input event offsets ( flutter/engine#52532 )
...
Fixes https://github.com/flutter/flutter/issues/146570 , which tracks a regression from https://github.com/flutter/engine/pull/49268 regarding platform view inputs in some specific cases.
This PR translates the input event location to be the same as the location we calculated before https://github.com/flutter/engine/pull/49268 , returning to the previous behavior, while maintaining the input event's verified status (I checked this manually with the `InputManager`).
Tested manually with the reproduction in the linked issue.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-14 23:07:53 +00:00
skia-flutter-autoroll
98713e6aa6
Roll Dart SDK from 0380354e2448 to 0b77fbab8cf5 (1 revision) ( flutter/engine#52827 )
...
https://dart.googlesource.com/sdk.git/+log/0380354e2448..0b77fbab8cf5
2024-05-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-154.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 23:00:06 +00:00
Jonah Williams
ff5ea29080
[Impeller] reland: directly encode blit commands for Metal. ( flutter/engine#52819 )
...
Fixes bad interaction with render pass clear patch, which potentially created an active blit and render pass encoder at the same time. Make sure that we start/finish the render pass before we start the blit pass.
2024-05-14 22:32:19 +00:00
skia-flutter-autoroll
c16a2409e5
Roll Skia from 81ba2eea7b42 to d0d87c26b489 (2 revisions) ( flutter/engine#52825 )
...
https://skia.googlesource.com/skia.git/+log/81ba2eea7b42..d0d87c26b489
2024-05-14 michaelludwig@google.com [graphite] Default to approx fit textures for layers/filters
2024-05-14 michaelludwig@google.com [graphite] Include proxy label in assert
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 22:19:49 +00:00
Chris Bracken
e210669748
[docs] Suggest using same Xcode version as bots ( flutter/engine#52821 )
...
Document that when using RBE, users should ensure the locally installed Xcode toolchain version matches that of the bots, otherwise they're likely to experience slow builds due to cache misses.
Ideally, we should also check the value automatically against the `sdk_version` specified in the relevant `et` build config itself.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-14 21:37:09 +00:00
Zachary Anderson
cd9cf6d62b
[et] Print reproxy stats when RBE shuts down ( flutter/engine#52818 )
...
```
$ bin/et build -c ci/android_release_arm64 ─╯
[2024-05-14T11:28:40.856][ci/android_release_arm64: GN]: OK
[2024-05-14T11:28:42.527][ci/android_release_arm64: RBE startup]: Proxy started successfully.
[2024-05-14T11:31:14.869][ci/android_release_arm64: ninja]: 100.0% (1096/1096) STAMP obj/flutter/lib/snapshot/snapshot.stamp
[2024-05-14T11:31:14.871][ci/android_release_arm64: ninja]: OK
[2024-05-14T11:31:15.182][ci/android_release_arm64: RBE shutdown]: Actions completed: 1021 (569 racing locals, 452 racing remotes)
```
2024-05-14 14:15:10 -07:00
skia-flutter-autoroll
fadafad193
Roll Skia from e26aee36345f to 81ba2eea7b42 (3 revisions) ( flutter/engine#52820 )
...
https://skia.googlesource.com/skia.git/+log/e26aee36345f..81ba2eea7b42
2024-05-14 scroggo@google.com Change CtsEnforcement for ImageAsyncReadPixels
2024-05-14 armansito@google.com Fix CanvasKit WebGPU build
2024-05-14 kjlubick@google.com Add WebGPU build to the CQ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 21:07:04 +00:00
Jason Simmons
6ee57afaf3
Migrate third_party/gradle to flutter/third_party/gradle ( flutter/engine#52814 )
...
Based on https://github.com/flutter/engine/pull/52030
2024-05-14 20:51:10 +00:00
auto-submit[bot]
c7a5f42051
Reverts "[Impeller] immediately encode blit commands for Metal. ( #52795 )" ( flutter/engine#52816 )
...
Reverts: flutter/engine#52795
Initiated by: jonahwilliams
Reason for reverting: failing postsubmit testing -[MTLIGAccelCommandBuffer renderCommandEncoderWithDescriptor:]:438: failed assertion `Already have uncommitted encoder'
Original PR Author: jonahwilliams
Reviewed By: {chinmaygarde}
This change reverts the following previous change:
Metal equivalent of https://github.com/flutter/engine/pull/52794
No need to defer encoding of blit commands when the command encoder already defers execution until we submit the command buffer. Removes extra indirection and heap allocation.
2024-05-14 19:39:47 +00:00
Jonah Williams
fe8dfc3e19
[Impeller] immediately encode blit commands for Metal. ( flutter/engine#52795 )
...
Metal equivalent of https://github.com/flutter/engine/pull/52794
No need to defer encoding of blit commands when the command encoder already defers execution until we submit the command buffer. Removes extra indirection and heap allocation.
2024-05-14 18:04:18 +00:00
gaaclarke
cbac232591
[Impeller] migrated one test over from aiks to dl ( flutter/engine#52786 )
...
A redo of https://github.com/flutter/engine/pull/52711 that maintains
our existing testing patterns.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: jonahwilliams <jonahwilliams@google.com>
2024-05-14 09:46:06 -07:00
Jason Simmons
e6f329968d
[Impeller] Create framebuffer blend vertices based on the snapshot's texture size instead of coverage ( flutter/engine#52790 )
...
The snapshot's transform is provided to the pipeline. If the vertices are based on the coverage rectangle, then that will apply the snapshot's transform twice.
Fixes https://github.com/flutter/flutter/issues/148213
2024-05-14 16:36:47 +00:00
Jenn Magder
e4e7b3242e
Refactor Semantics in preparation for ARC migration ( flutter/engine#52729 )
...
Split the too-large `Semantics` [MRC to ARC migration](https://github.com/flutter/flutter/issues/137801 ) into two PRs: this one, which refactors, and the next which will actually do the migration.
1. Use properties instead of their backing ivars (except in the usual init, dealloc, getters/setters)
2. For Foundation collections prefer `copy` over `strong`.
3. Dot notation for properties
4. Change `privateSetParent:` to instead use a `readwrite` property in `SemanticsObject ()`.
5. Switch the `semanticsObject` property from `weak` to `retain` to get the synthesized property (keeping it as `weak` is a compilation error in MRC) but I'll swap it back to a `weak` in the ARC migration PR coming next.
6. `SemanticsObjectTest` fails on my machine and passes on CI. Switched the cleaner `CGRectEqualToRect` (and related) checks to instead assert x, y, width, height so we can see the value when it fails:
```
((CGSizeEqualToSize( scrollView.contentSize, CGSizeMake((w + scrollExtentMax) * effectivelyScale, h * effectivelyScale))) is true) failed
```
becomes:
```
((scrollView.contentSize.height) equal to (h * effectivelyScale)) failed: ("33.3333333333") is not equal to ("33.333336")
```
Use `XCTAssertEqualWithAccuracy` now that I can see it's a floating point precision issue.
2024-05-14 16:30:52 +00:00
skia-flutter-autoroll
c051d81690
Roll Skia from 421d8d034e6e to 7dad6da92119 (1 revision) ( flutter/engine#52806 )
...
https://skia.googlesource.com/skia.git/+log/421d8d034e6e..7dad6da92119
2024-05-14 armansito@google.com Revert "Add ISO 21496-1 gainmap parsing"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 13:19:23 +00:00
skia-flutter-autoroll
aacb95ffc1
Roll Skia from 7045b90f1ef8 to 421d8d034e6e (1 revision) ( flutter/engine#52803 )
...
https://skia.googlesource.com/skia.git/+log/7045b90f1ef8..421d8d034e6e
2024-05-14 blundell@chromium.org [Graphite] Add YCbCr info to DawnTextureInfo
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 08:11:53 +00:00
skia-flutter-autoroll
1418daa2be
Roll Skia from 19153175a79b to 7045b90f1ef8 (3 revisions) ( flutter/engine#52801 )
...
https://skia.googlesource.com/skia.git/+log/19153175a79b..7045b90f1ef8
2024-05-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b43af3a7d497 to 57395f92b117
2024-05-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 4910599942c0 to b43af3a7d497 (4 revisions)
2024-05-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 1b2d3eb175fd to 166c9d5d561d (18 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 06:40:35 +00:00
Jonah Williams
12b56a350b
[Impeller] use render pass to clear glyph atlas texture to transparent black. ( flutter/engine#52791 )
...
Alternative to https://github.com/flutter/engine/pull/52746
Work towards https://github.com/flutter/flutter/issues/138798
If possible, use a render pass to clear texture to transparent black. The goal is to reduce the CPU cost for larger atlases.
2024-05-14 06:06:12 +00:00
dependabot[bot]
f331d37840
Bump google/osv-scanner-action from 1.7.1 to 1.7.3 ( flutter/engine#52798 )
...
Bumps [google/osv-scanner-action](https://github.com/google/osv-scanner-action ) from 1.7.1 to 1.7.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/google/osv-scanner-action/releases ">google/osv-scanner-action's releases</a>.</em></p>
<blockquote>
<h2>v1.7.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Branches filter is not available for merge_group by <a href="https://github.com/thomasleplus "><code>@âthomasleplus</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/15 ">google/osv-scanner-action#15</a></li>
<li>Update to track osv-scanner v1.7.3 by <a href="https://github.com/another-rex "><code>@âanother-rex</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/17 ">google/osv-scanner-action#17</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/shahar-h "><code>@âshahar-h</code></a> made their first contribution in <a href="https://redirect.github.com/google/osv-scanner-action/pull/8 ">google/osv-scanner-action#8</a></li>
<li><a href="https://github.com/thomasleplus "><code>@âthomasleplus</code></a> made their first contribution in <a href="https://redirect.github.com/google/osv-scanner-action/pull/15 ">google/osv-scanner-action#15</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/google/osv-scanner-action/compare/v1.7.1...v1.7.3 ">https://github.com/google/osv-scanner-action/compare/v1.7.1...v1.7.3 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="75532bf0bfhttps://redirect.github.com/google/osv-scanner-action/issues/17 ">#17</a> from google/update-to-v1.7.3</li>
<li><a href="55793806cbe1d89d3de2667ecd2ffehttps://redirect.github.com/google/osv-scanner-action/issues/15 ">#15</a> from thomasleplus/main</li>
<li><a href="d8e1333b3cc6d5eb195dhttps://redirect.github.com/google/osv-scanner-action/issues/8 ">#8</a> from shahar-h/upgrade-actions</li>
<li><a href="1d49da2626https://redirect.github.com/google/osv-scanner-action/issues/9 ">#9</a> from google/add-renovatebot</li>
<li><a href="e847f4e9a792d143c58857ddf9f868https://redirect.github.com/google/osv-scanner-action/issues/6 ">#6</a> from google/update-readme</li>
<li>Additional commits viewable in <a href="https://github.com/google/osv-scanner-action/compare/v1.7.1...v1.7.3 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-05-14 05:57:52 +00:00
dependabot[bot]
f9fd65213c
Bump ossf/scorecard-action from 2.3.1 to 2.3.3 ( flutter/engine#52799 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.3.1 to 2.3.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ossf/scorecard-action/releases ">ossf/scorecard-action's releases</a>.</em></p>
<blockquote>
<h2>v2.3.3</h2>
<blockquote>
<p>[!NOTE]<br />
There is no v2.3.2 release as a step was skipped in the release process. This was fixed and re-released under the v2.3.3 tag</p>
</blockquote>
<h2>What's Changed</h2>
<ul>
<li>🌱 Bump github.com/ossf/scorecard/v4 (v4.13.1) to github.com/ossf/scorecard/v5 (v5.0.0-rc1) by <a href="https://github.com/spencerschrock "><code>@âspencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1366 ">ossf/scorecard-action#1366</a></li>
<li>🌱 Bump github.com/ossf/scorecard/v5 from v5.0.0-rc1 to v5.0.0-rc2 by <a href="https://github.com/spencerschrock "><code>@âspencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1374 ">ossf/scorecard-action#1374</a></li>
<li>🌱 Bump github.com/ossf/scorecard/v5 from v5.0.0-rc2 to v5.0.0-rc2.0.20240509182734-7ce860946928 by <a href="https://github.com/spencerschrock "><code>@âspencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1377 ">ossf/scorecard-action#1377</a></li>
</ul>
<p>For a full changelist of what these include, see the <a href="https://github.com/ossf/scorecard/releases/tag/v5.0.0-rc1 ">v5.0.0-rc1</a> and <a href="https://github.com/ossf/scorecard/releases/tag/v5.0.0-rc2 ">v5.0.0-rc2</a> release notes.</p>
<h3>Documentation</h3>
<ul>
<li>📖 Move token discussion out of main README. by <a href="https://github.com/spencerschrock "><code>@âspencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1279 ">ossf/scorecard-action#1279</a></li>
<li>📖 link to <code>ossf/scorecard</code> workflow instead of maintaining an example by <a href="https://github.com/spencerschrock "><code>@âspencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1352 ">ossf/scorecard-action#1352</a></li>
<li>📖 update api links to new scorecard.dev site by <a href="https://github.com/spencerschrock "><code>@âspencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1376 ">ossf/scorecard-action#1376</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/ossf/scorecard-action/compare/v2.3.1...v2.3.3 ">https://github.com/ossf/scorecard-action/compare/v2.3.1...v2.3.3 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="dc50aa9510🌱 Bump docker tag for v2.3.3 release (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1368 ">#1368</a>)</li>
<li><a href="8ff5700173🌱 Bump github.com/ossf/scorecard/v5 from v5.0.0-rc2 to v5.0.0-rc2.0....</li>
<li><a href="8ba5e73d11https://redirect.github.com/ossf/scorecard-action/issues/1376 ">#1376</a>)</li>
<li><a href="92ddde3eafhttps://redirect.github.com/ossf/scorecard-action/issues/1374 ">#1374</a>)</li>
<li><a href="6c55905542🌱 Bump golang.org/x/net from 0.24.0 to 0.25.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1373 ">#1373</a>)</li>
<li><a href="09bb953b6a🌱 Bump distroless/base in the docker-images group (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1372 ">#1372</a>)</li>
<li><a href="1511e1305b🌱 Bump the github-actions group across 1 directory with 6 updates (#...</li>
<li><a href="df66cd8fd8🌱 Bump the docker-images group with 2 updates (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1370 ">#1370</a>)</li>
<li><a href="fad9a3cc53🌱 Bump distroless/base in the docker-images group (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1364 ">#1364</a>)</li>
<li><a href="1e01a309c1🌱 Bump the github-actions group with 3 updates (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1365 ">#1365</a>)</li>
<li>Additional commits viewable in <a href="0864cf1902...dc50aa9510https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ossf/scorecard-action&package-manager=github_actions&previous-version=2.3.1&new-version=2.3.3 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-05-14 05:57:50 +00:00
skia-flutter-autoroll
9942fc30cf
Roll Skia from 93912d50850d to 349fdd5f0b69 (2 revisions) ( flutter/engine#52796 )
...
https://skia.googlesource.com/skia.git/+log/93912d50850d..349fdd5f0b69
2024-05-14 sharaks@google.com Merge 7 release notes into RELEASE_NOTES.md
2024-05-14 sharaks@google.com Update Skia milestone to 127
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 04:31:03 +00:00
Matan Lurey
d89f54dd65
Replace json_utils with a modern extension type, add tests. ( flutter/engine#52769 )
...
I started on a refactoring of
https://github.com/flutter/flutter/issues/147666 , and was frustrated
with the JSON decoding of `gn desc --format=json`, so I used a similar
pattern from my micro-json library (https://pub.dev/packages/jsonut ) and
encapsulated it as an extension type.
My favorite is the `JsonObject.map` function which replaces:
```dart
/// Construct a RunTarget from a JSON map.
factory RunTarget.fromJson(Map<String, Object> map) {
final List<String> errors = <String>[];
final String name = stringOfJson(map, _nameKey, errors)!;
final String id = stringOfJson(map, _idKey, errors)!;
final String targetPlatform =
stringOfJson(map, _targetPlatformKey, errors)!;
if (errors.isNotEmpty) {
throw FormatException('Failed to parse RunTarget: ${errors.join('\n')}');
}
return RunTarget._(name, id, targetPlatform);
}
```
... with:
```dart
/// Construct a RunTarget from a JSON map.
factory RunTarget.fromJson(Map<String, Object> map) {
return JsonObject(map).map((JsonObject json) => RunTarget._(
json.string(_nameKey),
json.string(_idKey),
json.string(_targetPlatformKey),
));
}
```
2024-05-13 20:03:43 -07:00
Jason Simmons
3c17cf0357
Move libcxx to //flutter/third_party ( flutter/engine#52773 )
...
Fixes https://github.com/flutter/flutter/issues/144202
2024-05-13 19:26:04 -07:00
Dustin Green
cb40a91c25
[fuchsia][sysmem2] route fuchsia.sysmem2.Allocator ( flutter/engine#52708 )
...
Route fuchsia.sysmem2.Allocator everywhere that
fuchsia.sysmem.Allocator is routed.
fixes flutter/flutter#146858
2024-05-13 19:24:46 -07:00
skia-flutter-autoroll
efa6bcd8b9
Roll Dart SDK from 7c7767ecc3d7 to fe75fa5f7dc0 (1 revision) ( flutter/engine#52792 )
...
https://dart.googlesource.com/sdk.git/+log/7c7767ecc3d7..fe75fa5f7dc0
2024-05-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-152.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 02:00:06 +00:00
