62 Commits

Author SHA1 Message Date
Chinmay Garde
1bc0e1bb9a
On windows, refer to Dart snapshot directly executable. (#5024) 2018-04-16 22:02:19 -07:00
Chinmay Garde
58e84c8bf0
Re-land "Support multiple shells in a single process. (#4932)" (#4998)
* Re-land "Support multiple shells in a single process. (#4932)"

This reverts commit 723c7d01439da4261bc836075fb55651ce9e7f03.
2018-04-13 13:48:15 -07:00
Vyacheslav Egorov
723c7d0143
Revert "Re-land "Support multiple shells in a single process. (#4932)" (#4977)" (#4981)
This reverts commit a3327bff86800b3e654a2988fa7e6049edeb679c.
2018-04-12 18:28:55 +02:00
Chinmay Garde
a3327bff86
Re-land "Support multiple shells in a single process. (#4932)" (#4977)
This reverts commit 9199b40f2a2a6e448cd251de44e020ec3b75002d.
2018-04-11 15:41:23 -07:00
Chinmay Garde
9199b40f2a
Revert "Support multiple shells in a single process. (#4932)" (#4964)
This reverts commit 6baff4c821350bbcb64e7d029574b567f3801a1a.
2018-04-10 15:28:43 -07:00
Chinmay Garde
6baff4c821
Support multiple shells in a single process. (#4932)
* Support multiple shells in a single process.

The Flutter Engine currently works by initializing a singleton shell
instance. This shell has to be created on the platform thread. The shell
is responsible for creating the 3 main threads used by Flutter (UI, IO,
GPU) as well as initializing the Dart VM. The shell, references to task
runners of the main threads as well as all snapshots used for VM
initialization are stored in singleton objects. The Flutter shell only
creates the threads, rasterizers, contexts, etc. to fully support a
single Flutter application. Current support for multiple Flutter
applications is achieved by making multiple applications share the same
resources (via the platform views mechanism).

This scheme has the following limitations:

* The shell is a singleton and there is no way to tear it down. Once you
  run a Flutter application in a process, all resources managed by it
  will remain referenced till process termination.
* The threads on which the shell performs its operations are all
  singletons. These threads are never torn down and multiple Flutter
  applications (if present) have to compete with one another on these
  threads.
* Resources referenced by the Dart VM are leaked because the VM isn't
  shutdown even when there are no more Flutter views.
* The shell as a target does not compile on Fuchsia. The Fuchsia content
  handler uses specific dependencies of the shell to rebuild all the
  shell dependencies on its own. This leads to differences in frame
  scheduling, VM setup, service protocol endpoint setup, tracing, etc..
  Fuchsia is very much a second class citizen in this world.
* Since threads and message loops are managed by the engine, the engine
  has to know about threading and platform message loop interop on each
  supported platform.

Specific updates in this patch:

* The shell is no longer a singleton and the embedder holds the unique
  reference to the shell.
* Shell setup and teardown is deterministic.
* Threads are no longer managed by the shell. Instead, the shell is
  given a task runner configuration by the embedder.
* Since the shell does not own its threads, the embedder can control
  threads and the message loops operating on these threads. The shell is
  only given references to the task runners that execute tasks on these
  threads.
* The shell only needs task runner references. These references can be
  to the same task runner. So, if the embedder thinks that a particular
  Flutter application would not need all the threads, it can pass
  references to the same task runner. This effectively makes Flutter
  application run in single threaded mode. There are some places in the
  shell that make synchronous calls, these sites have been updated to
  ensure that they don’t deadlock.
* The test runner and the headless Dart code runner are now Flutter
  applications that are effectively single threaded (since they don’t
  have rendering concerns of big-boy Flutter application).
* The embedder has to guarantee that the threads and outlive the shell.
  It is easy for the embedder to make that guarantee because shell
  termination is deterministic.
* The embedder can create as many shell as it wants. Typically it
  creates a shell per Flutter application with its own task runner
  configuration. Most embedders obtain these task runners from threads
  dedicated to the shell. But, it is entirely possible that the embedder
  can obtain these task runners from a thread pool.
* There can only be one Dart VM in the process. The numerous shell
  interact with one another to manage the VM lifecycle. Once the last
  shell goes away, the VM does as well and hence all resources
  associated with the VM are collected.
* The shell as a target can now compile and run on Fuchsia. The current
  content handler has been removed from the Flutter engine source tree
  and a new implementation has been written that uses the new shell
  target.
* Isolate management has been significantly overhauled. There are no
  owning references to Dart isolates within the shell. The VM owns the
  only strong reference to the Dart isolate. The isolate that has window
  bindings is now called the root isolate. Child isolates can now be
  created from the root isolate and their bindings and thread
  configurations are now inherited from the root isolate.
* Terminating the shell terminates its root isolates as well as all the
  isolates spawned by this isolate. This is necessary be shell shutdown
  is deterministic and the embedder is free to collect the threads on
  which the isolates execute their tasks (and listen for mircrotasks
  flushes on).
* Launching the root isolate is now significantly overhauled. The shell
  side (non-owning) reference to an isolate is now a little state
  machine and illegal state transitions should be impossible (barring
  construction issues). This is the only way to manage Dart isolates in
  the shell (the shell does not use the C API is dart_api.h anymore).
* Once an isolate is launched, it must be prepared (and hence move to
  the ready phase) by associating a snapshot with the same. This
  snapshot can either be a precompiled snapshot, kernel snapshot, script
  snapshot or source file. Depending on the kind of data specified as a
  snapshot as well as the capabilities of the VM running in the process,
  isolate preparation can fail preparation with the right message.
* Asset management has been significantly overhauled. All asset
  resolution goes through an abstract asset resolver interface. An asset
  manager implements this interface and manages one or more child asset
  resolvers. These asset resolvers typically resolve assets from
  directories, ZIP files (legacy FLX assets if provided), APK bundles,
  FDIO namespaces, etc…
* Each launch of the shell requires a separate and fully configured
  asset resolver. This is necessary because launching isolates for the
  engine may require resolving snapshots as assets from the asset
  resolver. Asset resolvers can be shared by multiple launch instances
  in multiple shells and need to be thread safe.
* References to the command line object have been removed from the
  shell. Instead, the shell only takes a settings object that may be
  configured from the command line. This makes it easy for embedders and
  platforms that don’t have a command line (Fuchsia) to configure the
  shell. Consequently, there is only one spot where the various switches
  are read from the command line (by the embedder and not the shell) to
  form the settings object.
* All platform now respect the log tag (this was done only by Android
  till now) and each shell instance have its own log tag. This makes
  logs from multiple Flutter application in the same process (mainly
  Fuchsia) more easily decipherable.
* The per shell IO task runner now has a new component that is
  unfortunately named the IOManager. This component manages the IO
  GrContext (used for asynchronous texture uploads) that cooperates with
  the GrContext on the GPU task runner associated with the shell. The
  IOManager is also responsible for flushing tasks that collect Skia
  objects that reference GPU resources during deterministic shell
  shutdown.
* The embedder now has to be careful to only enable Blink on a single
  instance of the shell. Launching the legacy text layout and rendering
  engine multiple times is will trip assertions. The entirety of this
  runtime has been separated out into a separate object and can be
  removed in one go when the migration to libtxt is complete.
* There is a new test target for the various C++ objects that the shell
  uses to interact with the Dart VM (the shell no longer use the C API
  in dart_api.h). This allows engine developers to test VM/Isolate
  initialization and teardown without having the setup a full shell
  instance.
* There is a new test target for the testing a single shell instances
  without having to configure and launch an entire VM and associated
  root isolate.
* Mac, Linux & Windows used to have different target that created the
  flutter_tester referenced by the tool. This has now been converted
  into a single target that compiles on all platforms.
* WeakPointers vended by the fml::WeakPtrFactory(notice the difference
  between the same class in the fxl namespace) add threading checks on
  each use. This is enabled by getting rid of the “re-origination”
  feature of the WeakPtrFactory in the fxl namespace. The side effect of
  this is that all non-thread safe components have to be created, used
  and destroyed on the same thread. Numerous thread safety issues were
  caught by this extra assertion and have now been fixed.
  * Glossary of components that are only safe on a specific thread (and
    have the fml variants of the WeakPtrFactory):
    * Platform Thread: Shell
    * UI Thread: Engine, RuntimeDelegate, DartIsolate, Animator
    * GPU Thread: Rasterizer, Surface
    * IO Thread: IOManager

This patch was reviewed in smaller chunks in the following pull
requests. All comments from the pulls requests has been incorporated
into this patch:

* flutter/assets: https://github.com/flutter/engine/pull/4829
* flutter/common: https://github.com/flutter/engine/pull/4830
* flutter/content_handler: https://github.com/flutter/engine/pull/4831
* flutter/flow: https://github.com/flutter/engine/pull/4832
* flutter/fml: https://github.com/flutter/engine/pull/4833
* flutter/lib/snapshot: https://github.com/flutter/engine/pull/4834
* flutter/lib/ui: https://github.com/flutter/engine/pull/4835
* flutter/runtime: https://github.com/flutter/engine/pull/4836
* flutter/shell: https://github.com/flutter/engine/pull/4837
* flutter/synchronization: https://github.com/flutter/engine/pull/4838
* flutter/testing: https://github.com/flutter/engine/pull/4839
2018-04-10 14:57:02 -07:00
Jason Simmons
d42b5b73b5
libtxt: support for locale-specific text styles (#4943)
Fixes https://github.com/flutter/flutter/issues/12630
2018-04-06 11:48:03 -07:00
P.Y. Laligand
f6905f575a
[fuchsia] Look for .packages under the proper directory. (#4909) 2018-03-30 21:08:47 -07:00
P.Y. Laligand
4a347699e7
[fuchsia] Use the dart_library template instead of the build system's implementation. (#4908) 2018-03-30 19:27:15 -07:00
Régis Crelier
485e7eef8f
List missing core lib bigint_patch.dart source for new Bigint implementation (#4735)
* work in progress

* work in progress
2018-03-01 14:57:21 -08:00
Alexander Markov
f7c5fea6fb
Move generated entry points JSON out of flutter_patched_sdk, add an option to pass entry points to frontend_server (#4734)
Flutter downloads only one version of flutter_patched_sdk, which was obtained from host_debug build on Linux. Generated entry points JSON files are different in profile and release builds (as release build omits observatory), so these files should be downloaded independently of flutter_patched_sdk.

This PR moves generated entry points JSON files from flutter_patched_sdk to a separate directory (out/*/dart_entry_points) and adds an option to specify entry points to frontend_server (as Flutter tools will need to pass custom locations of entry points files outside of flutter_patched_sdk).
2018-03-01 14:02:35 -08:00
Alexander Markov
6607231638
Prepare to enable global type flow analysis in AOT (#4725)
* Generate Flutter-specific entry points JSON file while building engine.
* Add ''--tfa' option to front-end server.
* Rename _entryPoint field in front-end server to _mainSource to avoid disambiguation.
2018-02-28 15:31:52 -08:00
Ryan Macnak
e5a597fb7e
[fuchsia] Decouple common packages from the core snapshot. (#4660) 2018-02-12 14:55:11 -08:00
Ryan Macnak
638af1532a
Some cleanups for building platform.dill. (#4635) 2018-02-05 15:33:55 -08:00
Alexander Aprelev
9bc2efdf47
Roll dart, remove patched_sdk from flutter now that frontend handles patching (#4633)
* Fixes to make https://dart-review.googlesource.com/c/sdk/+/36641 work with Flutter

* Roll dart

* Update license

* Roll dart

* Update license

* Add libraries.json to dependencies
2018-02-05 13:44:16 -08:00
Siva
0f0b144b03
Add support for --strong option in the engine, create a strong mode version of the platform file (#4504)
* Add a --strong option to the front end server so we can use strong mode with preview-dart-2.

* Plumb the --strong option through the dart controller into the VM.

* - Build a strong version of platform.dill for use with the engine.
- Fix a strong mode static error in the assert statement

* Enable asserts when running debug version even in strong mode.

* Use the correct platform dill file for linking when doing the aot builds.

* Fix formatting issue.
2018-01-03 16:52:24 -08:00
Zachary Anderson
9463b32b23
Reland: [GN] Don't set dart_host_toolchain (#4314) 2017-11-02 10:04:06 -07:00
Mikkel Nygaard Ravn
b41511e9a5
Revert "[GN] Don't set dart_host_toolchain (#4308)" (#4310)
This reverts commit 4caa68b8a061595ccdd8de17b530584604947b79.
2017-11-02 09:09:15 +01:00
Zachary Anderson
4caa68b8a0
[GN] Don't set dart_host_toolchain (#4308) 2017-11-01 13:36:18 -07:00
P.Y. Laligand
f339b2fbb4 [fuchsia] Account for the new Dart toolchain. (#4271) 2017-10-24 21:30:40 -07:00
P.Y. Laligand
419ee7c355 Update the location of Flutter packages. (#4257) 2017-10-20 14:25:49 -07:00
P.Y. Laligand
6fcb45991d Move //dart to //third_party/dart. (#4245) 2017-10-19 01:20:38 -07:00
P.Y. Laligand
5fae5d52cf Allow the project to be mapped to a location other than //flutter. (#4203)
This is for Fuchsia where we would like it to be located at //third_party/flutter.
2017-10-13 17:00:58 -07:00
Alexander Aprelev
a91e7b0c8b Revert "Change kernel platform generation dependency name (#4189)" (#4192)
This reverts commit 83224fb6012c893b78c75e87184d3877c088394a.
2017-10-10 13:34:28 -07:00
Alexander Aprelev
83224fb601 Change kernel platform generation dependency name (#4189)
* Change kernel platform generation dependency name

* Include vmservice which is needed by gen_snapshot for Flutter release build
2017-10-10 13:24:04 -07:00
Alexander Aprelev
a9390e6fdc Revert "Revert "Roll dart to pick up change where platform.dill was removed (#4180)" (#4185)" (#4186)
This reverts commit a89f46696d4bc16d814f6697f46e9514b1193b0e.

Doing the synchronized roll of Dart into engine as well as into Fuchsia
to prevent Fuchsia breakage.
2017-10-09 11:18:59 -07:00
Adam Barth
a89f46696d Revert "Roll dart to pick up change where platform.dill was removed (#4180)" (#4185)
This reverts commit 37f571ee09b24f0248e3ab5d530acdb8ec2db018.
2017-10-09 09:13:13 -07:00
Alexander Aprelev
37f571ee09 Roll dart to pick up change where platform.dill was removed (#4180)
* Roll dart to pick up change where platform.dill was removed

* Fix flutter patch sdk generation

* Update license hash. No changes to license text.

* Roll dart to pick up a fix for zero-rebuild problem

* Update license hash
2017-10-09 07:29:21 -07:00
Zachary Anderson
be547d66c2 Remove daed --assert_initializer flag (#4181) 2017-10-06 14:54:08 -07:00
Adam Barth
160a98c2b2 Update paths to Fuchsia libraries (#4147)
These libraries are in Topaz now.
2017-09-27 13:45:49 -07:00
George Kulakowski
550d0c6490 Rename Magenta to Zircon, along with associated abbreviations (#4114) 2017-09-14 22:49:46 -07:00
Adam Barth
2a13951fa9 Update paths for //application move (#4085) 2017-09-11 14:40:03 -07:00
Ian McKellar
0558644e66 Remove package:lib.fidl.dart/core.dart (#4082) 2017-09-08 16:24:48 -07:00
Adam Barth
457f92ba48 Update paths for Mozart move (#4081) 2017-09-08 15:24:16 -07:00
Ian McKellar
0047b71aaf Updates for the dart:fidl.internal rename and split. (#4070)
Now it references dart:zircon and dart:fuchsia.
2017-09-06 15:33:43 -07:00
P.Y. Laligand
277abef91f Removed reference to lib.widgets. (#4050) 2017-09-01 19:26:06 -07:00
Adam Barth
73554a1c32 Add //garnet (#4043)
This repository contains FTL now in the Fuchsia build.
2017-08-31 16:47:13 -07:00
Adam Barth
70f6251f21 Update gn path for FIDL move (#4023)
We're moving the FIDL library to a new path. This patch updates the GN
dependency.
2017-08-30 12:53:03 -07:00
Ian McKellar
f08b08417d Update to new Dart FIDL bindings API. (#3988)
* Update to new Dart FIDL bindings API.
2017-08-22 13:32:46 -07:00
Zachary Anderson
23036e515a Fixes for gypi -> gni change in Dart (#3977) 2017-08-15 07:44:27 -07:00
Alexander Aprelev
ba9a525bdc Update Flutter engine kernel-loading logic. (#3886)
* Fix Flutter loading from dill files.

* Remove disable of causal async stacks.

* Include mirrors patch files as they are needed for release/profile gen_snapshot

* Free the bytes

* Add FTL_DCHECK
2017-07-24 09:47:23 -07:00
Ryan Macnak
9d6d69fe15 GN: Use a depfile when generating the core snapshot. (#3844)
Roll Dart to f445c318184b30b3db997ac27f357bcb5d45670a.

Fuchsia issue TO-365
2017-06-30 13:06:35 -07:00
Alexander Aprelev
42b23effaf Fix target name for flutter_patched_sdk so it doesn't conflict with patched_sdk target name, doesn't confuse ninja with depfile defined as .d (#3834) 2017-06-27 17:19:20 -07:00
Alexander Aprelev
009d470d50 Generate flutter-flavoured dart patched sdk and platform.dill (#3814)
* Build Flutter patched-sdk with kernel artifacts

* Switch to new dart_host_toolchain argument mechanism to let dart patch_sdk know of host_toolchain.

* Update dart dependency

* Updated licenses

* Rename dart dependencies tag so they have just 'dart_'-prefixed dart's names.

* Fix indentation and line breaks for newly added deps.

* Add toolchain for windows host

* Update dart revision

* Licenses

* Update licenses

* Revert changes to licenses_third_party
2017-06-27 02:44:04 +00:00
P.Y. Laligand
d13622c0bf Only add Fuchsia-specific stuff when the current OS is Fuchsia. (#3809)
This allows the shell to be built normally for a Fuchsia host.
2017-06-21 15:40:50 -07:00
Ryan Macnak
2c611fdac7 [fuchsia] core-jit (#3753) 2017-06-19 12:12:18 -07:00
Ryan Macnak
3f8eddf34a Plumbing for a core snapshot with code (currently empty). (#3749) 2017-06-07 09:57:24 -07:00
Zachary Anderson
a808ab9f0c Stop passing ignored argument to snapshot script (#3723) 2017-06-01 12:09:14 -07:00
Ryan Macnak
1084a83f11 AOT for Fuchsia. (#3570) 2017-04-11 14:53:14 -07:00
Jason Simmons
29f289acbb Remove dart:jni (#3546)
Fixes https://github.com/flutter/flutter/issues/9129
2017-03-31 13:07:52 -07:00