7682 Commits

Author SHA1 Message Date
Chinmay Garde
b659646ffb Allow embedders to specify arbitrary data to the isolate on launch. (flutter/engine#13047)
Since this is currently only meant to be used by the embedding internally, the setter in Objective-C is only exposed via the FlutterDartProject private class extension. Unit tests have been added to the shell_unittests harness.

Fixes https://github.com/flutter/flutter/issues/37641
2019-10-10 12:31:14 -07:00
skia-flutter-autoroll
e5b64c79a6 Roll src/third_party/skia 69537d798994..b484e7ce24c9 (8 commits) (flutter/engine#13065)
https://skia.googlesource.com/skia.git/+log/69537d798994..b484e7ce24c9

git log 69537d798994..b484e7ce24c9 --date=short --no-merges --format='%ad %ae %s'
2019-10-10 mtklein@google.com hand off frames to encoder as they come
2019-10-10 robertphillips@google.com Pass GrProgramInfo further down Vulkan call chain
2019-10-10 jvanverth@google.com Draw perspective text as paths.
2019-10-10 robertphillips@google.com Add computation of requestedFeatures to GrProgramInfo and use it
2019-10-10 kjlubick@google.com [debugger] Use alternate buffer
2019-10-10 nigeltao@google.com Update Wuffs version to 0.2.0-rc.1
2019-10-10 fmalita@chromium.org [SkVideoEncoder] Allow clients to control the color type
2019-10-10 brianosman@google.com Roll third_party/externals/angle2 8e7d9d6c2326..5d9c4ee328bc (9 commits)

Created with:
  gclient setdep -r src/third_party/skia@b484e7ce24c9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=kjlubick@google.com
2019-10-10 14:00:18 -04:00
Jason Simmons
1759de2b98 Allow embedders to disable causal async stacks in the Dart VM (flutter/engine#13004)
Fixes https://github.com/flutter/flutter/issues/39511
2019-10-10 10:09:03 -07:00
Jason Simmons
524af5638b Integration with more of Skia's SkShaper/SkParagraph APIs (flutter/engine#13008)
Based on https://github.com/Rusino/engine/tree/temp
2019-10-10 10:08:29 -07:00
Yegor
2f8ab3f058 Add "felt clean" command (flutter/engine#13042)
Add "felt clean" command
2019-10-10 07:15:24 -07:00
skia-flutter-autoroll
e55459c358 Roll src/third_party/skia 0fc9b3829b47..69537d798994 (1 commits) (flutter/engine#13061)
https://skia.googlesource.com/skia.git/+log/0fc9b3829b47..69537d798994

git log 0fc9b3829b47..69537d798994 --date=short --no-merges --format='%ad %ae %s'
2019-10-10 kjlubick@google.com [skottie-perf] Remove beetle from list of tests

Created with:
  gclient setdep -r src/third_party/skia@69537d798994

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=kjlubick@google.com
2019-10-10 10:14:13 -04:00
Dan Field
80492fb4e9 Android targets create final zip artifacts (flutter/engine#13059) 2019-10-10 06:56:43 -07:00
sjindel-google
5ea9c249cd Remove use of the blobs snapshot format from unittests (flutter/engine#12563)
* Remove uses of the "blobs" snapshot format in Engine tests.

* Comments

* Rebasing against updated ELF loader API.
2019-10-10 14:03:42 +02:00
skia-flutter-autoroll
6067cb65ea Roll fuchsia/sdk/core/linux-amd64 from QIjex... to v8utw... (flutter/engine#13060)
Roll fuchsia/sdk/core/linux-amd64 from QIjex... to v8utw...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-10 06:52:41 -04:00
skia-flutter-autoroll
c96eb26a04 Roll src/third_party/skia fe23b1de9ed0..0fc9b3829b47 (1 commits) (flutter/engine#13058)
https://skia.googlesource.com/skia.git/+log/fe23b1de9ed0..0fc9b3829b47

git log fe23b1de9ed0..0fc9b3829b47 --date=short --no-merges --format='%ad %ae %s'
2019-10-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 309b078c964e..92809357d851 (414 commits)

Created with:
  gclient setdep -r src/third_party/skia@0fc9b3829b47

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=kjlubick@google.com
2019-10-10 01:40:17 -04:00
Dan Field
7fb9737129 Minimal test harness for iOS (flutter/engine#13029) 2019-10-09 21:16:11 -07:00
Chinmay Garde
2f7e94a0d9 Don’t bump iOS deployment target for Metal builds. (flutter/engine#13051)
Fixed by https://skia-review.googlesource.com/c/skia/+/245957
Fixes https://github.com/flutter/flutter/issues/41807
2019-10-09 20:37:38 -07:00
CloudWebRTC
2362c4e741 Add texture support for macOS shell. (flutter/engine#8507) 2019-10-09 20:35:09 -07:00
Chinmay Garde
6ea0f49c4d Set the Cirrus badge to only display status of the master branch. (flutter/engine#13053)
The badge used to query the last build which may be a pull request (or an aborted run).
2019-10-09 20:04:34 -07:00
skia-flutter-autoroll
b680aba86e Roll src/third_party/skia 76826fc91c0a..fe23b1de9ed0 (4 commits) (flutter/engine#13050)
https://skia.googlesource.com/skia.git/+log/76826fc91c0a..fe23b1de9ed0

git log 76826fc91c0a..fe23b1de9ed0 --date=short --no-merges --format='%ad %ae %s'
2019-10-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-09 herb@google.com Revert "Draw perspective text as paths."
2019-10-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@fe23b1de9ed0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=kjlubick@google.com
2019-10-09 21:54:32 -04:00
Chinmay Garde
1de602f0ad Ignore thread leaks from Dart VM in tsan instrumented builds. (flutter/engine#13049) 2019-10-09 18:12:57 -07:00
Ferhat
931be8696b [web] Implement basic radial gradient (TileMode.clamp, no transform) (flutter/engine#12811)
* Add GradientRadial paintStyle implementation
2019-10-09 15:51:31 -07:00
Dan Field
ad95a1aa04 dart analysis of tests, cleanup (flutter/engine#13033) 2019-10-09 15:13:29 -07:00
skia-flutter-autoroll
aebef7433b Roll fuchsia/sdk/core/linux-amd64 from cknsi... to QIjex... (flutter/engine#13041)
Roll fuchsia/sdk/core/linux-amd64 from cknsi... to QIjex...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-09 18:03:51 -04:00
skia-flutter-autoroll
94ca06cde1 Roll src/third_party/skia e27a503a0a21..76826fc91c0a (9 commits) (flutter/engine#13040)
https://skia.googlesource.com/skia.git/+log/e27a503a0a21..76826fc91c0a

git log e27a503a0a21..76826fc91c0a --date=short --no-merges --format='%ad %ae %s'
2019-10-09 jvanverth@google.com Draw perspective text as paths.
2019-10-09 herb@google.com Introduce SkGlyphPositionRoundingSpec.
2019-10-09 robertphillips@google.com Centralize error checking w/in the GrProgramInfo class
2019-10-09 egdaniel@google.com Add new public api on GrContext for computing image size.
2019-10-09 mtklein@google.com add -f mp4 to skottie_tool
2019-10-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-09 robertphillips@google.com Tighten up creation of the GrProgramDesc and remove some unnecessary checks
2019-10-09 kjlubick@google.com [canvaskit] Update to build with emscripten 1.38.47
2019-10-09 bungeman@google.com Retain hints when subsetting for PDF.

Created with:
  gclient setdep -r src/third_party/skia@76826fc91c0a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=kjlubick@google.com
2019-10-09 17:54:48 -04:00
Harry Terkelsen
5b6b713615 [web_ui] Check if a pointer is already down for the specific device (flutter/engine#12470)
* WIP on fixing pointer event clicks

* Don't set canvaskit as enabled by default

* Use a Set of pressed buttons rather than a Map of button status to
avoid memory leaks

* Add test for pointer binding

Fix bug where event listeners weren't properly removed
2019-10-09 12:43:06 -07:00
Greg Spencer
1adf6d2ed0 Add missing focusable testing info (flutter/engine#13013)
This adds a couple of instances of semantic node isFocusable info that were missing that the framework testing depends upon.
2019-10-09 09:00:24 -07:00
skia-flutter-autoroll
04f362791e Roll src/third_party/skia 54548626a977..e27a503a0a21 (1 commits) (flutter/engine#13024)
https://skia.googlesource.com/skia.git/+log/54548626a977..e27a503a0a21

git log 54548626a977..e27a503a0a21 --date=short --no-merges --format='%ad %ae %s'
2019-10-09 kjlubick@google.com [canvaskit] Clean up embedded fonts

Created with:
  gclient setdep -r src/third_party/skia@e27a503a0a21

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=kjlubick@google.com
2019-10-09 11:38:45 -04:00
gaaclarke
d4a3cc6b67 Refactor: FlutterDartProject (flutter/engine#13006)
- Removed unused instance variable
- Explicitly listed nullability
2019-10-09 07:21:44 -07:00
skia-flutter-autoroll
fd86b3b717 Roll src/third_party/skia 77dde599c98a..54548626a977 (1 commits) (flutter/engine#13023)
https://skia.googlesource.com/skia.git/+log/77dde599c98a..54548626a977

git log 77dde599c98a..54548626a977 --date=short --no-merges --format='%ad %ae %s'
2019-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a333b87cfcbe..8e7d9d6c2326 (9 commits)

Created with:
  gclient setdep -r src/third_party/skia@54548626a977

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=kjlubick@google.com
2019-10-09 05:44:19 -04:00
skia-flutter-autoroll
75e1125f11 Roll src/third_party/skia 2b1a25a4d324..77dde599c98a (1 commits) (flutter/engine#13021)
https://skia.googlesource.com/skia.git/+log/2b1a25a4d324..77dde599c98a

git log 2b1a25a4d324..77dde599c98a --date=short --no-merges --format='%ad %ae %s'
2019-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 5c41949c8fc4..309b078c964e (481 commits)

Created with:
  gclient setdep -r src/third_party/skia@77dde599c98a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=kjlubick@google.com
2019-10-09 01:59:08 -04:00
skia-flutter-autoroll
79f882fc68 Roll fuchsia/sdk/core/linux-amd64 from q_uYX... to cknsi... (flutter/engine#13019)
Roll fuchsia/sdk/core/linux-amd64 from q_uYX... to cknsi...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-08 23:59:14 -04:00
skia-flutter-autoroll
12267a5ce2 Roll src/third_party/skia 1494a7f1ec03..2b1a25a4d324 (15 commits) (flutter/engine#13016)
https://skia.googlesource.com/skia.git/+log/1494a7f1ec03..2b1a25a4d324

git log 1494a7f1ec03..2b1a25a4d324 --date=short --no-merges --format='%ad %ae %s'
2019-10-08 joe@bitworking.org Fix Cloud Build for vpython.
2019-10-08 jcgregorio@google.com Revert "Another attempt to fix vpython in Cloud Build."
2019-10-08 robertphillips@google.com Add GrRenderTask and GrOp prePrepare framework
2019-10-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-08 jlavrova@google.com Bug fix (strut must be false by default)
2019-10-08 robertphillips@google.com Add GrProgramInfo to centralize management of program information
2019-10-08 jcgregorio@google.com Another attempt to fix vpython in Cloud Build.
2019-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 5c593bf702db..a52db47aa53f (1 commits)
2019-10-08 egdaniel@google.com Add bytes per pixel to metal format table.
2019-10-08 herb@google.com Use SkZip in SkGlyphRun
2019-10-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 684790252fe2..5c593bf702db (1 commits)
2019-10-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-08 egdaniel@google.com Track gl format bytes per pixel on format table.

Created with:
  gclient setdep -r src/third_party/skia@2b1a25a4d324

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=kjlubick@google.com
2019-10-08 22:13:12 -04:00
Chinmay Garde
95297dba87 Revert "Upgrade compiler to Clang 10. (#11256)" (flutter/engine#13017)
This reverts commit 655c98543235dd9452a304dc035d3e39990ebc2a.
2019-10-08 18:23:59 -07:00
Chinmay Garde
655c985432 Upgrade compiler to Clang 10. (flutter/engine#11256) 2019-10-08 17:45:30 -07:00
Greg Spencer
cb3ae0ec59 Send AccessibilityEvent.TYPE_VIEW_FOCUSED when input focus is set. (flutter/engine#12746)
When the focus changes, we should be sending a TYPE_VIEW_FOCUSED event. This enables that.
2019-10-08 16:54:17 -07:00
Dan Field
117f6e94eb Fix for a11y crash on iOS (flutter/engine#12990) 2019-10-08 16:37:09 -07:00
Kate Lovett
5b656f8f70 Link Semantics Typo (flutter/engine#13009) 2019-10-08 16:26:00 -07:00
Ferhat
16bb890bbf [web] Add support for path transform (flutter/engine#12794)
* Implement path.transform
2019-10-08 16:05:54 -07:00
Jason Simmons
4a39184fec Auto-formatter fixes for BUILD.gn files (flutter/engine#13005) 2019-10-08 15:15:47 -07:00
Ben Konyi
5c9fdc84d4 Unblock SIGPROF on flutter_tester start (flutter/engine#12813)
Fixes https://github.com/flutter/flutter/issues/35140
2019-10-08 15:13:08 -07:00
Mouad Debbar
94257be6d7 [web] Update the url when route is replaced (flutter/engine#13003) 2019-10-08 14:47:25 -07:00
Kate Lovett
42140242f0 Missing link flag (flutter/engine#13001) 2019-10-08 13:49:46 -07:00
gaaclarke
15c78df45f Started setting our debug background task id to invalid after completion. (flutter/engine#12999) 2019-10-08 13:12:52 -07:00
Chris Yang
cc04914ab4 Add onUnregistered callback in 'Texture' and 'FlutterTexture' (flutter/engine#12695)
Texture unregistration is finished on the GPU thread. The FlutterTexture implementation might not know when it is finished which leads to a race condition. Adding this callback so the FlutterTexture is aware of end of the unregistration process.
2019-10-08 12:45:57 -07:00
skia-flutter-autoroll
5af3cba112 Roll src/third_party/skia 902cf1e12a74..1494a7f1ec03 (10 commits) (flutter/engine#13000)
https://skia.googlesource.com/skia.git/+log/902cf1e12a74..1494a7f1ec03

git log 902cf1e12a74..1494a7f1ec03 --date=short --no-merges --format='%ad %ae %s'
2019-10-08 jcgregorio@google.com Revert "cloud-build: set HOME env variable."
2019-10-08 jcgregorio@google.com cloud-build: set HOME env variable.
2019-10-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-08 herb@google.com Add tests for SkZip first, data, and consting copy ctor
2019-10-08 brianosman@google.com Remove SkCurve and SkColorCurve
2019-10-08 egdaniel@google.com Also blacklist path_text benches on vulkan pixel3a.
2019-10-08 robertphillips@google.com Black list failing test(s) on internal bot
2019-10-08 fs@opera.com Fix mapping the morphology filter's radius when the CTM is a mirror op
2019-10-08 egdaniel@google.com Move vulkan BytesPerPixel to format table.
2019-10-08 benjaminwagner@google.com Reland "Use integer patchset and issue variables."

Created with:
  gclient setdep -r src/third_party/skia@1494a7f1ec03

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=kjlubick@google.com
2019-10-08 14:54:44 -04:00
liyuqian
7bffe3c0a8 SkSL precompile (flutter/engine#12412)
For https://github.com/flutter/flutter/issues/40686

Unit tests added:
- CacheSkSLWorks
- VisitFilesCanBeCalledTwice
- CanListFilesRecursively
2019-10-08 11:51:28 -07:00
Chinmay Garde
3873eeabb6 Compile sanitizer suppressions list and file bugs as necessary. (flutter/engine#12991) 2019-10-08 11:33:26 -07:00
Chinmay Garde
b05e9e7d6a Add a unit-test to verify that root surface transformation affect platform view coordinates. (flutter/engine#12783)
See b/141980393 for details.

In the issue, the embedder (assumed to render Flutter contents of size 800 x 600 [1]) is meant to be displayed on its side. To achieve this, it specifies a root surface transformation that translates the surface by its width (or height when it held in the correct viewing position) and then rotates it counter-clockwise by 90 degrees. This test verifies that the Flutter Engine accounts for those transformations in the custom compositor platform view coodinates.

[1] The actual size is something different. 800x600 is for illustrative purposes.
2019-10-08 11:30:00 -07:00
Kate Lovett
73b60d4d7c Re-land Adding Link Semantics (flutter/engine#12972) 2019-10-08 11:27:56 -07:00
gaaclarke
17cbf8c51e Added an embedder example (flutter/engine#12808) 2019-10-08 10:07:27 -07:00
Sebastian Roth
2590c9ff02 Fix typo on channel buffer debug output. (flutter/engine#12960) 2019-10-08 18:06:32 +01:00
gaaclarke
e00573aa95 Made _printDebug only happen on debug builds of the engine for now. (flutter/engine#12980) 2019-10-08 10:05:48 -07:00
Devon Carew
00ae651c92 remove references to package:_chrome (flutter/engine#12931) 2019-10-08 09:41:46 -07:00
David Iglesias
daeccbceb5 Open source canvas tests from flutter_web_ui (flutter/engine#12819)
* Open source canvas tests from flutter_web_ui

Reimplement some painter tests as screenshot tests on canvas.

Needs https://github.com/flutter/goldens/pull/53
Fixes https://github.com/flutter/flutter/issues/42027

* Remove whitespace

* Address PR feedback

* Add latest hash to dev/goldens_lock.yaml
* Rename (with git mv) *scuba_test.dart -> *golden_test.dart
2019-10-08 09:40:09 -07:00