DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
28,492 Commits 882 Branches 1,069 Tags
Commit Graph

21975 Commits

Author SHA1 Message Date
skia-flutter-autoroll
6df3a85712 Roll Fuchsia Linux SDK from PqBDstaESE_l77k1e... to Edv0I0o8GQ7c0z8XK... (flutter/engine#41393) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-21 09:21:09 +00:00
Brandon DeRosier
c222cc4715 [Impeller] Fix SupportsReadFromOnscreenTexture capability check (flutter/engine#41386) 2023-04-21 01:45:35 -07:00
Brandon DeRosier
b98bc7c360 [Impeller] Always use BGRA10_XR for wide gamut (flutter/engine#41385) 
Fixes errors blitting offscreen textures to onscreen textures
when wide gamut is enabled due to the mismatching formats.
 2023-04-21 01:45:06 -07:00
skia-flutter-autoroll
cbd8789c22 Roll Skia from 524ecb58945e to 90a93bb0990f (1 revision) (flutter/engine#41390) 
https://skia.googlesource.com/skia.git/+log/524ecb58945e..90a93bb0990f

2023-04-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 8b632f5f2d8d to f5a15d80499c (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-21 07:24:27 +00:00
skia-flutter-autoroll
6c76730570 Roll Skia from f4609aa2eaba to 524ecb58945e (23 revisions) (flutter/engine#41388) 
https://skia.googlesource.com/skia.git/+log/f4609aa2eaba..524ecb58945e

2023-04-21 fmalita@chromium.org [skottie] Add option for disabling image asset scaling
2023-04-20 johnstiles@google.com Reland "Add a GN flag 'skia_enable_skvm'."
2023-04-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c1d27abff170 to 2c49741eda05 (8 revisions)
2023-04-20 herb@google.com Cleanup code for SkGlyph underline
2023-04-20 johnstiles@google.com Use src.rgba for SkRP execution masks.
2023-04-20 sunnyps@chromium.org graphite: Add test guard for RecorderPriv::resourceCache
2023-04-20 brianosman@google.com Reland "Change Flutter to always use analytic AA"
2023-04-20 scroggo@google.com Remove group_static_libs
2023-04-20 skia-autoroll@skia-public.iam.gserviceaccount.com (Manual) Roll Dawn from 27c772262048 to 9e9c4560752a (61 revisions)
2023-04-20 chillers@google.com Revert "Change Flutter to always use analytic AA"
2023-04-20 jmbetancourt@google.com Revert "[skottie] pass slot id to opacity callback"
2023-04-20 johnstiles@google.com Create a Raster Pipeline op to exchange src.rgba with memory.
2023-04-20 robertphillips@google.com [graphite] Make SkGradientShaderBase own the color and offset bitmap
2023-04-20 brianosman@google.com Reland "Always run color space math in full-float within Ganesh"
2023-04-20 briansalomon@gmail.com Add BAZEL.build file for tools/gpu/mtl
2023-04-20 briansalomon@gmail.com [bazel] Support optional building of Ganesh Metal backend.
2023-04-20 johnstiles@google.com Revert "Wrap SkShader::program calls with #ifdef SK_ENABLE_SKVM."
2023-04-20 johnstiles@google.com Wrap SkShader::program calls with #ifdef SK_ENABLE_SKVM.
2023-04-20 lehoangquyen@chromium.org graphite-dawn: Use Depth24PlusStencil8 instead of Depth32FloatStencil8.
2023-04-20 robertphillips@google.com [graphite] Share boilerplate code in ProxyCacheTests
2023-04-20 johnstiles@google.com Add header guards to SkSLRasterPipelineBuilder.h.
2023-04-20 herb@google.com Unposion stack allocated memory in arena allocs
2023-04-20 johnstiles@google.com Revert "Add a GN flag 'skia_enable_skvm'."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-21 05:37:52 +00:00
keyonghan
a1fa5b436e Update xcode to 14c18 (flutter/engine#41370) 
With https://flutter-review.googlesource.com/c/recipes/+/42160, we are
ready to make all tests consistent with xcode 14c18.

Fixes https://github.com/flutter/flutter/issues/125216
 2023-04-20 20:53:35 -07:00
Zachary Anderson
30bcef02d5 Revert "[Impeller] Turned on wide gamut support by default." (flutter/engine#41382) 
Reverts flutter/engine#39801

`customer: chalk` hit some rendering issues that was narrowed down to this: b/278976014
 2023-04-21 02:20:12 +00:00
Casey Hillers
124093c6de Revert "Manual roll skia to d5b4acfb4" (flutter/engine#41381) 
Reverts flutter/engine#41378

Tests are passing at
https://dart.googlesource.com/sdk/+/7247a1b3b7166c828a0c2e00259ec03fd737d455
 2023-04-20 18:36:06 -07:00
Loïc Sharma
f79695512e [Windows] Don't block raster thread until v-blank (flutter/engine#41231) 
Currently the Windows raster thread blocks until the v-blank. As a result, on Windows a frame can spend 17ms on the raster thread even if rasterization completes in under 1ms. This behavior prevents us from rendering multiple views on the same raster thread on Windows.

This change does not make rasterization faster. Instead, it allows the raster thread to do more work. 

Addresses https://github.com/flutter/flutter/issues/124903

### Results

Here are the performance graphs if I hover on and off the counter app's button repeatedly.

#### Before 
The raster thread spends ~17ms per frame consistently:

![Pasted image 20230414180144](https://user-images.githubusercontent.com/737941/232175444-f4b8eb64-b8a3-47b3-aa85-112c56d596a2.png)

#### After
After this change, the raster thread spends less than 1ms per frame consistently:
![Pasted image 20230414180011](https://user-images.githubusercontent.com/737941/232176377-a2f26c41-dfd1-4140-a775-59d6f0fac31f.png)

### Background

Blocking until the v-blank prevents screen tearing if the OS does not synchronize to the vsync. Windows does synchronize if the Desktop Windows Manager composition is enabled, which is required on Windows 8 and newer. In other words, this blocking behavior is unnecessary for Windows 8 and newer.

For Windows 7, screen tearing is possible if DWM composition is disabled (either by the user or by an app). In this scenario, the Flutter app should block until the v-blank to synchronize with the vsync and prevent screen tearing. We can detect if DWM composition is disabled using [`DwmIsCompositionEnabled`](https://learn.microsoft.com/en-us/windows/win32/api/dwmapi/nf-dwmapi-dwmiscompositionenabled). We can detect changes to DWM composition using the top-level [`WM_DWMCOMPOSITIONCHANGED`](https://learn.microsoft.com/en-us/windows/win32/dwm/wm-dwmcompositionchanged) Windows message.

Useful resources:
1. https://learn.microsoft.com/en-us/windows/win32/dwm/composition-ovw
2. https://www.khronos.org/opengl/wiki/Swap_Interval
3. https://forums.imgtec.com/t/eglswapinterval-0-tearing-problem/2356/5
4. https://stackoverflow.com/questions/32282252/can-eglswapinterval0-cause-screen-tearing
5. https://bugs.chromium.org/p/chromium/issues/detail?id=480361
 2023-04-21 01:01:50 +00:00
Casey Hillers
d6886ee41e Manual roll skia to d5b4acfb4 (flutter/engine#41378) 2023-04-20 17:01:14 -07:00
Jenn Magder
bda11b675c Run mac unopt arm builds with arm toolchain (flutter/engine#41353) 
Add `--force-mac-arm64` to arm gn commands running on Mac ARM bots to compile natively and not with Rosetta.  Sometimes we've seen random slow-downs in CI when lots of Rosetta processes run at the same time.

This will disable goma for these builds but it doesn't seem to be much slower:

`build ios_debug_sim_arm64` step on prod:
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Production%20Engine%20Drone/123894/overview - 1.1 minute
vs this PR:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/747210/overview - 1.8 minute
 2023-04-21 00:00:53 +00:00
Zachary Anderson
d2cf696dc0 Revert "re-land "Migrate mac_host_engine to engine v2 builds." (#41233)"" (flutter/engine#41380) 
Reverts flutter/engine#41323
 2023-04-20 23:48:08 +00:00
yaakovschectman
690791e88a Move ownership of AccessibilityBridgeWindows to FlutterWindowsView (flutter/engine#41308) 
Move ownership of the pointer to `AccessibilityBridgeWindows` from
`FlutterWindowsEngine` to `FlutterWindowsView` in preparation for
multi-window.

https://github.com/flutter/flutter/issues/124995

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-04-20 16:28:00 -04:00
skia-flutter-autoroll
57773fc8af Roll Fuchsia Linux SDK from AoPEjX8Xfq1v0h4kx... to PqBDstaESE_l77k1e... (flutter/engine#41373) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-20 19:33:03 +00:00
godofredoc
c503b3632b Revert "Upload windows arm artifacts to production bucket." (flutter/engine#41372) 
Reverts flutter/engine#41324
 2023-04-20 18:06:19 +00:00
godofredoc
0a0aa1e23e re-land "Migrate mac_host_engine to engine v2 builds." (#41233)" (flutter/engine#41323) 
This reverts commit 2753bcaf63ebe94f84c091cb84f23c01b5a718e3.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-04-20 17:12:14 +00:00
godofredoc
8bb1f32551 Upload windows arm artifacts to production bucket. (flutter/engine#41324) 
This will start uploading the arm artifacts to the production bucket without the experimental namespace.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-04-20 15:47:12 +00:00
Jason Simmons
8e87882fec [Impeller] Change the default color format for the GLES backend to RGBA (flutter/engine#41342) 
This provides compatibility with BlitCopyTextureToBufferCommandGLES::Encode and glReadPixels (which only guarantees support for RGBA).
 2023-04-20 15:40:22 +00:00
maRci002
da6f9f69f2 [web] change status bar color based on SystemUiOverlayStyle (flutter/engine#40599) 
Closes flutter/flutter#123365

In my [example code](https://github.com/flutter/flutter/issues/123365#issue-1638490447) I'm using `SystemUiOverlayStyle.dark` which has `null` `statusBarColor` by default (_which can be changed via `Change status bar color` button_) in this case we do not override browser's default status bar color.

| Old behaviour | New behaviour |
| -- | -- |
| <video src="https://user-images.githubusercontent.com/8436039/227386349-e30cce47-ffc6-4465-bb30-cd2888f77d32.mp4" /> | <video src="https://user-images.githubusercontent.com/8436039/227580430-a25e57dc-9d5a-43a1-bcb3-3bd8abd753d8.mp4" /> |

In case of PWA the when `statusBarColor` is `null` it will use `theme_color` property from `manifest.json` (I don't know from where does flutter generate `manifest.json`).

The default status bar color for PWA is: `"theme_color": "#0175C2",`
f4caee6efb/examples/api/web/manifest.json (L7)

| Old PWA behaviour | New PWA behaviour |
| -- | -- |
| <video src="https://user-images.githubusercontent.com/8436039/227607373-79be7294-d9f7-4a45-9014-28720acce0c7.mp4" /> | <video src="https://user-images.githubusercontent.com/8436039/227607329-be16131f-4104-419a-8e16-2b229d73d95e.mp4" /> |

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-04-20 14:33:07 +00:00
skia-flutter-autoroll
2cbc1424bf Roll Skia from c21e7df194c3 to c50081c62219 (11 revisions) (flutter/engine#41358) 
https://skia.googlesource.com/skia.git/+log/c21e7df194c3..c50081c62219

2023-04-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 2b944a5cb38c to 8b632f5f2d8d (3 revisions)
2023-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4fbe7556fc02 to 2782b5af9734 (2 revisions)
2023-04-19 brianosman@google.com Revert "Always run color space math in full-float within Ganesh"
2023-04-19 brianosman@google.com Revert "Always run color space math in full-float on the GPU (Part 2)"
2023-04-19 jvanverth@google.com [graphite] Stub in VulkanGraphicsPipeline.
2023-04-19 brianosman@google.com Always run color space math in full-float on the GPU (Part 2)
2023-04-19 brianosman@google.com Always run color space math in full-float within Ganesh
2023-04-19 scroggo@google.com Clarify where changes to gn_to_bp should be submitted
2023-04-19 johnstiles@google.com Add a GN flag 'skia_enable_skvm'.
2023-04-19 johnstiles@google.com Restructure Generator::pushConstructorCast to use a switch.
2023-04-19 michaelludwig@google.com [graphite] Replace BlockReader with ShaderNode trees

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-20 07:01:22 +00:00
skia-flutter-autoroll
ab43e2c479 Roll Fuchsia Linux SDK from Tun7i4VLz6ncx8JJJ... to AoPEjX8Xfq1v0h4kx... (flutter/engine#41357) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-20 05:19:25 +00:00
Jason Simmons
7938a1c2b3 Manual Skia roll from ad90b6bd4760 to c21e7df194c3 (flutter/engine#41341) 
https://skia.googlesource.com/skia.git/+log/ad90b6bd4760..c21e7df194c3

2023-04-19 brianosman@google.com Change Flutter to always use analytic
AA
 2023-04-19 18:46:55 -07:00
Jonah Williams
f73ae51144 [impeller] convert src over to src for solid color (flutter/engine#41351) 
Related to https://github.com/flutter/flutter/issues/114402

At least in the flutter gallery test app, with https://github.com/flutter/gallery/pull/909 reverted - this significantly improves the performance in the Xcode frame debugger. If we wanted to do this for more color sources or filter effects, we need to do much more work to track texture opacity, but this seems like a reasonable and low cost first step.

### Before

![image](https://user-images.githubusercontent.com/8975114/233222371-f33d29ad-c556-4db0-b949-84777bb09307.png)

### After

![image](https://user-images.githubusercontent.com/8975114/233222350-0517d109-cabd-45af-a0af-06b95da2d026.png)
 2023-04-20 01:07:33 +00:00
Brandon DeRosier
b4271c24de Add missing header guards (flutter/engine#41322) 
These keep turning up, so I did a little bash-fu to find them all.
```bash
grep -lL "#pragma once" $(grep -lL "#ifndef .*_H_" $(find . | grep "\.h$")) | cut -c 3-
```
 2023-04-19 21:20:21 +00:00
joshualitt
90138c2003 [web] Fix trivial type issue. (flutter/engine#40956) 2023-04-19 12:58:30 -07:00
Brandon DeRosier
c43fb87612 [Impeller] Comprehensively label snapshots (flutter/engine#41325) 
Makes it much easier to work out where things are going wrong in filter
chains.

For example, when capturing the app in
https://github.com/flutter/flutter/issues/124956, the chain of
RenderPasses gets labeled as follows:
1. Contents to ForegroundPorterDuffBlend Filter Snapshot
2. Contents to GaussianBlur Filter Snapshot
3. Directional Gaussian Blur Filter
4. Directional Gaussian Blur Filter

...and so it's easy to see that the filter chain is
ForegroundPorterDuffBlend->DirectionalGaussianBlur->DirectionalGaussianBlur,
and the former two are triggering a non-collapsed snapshot of their
inputs.
 2023-04-19 11:56:12 -07:00
Brandon DeRosier
c7eefdf7f0 [Impeller] Fix transform regressions for chained filters (flutter/engine#41332) 
Resolves https://github.com/flutter/flutter/issues/124956.

Fixes some recent transform issues that mainly apply to chained filters
(like when both a color + image filter has been set).

- For all filters, the returned entity should just be an identity matrix
because the snapshot transform gets fully absorbed.
- For all filters, given entity's transform should be applied in the
coverage proc (although this currently makes no difference because of
the way coverage is queried when snapshotting).
- For filters drawing with coverage + transforming UVs, the transform
handed to the contents of the deferred entity needs to be applied.
Otherwise the entity won't get repositioned correctly while
snapshotting.
 2023-04-19 11:55:42 -07:00
Chinmay Garde
4117cb927e [Impeller] Make //impeller/display_list TU naming consistent. (flutter/engine#41174) 
No change in functionality. I've just renamed the TU's to replace `display_list_` to `dl_`. I am sure there are chances to make the naming better. For instance, the op receiver still being named a dispatcher.
 2023-04-19 17:32:53 +00:00
Mouad Debbar
2bc352f431 [web] Remove non-ShadowDom mode (flutter/engine#39915) 
If we still want to do this, here's a quick PR :)

Fixes https://github.com/flutter/flutter/issues/116204
 2023-04-19 16:15:21 +00:00
gaaclarke
166895773e [impeller] added moltenvk notice (flutter/engine#41317) 
fixes https://github.com/flutter/flutter/issues/125076

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-04-19 09:11:10 -07:00
skia-flutter-autoroll
7d93772a65 Roll Skia from 8af1dd9659f0 to ad90b6bd4760 (3 revisions) (flutter/engine#41337) 
https://skia.googlesource.com/skia.git/+log/8af1dd9659f0..ad90b6bd4760

2023-04-19 johnstiles@google.com Disable SkSL traces when optimize-for-size is on.
2023-04-19 johnstiles@google.com Implement onFilterColor4f in SkRP.
2023-04-19 johnstiles@google.com Add no-child limitation to SupportsConstantOutputForConstantInput.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-19 16:07:47 +00:00
skia-flutter-autoroll
2334d5b752 Roll Fuchsia Linux SDK from Cy5LG4U2InaFLkJGz... to Tun7i4VLz6ncx8JJJ... (flutter/engine#41331) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-19 09:36:03 +00:00
skia-flutter-autoroll
3ef37ef0d5 Roll Skia from 5a718d9e9c06 to 85d9e67653b1 (4 revisions) (flutter/engine#41330) 
https://skia.googlesource.com/skia.git/+log/5a718d9e9c06..85d9e67653b1

2023-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2f19bb746c6c to 25f843f89e20 (12 revisions)
2023-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 2b944a5cb38c to 08883892b342
2023-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e81a1152c10c to dd55e592406d (1 revision)
2023-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d0db0611a16d to 2b944a5cb38c (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-19 08:45:48 +00:00
skia-flutter-autoroll
aa6897c9d9 Roll Dart SDK from 1f224df52bee to 27e71f19c144 (3 revisions) (flutter/engine#41329) 
https://dart.googlesource.com/sdk.git/+log/1f224df52bee..27e71f19c144

2023-04-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-18.0.dev
2023-04-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-17.0.dev
2023-04-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-16.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,chinmaygarde@google.com,dart-vm-team@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-19 07:54:18 +00:00
Brandon DeRosier
addeb03c02 [Impeller] Add buffer-to-texture blit capability check; fix GL+VK playgrounds on macOS (flutter/engine#41320) 
GL/VK playgrounds that load image fixtures are currently broken on
macOS.
 2023-04-18 21:38:35 -07:00
Alexander Aprelev
ee5279217a Roll dart, zlib, emscripten, tweak license script for rolled zlib (flutter/engine#41299) 
Changes since last dart roll
```
1f224df52be Version 3.1.0-15.0.dev
3c284a0c95c Revert "Reland "[VM] Begin supporting Perfetto file recorder""
754aca00499 Bump github/codeql-action from 2.2.11 to 2.2.12
7c8e61104f6 Bump actions/checkout from 3.5.0 to 3.5.2
f9f1030959d (origin/base) [infra] DEPS and test dart-lang/native packages
b04b0844067 [vm/win7] Dynamically load functions for unwinding instructions.
a6ebd6fa8e9 Bump tools to 545d7e1c73ce21b8c91f638021f9d487d324a501
c4795a75508 [vm, compiler] Don't do safepoint transitions in generated code under TSAN.
2fcf9754032 Version 3.1.0-14.0.dev
393b1016292 Version 3.1.0-13.0.dev
39fc15a0b4c (origin/lkgr) [analysis_server] Add missing declaration semantic token modifier on classes/constructors
609db33dc7a Issue 51985. Quick fix to add missing pattern case to switch expression/pattern.
8fa08ae80b6 Add 'Convert to if-case statement' quick assist.
17d92f90d0b offer wildcard suggestions for destructured record fields
3149f813bbf [dartdev] Update --enable-analytics to re-enable unified analytics
eee509140dd Add dependency overrides for pkg/analyzer
3069c4f3e2b [analysis_server] Add missing "constructor" semantic token modifiers on constructor declarations
9834f87c542 [dart2js] Fix noSuchMethod override handling.
639a6f06ef9 Simplify several non-terminals to use regex-like grammar operators
f88e3bd77c5 Issue 51903. Test fixes for ParserErrorCode.VAR_AND_TYPE
f4d42303ad2 [analysis_server] Handle completion in whitespace after string values
70762f0de0e [ANTLR] Transform recursive definition of onParts to use iteration ...
453647022f6 [analysis_server] Don't fail on invalid/complex setters in LSP code completion
a565638b910 Issue 51689. Report when 'super' is used as a standalone expression, not as a receiver of an invocation.
b78d89ce0c7 Fix DynamicTypeImpl to InterfaceTypeImpl cast exception in AddTypeAnnotation, when ambiguous SetOrMapLiteral.
bd9c7a46e2b Roll zlib to 14dd4c4455602c9b71a1a89b5cafd1f4030d2e3f
18b5ecdfc99 [vm] Cleanup dead code around TypeArgumentClassFinder
9d4d48949c0 Add a top-level variable strict-inference test case
8df1b888771 [VM/Service] Create JSONBase64String class
b4aa83b0b7f [VM/Service] Rename JSONStream::AppendSerializedObject to JSONStream::AppendBytes
4cd9c9c6666 Reland "[VM] Begin supporting Perfetto file recorder"
fa3a72fa7e5 [cfe/ffi] Error on compound constructors
```
 2023-04-19 04:12:20 +00:00
skia-flutter-autoroll
2ce3ad07f1 Roll Skia from 84630c3c18b2 to 5a718d9e9c06 (3 revisions) (flutter/engine#41318) 
https://skia.googlesource.com/skia.git/+log/84630c3c18b2..5a718d9e9c06

2023-04-18 johnstiles@google.com Reject structs containing any unsized arrays.
2023-04-18 jmbetancourt@google.com [skottie] pass slotID to property observer text callback
2023-04-18 johnstiles@google.com Implement GrSkSLFP::constantOutputForConstantInput in SkRP.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-19 02:01:20 +00:00
Brandon DeRosier
447024ed0f [Impeller] Provide an opaque interface for color sources in Aiks (flutter/engine#41315) 
Part of https://github.com/flutter/flutter/issues/125017.

Pulls ColorSource construction out of the dispatcher and into Aiks.

Cleans up a few design warts we've accumulated over time:
- Removes special exceptions for solid colors in `Paint`.
- Makes `SolidColorContents` a `ColorSourceContents`.
- Removes paint ref capture for kImage.
 2023-04-18 17:14:53 -07:00
Yegor
d5474b17ac [web:canvaskit] remove unnecessary instrumentation from picture (flutter/engine#41313) 
Remove unnecessary instrumentation from picture. `UniqueRef`
automatically instruments all allocations, disposals, and garbage
collections, which covers `CkPicture`.
 2023-04-18 16:49:00 -07:00
skia-flutter-autoroll
7909cdcbbe Roll Skia from 476ee3fd54cc to 84630c3c18b2 (5 revisions) (flutter/engine#41316) 
https://skia.googlesource.com/skia.git/+log/476ee3fd54cc..84630c3c18b2

2023-04-18 jmbetancourt@google.com [skottie] pass slot id to opacity callback
2023-04-18 robertphillips@google.com [graphite] Have ResourceCache call ProxyCache::freeUniquelyHeld
2023-04-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 6a521002def5 to 9263fd4841e9 (1 revision)
2023-04-18 armansito@google.com [graphite] Declare UniformManager tests with DEF_GRAPHITE_TEST
2023-04-18 briansalomon@gmail.com [bazel] git_repos_from_deps takes optional workspace parameter

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-18 23:44:46 +00:00
godofredoc
1a7e90d177 Double zip FlutterMacOS.framework.zip. (flutter/engine#41306) 
This is required to make the artifact consistent with the legacy artifacts while the tool is modified to remove the need of double zipping.

Bug: https://github.com/flutter/flutter/issues/124911

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-04-18 23:40:55 +00:00
Yegor
1289bfa247 [web:canvaskit] clean up the rest of skia_object_cache usages (flutter/engine#41259) 
This should go after https://github.com/flutter/engine/pull/41230.

Removes the remaining usages of `skia_object_cache.dart` and deletes it.

Also fixes https://github.com/flutter/flutter/issues/86632
 2023-04-18 14:34:01 -07:00
skia-flutter-autoroll
60494f6f45 Roll Skia from f80ee1088861 to 476ee3fd54cc (2 revisions) (flutter/engine#41309) 
https://skia.googlesource.com/skia.git/+log/f80ee1088861..476ee3fd54cc

2023-04-18 armansito@google.com [graphite] Enforce std140 layout rule 4 for 2x2 matrices
2023-04-18 robertphillips@google.com [graphite] trim down PaintParamsKeyTest

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-18 21:07:55 +00:00
Dan Field
842e8cea52 [Impeller] Gpu model information to Skia gold (flutter/engine#41216) 
Does two things:

- Exposes a string about the GPU model on `impeller::Context`
- passes that string on to Skia gold when we add a test image.

This should help reduce noise/flakiness in golden images.
 2023-04-18 20:11:05 +00:00
gaaclarke
d7752e30c5 [Impeller] faster glyph atlas generation by removing data copies (flutter/engine#41290) 
fixes https://github.com/flutter/flutter/issues/124996

This is the best I could come up with easily.  It doesn't give as good of a result as I'd hoped.  I measured it with a simple microbenchmark derived from one of the unit tests and it gave a 6% decrease in time ( 241.314us vs 257.626us) on macos release builds (run with rosetta).

Improvements:
1) Removed the copying of the std::set to an std::vector
1) Uses references instead of copying FontGlyphPairs out of collections in a few places
1) Holds new glyphs as a vector of references to the set instead of copying all the FontGlyphPairs
1) Deletes more lines of code than it adds

## the benchmark

```diff
diff --git a/impeller/typographer/typographer_unittests.cc b/impeller/typographer/typographer_unittests.cc
index 01a11d494c..1b99afa699 100644
--- a/impeller/typographer/typographer_unittests.cc
+++ b/impeller/typographer/typographer_unittests.cc
@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <chrono>
 #include "flutter/testing/testing.h"
 #include "impeller/playground/playground_test.h"
 #include "impeller/typographer/backends/skia/text_frame_skia.h"
@@ -149,23 +150,29 @@ TEST_P(TypographerTest, GlyphAtlasWithLotsOfdUniqueGlyphSize) {
       sk_font);
   ASSERT_TRUE(blob);
 
-  TextFrame frame;
-  size_t count = 0;
-  TextRenderContext::FrameIterator iterator = [&]() -> const TextFrame* {
-    if (count < 8) {
-      count++;
-      frame = TextFrameFromTextBlob(blob, 0.6 * count);
-      return &frame;
-    }
-    return nullptr;
-  };
-  auto atlas = context->CreateGlyphAtlas(GlyphAtlas::Type::kAlphaBitmap,
-                                         atlas_context, iterator);
-  ASSERT_NE(atlas, nullptr);
-  ASSERT_NE(atlas->GetTexture(), nullptr);
-
-  ASSERT_EQ(atlas->GetTexture()->GetSize().width * 2,
-            atlas->GetTexture()->GetSize().height);
+  auto beg = std::chrono::high_resolution_clock::now();
+  int count = 10000;
+  for (int i = 0; i < count; ++i) {
+    TextFrame frame;
+    size_t count = 0;
+    TextRenderContext::FrameIterator iterator = [&]() -> const TextFrame* {
+      if (count < 8) {
+        count++;
+        frame = TextFrameFromTextBlob(blob, 0.6 * count);
+        return &frame;
+      }
+      return nullptr;
+    };
+    auto atlas = context->CreateGlyphAtlas(GlyphAtlas::Type::kAlphaBitmap,
+                                           atlas_context, iterator);
+    ASSERT_NE(atlas, nullptr);
+    ASSERT_NE(atlas->GetTexture(), nullptr);
+    ASSERT_EQ(atlas->GetTexture()->GetSize().width * 2,
+              atlas->GetTexture()->GetSize().height);
+  }
+  auto end = std::chrono::high_resolution_clock::now();
+  auto duration = std::chrono::duration_cast<std::chrono::microseconds>(end - beg);
+  FML_LOG(ERROR) << "Elapsed Time: " << static_cast<double>(duration.count())/count << "us";
 }

```

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-04-18 20:07:58 +00:00
godofredoc
3b0e23c9c6 Migrate android AOT to engine_v2. (flutter/engine#41229) 
The artifacts have been used in prod for a few weeks already and this change is just migrating the generation of the artifacts to engine_v2 builds and moving the legacy recipe to staging.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-04-18 19:53:15 +00:00
skia-flutter-autoroll
3dfade7147 Roll Skia from 5bd4bdc0d8e2 to f80ee1088861 (8 revisions) (flutter/engine#41302) 
https://skia.googlesource.com/skia.git/+log/5bd4bdc0d8e2..f80ee1088861

2023-04-18 johnstiles@google.com Disable an untested/unreachable GrSkSLFP optimization.
2023-04-18 robertphillips@google.com [graphite] centralize gradient shader key generation
2023-04-18 jvanverth@google.com [graphite] Rename SDF variable to avoid collision with intrinsic
2023-04-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f81e1056ccbc to 6a521002def5 (3 revisions)
2023-04-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d0148f12bc12 to 2f19bb746c6c (5 revisions)
2023-04-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from d0db0611a16d to 93d445650f3a
2023-04-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 174e65e85901 to e81a1152c10c (1 revision)
2023-04-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 258b5715fe30 to d0db0611a16d (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-18 18:48:07 +00:00
Greg Spencer
70e9ea9a3c Some minor doc typo and diagnostic fixes. (flutter/engine#40982) 2023-04-18 10:39:06 -07:00
gaaclarke
dc938db866 [Impeller] Turned on wide gamut support by default. (flutter/engine#39801) 
After having run a memory audit on Flutter Gallery I believe we can turn
on wide gamut support by default for impeller. Here are the
ramifications of this change:
1) If an opaque surface is used and no transparent wide gamut images are
used, there should be no change in performance or memory usage.
1) If a transparent surface is used; the surface will take up 2x memory
(ex 4MB on iPhone 7) and will have a runtime performance cost.
1) If wide gamut **transparent** images are used, they will take up 2x
memory. Opaque wide-gamut images will take up the same amount of memory.

## Flutter gallery test results

### Test 1

Steps:
* Tap "Material"
* Scroll down and back to "Cards"
* Tap "Cards"
* Scroll to bottom of "Cards" example

Notice that the card images are wide gamut, AdobeRGB.

**Memory increase:** 10.401 MB (+8.7%)

### Test 2

Steps:
* Just launch the gallery

Notice that there shouldn't be any wide gamut images.

**Memory Increase:** 1.22 MB (+1%, this is probably a fluke of
measurement)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-04-18 10:28:40 -07:00
skia-flutter-autoroll
3bd9d3aa2d Manual roll Skia from d9e216e62223 to 5bd4bdc0d8e2 (12 revisions) (flutter/engine#41286) 
Manual roll requested by jacksongardner@google.com

https://skia.googlesource.com/skia.git/+log/d9e216e62223..5bd4bdc0d8e2

2023-04-17 johnstiles@google.com Fix assertion when compiling oversized interface blocks.
2023-04-17 johnstiles@google.com Return a span from SkSL::Type::fields().
2023-04-17 brianosman@google.com Fix SkJpegMetadataDecoder for Windows shared build
2023-04-17 jvanverth@google.com [Graphite] Enable shader derivatives in Dawn backend.
2023-04-17 jmbetancourt@google.com [skottie] pass sid if present to PropertyObserver
2023-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a6e68d7ed2e8 to f81e1056ccbc (1 revision)
2023-04-17 ccameron@chromium.org Add SkJpegMetadataDecoder interface
2023-04-17 robertphillips@google.com [graphite] Add ProxyCache::purgeProxiesNotUsedSince
2023-04-17 egdaniel@google.com [Graphite] As purgeAsNeeded to ResourceCache.
2023-04-17 egdaniel@google.com [Graphite] Have zero sized resources always have max timestamp value.
2023-04-17 jamesgk@google.com [graphite] Refactor blend shader generation
2023-04-17 nicolettep@google.com Revert "Manual roll Dawn from 27c772262048 to a20c1ee82d29 (13 revisions)"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-04-18 16:30:29 +00:00