The average frame time of page transitions on Moto G4 is now very
close to 16ms (the last 10 measurements on our dashboard are
between 15.5ms to 16.7ms and half of them are below 16ms).
It is now much faster than when we disabled it (which was at about
35ms). So I think that we should be able to enable it by default.
I'll leave the flag there until we implement the retained rendering
to bring the frame time comfortably below 16ms.
See https://github.com/flutter/flutter/issues/13736
Enable taking screenshots of arbitrary RenderObjects from a running application from within the inspector.
Key functionality is in the added _ScreenshotPaintingContext class.
* Roll engine to 56139397e6ae1257bdabd1ef79ff7aca96c67d4.6
Changes since last roll:
```
56139397e Roll src/third_party/skia 7ba1d64f0706..5f0726b01019 (12 commits) (#6104)
47a1ce0e6 Allow embedders to set the root surface transformation. (#6085)
```
* Roll engine to f3ff83a5db71262d240aa5337a2a9a22c73c4749. (dart roll).
* Add const
* Add ignore analyzer prefer_const_constructors_in_immutables
This updates the test to match the engine API change introduced in:
https://github.com/flutter/engine/pull/6081
This also rolls the engine, the roll includes only the relevant engine commit:
```
091492601 Allow passing extra creation parameters for embedded Android views. (#6081)
```
This includes the following changes
c62248bdd Roll src/third_party/skia 82cf64a0d317..33d5394d08f6 (14 commits) (#6068)
b0fb3e660 Roll src/third_party/skia 96597c22c344..82cf64a0d317 (12 commits) (#6067)
ea8b949a7 Roll src/third_party/skia 4d727c560b58..96597c22c344 (27 commits) (#6066)
4fde39583 Roll Dart to version ccb16f72824374163562364bf19dd18e8a882fab (#6065)
140a5b757 Alllow access to Flutter engine, Dart & Skia versions in the Shell API. (#6060)
Contains the following changes:
4fde39583 Roll Dart to version ccb16f72824374163562364bf19dd18e8a882fab (#6065)
140a5b757 Alllow access to Flutter engine, Dart & Skia versions in the Shell API. (#6060)
This fixes#20483 by letting InkWell do its own clipping.
PathOp.intersect is not used because we have too many unit tests that rely on clipping (e.g., paints..clipXXX()..drawCircle())
The goldens are updated due to small AA changes of the additional clipPath.
* Reland "Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 (#20427)"
This is a re-land with downgraded `package:flutter_gallery_assets`
version.
* Downgrade package:flutter_gallery_assets to 0.1.4
* Change engine.version to 81baff97c29bb08cbf8453a3f9042c5813f84ad3 (which contains an additional fix)
* Change engine.version to e3687f70c7ece72000b32ee1b3c02755ba5361ac (since mac tarballs are corrupted on earlier commit)
Reason for revert: The package:flutter_gallery_assets has removed some images which are required for the examples/flutter_gallery, so the gallery build is failing (only discovered after landing, since gallery doesn't seem to get built during github PR presubmit checks)
This CL
* rolls `engine.version` to flutter/engine@b148e628 (which includes dart sdk 2.1.0-dev)
* rolls `goldens.version` to flutter/goldens@6c45fafdf (which includes updates due to skia changes in engine)
* changes `platform.dill` to `platform_strong.dill` in various places due to flutter/engine@a84b210b
* adds explicit `environment: sdk: ">=2.0.0-dev.68 < 3.0.0"` constraints to `pubspec.yaml` and `pubspec.yaml.tmpl` files (since pub defaults to `<2.0.0` if omitted)
* upgrades to newer versions of various 3rd party packages (to ensure transitive dependencies have `<3.0.0` sdk constraint)
This changes the flutter tool to just try 10 times before giving up when running "flutter upgrade". Infinite retries can hang bots, and really don't provide a lot of help: if we've failed to upgrade for for nearly a minute, trying every five seconds, then something is just not responding.
Also, changed the bot default warning level to "normal" from "all", because the solver messages are VERY verbose: several megs of output for doing packages get on Flutter. "normal" will give warnings, user messages and errors, which should be sufficient to diagnose problems on the bots without spamming the log.
I removed the retrying for building the snapshot on flutter.bat because we don't do that on the other platforms, and because I can't imagine how running it again would give a different answer.
I also fixed a problem in the whitespace detection when no files matched the type of file that it is looking for, and removed the code that waits until failure to print the logs on setup, since reducing the log output made a huge difference.
This includes the following changes :
e54bc4ea1 Fixed invalid call site of runWithEntrypointAndCallback (#5984)
764884b91 Removed callback for HeadlessDartRunner (#5983)
91537abba Revert "Temporarily add travis/analyze.sh back for Chrome bot (#5961)" (#5966)
3501acb70 Roll src/third_party/skia 9c9611fcc1bb..0d5d0659a684 (7 commits) (#5980)
Includes the following changes :
377793180 Roll Dart to version eab492385c3f345cb2f44f3b702b0e30e4a9c107 (#5979)
8a7af11f7 Fix IsolateStart event kind. (#5978)
Includes the following changes:
78f8bcace Annotate deprecated methods with @Deprecated (#5976)
4c7e5d5a1 Roll src/third_party/skia 0c5b0b1dd692..9c9611fcc1bb (13 commits) (#5977)
4208f8404 make ios text affinity behavior match android (#5971)
69b19a5f5 Roll src/third_party/skia f5402004c4a6..0c5b0b1dd692 (11 commits) (#5975)
8137d3411 Roll src/third_party/skia 4856f5fa596d..f5402004c4a6 (1 commits) (#5974)
cbe960d90 Roll src/third_party/skia 20714bdf90f3..4856f5fa596d (1 commits) (#5973)
f05a4ccaa Roll src/third_party/skia faeef7837210..20714bdf90f3 (11 commits) (#5970)
14af0348b Complete the AndroidView resize call only after a new frame is ready. (#5968)
