2050 Commits

Author SHA1 Message Date
Dragoș Tiselice
42f773c327 Fixed DragTarget calling setState after dispose. (#6150)
DragTarget would call setState after it was disposed in didLeave
and didDrop. Fixes #6128.
2016-09-30 13:42:26 -07:00
Adam Barth
c9eda86b0e Switch to PointerData API (#6131)
Now dart:ui does the decoding of the pointer data itself, which means we don't
need to do it in the framework.
2016-09-29 21:25:20 -07:00
Hans Muller
6a1ac731d8 PopupMenuButton menus inherit the button theme (#6132) 2016-09-29 15:34:12 -07:00
Adam Barth
036f7ef59d Add support for landscape date pickers
Fixes #5141
2016-09-29 08:59:22 -07:00
Adam Barth
a3b06f31da Switch date picker to using a custom Dialog
Rather than removing all the padding from an AlertDialog, we now just use
Dialog directly for the date picker.
2016-09-29 08:59:22 -07:00
qchong
7f9c8c4b3e docs: Updates to API docs based on usability study feedback. (#6126) 2016-09-28 13:09:38 -07:00
Adam Barth
6469872abd Rename Container.align to alignment (#6116)
To match the Align widget (and several other widgets).

Fixes #6101
2016-09-28 11:17:04 -07:00
Adam Barth
c621ec82a0 Rename Interval.start to begin (#6115)
For consistency with Tween.

Fixes #5169
2016-09-28 10:30:50 -07:00
Ian Hickson
e01592a0c0 Fix globalToLocal and update spinning_mixed (#6035)
* globalToLocal was just broken when there was a rotation and a
  translation at the same time. This fixes that and adds a test.

* update graphic used by spinning_mixed since the old one went 404.

* simplify some of the code in the demo.

* fix MatrixUtils.transformPoint to be consistent with how we transform
  points elsewhere.

* stop transforming points elsewhere, just use
  MatrixUtils.transformPoint.

* make the Widget binding handle not having a root element.

* make the spinning_mixed demo update its widget tree.
2016-09-28 01:06:32 -07:00
Adam Barth
dc4a1638ee Specialize AlertDialog and SimpleDialog (#6098)
We were trying to cram too much functionality in to the Dialog widget. Now we
have AlertDialog and SimpleDialog to cover to two different kinds of dialogs in
the spec.
2016-09-27 15:44:11 -07:00
Matt Perry
f6da3b2a95 Add a Submit button to text fields demo. (#6102)
Fixes https://github.com/flutter/flutter/issues/6056
2016-09-27 17:11:22 -04:00
Adam Barth
0734edbeb0 Dialogs shouldn't scroll their headers or buttons (#6082)
Rather than scrolling the entire contents of the dialog, we should instead
scroll only the part between the title and the button bar.

Also, polish up the padding in the simple dialog demo.

Fixes #6057
2016-09-27 09:20:33 -07:00
Adam Barth
4c5084cbd2 Update clip geometry during hitTest if needed (#6091)
The code previously assumed that paint would be called before hitTest, but that
assumption isn't valid because RenderOpacity hit tests its children without
painting them.

Fixes #6089
2016-09-27 09:17:18 -07:00
Adam Barth
55f48f72c9 Persistent bottom sheet should not overlap app bar (#6076)
The spec forbids persistent bottom sheets from overlapping the app bar. There
are also some fancy scroll-linked effects that we're supposed to do with
persistent bottom sheets, but those will need to wait for another patch.

Fixes #5143
2016-09-26 14:02:01 -07:00
David Yang
d5b3588578 Adding Reference to Text Input guide in Input API Documentation (#6075)
* Adding reference to Flutter-website Text Input guide in API docs for Input

* Grammar

* PR fixes
2016-09-26 13:00:54 -07:00
Adam Barth
8c048ec944 Polish SnackBar padding (#6071)
Previously, we were getting double padding: both inside and outside the button.
This patch moves all the padding inside the button so that the whole region is
hittable and the text is positioned correctly.

Fixes #6059
2016-09-26 12:01:23 -07:00
Ian Hickson
bc9b32b99f More docs for TickerProvider in AnimationController (#6073) 2016-09-26 12:00:36 -07:00
Ian Hickson
9e673853e5 Turn off AnimationControllers when not in use (#5902)
This requires all AnimationController objects to be given a
TickerProvider, a class that can create the Ticker.

It also provides some nice mixins for people who want to have their
State provide a TickerProvider. And a schedulerTickerProvider for those
cases where you just want to see your battery burn.

Also, we now enforce destruction order for elements.
2016-09-26 10:57:10 -07:00
Ian Hickson
78c74116a9 LayoutBuilder + GlobalKey + setState assert (#6068)
This silences an assertion that fired when reparenting a widget with a
global key inside a LayoutBuilder callback when that callback also
happened to call setState (directly or indirectly) on that widget.

Normally such setStates are considered ok since we know we haven't
cleaned that subtree yet, but we were not correctly handling the case
where the list needed resorting in that situation.
2016-09-26 10:27:53 -07:00
Adam Barth
c27b03b823 Add FittedBox (#6029)
This widget lets you apply an ImageFit to a child widget.

Fixes #5830
2016-09-23 17:40:16 -07:00
Ian Hickson
12054e33b7 Clean up some of the fn3 debugging logic. (#6024)
The debugging logic was lagging behind the recent actual logic changes,
especially around buildScope.
2016-09-23 17:00:12 -07:00
Dragoș Tiselice
2dc26ba986 Changed BottomNavigationBar to handle dark theme. (#6006)
Changed the fixed type to better support the dark theme.
2016-09-22 15:03:34 -07:00
Ian Hickson
6a5e658131 Make sure to rebuild widgets even when they move (#5975)
Previously in some rather esoteric cases involving global keys reversing
relative positions we would forget to build everyone.
2016-09-22 14:44:57 -07:00
Ian Hickson
7b247d2ce1 Minor improvements to hero docs (#5998) 2016-09-22 14:26:14 -07:00
Dragoș Tiselice
d35a8c49fd Changed BottomNavigationBar background. (#6005)
When switching from shifting to fixed, the BottomNavigationBar no
longer displays the old color of the background.
2016-09-22 13:50:50 -07:00
Dragoș Tiselice
3a6530d5a4 Added bottom navigation. (#5877) 2016-09-22 12:45:10 -07:00
Hans Muller
d3f540d4bd Fixed tabs fling velocity threshold (#5990) 2016-09-22 11:06:14 -07:00
Dan Rubel
8a186f3bbd tests to assert futures complete as expected (#5947) 2016-09-22 07:43:29 -04:00
Adam Barth
8e4ca4bd34 Draggable should have an affinity that selects an axis (#5985)
This structure for the API is hopefully less confusing that the previous one
(which implied that vertical drags would not trigger horizontally draggable
widgets).

Fixes #1987
2016-09-21 20:45:00 -07:00
James Robinson
a95c9fdb58 Isolate imports of generated Dart code from generated path (#5960)
This rewrites imports of various mojom.dart files from the Flutter
engine repo to instead import normal-looking dart files from the
(new) flutter_services package. This package handles exporting the
correct symbols from generated code wherever that may live.

Includes an engine roll to 3551e7a48e2e336777b15c7637af92fd7605b6c5
which contains the new flutter_services package.
2016-09-21 14:00:29 -07:00
Matt Perry
dc5e1bba36 Disallow back gestures during a page transition. (#5982)
Fixes https://github.com/flutter/flutter/issues/5973
2016-09-21 15:10:07 -04:00
Adam Barth
20d554c19a Document two-level lists (#5972)
These are the last dartdocs needed in the material library.
2016-09-21 12:04:05 -07:00
Hans Muller
fc83640c88 ClampOverscrolls clamps Scrollable, not its Viewport (#5909) 2016-09-21 11:32:19 -07:00
Matt Perry
c9b08aa686 Fix a bug with how ScrollableGrid deals with padding. (#5963)
It wasn't taking padding into account when deciding which children were
visible. I modeled the solution off of the way ScrollableList handles
this.

Fixes https://github.com/flutter/flutter/issues/5522
2016-09-21 13:29:35 -04:00
Adam Barth
49e592318c Finish dartdocs for framework.dart (#5971) 2016-09-20 18:49:56 -07:00
Adam Barth
42dee0be27 Rename DefaultTextStyle.inherit to merge (#5974)
For consistency with IconTheme and TextStyle.merge.

Fixes #4652
2016-09-20 18:49:46 -07:00
Adam Barth
bfced97d08 Add documentation for Element (#5958) 2016-09-20 15:59:30 -07:00
Hans Muller
aa9aaf2eb7 Restore Flutter gallery license page scrolling (#5934) 2016-09-20 15:13:50 -07:00
Adam Barth
51960b4482 Complete dartdocs for material/material.dart (#5941) 2016-09-20 14:44:11 -07:00
Chinmay Garde
400585cb96 Update flutter/http.dart to use dart:io. (#5940) 2016-09-20 14:17:33 -07:00
Ian Hickson
4f0eff31bc Fix crash when a RenderObject tree is rooted in a non-RenderObject environment (#5933) 2016-09-20 14:14:05 -07:00
Hans Muller
63828aab23 Underflowing LazyBlock should relayout for additional children (#5956) 2016-09-20 11:15:23 -07:00
Adam Barth
17ac73890e Add MediaQuery.textScaleFactor (#5936)
This feature is the implementation of an accessibility feature that changes the
size of text by a constant factor.

Fixes #5873
2016-09-20 09:14:48 -07:00
Adam Barth
869371fc3e Add more docs to framework.dart (#5944)
There are still more to go, but this patch completes the widget section.
2016-09-19 21:41:03 -07:00
Lex Berezhny
3800118a08 fix for #5549 (#5949) 2016-09-19 21:06:52 -07:00
Adam Barth
e1a5bfb3e2 Complete dartdocs for navigator.dart (#5943)
These are late-breaking docs needed (mostly) for the iOS back gesture.
2016-09-19 18:12:04 -07:00
Ian Hickson
bfabb56773 Docs for heroes (#5923) 2016-09-19 16:50:38 -07:00
Adam Barth
e04135e983 Change the definition of MainAxisSize (#5931)
This property now applies only to the free space in the flex layout (i.e.,
minimize or maximize the amount of free space). Previously, the flexible
children were always allocated a size of zero when MainAxisSize was min. Now
they're allocated the same size that would be if the MainAxisSize was max.
2016-09-19 15:04:58 -07:00
Adam Barth
9ec3cabf99 Rename TabSelection.registerAnimationListener to addAnimationListener (#5932)
This name is more consistent with our other names.

Fixes #4714
2016-09-19 14:01:02 -07:00
Adam Barth
f64d52e6e5 Add @protected to AnimatedWidget build function (#5929)
We use `@protected` in this way in StatelessWidget to avoid developers calling
this function directly.
2016-09-19 13:27:04 -07:00