24470 Commits

Author SHA1 Message Date
Kris Giesing
70ea4b2cc7 Use explicit service name for activity service 2015-12-09 13:15:54 -08:00
Adam Barth
4f22f3ecde Merge pull request #838 from abarth/cleanup_global_scope
Cleanup the global scope a bit:
2015-12-09 12:44:27 -08:00
Adam Barth
13f9e91f63 Cleanup the global scope a bit:
- Remove unused FocusChanged typedef.
- Remove unused centerOfAttentionHeroTag.
- Modernize static functions for interacting with Scrollable by moving them
  into the Scrollable class.
2015-12-09 11:12:12 -08:00
Hans Muller
b42ac4e6ab Merge pull request #824 from HansMuller/save_tabs_selection
Make the StockHome TabBar selection persistent

Fixes #671
2015-12-09 09:57:36 -08:00
Adam Barth
f58c3d2bc5 Merge pull request #836 from abarth/update_docs
Update documentation based on comments in previous patch
2015-12-09 09:49:19 -08:00
Adam Barth
5d6d258533 Update documentation based on comments in previous patch 2015-12-09 09:48:22 -08:00
Hans Muller
4eeddab959 Make the StockHome TabBar selection persistent 2015-12-09 09:17:40 -08:00
Adam Barth
8be3a4fd7a Merge pull request #832 from abarth/widget_docs
Add some more dartdoc to widgets
2015-12-09 00:03:33 -08:00
Adam Barth
36c387318a Merge pull request #831 from abarth/scroll_tolerance
Improve tolerance for ending scroll animations
2015-12-09 00:03:07 -08:00
Adam Barth
95fc98108f Improve tolerance for ending scroll animations
We had the units wrong on the tolerances. Previously we multiplied by the
device pixel ratio, which meant we got larger tolerances as we got more
resolution. Also, simplify logic in Newton for applying the tolerances.

Fixes #828
2015-12-08 23:54:43 -08:00
Adam Barth
e55858411f Add some more dartdoc to widgets 2015-12-08 23:42:34 -08:00
Adam Barth
11da9b02ab Merge pull request #830 from Hixie/BoxConstraints
Catch un-normalized BoxConstraints
2015-12-08 21:52:31 -08:00
Ian Hickson
1a049c14e5 Catch un-normalized BoxConstraints
Add BoxConstraints.isNormalized feature.

Use this feature in asserts in all the intrinsic dimension methods, in
various relevant BoxConstraints methods, and in layout().

Wrap the _DebugSize logic in BoxConstraints.constrain() in an assert
block to avoid a branch in release mode.

Remove the logic in BoxConstraints.isSatisfiedBy() that dealt with
non-normalized values.

Add BoxConstraints.normalize().

Make RenderCustomOneChildLayoutBox.performLayout() only set
parentUsesSize on the child if the constraints aren't tight.
2015-12-08 21:35:39 -08:00
Adam Barth
23ab08ad14 Merge pull request #816 from flutter/testing_updates
Update testing instructions per abarths' feedback
2015-12-08 20:12:20 -08:00
Adam Barth
d1e907f3fa Merge pull request #826 from abarth/gesture_dartdoc
Add some dartdoc for GestureDetector
2015-12-08 19:54:54 -08:00
Adam Barth
25da2cf09c Add some dartdoc for GestureDetector
... just a start.
2015-12-08 19:49:02 -08:00
Eric Seidel
2f4864efbb Merge pull request #825 from eseidelGoogle/locale_test
Add a test to stocks for changing the locale
2015-12-08 16:34:53 -08:00
Eric Seidel
09894ec50b Add a test to stocks for changing the locale
I had to add a setLocale method to WidgetTester and
split the code in FlutterBinding which handled locale
changes to allow me to dispatch a locale change w/o actually
changing what the c++ code reports as the locale.

Also added the test to Travis.

@abarth @jason-simmons
2015-12-08 16:16:24 -08:00
Adam Barth
003ecb6751 Merge pull request #819 from abarth/travis_artifacts
Switch over to the Travis-built artifacts
2015-12-08 16:12:41 -08:00
Todd Volkert
5cdfb2d7ea Merge pull request #818 from tvolkert/payouts
Make AssetImage constructor const
2015-12-08 15:24:48 -08:00
Todd Volkert
56197d4353 Merge commit '1e3a85fe73c032ac656d363a60ff5fc6800e9869' into HEAD 2015-12-08 15:19:40 -08:00
Todd Volkert
d84412d116 Make AssetImage constructor const 2015-12-08 15:13:56 -08:00
Adam Barth
2b6b781c7a Switch over to the Travis-built artifacts
We've been bulding these binaries using Travis for a while. We can start using
them now.
2015-12-08 15:01:44 -08:00
Eric Seidel
b55acb4b16 Update CONTRIBUTING.md 2015-12-08 14:38:03 -08:00
Seth Ladd
0d8541ebdf Merge pull request #817 from sethladd/sethladd-patch-1
use async / await
2015-12-08 14:37:09 -08:00
Todd Volkert
1e3a85fe73 Make AssetImage constructor const 2015-12-08 14:25:52 -08:00
Seth Ladd
2666628b12 use async / await 2015-12-08 14:16:14 -08:00
Eric Seidel
723e5f790b Update testing instructions per abarths' feedback
724388d24f
2015-12-08 14:09:47 -08:00
Eric Seidel
724388d24f Update Contributing.md to document testing
@abarth
2015-12-08 13:51:05 -08:00
Adam Barth
c130dfff5f Merge pull request #812 from abarth/check_material
Widgets that depend on Material should assert that
2015-12-08 13:50:02 -08:00
Adam Barth
c0f068ce5a Merge pull request #814 from abarth/rm_event_recorder
Remove unused EventRecorder
2015-12-08 13:49:53 -08:00
Collin Jackson
56818d186d Merge pull request #801 from collinjackson/fix_dynamic_hero
Fix hero transition when using dynamic routes
2015-12-08 13:48:45 -08:00
Ian Hickson
b1448e0f6d Merge pull request #810 from Hixie/pointers
Clean up pointer handling.
2015-12-08 13:47:38 -08:00
Ian Hickson
8083c2d424 Merge pull request #815 from Hixie/rev
rev engine
2015-12-08 13:46:54 -08:00
Hixie
304ca57b53 rev engine 2015-12-08 13:45:59 -08:00
Adam Barth
8dc607a976 Widgets that depend on Material should assert that
After this patch, if you try to use a widget that depends on being enclosed in
a material, you now get an assert and a debugPrint if you're not inside a
material.

Fixes #243
2015-12-08 13:38:19 -08:00
Adam Barth
a45b85c345 Remove unused EventRecorder 2015-12-08 13:34:07 -08:00
Collin Jackson
d05c564cef Fix hero transition when using dynamic routes 2015-12-08 13:08:16 -08:00
Hixie
7514ce12a2 Clean up pointer handling.
Previously we tried to work around some possible badness from the engine
side, but now we are more assertive about the engine needing to do the
right thing.
2015-12-08 12:45:19 -08:00
Jason Simmons
bf5ef790fa Merge pull request #807 from jason-simmons/sprite_pointer
Change flutter_sprites to use the current PointerEvent.position API
2015-12-08 10:53:29 -08:00
Jason Simmons
0c9333cc10 Change flutter_sprites to use the current PointerEvent.position API 2015-12-08 10:46:44 -08:00
Adam Barth
5eae4d5a44 Merge pull request #805 from abarth/double_pop
Double-tapping modal barrier pops twice
2015-12-08 09:40:23 -08:00
Adam Barth
e857bc6f11 Merge pull request #806 from abarth/use_route_state
_ModalScope has local copies of route state
2015-12-07 22:42:40 -08:00
Adam Barth
f202e7ab17 _ModalScope has local copies of route state
Now we just use the state from the Route.

Fixes #744
2015-12-07 21:50:06 -08:00
Ian Hickson
2a69a9810c Merge pull request #781 from Hixie/box_decoration
Make BoxDecoration replaceable.
2015-12-07 21:38:44 -08:00
Ian Hickson
2afa87dfcd Make BoxDecoration replaceable.
Factor out a reusable interface called Decoration from BoxDecoration.

Make all the consumers of BoxDecoration and the erstwhile BoxPainter
into consumers of Decoration.

Make a BoxPainter be something you get from a Decoration, rather than
something to which you pass a BoxDecoration.

Rename Shape to BoxShape now that it's documented specifically as
applying to boxes.

Move EdgeDims to its own file.

Move FractionalOffset up so that it's with the other helper classes in
its file rather than alone at the end.

Minor change to RenderClipOval's hit testing to avoid taking an
unnecessary square root.

Rename BoxDecorationPosition to DecorationPosition since
RenderDecoratedBox now takes any Decoration.

Implement hit testing for rounded rects.

Rename AnimatedBoxDecorationValue to AnimatedDecorationValue, and make
it support lerping across any Decoration (by deferring to the objects
involved).
2015-12-07 19:24:25 -08:00
Jason Simmons
0fe72b17f3 Merge pull request #788 from jason-simmons/platform_locale
Add a LocaleQuery widget that can be used to fetch locale-specific data
2015-12-07 17:44:20 -08:00
Jason Simmons
9693cd5537 Add a LocaleQuery widget that can be used to fetch locale-specific data
Users of MaterialApp can provide an onLocaleChanged handler that will be
called to asynchronously fetch locale-specific data.  MaterialApp will
then instantiate a LocaleQuery that supplies the locale data to its
descendants.
2015-12-07 17:38:50 -08:00
Adam Barth
c05871a7b4 Double-tapping modal barrier pops twice
Now we ignore the pointer after we start popping the route.

Fixes #686
2015-12-07 16:54:25 -08:00
Adam Barth
8dd8c203e2 Merge pull request #803 from abarth/dropdown
Material gallery crashes when you press the drop-down button
2015-12-07 16:20:11 -08:00