34 Commits

Author SHA1 Message Date
Alexandre Ardhuin
fa19b3d3bd
add missing trailing commas (#81329) 2021-04-27 17:09:03 -07:00
Alexandre Ardhuin
8de7020a5f
remove unnecessary trailing commas (#79562) 2021-04-01 21:52:35 +02:00
Michael Goderbauer
807bb29888
enable prefer_function_declarations_over_variables lint (#77398) 2021-03-05 18:29:04 -08:00
Sam Rawlins
f6640a00f8
Remove "unnecessary" imports in test/material (#75359) 2021-02-03 16:16:03 -08:00
Greg Spencer
de884f1afe
Remove the nullOk parameter from Navigator.of and add Navigator.maybeOf (#70726)
Adds Navigator.maybeOf to replace calling Navigator.of(context, nullOk: true), and removes the nullOk parameter. Also changes Navigator.of to return a non-nullable value, and removes many (120!) instances of the ! operator, reducing the possible places where a null dereference could occur.
2020-11-20 09:10:46 -08:00
Xavier Chrétien
f26fbb6bdd
Set slider semantics flag for sliders (#68019) 2020-10-19 08:12:03 -07:00
Michael Goderbauer
727cee6d87
Migrate More Material Tests (#67482) 2020-10-07 11:02:04 -07:00
xubaolin
73194cd9f2
Fix bug when updating the divisions and value of the slider at the same time (#65998) 2020-09-18 14:52:03 -07:00
xubaolin
c7353bc414
Slider and RangeSlider can be painted in a narrower constraint like other Material Wi… (#64627) 2020-09-02 11:20:03 -07:00
Chris Bracken
c0ea00ed3f
Prefer moreOrLessEquals over closeTo (#64915)
Flutter's `moreOrLessEquals` has a few advantages over `closeTo` from
the `matcher` package:

   * It emits the epsilon value in the test result on failure.
   * It uses a named parameter for epsilon, which improves readability
     at the call site.
   * It has a reasonable default for epsilon in cases where something
     more specific isn't required.

Using it also has the nice property that it aids in its own discovery
when when people go looking for such functionality in new tests.

This change also includes a couple unrelated whitespace formatting cleanups.
2020-08-30 22:20:16 -07:00
Darren Austin
d169880278
Updated references to the old button classes to the new ones in comments and documentation for tests in the material and cupertino libraries. (#62164) 2020-07-28 11:01:04 -07:00
Pierre-Louis
629395f7ad
Add per thumb Range Slider semantics (#61439) 2020-07-22 18:26:11 -07:00
Jose Alba
9265bdd1ad
RangeSlider overlap properly (#60549) 2020-07-06 17:54:02 -07:00
Alexandre Ardhuin
4d7525f05c
Opt out nnbd in packages/flutter (#59186)
* add language version 2.8 in packages/flutter

* enable non-nullable analyzer flag
2020-06-11 14:11:30 +02:00
Darren Austin
012cee2731
Typo fixing sweep through packages/flutter. (#59219) 2020-06-11 05:10:01 -07:00
Jose Alba
76de30edc8
Updated Slider test (#58630) 2020-06-10 12:10:02 -07:00
Jose Alba
bd06749edc
Slider value indicator gets disposed if it is activated (#57535) 2020-05-27 15:27:01 -07:00
Jose Alba
0549ab2390
Removed useV2 Slider flag (#55857) 2020-04-30 15:19:01 -07:00
Jose Alba
7eb3df4a11
Default to use V2 Slider (#55599)
* Instead of changing test I just flipped flag so the test uses the proper slider

* Use Depracated annotation

* Updated depracation notice

* Updated depracation notice again

* Ignore analyze issues

* flutter analyze .

* ignore analyzer

* // ignore: deprecated_member_use

* Ignoring notice

* indentation
2020-04-27 17:57:42 -04:00
Jose Alba
3441d6cbe7
Slider rebase work (#53916)
* [Slider] Rebase.

* disabled thumb color with alphaBlend of colorScheme surface

* test remove alphablend

* Change rectangular track to how it used to be

* Chaned to adaptive slider

* blank lines

Co-authored-by: Will Larche <larche@google.com>
2020-04-07 17:10:18 -04:00
Jose Alba
d14a301e41
Revert "[Slider] Rebase. (#52663)" (#53698)
This reverts commit e71cf1cdbeebab9081d09daa73d4d7642f165b9d.
2020-03-31 16:14:22 -07:00
Jose Alba
e71cf1cdbe
[Slider] Rebase. (#52663) 2020-03-31 10:56:01 -07:00
Dan Field
24f39d40a4 Revert "Revert "Add many more global analyses. (#47875)" (#48080)" (#48081)
This reverts commit 04ea3183ce67c62def5852a5c2615e38188195ca.
2020-01-02 11:47:28 -08:00
Francisco Magdaleno
04ea3183ce
Revert "Add many more global analyses. (#47875)" (#48080)
This reverts commit e768c92fbc6cf8bf4e1814ef950a6092bbb6f658.
2020-01-02 09:25:59 -08:00
Ian Hickson
e768c92fbc
Add many more global analyses. (#47875)
* Update packages.

* Add many more global analyses.

* Catch trailing spaces and trailing newlines in all text files.
  Before we were only checking newly added files, but that means we
  missed some.

* Port the trailing spaces logic to work on Windows too.

* Correct all the files with trailing spaces and newlines.

* Refactor some of the dev/bots logic into a utils.dart library.
  Notably, the "exit" and "print" shims for testing are now usable
  from test.dart, analyze.dart, and run_command.dart.

* Add an "exitWithError" function that prints the red lines and
  then exits. This is the preferred way to exit from test.dart,
  analyze.dart, and run_command.dart.

* More consistency in the output of analyze.dart.

* Refactor analyze.dart to use the _allFiles file enumerating logic
  more widely.

* Add some double-checking logic to the _allFiles logic to catch
  cases where changes to that logic end up catching fewer files
  than expected (helps prevent future false positives).

* Add a check to prevent new binary files from being added to
  the repository. Grandfather in the binaries that we've already
  added.

* Update all the dependencies (needed because we now import crypto in
  dev/bots/analyze.dart).
2019-12-30 17:12:19 -08:00
Ian Hickson
449f4a6673
License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Todd Volkert
ce8e2bb7cf
Revert "[Material] Update the Slider and RangeSlider to the latest Material spec (#44351)" (#45268)
This reverts commit 421bf64703b5c0fae7196923da0561f6a4c6ec79.

Was causing severe breakages in Google.
2019-11-20 10:42:23 -08:00
Anthony
421bf64703
[Material] Update the Slider and RangeSlider to the latest Material spec (#44351)
Update the Slider and RangeSlider to the latest Material spec. This introduces an updated track, updated thumbs, updated tick marks, and a new value indicator shape. The old paddle value indicator shape is also updated so that text scaling works consistently.
2019-11-20 18:18:40 +01:00
Shi-Hao Hong
0821b759f5
Typo fixes (#42688) 2019-10-15 10:06:50 -07:00
Slade Capasso
a9c28d5f6c
range_slider_test.dart diagnostics property tests (#40291)
* Updates to slider_test.dart

Fixed error that required onChanged.

* Updated slider.dart and slider_test.dart debugFillProperties

Updated slider.dart debugFillProperties to include all properties and slider_test debugFillProperties to test all properties

* Updated Slider onChanged property

* Updated debugFillProperties to ignore testing methods that are null in test

Per feedback from Hans/Anthony on Flutter Material

* Updated spacing in debugFillProperties

Per feedback from Hans

* Updated range_slider.dart and range_slider_test.dart to have DiagnosticProperties tests for all properties

* Updated range_slider.dart and range_slider_test.dart per feedback

Preventing null labels from creating an error.

Added made RangeLabels and RangeValues constants in instantiation of Range Slider.

Fixed spacing.

* Updates to start and end labels in diagnostic property tests

Updated per feedback from @clocksmith
2019-10-01 17:06:34 -04:00
Alexandre Ardhuin
e9965f5636
add missing trailing commas in packages/flutter (#41076) 2019-09-24 08:05:41 +02:00
Anthony
aae50f541a
[Material] Text scale and wide label fixes for Slider and Range Slider value indicator shape (#35496)
Various bug fixes for Slider and Range Slider value indicator around accessibility and wide labels.
2019-07-09 13:26:10 -04:00
Anthony
a276ab3d6d
[Material] Properly call onChangeStart and onChangeEnd in Range Slider (#34869)
Fixes a bug in the Range Sider where the onChangeStart and onChangeEnd were not being called if the initial thumb selection came from a drag (rather than a tap).
2019-06-24 17:09:07 -04:00
Anthony
e1d0ded926
[Material] Create a themable Range Slider (continuous and discrete) (#31681)
Creates a Material Design range slider.

The range slider is based off the updated slider, with the main difference being that it has 2 thumbs.
By default, the thumbs cannot pass each other and both the thumb and the value indicator create a stroke when they are overlapping for better visibility.
2019-06-06 15:31:02 -04:00