92 Commits

Author SHA1 Message Date
Alexandre Ardhuin
157bc92d4a
end of sort_child_properties_last (#82457) 2021-05-13 13:39:04 -07:00
Alexandre Ardhuin
fa19b3d3bd
add missing trailing commas (#81329) 2021-04-27 17:09:03 -07:00
chunhtai
00592ceb27
Fixes AlertDialog and SimpleDialog to not merge their content semantics (#78633) 2021-03-23 12:01:03 -07:00
Hans Muller
fe0ceeb80d
Reland: Removed ButtonBar from AlertDialog #75676 (#76167) 2021-02-17 11:02:02 -08:00
Hans Muller
9296a527b3
Revert "Removed ButtonBar from AlertDialog (#75676)" (#75873)
This reverts commit 705cebb239a05bcdf69c6eeae6d31eda7fa24895.
2021-02-11 18:33:24 -08:00
Hans Muller
705cebb239
Removed ButtonBar from AlertDialog (#75676) 2021-02-10 16:06:50 -08:00
Sam Rawlins
4e154eb8d5
Remove "unnecessary" imports in test/material (#75358) 2021-02-03 21:01:04 -08:00
Alexandre Ardhuin
d546e1d311
fix for upcoming lint use_named_constants (#74788) 2021-01-27 20:20:44 +01:00
Yurii Cherniavskyi
6d9e3c3fa9
Expose insetPadding and clipBehavior in SimpleDialog (#73571) 2021-01-25 19:44:05 -08:00
Shi-Hao Hong
5801f0e5fe
Expose DialogRoutes for state restoration support (#73829) 2021-01-22 16:20:44 -08:00
Kate Lovett
3abb9e5008
Remove deprecated showDialog.child (#72532) 2020-12-23 15:09:01 -08:00
Amit Patil
2cb652600c
showDialog assertion for non-null builder or child property (#71838) 2020-12-08 09:03:03 -08:00
Greg Spencer
de884f1afe
Remove the nullOk parameter from Navigator.of and add Navigator.maybeOf (#70726)
Adds Navigator.maybeOf to replace calling Navigator.of(context, nullOk: true), and removes the nullOk parameter. Also changes Navigator.of to return a non-nullable value, and removes many (120!) instances of the ! operator, reducing the possible places where a null dereference could occur.
2020-11-20 09:10:46 -08:00
Greg Spencer
55289324c6
Remove nullOk in MediaQuery.of (#68736)
Adds MediaQuery.maybeOf to replace calling MediaQuery.of(context, nullOk: true), and removes the nullOk parameter. Also changes MediaQuery.of to return a non-nullable value, and removes many instances of the ! operator, reducing the possible places where a null dereference could occur.
2020-10-28 07:56:41 -07:00
chunhtai
6cab3f6008
fix simple dialog introducing additional node for semantics label (#68804)
* fix simple dialog introducing additional node for semantics label

* add test
2020-10-22 13:33:17 -07:00
Michael Goderbauer
42f3709a5a
Sound null safety for framework and flutter_test (#68642) 2020-10-21 10:09:11 -07:00
Kate Lovett
e48c9b5553
[NNBD] Migrating some Material tests (#67689) 2020-10-13 11:37:03 -07:00
chunhtai
70f21de9de
reland always adds alert label for alert dialog in Android (#66057) 2020-09-17 16:17:05 -07:00
Jonah Williams
d15da04f4f
Revert "always adds alert label for alert dialog in Android (#65973)" (#66031)
This reverts commit fd0554ba89e6e2904355bc96622554b6a4ca6bf9.
2020-09-17 07:51:28 -07:00
chunhtai
fd0554ba89
always adds alert label for alert dialog in Android (#65973) 2020-09-16 17:42:05 -07:00
Chris Bracken
c0ea00ed3f
Prefer moreOrLessEquals over closeTo (#64915)
Flutter's `moreOrLessEquals` has a few advantages over `closeTo` from
the `matcher` package:

   * It emits the epsilon value in the test result on failure.
   * It uses a named parameter for epsilon, which improves readability
     at the call site.
   * It has a reasonable default for epsilon in cases where something
     more specific isn't required.

Using it also has the nice property that it aids in its own discovery
when when people go looking for such functionality in new tests.

This change also includes a couple unrelated whitespace formatting cleanups.
2020-08-30 22:20:16 -07:00
Darren Austin
d169880278
Updated references to the old button classes to the new ones in comments and documentation for tests in the material and cupertino libraries. (#62164) 2020-07-28 11:01:04 -07:00
Anthony
6f56ba453d
Automatically scale down Dialog padding for larger text scale factors (#58245) 2020-07-15 09:36:03 -07:00
Alexandre Ardhuin
4d7525f05c
Opt out nnbd in packages/flutter (#59186)
* add language version 2.8 in packages/flutter

* enable non-nullable analyzer flag
2020-06-11 14:11:30 +02:00
Darren Austin
012cee2731
Typo fixing sweep through packages/flutter. (#59219) 2020-06-11 05:10:01 -07:00
chunhtai
333eb9d76a
enable Navigator.of to accept a navigator element and return its stat… (#58259) 2020-06-08 16:13:02 -07:00
Kate Lovett
b915808f63
Step 2 (#57751) 2020-06-04 10:38:02 -07:00
Kate Lovett
04860d7256
Step 1 of 3: Add opt-in fixing Dialog border radius to match Material Spec (#56084) 2020-05-19 17:52:05 -07:00
Darren Austin
d35ade4a6c
Added 'barrierColor' and 'useSafeArea' parameters to showDialog. (#54110) 2020-04-06 11:26:01 -07:00
Shi-Hao Hong
ad44b05ca4
Revert "AlertDialog widget scrollable by default (#49848)" (#51886)
This reverts commit 28f2c96a8a63ca75700b307692b3bc691d6d010c.
2020-03-03 14:03:05 -08:00
Shi-Hao Hong
28f2c96a8a
AlertDialog widget scrollable by default (#49848) 2020-03-03 13:39:01 -08:00
Darren Austin
fef2d6ccd6
Pass RouteSettings into all callers of showGeneralDialog. (#51525) 2020-02-27 15:11:01 -08:00
Darren Austin
7a83c6fcd4
Expose insetPadding and clipBehavior in Dialog and AlertDialog. (#50775) 2020-02-19 18:26:04 -08:00
Shi-Hao Hong
a833effbc7
Reland Alert dialog overflow spacing (#50675)
* Add ButtonBar.overflowButtonSpacing

* Add AlertDialog overflow button spacing functionality
2020-02-13 10:00:15 -08:00
Jenn Magder
24017e761e
Revert "AlertDialog.actionsOverflowButtonSpacing and ButtonBar.overflowButtonSpacing (#50609)" (#50674) 2020-02-12 15:20:13 -08:00
Shi-Hao Hong
23d61a81dc
AlertDialog.actionsOverflowButtonSpacing and ButtonBar.overflowButtonSpacing (#50609)
* Add ButtonBar.overflowButtonSpacing

* Add AlertDialog overflow button spacing functionality
2020-02-12 14:53:59 -08:00
Arthur Denner
d3e1e29375
SimpleDialogOption: support custom padding (#50035) 2020-02-12 08:58:03 -08:00
Shi-Hao Hong
0174267316 ButtonBar.verticalDirection and AlertDialog.actionsVerticalDirection (#48728) 2020-01-14 16:48:02 -08:00
Shi-Hao Hong
62e436f049
Implement AlertDialog.actionsPadding and AlertDialog.buttonPadding (#47709)
* Implement AlertDialog.actionsPadding and AlertDialog.buttonPadding
2020-01-03 08:18:21 -08:00
Shi-Hao Hong
bde351eea2
Make AlertDialog scrollable through AlertDialog.scrollable parameter (#45079)
* Add AlertDialog.scrollable

* Add deprecation notice

* Ignore deprecation warning in dialog.dart with TODO
2019-12-18 12:31:16 -08:00
Alexandre Ardhuin
dfbd585668 implicit-casts:false in flutter/test (#46245) 2019-12-16 15:03:02 -08:00
Ian Hickson
449f4a6673
License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Shi-Hao Hong
bf45897f13
Revert "Implement AlertDialog title/content overflow scroll #43226" (#44003) 2019-11-01 11:30:58 -07:00
Brian Egan
2e41483384 Add "navigator" option to "showDialog" and "showGeneralDialog" (#42842) 2019-11-01 11:16:32 -07:00
Shi-Hao Hong
c461ff9d4a
Implement AlertDialog title/content overflow scroll (#43226)
* Wrap alert dialog title and content in single child scroll view

* Scrollable alert dialog title and content tests

* Remove unnecessary comment

* Fix mainAxisSize and crossAxisAlignment issue
2019-10-28 13:45:05 -07:00
Dan Field
fe9512fa72
Re-enable const (#31600)
* Re-enable const
2019-04-29 16:02:42 -07:00
MH Johnson
3bbb8d8b77
[Material] Fix showDialog crasher caused by old contexts (#30754)
* Fix bug, add regression test.

* remove unnecessary space
2019-04-11 09:48:35 -04:00
Alexandre Ardhuin
440ce8fde6
Fix indentations of statements in BlockFunctionBody (#28933)
* fix indentof statements in BlockFunctionBody

* fix indentof statements in BlockFunctionBody in tests
2019-03-07 21:09:28 +01:00
Alexandre Ardhuin
387f885481
Add missing trailing commas (#28673)
* add trailing commas on list/map/parameters

* add trailing commas on Invocation with nb of arg>1

* add commas for widget containing widgets

* add trailing commas if instantiation contains trailing comma

* revert bad change
2019-03-01 08:17:55 +01:00
Alexandre Ardhuin
5169ab5974
format parameter list (#27261) 2019-02-21 09:27:07 +01:00