91 Commits

Author SHA1 Message Date
Alexandre Ardhuin
fa19b3d3bd
add missing trailing commas (#81329) 2021-04-27 17:09:03 -07:00
Phil Quitslund
61c30c41b2
fix sort_directives violations (#80817) 2021-04-21 13:49:03 -07:00
Alexandre Ardhuin
8de7020a5f
remove unnecessary trailing commas (#79562) 2021-04-01 21:52:35 +02:00
Craig Labenz
9bbe89d8e7
Add MaterialStateBorderSide.resolveWith (#78731)
* added MaterialStateBorderSide.resolveWith

(Partially) Resolves #68596

* responded to comment nits

* reversed changes to text_buttons

* added test confirming compatibility with chips

* added MaterialStateBorderSide test for chip

* added intended usage for MaterialStateXYZ classes

* another docstring update

* corrected error in use case

* made resolvewith samples closures

* refined materialstatecolor example in docstring

* changed nullability in docstring and added null test

* added missing type in test

* fixed another typo in docstrings
2021-03-30 21:20:12 -07:00
Jonathan Lau
5a27340c45
Add minWidth constraint to RawChip when materialTapTargetSize is padded (#77881) 2021-03-12 12:48:03 -08:00
Michael Goderbauer
cb867bbedc
Enable unnecessary_await_in_return lint (#77434) 2021-03-05 18:38:15 -08:00
Greg Spencer
c6ef4c75d9
Turn on sized_box_for_whitespace lint, fix instances. (#77099) 2021-03-03 17:29:02 -08:00
Sam Rawlins
4e154eb8d5
Remove "unnecessary" imports in test/material (#75358) 2021-02-03 21:01:04 -08:00
Ian Hickson
824042f9b2
Catch cases in tests where people try to tap on widgets that aren't reachable. (#74798) 2021-02-03 16:11:02 -08:00
Alexandre Ardhuin
d546e1d311
fix for upcoming lint use_named_constants (#74788) 2021-01-27 20:20:44 +01:00
David Martos
56716f61a2
Chip theme label style is merged with the provided label style (#70687) 2020-12-09 11:28:05 -08:00
LongCatIsLooong
319722997c
fix typo in computeMaxIntrinsicWidth implementation (#69812) 2020-11-04 16:19:04 -08:00
Per Classon
92d9630eaf
Add side property to Chips, and resolve it and the state of Chips to be MaterialState aware (#68596) 2020-10-28 11:12:09 -07:00
Anurag Roy
f03caeafa7
Add useDeleteButtonTooltip property for Chip (#68237) 2020-10-28 11:07:04 -07:00
Darren Austin
3c21775c94
Migrate Material framework tests to null safety (#67556)
Migrate Material framework tests to null safety.
2020-10-07 16:44:00 -07:00
Chris Bracken
c0ea00ed3f
Prefer moreOrLessEquals over closeTo (#64915)
Flutter's `moreOrLessEquals` has a few advantages over `closeTo` from
the `matcher` package:

   * It emits the epsilon value in the test result on failure.
   * It uses a named parameter for epsilon, which improves readability
     at the call site.
   * It has a reasonable default for epsilon in cases where something
     more specific isn't required.

Using it also has the nice property that it aids in its own discovery
when when people go looking for such functionality in new tests.

This change also includes a couple unrelated whitespace formatting cleanups.
2020-08-30 22:20:16 -07:00
Nolan Scobie
dc0f122881
Revert "Revert "Tweaking Material Chip a11y semantics to match buttons (#60141)" (#60645)" (#61048) 2020-07-10 14:21:03 -07:00
gaaclarke
e8670de011
Revert "Tweaking Material Chip a11y semantics to match buttons (#60141)" (#60645) 2020-06-30 18:28:01 -07:00
Nolan Scobie
da489c337a
Tweaking Material Chip a11y semantics to match buttons (#60141) 2020-06-26 17:24:27 -04:00
chunhtai
5623fea53c
Reverse the semantics order of modal barrier and modal scope (#59290)
* Add semantics sort key for modal scope and modal barrier

* fix test

* fix test

* fix test

* fix space

* fix more tests

* addressing comments
2020-06-24 10:37:53 -07:00
Jose Alba
c6f6de6d1b
Chips text scaling (#57745) 2020-06-18 11:48:03 -07:00
Alexandre Ardhuin
4d7525f05c
Opt out nnbd in packages/flutter (#59186)
* add language version 2.8 in packages/flutter

* enable non-nullable analyzer flag
2020-06-11 14:11:30 +02:00
Kate Lovett
5d5175b0b3
Skip Audit - Material Library (#54322) 2020-04-21 19:13:02 -07:00
Anthony
aeb12144e6 Use a separately focusable semantics node for the chip delete icon (#48740) 2020-01-15 16:38:04 -08:00
Michael Goderbauer
beb86d2cc4 Revert "Simplify Chip slightly (#47254)" (#47353) 2019-12-18 14:03:01 -08:00
Michael Goderbauer
b7d221227c
Simplify Chip slightly (#47254) 2019-12-17 16:23:05 -08:00
Alexandre Ardhuin
dfbd585668 implicit-casts:false in flutter/test (#46245) 2019-12-16 15:03:02 -08:00
Greg Spencer
bc7ed36db5
Add visualDensity to checkbox, radio, icon button, and chip. (#46091)
This adds a visualDensity attribute to checkbox, radio, icon button, and chip.
2019-12-05 17:36:42 -08:00
Ian Hickson
449f4a6673
License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Greg Spencer
0028887a69
Don't allow Disabled InkWells to be focusable (#43848)
Makes sure that disabled InkWell/InkResponse and widgets that use them don't allow themselves to be focused.

ListTile, PopupMenu, and Stepper were not setting canRequestFocus properly on the InkWell, and InkWell was allowing focus even if it was disabled (it was basically just relying on the containing widget to set canRequestFocus properly). Now InkWell must both be enabled (have an onTap or similar) and have canRequestFocus set to true.
2019-10-31 12:58:14 -07:00
Jonah Williams
c9ec26ee29
Revert "[Chip] Make sure InkResponse is in the foreground on delete for chips with background color (#41463)" (#43391)
This reverts commit 588275e179379c957c4b7acf5cea1d2d1f2d6ce0.
2019-10-23 18:11:47 -07:00
Per Classon
588275e179
[Chip] Make sure InkResponse is in the foreground on delete for chips with background color (#41463)
* Make sure InkResponse is visible on delete for chips with background color set

* Override computeDistanceToActualBaseline in layout builder
2019-10-23 17:55:46 -07:00
Tianguang
320a933d9e
Fix chip ripple bug — No longer two ripples (#42779)
* Fixed chip ripple.

* Fixed chip ripple. All tests passed.

* Fix one minor detail.

* Fixed reference box.

* Playing around 2.

* Added tests for chip ripple.

* Reverting print-debugging statements

* Remove extra blank line.

* Fixed chip ripple.

* Remove commented code.

* Reconciles with upstream/master.

* Remove print-debugging statement.

* Remove empty line.

* Edit comments.

* Edit style and comments.

* Edit style.

* Fix style and capitalization.

* Return bool.

* Edit style.

* Use getMaterialBox instead of Material.of(...).

* Experiment 3.

* Revert.

* Using tester.pump instead of pumpFrames

* Delete pumpFrames.

* Edit comments.
2019-10-23 11:21:45 -07:00
Greg Spencer
89d6c8d90b
Enables setting of semantics focused and focusable attributes within Focus widgets. (#41814)
This adds a Semantics node to the Focus and FocusScope widgets, setting the focused and focusable attributes so that the accessibility subsystem can be told when a control has the input focus.

Includes an engine roll to flutter/engine@77252d2, and the following 8 engine changes:

flutter/engine@77252d2 Greg Spencer Add missing focusable testing info (flutter/engine#13013)
flutter/engine@0e42a29 skia-flutter-.. Roll src/third_party/skia 54548626a977..e27a503a0a21 (1 commits) (flutter/engine#13024)
flutter/engine@6b56ed7 gaaclarke Refactor: FlutterDartProject (flutter/engine#13006)
flutter/engine@393480c skia-flutter-.. Roll src/third_party/skia 77dde599c98a..54548626a977 (1 commits) (flutter/engine#13023)
flutter/engine@080b89d skia-flutter-.. Roll src/third_party/skia 2b1a25a4d324..77dde599c98a (1 commits) (flutter/engine#13021)
flutter/engine@90b0f30 Ben Konyi Roll src/third_party/dart f4a72bfc64..bb04f145b2 (18 commits) (flutter/engine#13020)
flutter/engine@049fb89 skia-flutter-.. Roll fuchsia/sdk/core/linux-amd64 from q_uYX... to cknsi... (flutter/engine#13019)
flutter/engine@6925b2a skia-flutter-.. Roll fuchsia/sdk/core/mac-amd64 from wuAtw... to u0JpE... (flutter/engine#13018)

Related Issues
Addresses #40101

Landing on red in order to fix the build: it's red because of the needed engine roll.
2019-10-09 14:45:42 -07:00
Alexandre Ardhuin
f0553ba58e
Missing trailing commas (#41473)
* add missing trailing commas

* add more missing trailing commas

* add more and more missing trailing commas
2019-09-30 18:48:23 +02:00
Alexandre Ardhuin
b873162194
fix some bad indentations (#41172) 2019-09-24 21:03:37 +02:00
Alexandre Ardhuin
e9965f5636
add missing trailing commas in packages/flutter (#41076) 2019-09-24 08:05:41 +02:00
Anthony
c17086a06d
Add the option to configure a chip check mark color (#40608)
Add the option to configure a chip check mark color
2019-09-17 14:17:34 -04:00
Greg Spencer
8daa165d01
Make disabled buttons/chips/text fields not be focusable. (#38726)
This changes the behavior of text fields, Material buttons, and Chips so that if they are disabled they lose focus. Before this change, it was possible to disable a control and then use focus traversal to reach it anyhow, and in the case of text fields, enter text into a disabled field.

Fixes #33985
2019-09-03 07:51:28 -07:00
MH Johnson
17ddfb1b42
make RawChip.selected non-nullable (#37556) 2019-08-13 17:36:44 -04:00
MH Johnson
da8c7a9756
[Material] Add support for hovered, pressed, focused, and selected text color on Chips. (#37259)
* Chip keeps track of state, resolves text color
2019-08-03 12:52:00 -04:00
Jonah Williams
3ae6abd9e8
Compatibility pass on flutter/material tests for JavaScript compilation. (9) (#33378) 2019-06-12 17:06:01 -07:00
Shi-Hao Hong
7690bb47dc
Add Horizontal Padding to Constrained Chip Label Calculations (#31861)
* Add horizontal padding and properly constrain chip label calculations

* Added regression test for avatar, label and delete icon constraint
2019-05-01 13:46:36 -07:00
Alexandre Ardhuin
a0d1f93b07
fix block formatting (#29051) 2019-03-09 09:03:11 +01:00
Alexandre Ardhuin
440ce8fde6
Fix indentations of statements in BlockFunctionBody (#28933)
* fix indentof statements in BlockFunctionBody

* fix indentof statements in BlockFunctionBody in tests
2019-03-07 21:09:28 +01:00
ocavue
1df28e8b7a Fix ink highlight effect of RawChip (#28653) 2019-03-01 10:33:58 -08:00
Alexandre Ardhuin
387f885481
Add missing trailing commas (#28673)
* add trailing commas on list/map/parameters

* add trailing commas on Invocation with nb of arg>1

* add commas for widget containing widgets

* add trailing commas if instantiation contains trailing comma

* revert bad change
2019-03-01 08:17:55 +01:00
rami-a
b73dd0e81e
[Material] Add ability to set shadow color and selected shadow color for chips and for chip themes (#28163)
* Add ability to set shadow color for chips and for chip themes

* Add selected shadow color as a property as well

* Update phrasing of documentation

* Address PR feedback
2019-02-22 15:50:39 -05:00
Alexandre Ardhuin
5169ab5974
format parameter list (#27261) 2019-02-21 09:27:07 +01:00
rami-a
4ba35a6eab
Add elevation/pressElevation to ChipThemeData (#27399)
Allow the theme to provide these values to Chips
2019-02-01 15:54:02 -05:00