1515 Commits

Author SHA1 Message Date
Jenn Magder
135aab9cf5
Increase device run perf test timeout (#69260) 2020-10-28 18:29:04 -07:00
Jonah Williams
d306c37bc4
[flutter_tools] fix --use-existing-app (#69237) 2020-10-28 13:55:29 -07:00
Jonah Williams
3b9ef2e8de
[devicelab] mark routing test as flaky (#69228) 2020-10-28 12:11:58 -07:00
Jonah Williams
18f0a2288e
[flutter_tools] update to vm_service 5.2.0, update to dwds 7.0.0 (#69067)
Rolls in several fixes to web tooling, including better handling of absolute file imports. Updates to latest vm service to unblock null safety mode query

Co-authored-by: Gary Roumanis <grouma@google.com>
Co-authored-by: Anna Gringauze <annagrin@google.com>
2020-10-27 13:55:32 -07:00
Jacob MacDonald
193fe3e980
Update null safe deps to prepare for the 2.12 sdk version (#69041)
* update pinned null safety deps

* run update-packages

* add http dep to devicelab package

* rerun update-packages
2020-10-26 14:31:13 -07:00
Jonah Williams
2c12a8d917
[devicelab] remove twc enabled test and uncaught image test (#68518) 2020-10-24 13:19:51 -07:00
Jonah Williams
9f6b575ef1
[devicelab] mark uncaught exceptions as flaky (#68906)
* [devicelab] mark uncaight exceptions as flaky

* add print error output

* try and fix test
2020-10-23 12:32:08 -07:00
Jonah Williams
d75cda9d82
[devicelab] never run pub (#68900) 2020-10-23 11:13:25 -07:00
Jonah Williams
f0ecfff3ca
[devicelab] mark twc as flaky and fix flutter test perf (#68895) 2020-10-23 10:39:33 -07:00
Casey Hillers
ce3ce20b14
[devicelab] Upload git branch (#68541) 2020-10-23 08:02:02 -07:00
Casey Hillers
d2314ecfa9
[Doc Fixit 2020] Move dashboard documentation to flutter/cocoon (#68822) 2020-10-23 06:37:03 -07:00
Jonah Williams
37042fdb08
[flutter_tools] remove iOS screenshot on failure functionality (#68650)
* [flutter_tools] remove iOS screenshot on failure functionality

* remove all screenshot code
2020-10-22 13:34:07 -07:00
Yuqian Li
8a25557619
Mark the test as flaky again (#68636)
It seems that I was lucky to see 10 consecutive successes. Now the test
seems to be quite flaky again.
2020-10-20 11:58:49 -07:00
Jonah Williams
0e1c3fc7c4
[devicelab] remove commands test (#68539) 2020-10-20 09:50:06 -07:00
Jonah Williams
ab20ae782a
[devicelab] uinstall during memory test (#68548) 2020-10-20 09:49:50 -07:00
Jonah Williams
938fae9c99
remove --machine flag (#68538) 2020-10-19 17:06:28 -07:00
Jonah Williams
a152c0f429
[devicelab] reland: reduce iterations of startup test, use application binary (#68532)
These devicelab tests are incredibly flaky. Currently they will build & install the same application 15 times. This causes the temp storage to fill up on android, and has a good chance of flaking on iOS due to install issues.

The change from 3 to 15 increased total test time for 2 -> 12 minutes on iOS, or roughly 5 more test equivalents for every single iOS test. Reduce the iteration count back to 5

Uninstall the app after each run so temp storage does not fill up.
2020-10-19 16:51:28 -07:00
Yuqian Li
91a5a1e7f9
Mark e2e ios32 warmup test as nonflaky (#68511) 2020-10-19 15:52:05 -07:00
Jonah Williams
4a3e2a1af5
Revert "[devicelab] reduce iterations, uninstall at end, and use --application-binary in all startup tests (#68516)" (#68531)
This reverts commit a4c2075a45f956baa018016e3593d6af84290c6d.
2020-10-19 15:05:46 -07:00
Jonah Williams
8262f808ba
Revert "[devicelab] fix flutter gallery app name (#68528)" (#68530)
This reverts commit 0f69f8e53b397a963df73627b396caa235761b60.
2020-10-19 15:05:10 -07:00
Jonah Williams
0f69f8e53b
[devicelab] fix flutter gallery app name (#68528) 2020-10-19 14:48:05 -07:00
Jonah Williams
a4c2075a45
[devicelab] reduce iterations, uninstall at end, and use --application-binary in all startup tests (#68516)
These devicelab tests are incredibly flaky. Currently they will build & install the same application 15 times. This causes the temp storage to fill up on android, and has a good chance of flaking on iOS due to install issues.

The change from 3 to 15 increased total test time for 2 -> 12 minutes on iOS, or roughly 5 more test equivalents for every single iOS test. Reduce the iteration count back to 5

Uninstall the app after each run so temp storage does not fill up.
2020-10-19 14:16:04 -07:00
Casey Hillers
1c35091a13
[devicelab] Cocoon client (#68333) 2020-10-19 13:12:04 -07:00
Jonah Williams
e8dc7a2e17
[devicelab] update hostonly tests to use flutter directly or precache deps (#68487)
Fixes #67370

By running most of these executions through flutter, we get the benefit of the flutter error handling and precaching. IN the test where this is not feasible, call pre-cache directly.
2020-10-19 13:01:50 -07:00
Jonah Williams
03db9bf918
[devicelab] migrate defines test to DriverTest (#68407)
Removes one-off handling for defines test and forces it to run through the DriverTest interface
2020-10-19 12:28:43 -07:00
Jonah Williams
223df0c351
[devicelab] split end to end tests into driver targets (#68410)
Split the integration_ui target into individual driver tests. Remove disabled screenshot tests
2020-10-19 12:28:13 -07:00
Jonah Williams
e422d5c724
[flutter_tools] reland: --no-android-gradle-daemon in devicelab (#68491)
Remove devicelab specific code for shutting down gradle daemon, add --android-gradle-daemon option to build/run/drive`. Avoids need for un-tested devicelab specific handler. There are also some feature requests for this, so 2 birds one stone.

Example:

flutter build apk --no-android-gradle-daemon will pass --no-daemon on to gradle
2020-10-19 10:27:58 -07:00
Jonah Williams
ed5482de19
Revert "[flutter_tools] add --android-gradle-daemon option, use in devicelab (#68409)" (#68489)
This reverts commit ddab72e79f72b7896d8f62b2062d46c764c224f6.
2020-10-19 09:33:52 -07:00
Jonah Williams
ddab72e79f
[flutter_tools] add --android-gradle-daemon option, use in devicelab (#68409)
Remove devicelab specific code for shutting down gradle daemon, add --android-gradle-daemon option to build/run/drive`. Avoids need for un-tested devicelab specific handler. There are also some feature requests for this, so 2 birds one stone.

Example:

flutter build apk --no-android-gradle-daemon will pass --no-daemon on to gradle
2020-10-19 09:12:21 -07:00
Alexandre Ardhuin
c0176c9ee5
use_is_even_rather_than_modulo (#68301) 2020-10-16 20:20:00 +02:00
Martin Kustermann
6fae89c8b5
Update package:stack_trace dependency to 1.10.0-nullsafety.4 (#68132) 2020-10-16 16:35:20 +02:00
Jonah Williams
35c364053b
Fix screenshotting code (#68261) 2020-10-15 19:03:28 -07:00
Jonah Williams
d7f80fcdd3
[flutter_tools] configure screenshot on failure for all tasks (#68260) 2020-10-15 18:53:00 -07:00
Jonah Williams
ef205f7ebf
[devicelab] mark catalina not flaky and list iproxy processes before tet (#68239) 2020-10-15 14:21:40 -07:00
Dan Field
12f54e17f4
reland List queue search optimization (#68214)
* Revert "Revert "Improve performance of collectAllElements (#68065)" (#68207)"

This reverts commit 46ff57d6f19360da1da5fbdf0db70c49a716734a.

* use fewer elements for benchmark
2020-10-15 13:46:50 -07:00
Jonah Williams
0f88644883
[devicelab] allow the devicelab to take a screenshot if the iOS connection fails with FLUTTER_IOS_SCREENSHOT_ON_CONNECTION_FAILURE (#68156)
More attempts to remote diagnose the issues in the iOS devicelab
2020-10-15 13:13:28 -07:00
Jenn Magder
25857ce513
Use --device-timeout instead of deprecated --timeout in devicelab (#68230) 2020-10-15 12:45:59 -07:00
Jonah Williams
f5608f2b33
[devicelab] track any leaked processes (#68218) 2020-10-15 10:54:31 -07:00
Jonah Williams
2321b72dfb
[flutter_tools] move gradle download failure handling into tool (#68140)
This crash affects anyone using flutter, so move it into the tool where it can be tested and documented. Ensure it works on windows devicelab too.
2020-10-15 09:20:52 -07:00
Jonah Williams
46ff57d6f1
Revert "Improve performance of collectAllElements (#68065)" (#68207)
This reverts commit 8ba5732c4c874f08d853f30b10f1912efc992cc3.
2020-10-15 08:04:59 -07:00
Dan Field
8ba5732c4c
Improve performance of collectAllElements (#68065) 2020-10-14 21:32:04 -07:00
Jonah Williams
83e99f75c6
[devicelab] move test from flaky (#68141) 2020-10-14 14:47:41 -07:00
Jonah Williams
c11a64e944
[devicelab] turn down android X migration gradle tests (#68110)
These androidx migration tests require downloading firebase, which is a large library with a number of dependencies - this causes frequent enough flakes.

AndroidX migration is ~2 years in the past, and while it would be nice to confirm this still works, ideally that would be done in a reduced manner.
2020-10-14 13:24:22 -07:00
Jonah Williams
33903c17e1
[devicelab] delete disabled or not useful benchmarks (#68107)
- run_without_leak_tests: have been disabled for months
- build_benchmark: the tooling work here is mostly done and we're not tracking further improvements, free up more devicelab capacity
- system_debug_ios: does not work post iOS13
- mac_enable_twc: not adding more mac tests to devicelab
- hello_world_start_up: disabled

Any tests that we think will be valuable in the future can be resurrected from the git history.
2020-10-14 10:30:10 -07:00
Jonah Williams
06722679da
[devicelab] mark ios catalina as flaky (#68109) 2020-10-14 08:52:28 -07:00
Jonah Williams
751459df24
[flutter_tool] support --use-application-binary in flutter drive (#68060)
--use-application-binary allows running with an already built APK. This can be useful for speeding up CI test cases, or in our case eventually supporting some sort of build server. Demonstrate that this works by updating the old gallery test to use it. Fixes #56604

Co-authored-by: Jenn Magder <magder@google.com>
2020-10-13 19:27:30 -07:00
Jonah Williams
eb24393efe
remove missing argument (#67974) 2020-10-12 17:18:09 -07:00
Jonah Williams
5dfe7e6d51
[flutter_tools] attempt to stabilize hot restart benchmark the old fashioned way (#67971)
A change which sped up hot restart locally caused many of the devicelab measures to regress. I think this is because we do not measure when the isolate is actually "ready", so starting a reload or restart prematurely can cause time spent doing initialization to be registered as part of the reload operation.

A fix for this would be to have the framework include some sort of "initialization complete" event ... but it is not clear what the correct trigger would be. Perhaps after the first frame is successfully registered?

(9a3a0dc caused the benchmark regression - possibly since we spend less time syncing files now so we start the restart earlier)
2020-10-12 17:00:26 -07:00
Sam Rawlins
23c7ee9deb
Bump meta to 1.3.0-nullsafety.4 (#67744) 2020-10-12 09:50:30 -07:00
Jonah Williams
e53bb74694
Revert "Revert "Delete fast start unit test (#67757)" (#67763)" (#67765)
This reverts commit b33bfcef0ffbeea36c8a846c54aaeeaf73bf1f87.
2020-10-09 13:04:20 -07:00