DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
33,771 Commits 882 Branches 1,069 Tags
Commit Graph

25585 Commits

Author SHA1 Message Date
Dan Field
b3ab50daf2 Add include suggested by clang-tidy (flutter/engine#49898) 
This is from the google3 roll. Adding this cuts down on noise for rollers.
 2024-01-25 21:15:00 +00:00
Callum Moffat
b473589fe5 Refactor macOS trackpad gesture tracking (flutter/engine#49424) 
The AppKit state machine was not well understood before. Sometimes the engine would leave orphan PanZoomStart after a certain sequences including NSEventPhaseMayBegin

Now track each gesture's specific phase instead of boolean true/false which doesn't really accurately represent the system state.

Fixes https://github.com/flutter/flutter/issues/140730
FIxes https://github.com/flutter/flutter/issues/136622
 2024-01-25 21:10:06 +00:00
Nishant Kumar
f27cfea630 winding order from tesellator.h to formats.h (flutter/engine#49865) 
i have removed WindingOrder from tesellator.h and moved it to formats.h . Fixes https://github.com/flutter/flutter/issues/138832

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-25 21:05:18 +00:00
John McCutchan
c4781018bc Optimizations for TLHC frame rate and jank (flutter/engine#50033) 
- ImageReaderSurfaceProducer no longer drops frames when the producer
and the consumers are up to two frames out of sync.
- Have the native C++ side of the Android external textures check if a
new frame has been pushed and that the texture needs to be updated. This
avoids having to schedule a task on the raster thread for each updated
texture.
- Notify the engine earlier that a frame is needed when updating a TLHC
texture.
 2024-01-25 12:44:38 -08:00
Jonah Williams
c80a0580f4 [Impeller] Fix mipmap generation for Vulkan render target textures. (flutter/engine#49848) 
Potentially fixes https://github.com/flutter/flutter/issues/141495

The texture used as a render target attachment can have miplevels, but
the image view cannot. Unconditionally create two image views per
texture (this could be optimized in some cases), where the specific
"render target texture view" always sets a mipcount of 1.

In theory this should allow us to generate mipmaps for textures that are
used as render target attachments, including toImage and toImageSync
textures which are currently missing this functionality.

---------

Co-authored-by: Aaron Clarke <aaclarke@google.com>
Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
 2024-01-25 12:28:26 -08:00
Jason Simmons
2bc62b42f1 [Impeller] Do not emit metadata for structs that are not part of the shader's interface (flutter/engine#50029) 
Fixes https://github.com/flutter/flutter/issues/138404
 2024-01-25 19:48:57 +00:00
skia-flutter-autoroll
5a1ecec956 Roll Skia from de46a989e0ca to 29b545e4356b (1 revision) (flutter/engine#50047) 
https://skia.googlesource.com/skia.git/+log/de46a989e0ca..29b545e4356b

2024-01-25 fmalita@chromium.org [skottie] Add TrivialFontRunIterator build option

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-25 19:41:10 +00:00
Jonah Williams
48384a2022 [Impeller] write vertices geometry data to host buffer. (flutter/engine#49741) 
Now that host buffer writes go directly to device buffers, there is no advantage to creating dedicated device buffers for the vertices contents.

Fixes https://github.com/flutter/flutter/issues/141202
 2024-01-25 18:58:57 +00:00
Jonah Williams
f9923488be Revert "[Impeller] round up subpass coverage when it is close to (and smaller) than root pass size." (flutter/engine#50041) 
Reverts flutter/engine#49925

This did not improve benchmarks: https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dnew_gallery_impeller_old_zoom__transition_perf&selected=commit%3D38910%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DPixel_7_Pro%252Cdevice_version%253Dnone%252Chost_type%253Dlinux%252Csub_result%253D99th_percentile_frame_rasterizer_time_millis%252Ctest%253Dnew_gallery_impeller_old_zoom__transition_perf%252C

From follow up investigation: some of the routes hit this optimization, while some did not as the the bounds size seems to depend on the exact contents.
 2024-01-25 18:51:23 +00:00
gaaclarke
d8b2624fcf [Impeller] turned on vulkan validation for all but one golden test (flutter/engine#50045) 
fixes https://github.com/flutter/flutter/issues/142017

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-25 18:38:17 +00:00
skia-flutter-autoroll
b35b7d7917 Roll Skia from 56c06ee7a252 to bcc2e8b6105a (2 revisions) (flutter/engine#50042) 
https://skia.googlesource.com/skia.git/+log/56c06ee7a252..bcc2e8b6105a

2024-01-25 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 601d5676bb98 to 43b6e2049a16 (3 revisions)
2024-01-25 michaelludwig@google.com [skif] Add stats tracking for surfaces/shader types

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-25 17:14:23 +00:00
Jonah Williams
14fe2f8c27 [Impeller] call shutdown method in Android context. (flutter/engine#49992) 
The Impeller context requires us to call Shutdown to ensure that all of its spawned worker threads are joined, ensuring that the raster thread retains the last reference. Without this, we may either destroy parts of the context to early, or attempt to join into a worker thread which will fail.
 2024-01-25 17:02:34 +00:00
maRci002
e0a9cc7ce0 [web] add support for AppLifecycleState changes (flutter/engine#44720) 
closes flutter/flutter#53107

This PR introduces support for `AppLifecycleState` on Web, aligning the web's lifecycle events with those of the mobile platforms. This ensures a more consistent developer experience and better lifecycle management across all platforms.

**PR includes:**

- Page Visibility Handling: Integrated the `visibilitychange` DOM event to determine if the app is in a `resumed` or `paused` state based on the visibility state of the document.
- Page Transition Handling: Used `beforeunload` events to better manage the `detached` state.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-25 16:31:12 +00:00
skia-flutter-autoroll
75bd18f4b2 Roll Skia from 416d7b0e5ba1 to 56c06ee7a252 (1 revision) (flutter/engine#50040) 
https://skia.googlesource.com/skia.git/+log/416d7b0e5ba1..56c06ee7a252

2024-01-25 penghuang@chromium.org Replace push_back() in `DrawList::recordDraw()` with emplace_back()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-25 16:19:25 +00:00
skia-flutter-autoroll
3a3b5667b9 Roll Skia from 699ee2b7cf34 to 416d7b0e5ba1 (2 revisions) (flutter/engine#50039) 
https://skia.googlesource.com/skia.git/+log/699ee2b7cf34..416d7b0e5ba1

2024-01-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4784bfd700e3 to 601d5676bb98 (3 revisions)
2024-01-25 drott@chromium.org [Fontations-backend] Keep outline collection object alive

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-25 14:37:05 +00:00
skia-flutter-autoroll
d832cd08b2 Roll Dart SDK from beb003009a4d to 2fb950853f06 (1 revision) (flutter/engine#50037) 
https://dart.googlesource.com/sdk.git/+log/beb003009a4d..2fb950853f06

2024-01-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-71.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-25 13:50:22 +00:00
zijiehe@
538d967f7c [Fuchsia] Redo - Use chromium test-scripts to download images and execute tests (flutter/engine#49940) 
This change is a redo of https://github.com/flutter/engine/pull/49847.

https://github.com/zijiehe-google-com/engine/compare/4530942..main
should show the diff between this and the original change; mainly fixes
the https://github.com/flutter/flutter/issues/141907.

Following paragraph is copied from the original change.

This change can be executed from buildroot by

```
python3 flutter/tools/fuchsia/with_envs.py flutter/testing/fuchsia/run_tests.py
```

Bug: https://github.com/flutter/flutter/issues/140179

- [V] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [V] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [V] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [V] I listed at least one issue that this PR fixes in the description
above.
- [V] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [V] I updated/added relevant documentation (doc comments with `///`).
- [V] I signed the [CLA].
- [V] All existing and new tests are passing.
 2024-01-25 11:58:03 +00:00
John Stiles
cd6d342e31 Use top-level GN arg for Skottie instead of CanvasKit-specific arg. (flutter/engine#50019) 
The GN flag `skia_canvaskit_enable_skottie` is being retired at http://review.skia.org/805336
 2024-01-25 03:43:05 +00:00
Jonah Williams
05e3314f30 [Impeller] round up subpass coverage when it is close to (and smaller) than root pass size. (flutter/engine#49925) 
Work towards https://github.com/flutter/flutter/issues/136510

generally speaking, we try to size subpasses as small as we possibly can as an optimization for memory usage and fragment load. Though with specific blend modes and/or filters we are required us to flood to a larger size. However in some cases, this optimization is counter productive - as we can only recycle textures that are exactly the same size.

In scenario where a large subpass slightly changes sizes every frame (such as for the android zoom page transition), the tight sizing is maximally inefficient as we discard and recreate large textures each frame.

This PR adds a heuristic which (at least locally) improves this by rounding up subpass size that is within 10% of the root pass size.
 2024-01-25 01:21:41 +00:00
MarkZ
6d345a5475 Adding DDC module system targets to web SDK artifacts. (flutter/engine#47783) 
This is part of an ongoing effort to replace DDC's module system in Flutter Web (for hot reload support).

Side effects of this change include doubling the code generated by DDC whenever this build pathway is hit (until the full module system transition lands), but this shouldn't affect debug performance. We may be able to lock this behind a build flag if this is an issue. 

See related issue: https://github.com/dart-lang/sdk/issues/52361
 2024-01-25 00:52:16 +00:00
Hasan Mohsin
eb072d8928 [Windows] Set cursor immediately when framework requests update (flutter/engine#49784) 
On Windows, when using a `MouseRegion` widget to change the cursor it is not actually updated until the cursor is moved. This is because the Windows embedder only updates the `current_cursor_` field but does not actually set the cursor until the window receives the `WM_SETCURSOR` message when the mouse moves. This change makes it set the cursor immediately.

Fixes flutter/flutter#76622
 2024-01-25 00:48:23 +00:00
Loïc Sharma
7aecd394de [Windows] Introduce egl::Surface and egl::WindowSurface (flutter/engine#49983) 
This introduces the `egl::Surface` and `egl::WindowSurface` types to abstract a raw `EGLSurface`. This also removes some - but not all - EGL surface logic out from `EGLManager`.

Subsequent pull requests will be necessary to:

1. Move ownership of the `egl::WindowSurface` from `egl::Manager` to `FlutterWindowsView`
2. Refactor external texture's off-screen EGL surface to use `egl::Surface`

Part of https://github.com/flutter/flutter/issues/141996

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-25 00:30:53 +00:00
skia-flutter-autoroll
3c8c5690fd Roll Dart SDK from e0bf6a261895 to 6211fedca10c (1 revision) (flutter/engine#50021) 
https://dart.googlesource.com/sdk.git/+log/e0bf6a261895..6211fedca10c

2024-01-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-69.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-24 23:23:43 +00:00
skia-flutter-autoroll
3fb1af7d31 Roll Skia from 247a61a5496d to 588caf1ceddd (2 revisions) (flutter/engine#50020) 
https://skia.googlesource.com/skia.git/+log/247a61a5496d..588caf1ceddd

2024-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from bc789bb959cd to 18030a03d509 (10 revisions)
2024-01-24 drott@chromium.org [Fontations-backend] Implement optimized fillPath() drawing operation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-24 23:16:48 +00:00
skia-flutter-autoroll
a82ee888c2 Roll Skia from 643160445720 to 7d69d275afd8 (3 revisions) (flutter/engine#50016) 
https://skia.googlesource.com/skia.git/+log/643160445720..7d69d275afd8

2024-01-24 armansito@google.com [graphite] ReadOnlyStorageBuffer ComputeStep resource type
2024-01-24 armansito@google.com [graphite][vello] BUFFER_BINDING macro
2024-01-24 kjlubick@google.com Fix includes in SkDebug_win to be base-friendly

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-24 21:24:33 +00:00
skia-flutter-autoroll
c24d1fc56b Roll Fuchsia Linux SDK from kYC2-fFgjbb36mukB... to Igt2rE-R6rgfmTRaF... (flutter/engine#50015) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-24 21:04:53 +00:00
skia-flutter-autoroll
056ba5359c Roll Skia from 9ea7cb490804 to 643160445720 (6 revisions) (flutter/engine#50014) 
https://skia.googlesource.com/skia.git/+log/9ea7cb490804..643160445720

2024-01-24 johnstiles@google.com Revert "Allow Skia to build properly when is_component_build is set."
2024-01-24 johnstiles@google.com Improve $colorize_grad_tex logic slightly.
2024-01-24 armansito@google.com [graphite][compute] Support for indirect dispatch
2024-01-24 nicolettep@google.com [graphite] Minor Vulkan graphics pipeline key improvements
2024-01-24 johnstiles@google.com Allow Skia to build properly when is_component_build is set.
2024-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 39ee283518bd to a7ae764f6888

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-24 20:35:40 +00:00
Robert Ancell
7efa9951c2 Add custom FlValue types and support their en/decoding via FlStandardMessageCodec (flutter/engine#49162) 
Add Linux support for custom data types in Flutter channels.

Fixes https://github.com/flutter/flutter/issues/140299
 2024-01-25 09:29:54 +13:00
Matan Lurey
43599a528a Do not double-increment nextId when using createSurfaceProducer with SurfaceTextures (flutter/engine#50011) 
The change is _very_ tiny, but I added some documentation as well.

After this PR, it appears we're "ready" to start using this API once it lands in stable. Hoorah!

Here are local tests using `video_player_android/example`:

## Skia

![Screenshot 2024-01-24 at 10 59 17 AM](https://github.com/flutter/engine/assets/168174/0cc890ee-4c43-47d3-8d3e-4503f5b1a545)

## Impeller

![Screenshot 2024-01-24 at 10 59 46 AM](https://github.com/flutter/engine/assets/168174/bf13a0f0-bcc7-40bf-a521-b61720dab0d9)
 2024-01-24 20:15:11 +00:00
Jim Graham
e61777cf89 [Impeller] allow non-square corner radii for fast blurs (flutter/engine#49994) 
Upgrades the fast blur shader to work with round rects and ovals that have different radii in X and Y.

Fixes https://github.com/flutter/flutter/issues/141850
Obsoletes https://github.com/flutter/engine/pull/49989
 2024-01-24 19:57:03 +00:00
skia-flutter-autoroll
12c6d2d504 Roll Dart SDK from 0f7c49da26da to e0bf6a261895 (1 revision) (flutter/engine#50009) 
https://dart.googlesource.com/sdk.git/+log/0f7c49da26da..e0bf6a261895

2024-01-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-68.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-24 19:29:13 +00:00
Tong Mu
d8b736ec94 [macOS] Fix: Memory sanitizer violated when encoding indirect strings (flutter/engine#49995) 
Fixes https://github.com/flutter/flutter/issues/142101

@cbracken However, this unit test requires the unit tests to be compiled
with `--asan` to work. Can we add this flag to CI?

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-01-24 11:18:07 -08:00
gaaclarke
029ae124b5 [Impeller] Share vulkan playground across goldens (flutter/engine#49981) 
fixes https://github.com/flutter/flutter/issues/142052

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-24 19:08:21 +00:00
Jonah Williams
31a5d5d5c9 [Impeller] use const std::unique_ptr ref for Sampler type. (flutter/engine#49974) 
The backend specific sampler libraries hold a strong reference to the native sampler objects and never clear this cache. As a result of this, we don't theoretically need rendering commands to increment a shared_ptr ref count - instead the sampler library can provide the Sampler object as a const ref and guarantee that it continues to be valid.

This allows us to reduce the amount of refcount ops for commands that use samplers.

Additionally, the sampler library uses nullptr as a sentinel for failing to construct a sampler object. Since sampler already has an isValid member that is checked - we can replace this with a specific invalid object subtype.
 2024-01-24 18:14:42 +00:00
skia-flutter-autoroll
f37eeba0cd Roll Skia from c353c00a4dcb to 9ea7cb490804 (1 revision) (flutter/engine#50005) 
https://skia.googlesource.com/skia.git/+log/c353c00a4dcb..9ea7cb490804

2024-01-24 johnstiles@google.com Add SK_API to SkString free functions.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-24 17:50:48 +00:00
Michael Brase
254f0f9829 Replace Fuchsia logging macros (FX_LOG*) with FML logging (flutter/engine#49970) 
This change updates all of the Fuchsia specific logging macros (e.g.
FX_LOG*) to use the logging macros provided by the FML library
(FML_LOG(...)). This will allow us to migrate to Fuchsia structured
logging backend in a future commit.

flutter/flutter#141924
 2024-01-24 11:42:15 -06:00
skia-flutter-autoroll
f9aaf3f990 Roll Skia from 26ac196b95c4 to c353c00a4dcb (1 revision) (flutter/engine#50004) 
https://skia.googlesource.com/skia.git/+log/26ac196b95c4..c353c00a4dcb

2024-01-24 brianosman@google.com Fix use of uninitialized memory in AVX512 stages

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-24 17:00:23 +00:00
skia-flutter-autoroll
b5d2581d60 Roll Dart SDK from 8307fb417cb9 to 0f7c49da26da (1 revision) (flutter/engine#50001) 
https://dart.googlesource.com/sdk.git/+log/8307fb417cb9..0f7c49da26da

2024-01-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-67.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-24 15:31:13 +00:00
skia-flutter-autoroll
dbd873dd86 Roll Dart SDK from 69af2ca8332f to 8115d045c95d (1 revision) (flutter/engine#49998) 
https://dart.googlesource.com/sdk.git/+log/69af2ca8332f..8115d045c95d

2024-01-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-65.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-24 08:08:16 +00:00
Matan Lurey
3fd9bd213f Fix a typo in geometry.cc#ComputeUVGeometryForRect. (flutter/engine#49986) 
Follow up to https://github.com/flutter/engine/pull/49910#pullrequestreview-1840067150.
 2024-01-24 05:44:24 +00:00
skia-flutter-autoroll
d655cb3d38 Roll Dart SDK from 838cd732e56a to 69af2ca8332f (1 revision) (flutter/engine#49990) 
https://dart.googlesource.com/sdk.git/+log/838cd732e56a..69af2ca8332f

2024-01-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-64.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-24 04:08:05 +00:00
skia-flutter-autoroll
ac3fa2f552 Roll Skia from c396b2171b16 to be4b398b4f2e (2 revisions) (flutter/engine#49988) 
https://skia.googlesource.com/skia.git/+log/c396b2171b16..be4b398b4f2e

2024-01-23 nicolettep@google.com [graphite] Fix an int value typo
2024-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ba9b221d297c to 53c4c636ae4c (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-24 00:47:50 +00:00
skia-flutter-autoroll
58e05b0e65 Roll Dart SDK from 5646ac9669f8 to 838cd732e56a (3 revisions) (flutter/engine#49982) 
https://dart.googlesource.com/sdk.git/+log/5646ac9669f8..838cd732e56a

2024-01-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-63.0.dev
2024-01-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-62.0.dev
2024-01-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-61.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-24 00:15:53 +00:00
Jonah Williams
6f0249a062 [ui] hold a strong reference to fragment program objects. (flutter/engine#49868) 
The native engine needs to hold a strong reference to fragment programs. So the dart side holding a weak ref is more or less pointless
 2024-01-24 00:08:24 +00:00
skia-flutter-autoroll
db041900f3 Roll Skia from 4e42423c7f6f to c396b2171b16 (1 revision) (flutter/engine#49987) 
https://skia.googlesource.com/skia.git/+log/4e42423c7f6f..c396b2171b16

2024-01-23 bungeman@google.com [pdf] Set DisplayDocTitle when title is set

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-23 23:58:17 +00:00
skia-flutter-autoroll
3dbc8dc62e Roll Skia from e7d10257ffb5 to 4e42423c7f6f (4 revisions) (flutter/engine#49985) 
https://skia.googlesource.com/skia.git/+log/e7d10257ffb5..4e42423c7f6f

2024-01-23 herb@google.com Fix IWYU problems
2024-01-23 herb@google.com Add Contours
2024-01-23 sharaks@google.com Merge 10 release notes into RELEASE_NOTES.md
2024-01-23 sharaks@google.com Update Skia milestone to 123

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-23 23:12:48 +00:00
Matan Lurey
b9e3df7659 Geometry Wars: Documentation Edition (flutter/engine#49910) 
Document some confusing bits of `geometry` for the next bub.

Originally this PR was to add a test and fix a bug, but that's being handled here: https://github.com/flutter/engine/pull/49938.
 2024-01-23 21:55:36 +00:00
Jason Simmons
e870bf885a Exclude the Dart SDK sdk/lib/svg/dart2js directory from the license crawl (flutter/engine#49977) 
This directory contains a file that is generated from other sources.

It is causing problems for the license script because it contains multiple copyright messages and one of the messages is partially included in the header region parsed by the script.
 2024-01-23 21:25:47 +00:00
skia-flutter-autoroll
401e11e2e0 Roll Skia from 59a70a1efc39 to e7d10257ffb5 (3 revisions) (flutter/engine#49978) 
https://skia.googlesource.com/skia.git/+log/59a70a1efc39..e7d10257ffb5

2024-01-23 nicolettep@google.com [graphite] Check if loading from MSAA when setting up Vulkan RenderPasses, pipeline keys
2024-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from a62b04845e6d to 02262d895ff3 (10 revisions)
2024-01-23 kjlubick@google.com Enforce IWYU on more src/core files

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-23 21:04:23 +00:00
Bruno Leroux
2538fd2edb [Web] Fix an assertion error due to synthesized keyboard events (flutter/engine#49087) 
## Description

On Web, browsers can emit key events with a logical key sets to `Process` during compostion.
It is usually not a problem, but in some edge cases (for instance when the browser window lost focus and some keys events were missed), the Flutter web engine might synthesize an up event with a logical key value different that the one used for the down event and this will lead to an assertion message on the framework side.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/126247.

## Tests

Adds 1 test.
 2024-01-23 20:26:12 +00:00