Jonah Williams
b35cbca6ed
[Impeller] fix missing GPU probe. ( flutter/engine#52580 )
...
Fixes https://github.com/flutter/flutter/issues/147723
The test that covers this is the benchmarks in the framework repo. Unfortunately emulators do not support the APIs needed to execute this code in the engine repo.
2024-05-06 18:59:12 +00:00
skia-flutter-autoroll
8387629491
Roll Skia from 29e77cd14063 to da772ace76ff (2 revisions) ( flutter/engine#52578 )
...
https://skia.googlesource.com/skia.git/+log/29e77cd14063..da772ace76ff
2024-05-06 kjlubick@google.com Add dedicated fuzzer for SVG parsing code
2024-05-06 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from b94ef82a4b1e to a87c5333bf91 (48 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-06 18:07:15 +00:00
skia-flutter-autoroll
48ace23439
Roll Fuchsia Linux SDK from Ieb4BPN0ZIRRgYl4y... to 27ZAbzJkEopmu0Emp... ( flutter/engine#52576 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-06 16:53:49 +00:00
skia-flutter-autoroll
9358e08209
Roll Skia from 4754c3fd6b73 to 29e77cd14063 (3 revisions) ( flutter/engine#52577 )
...
https://skia.googlesource.com/skia.git/+log/4754c3fd6b73..29e77cd14063
2024-05-06 bungeman@google.com [fontations] Treat sbix more like FreeType
2024-05-06 johnstiles@google.com Fix MSAN use-of-uninitialized-value error in libjpeg.
2024-05-06 kjlubick@google.com Make skunicode_icu for android depend only on icu headers
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-06 16:53:48 +00:00
Jason Simmons
6964119253
Skip files in the clang-tidy driver if clang-tidy crashes when processing the file ( flutter/engine#52379 )
...
Recent versions of clang-tidy have been segfaulting when processing a few of the engine source files. This patch skips over those errors so that the engine can roll Clang.
See https://github.com/flutter/flutter/issues/143178
2024-05-06 14:48:53 +00:00
skia-flutter-autoroll
7c751d83b2
Roll Skia from 2da0f29636d3 to 3bc48d128d4b (1 revision) ( flutter/engine#52574 )
...
https://skia.googlesource.com/skia.git/+log/2da0f29636d3..3bc48d128d4b
2024-05-06 rmistry@google.com Revert "Bump the npm_and_yarn group across 8 directories with 11 updates"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-06 14:45:18 +00:00
skia-flutter-autoroll
ecabda2c60
Roll Skia from 7f582d054385 to 2da0f29636d3 (1 revision) ( flutter/engine#52573 )
...
https://skia.googlesource.com/skia.git/+log/7f582d054385..2da0f29636d3
2024-05-06 49699333+dependabot[bot]@users.noreply.github.com Bump the npm_and_yarn group across 8 directories with 11 updates
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-06 13:41:37 +00:00
skia-flutter-autoroll
45fff19c4b
Roll Skia from 2365dff19ed4 to 1454154ed14e (1 revision) ( flutter/engine#52571 )
...
https://skia.googlesource.com/skia.git/+log/2365dff19ed4..1454154ed14e
2024-05-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 252d184177c3 to 69c4b5eb737c (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-06 05:53:06 +00:00
skia-flutter-autoroll
cc53ce6d04
Roll Fuchsia Linux SDK from PqcaFvWlaz5ZrFcpC... to Ieb4BPN0ZIRRgYl4y... ( flutter/engine#52569 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-05 15:07:18 +00:00
skia-flutter-autoroll
92eb43077e
Roll Fuchsia Linux SDK from QDv0tal7_BgoZx0ju... to PqcaFvWlaz5ZrFcpC... ( flutter/engine#52560 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-04 13:53:32 +00:00
skia-flutter-autoroll
0e280d9eb0
Roll Skia from f9409f6a7ad3 to 95302626a8df (1 revision) ( flutter/engine#52554 )
...
https://skia.googlesource.com/skia.git/+log/f9409f6a7ad3..95302626a8df
2024-05-03 michaelludwig@google.com [graphite] Define ScratchResourceManager
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 23:38:22 +00:00
skia-flutter-autoroll
e4e2f912c4
Roll Skia from ad143675a4d2 to f9409f6a7ad3 (1 revision) ( flutter/engine#52553 )
...
https://skia.googlesource.com/skia.git/+log/ad143675a4d2..f9409f6a7ad3
2024-05-03 bungeman@google.com [fontations] Correct CBDT glyph bounds
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 22:26:50 +00:00
skia-flutter-autoroll
921439b072
Roll Skia from 82c0277acaf8 to ad143675a4d2 (1 revision) ( flutter/engine#52552 )
...
https://skia.googlesource.com/skia.git/+log/82c0277acaf8..ad143675a4d2
2024-05-03 bungeman@google.com Fontations to vary font style with variation
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 20:17:49 +00:00
skia-flutter-autoroll
65975504c9
Roll Skia from 1b72286d0319 to 82c0277acaf8 (1 revision) ( flutter/engine#52551 )
...
https://skia.googlesource.com/skia.git/+log/1b72286d0319..82c0277acaf8
2024-05-03 bungeman@google.com Don't turn italic into oblique in FreeType
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 19:11:08 +00:00
skia-flutter-autoroll
ffd49f3d25
Roll Skia from 6ca5507db3e1 to 1b72286d0319 (2 revisions) ( flutter/engine#52550 )
...
https://skia.googlesource.com/skia.git/+log/6ca5507db3e1..1b72286d0319
2024-05-03 michaelludwig@google.com [graphite] Pare down pipeline labels' texture info details
2024-05-03 johnstiles@google.com Ensure that fImage[] always has at least one element.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 18:06:33 +00:00
skia-flutter-autoroll
360dc9896b
Roll Skia from 92d762cfe00b to 7b1e131050a0 (1 revision) ( flutter/engine#52547 )
...
https://skia.googlesource.com/skia.git/+log/92d762cfe00b..7b1e131050a0
2024-05-03 ccameron@chromium.org Remove APP15-based gainmap support
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 16:09:24 +00:00
skia-flutter-autoroll
e5c8ef3e26
Roll Skia from 37b9f707ce96 to 92d762cfe00b (1 revision) ( flutter/engine#52546 )
...
https://skia.googlesource.com/skia.git/+log/37b9f707ce96..92d762cfe00b
2024-05-03 kjlubick@google.com Roll ICU used for testing (and shipped with CanvasKit)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 15:05:49 +00:00
skia-flutter-autoroll
bd6faa1151
Roll Fuchsia Linux SDK from cScmnvKM3py9E2087... to QDv0tal7_BgoZx0ju... ( flutter/engine#52543 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 11:46:21 +00:00
skia-flutter-autoroll
b5b17ff361
Roll Dart SDK from 138695ec00bd to 33bb0f4b0770 (1 revision) ( flutter/engine#52542 )
...
https://dart.googlesource.com/sdk.git/+log/138695ec00bd..33bb0f4b0770
2024-05-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-129.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 08:12:03 +00:00
skia-flutter-autoroll
3833b53247
Roll Skia from d2f0fd0faf90 to 8f5808650129 (1 revision) ( flutter/engine#52541 )
...
https://skia.googlesource.com/skia.git/+log/d2f0fd0faf90..8f5808650129
2024-05-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 1092e40f5ba5 to 252d184177c3 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 06:29:21 +00:00
skia-flutter-autoroll
5d228f845b
Roll Dart SDK from 03b7868a71ae to 138695ec00bd (1 revision) ( flutter/engine#52539 )
...
https://dart.googlesource.com/sdk.git/+log/03b7868a71ae..138695ec00bd
2024-05-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-128.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 04:09:19 +00:00
Dustin Green
561a3c968b
[fuchsia] route fuchsia.sysmem2.Allocator pt 2 ( flutter/engine#52509 )
...
Fuchsia's fake-display will be migrating to sysmem2, which requires
fuchsia.sysmem2.Allocator to be routed.
fixes https://github.com/flutter/flutter/issues/146858
2024-05-02 18:43:30 -07:00
Jason Simmons
1b28d5a898
[et] Add Linux host_debug_unopt local engine builder ( flutter/engine#52538 )
2024-05-03 01:34:30 +00:00
Brandon DeRosier
5b35095a8e
[et] Add ios_debug_unopt build config. ( flutter/engine#52537 )
...
Resolves https://github.com/flutter/flutter/issues/147757
2024-05-03 01:28:22 +00:00
Brandon DeRosier
7130c5c3b3
[Impeller] Remove Entity capture/AiksInspector. ( flutter/engine#52526 )
...
Resolves https://github.com/flutter/flutter/issues/134748 .
This was a really fun experiment. I learned a lot from it, and it genuinely helped me solve some coverage-related problems, but the reality is it was too little too late -- by the time we had this capture system, we had already solved most of the problems that would have benefitted from this.
It's been a few months since I've used or extended the capabilities of this capture system for something, and I don't have the spare time/energy to give it the love it needs to realize the vision I had for it. I still almost exclusively use a combination of native frame captures and print debugging to solve problems.
RIP in peace.
2024-05-03 01:08:22 +00:00
skia-flutter-autoroll
c00314985f
Roll Dart SDK from 0316fa44b401 to 03b7868a71ae (1 revision) ( flutter/engine#52534 )
...
https://dart.googlesource.com/sdk.git/+log/0316fa44b401..03b7868a71ae
2024-05-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-127.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 00:03:21 +00:00
Harry Terkelsen
b28f8f5c42
[canvaskit] Round physical size to nearest whole number pixels ( flutter/engine#52467 )
...
The physical size is computed by multiplying the browser's `innerWidth`
and `innerHeight` by the `devicePixelRatio`. The physical size should be
an integer number of pixels. However, there may be some imprecision and
the result of the multiplication is not quite an integer. This change
rounds the physical size to integers before using them for drawing the
scene.
Fixes https://github.com/flutter/flutter/issues/144869
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-05-02 16:16:50 -07:00
gaaclarke
3892592ee1
Updated RBE documentation for default credentials. ( flutter/engine#52530 )
...
issue https://github.com/flutter/flutter/issues/147739
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-02 22:03:23 +00:00
Juanjo Tugores
3ec84538ca
Put the view focus functionality behind a (disabled by default) flag ( flutter/engine#52527 )
...
Put the view focus functionality behind a (disabled by default) flag
Should unblock https://github.com/flutter/flutter/pull/143259
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-02 21:27:23 +00:00
skia-flutter-autoroll
68f57e4fc2
Roll Skia from f9671ecda7da to 716e757c1ffb (5 revisions) ( flutter/engine#52528 )
...
https://skia.googlesource.com/skia.git/+log/f9671ecda7da..716e757c1ffb
2024-05-02 jvanverth@google.com [graphite] Add option to DrawAtlas to allow use of storage textures
2024-05-02 nscobie@google.com Make ATrace backend record arguments as sub-events in Android framework
2024-05-02 bungeman@google.com [fontations] Use CBDT advances
2024-05-02 egdaniel@google.com [Graphite] Fix Emscripten build after label change.
2024-05-02 jvanverth@google.com [graphite] Change GraphiteDawnTestContext to use new devicelost setup
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 21:19:08 +00:00
Brandon DeRosier
89f27d1eda
[Impeller] Remove checkerboard. ( flutter/engine#52524 )
...
I added this feature a long time ago on a rainy afternoon, and @gaaclarke mentioned that it's being removed from the framework anyway. We should just remove this if that's the case.
2024-05-02 20:28:35 +00:00
skia-flutter-autoroll
74975dd5df
Roll Skia from 894919003036 to f9671ecda7da (3 revisions) ( flutter/engine#52525 )
...
https://skia.googlesource.com/skia.git/+log/894919003036..f9671ecda7da
2024-05-02 bungeman@google.com [fontations] Properly place CBLC/CBDT glyphs
2024-05-02 robertphillips@google.com Disable GM_matrixconvolution_bigger/_biggest on the Nexus7/Tegra3
2024-05-02 egdaniel@google.com [Graphite] Add initial label support on Textures.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 20:08:08 +00:00
skia-flutter-autoroll
8ca89d7b37
Roll Skia from a0f0c08f31d8 to 894919003036 (2 revisions) ( flutter/engine#52522 )
...
https://skia.googlesource.com/skia.git/+log/a0f0c08f31d8..894919003036
2024-05-02 egdaniel@google.com [Graphite] Add support for setting label on backend Buffers.
2024-05-02 armansito@google.com [graphite] Wire up VelloScene::append
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 18:50:18 +00:00
skia-flutter-autoroll
49c8b74ba3
Roll Skia from 4dbf9ad5fa1e to a0f0c08f31d8 (3 revisions) ( flutter/engine#52521 )
...
https://skia.googlesource.com/skia.git/+log/4dbf9ad5fa1e..a0f0c08f31d8
2024-05-02 nicolettep@google.com [graphite] Add convenience method to get SharedContext from RecorderPriv
2024-05-02 sunnyps@chromium.org graphite: Explicitly destroy Dawn buffers
2024-05-02 borenet@google.com Remove Perf-Mac10.15.7-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-Graphite_Dawn_Metal job
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 17:41:23 +00:00
skia-flutter-autoroll
3435d9f4c2
Roll Skia from d37c4d0c5e5d to 4dbf9ad5fa1e (3 revisions) ( flutter/engine#52520 )
...
https://skia.googlesource.com/skia.git/+log/d37c4d0c5e5d..4dbf9ad5fa1e
2024-05-02 jvanverth@google.com [graphite] Add flag to mark Plots as 'full'.
2024-05-02 jvanverth@google.com [graphite] Restructure ComputePathAtlas::recordDispatches to take list
2024-05-02 brianosman@google.com Ignore mipmapping requessts for externally wrapped WebGL textures
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 16:36:15 +00:00
Alexander Aprelev
8bd9e60267
Use new Dart_PortEx api to ensure SendPort can be rebuild properly. ( flutter/engine#52498 )
...
Currently used Dart API can not be reliably used to rebuild dart
SendPort object, [new API was introduced in dart sdk
](https://dart.googlesource.com/sdk/+/de4029ee1ba3bc89d839ae7d2fd0706d29abae58 )
and this PR moves flutter engine to use that new API.
BUG: https://github.com/flutter/flutter/issues/147469
2024-05-02 09:06:38 -07:00
skia-flutter-autoroll
730fc72a32
Roll Dart SDK from faabc0c9861c to 040d3f6c4c45 (1 revision) ( flutter/engine#52518 )
...
https://dart.googlesource.com/sdk.git/+log/faabc0c9861c..040d3f6c4c45
2024-05-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-125.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 14:40:05 +00:00
skia-flutter-autoroll
1f1e058498
Roll Fuchsia Linux SDK from PIHl-e41i3mzbriG1... to cScmnvKM3py9E2087... ( flutter/engine#52516 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 10:24:24 +00:00
skia-flutter-autoroll
5c3698ae87
Roll Skia from 7c68b9c33b08 to 6c41182ab9bb (2 revisions) ( flutter/engine#52513 )
...
https://skia.googlesource.com/skia.git/+log/7c68b9c33b08..6c41182ab9bb
2024-05-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 85cd35a9f8f3 to 1092e40f5ba5 (8 revisions)
2024-05-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 816f6abb4c9a to b94ef82a4b1e (20 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 06:33:57 +00:00
Jonah Williams
bea69e9024
[Impeller] allow for one more active swapchain image. ( flutter/engine#52505 )
...
Currently the rendering performance is less stable with this patch: https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dcomplex_layout_scroll_perf_impeller__timeline_summary&selected=commit%3D40592%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DPixel_7_Pro%252Cdevice_version%253Dnone%252Chost_type%253Dlinux%252Csub_result%253D99th_percentile_frame_rasterizer_time_millis%252Ctest%253Dcomplex_layout_scroll_perf_impeller__timeline_summary%252C
The reason I suspect that is that we're signaling the semaphore at the start of the raster thread. This means that we're limiting the actual number of pending presents to 1, as we also need to account for the CPU access. Increase this and the max texture count to 3, to allow 2 pending presents and one image worked on by the CPU.
2024-05-02 05:05:18 +00:00
Ian Hickson
8966c48831
Remove rasterizerTracingThreshold, checkerboardRasterCacheImages, and checkerboardOffscreenLayers, etc ( flutter/engine#52446 )
2024-05-02 04:35:04 +00:00
skia-flutter-autoroll
51b0f37818
Roll Skia from 81ccf3ab27ee to 97aa3f4cf290 (1 revision) ( flutter/engine#52508 )
...
https://skia.googlesource.com/skia.git/+log/81ccf3ab27ee..97aa3f4cf290
2024-05-02 johnstiles@google.com Flatten branches from complex path of analytic_rrect_coverage_fn.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 03:09:22 +00:00
skia-flutter-autoroll
869cc3d144
Roll Dart SDK from 04d373e0a99d to 30b5422ec1b2 (1 revision) ( flutter/engine#52507 )
...
https://dart.googlesource.com/sdk.git/+log/04d373e0a99d..30b5422ec1b2
2024-05-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-122.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 02:26:45 +00:00
Brandon DeRosier
dfed7164a1
et phone home ( flutter/engine#52506 )
...
<img width="684" alt="image" src="https://github.com/flutter/engine/assets/919017/2dcdc7e9-b0e1-434d-9078-1de6a3d57d35 ">
2024-05-02 01:36:30 +00:00
David Iglesias
829ae71a50
[web] Expose browser_detection through ui_web. ( flutter/engine#52380 )
...
This PR moves the core of `browser_detection.dart` to a location in `dart:ui_web` so it can be used by apps and plugins.
In order for the code to be a little bit tidier in ui_web, it's encapsulated in a singleton instance that can be accessed through `BrowserDetection.instance` or a top level global `browser` in `dart:ui_web`.
## Issues
* Needed to fix: https://github.com/flutter/flutter/issues/128943
* Needed to land: https://github.com/flutter/flutter/pull/147346
## Tests
Updated affected tests. Mostly the update was to call the methods from `web_ui.browser.methodName` rather than a global scope. Also split the tests for this module in two files:
* `engine_browser_detect_test.dart` - with the tests specific to the engine (capability detection, etc...)
* `browser_detect_test.dart` - only the tests pertaining to the "core" of the library.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-02 01:20:10 +00:00
Jonah Williams
590b254c1a
[Impeller] remove incremental allocation during filled path tessellation. ( flutter/engine#52401 )
...
Don't allocate a polyline (and resulting std::vectors) when performing convex tessellation. Instead use a listener pattern and iterate through path verbs.
2024-05-02 01:05:55 +00:00
Jackson Gardner
bd471f7a8a
[skwasm] Don't mark the backend texture as mipmapped, since it isn't. ( flutter/engine#52501 )
...
We don't actually produce mipmaps for any of the textures generated through the `TextureSourceImageGenerator`, even if it is requested of us. So we shouldn't mark the texture as mipmapped in this case. This will allow rendering mechanisms to fall back to a non-mipmapped rendering strategy as needed.
2024-05-02 00:08:05 +00:00
skia-flutter-autoroll
e431e0190d
Roll Dart SDK from f5a429107c87 to 04d373e0a99d (2 revisions) ( flutter/engine#52503 )
...
https://dart.googlesource.com/sdk.git/+log/f5a429107c87..04d373e0a99d
2024-05-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-121.0.dev
2024-05-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-120.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-01 22:14:13 +00:00
Jenn Magder
374dc4a4e3
Migrate PlatformMessageHandlerIos to ARC ( flutter/engine#52226 )
...
Smart pointers support ARC as of https://github.com/flutter/engine/pull/47612 , and the unit tests were migrated in https://github.com/flutter/engine/pull/48162 .
Migrate `PlatformMessageHandlerIos` from MRC to ARC. Clean up the `#include`s.
Part of https://github.com/flutter/flutter/issues/137801 .
2024-05-01 21:07:07 +00:00
chunhtai
c4415fb8e0
macOS fluttertextinputplugin drops selector called if no client ( flutter/engine#52495 )
...
The observed behavior is that if a keypress both reach framework and flutter textinputplugin selector and the keypress handler in framework causes the the textinputplugin to resign first responder, the selector will still go through even if the textinputplugin has already resigned.
The pr makes it so textinputplugin will ignore these selector call
fixes https://github.com/flutter/flutter/issues/143270
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-01 20:57:39 +00:00
