1871 Commits

Author SHA1 Message Date
Hixie
d001a93211 Rev the Dart SDK to pick up better dartdocs 2015-10-28 14:50:19 -07:00
Ian Hickson
7aebaa00f4 Merge pull request #1851 from Hixie/MixedViewport-bug
Fix crash when removing a card in card_collection
2015-10-28 14:47:40 -07:00
Hixie
8b2b4927e9 rev-flutter tool
A tool to update all the pubspec.yaml versions when we're revving flutter.
2015-10-28 14:45:02 -07:00
Chinmay Garde
e2bcd97706 Merge pull request #1855 from chinmaygarde/master
Add missing dart:ui embedder entry points for the precompiler
2015-10-28 14:34:14 -07:00
Chinmay Garde
4e3c92ff9a Add missing dart:ui embedder entry points for the precompiler 2015-10-28 14:27:29 -07:00
Collin Jackson
fef799e908 Merge pull request #1831 from collinjackson/media_query
Media query class for querying viewport dimensions
2015-10-28 14:14:08 -07:00
Matt Perry
4b7d00a19f Merge pull request #1853 from mpcomplete/tests
Some initial unit tests for package signing
2015-10-28 16:57:27 -04:00
Hans Muller
f6b20de855 Support dismissing the modal bottom sheet with a drag gesture 2015-10-28 13:08:34 -07:00
Matt Perry
fd3ad472f9 Add some unit tests for flx signing code. 2015-10-28 15:52:34 -04:00
Collin Jackson
dbc0cfd116 Media query class for querying viewport information 2015-10-28 12:34:57 -07:00
Adam Barth
234f792f51 Remove ui.view
We don't use ui.view anymore.
2015-10-28 11:15:59 -07:00
Hixie
c1de88233e Fix crash when removing a card in card_collection
MixedViewport didn't use the building:true flag when locking itself, so
when it caused a rebuild of its children, we assumed that nobody was
allowed to mark things dirty below the list, and things crashed when
Inherited people did in fact rebuild.

Also:
 - default offset for MixedViewport
 - don't bother rebuilding if the underlying RenderObject is going to
   rebuild anyway for some reason
 - better docs for the "items must have keys" assert
 - keep the FlipComponent stuff together in test_widgets.dart
2015-10-28 10:31:12 -07:00
Adam Barth
939835ea49 Merge pull request #1848 from abarth/icon_size
Icon should use an enum rather than an int for size
2015-10-28 09:13:23 -07:00
Adam Barth
dcfdbc25d5 Merge pull request #1849 from abarth/rm_edges
Remove unused material edge definition
2015-10-28 09:13:11 -07:00
Adam Barth
1e5b25be8c Icon should use an enum rather than an int for size
Material design icons are defined to work at specific sizes: 18, 24, 36, 48.
The current API doesn't reflect that and just takes a size int. If an invalid
size is chosen an error is printed to the console and no icon shows up.

Fixes #1816
2015-10-28 08:55:49 -07:00
Adam Barth
e839883ecd Remove unused material edge definition
The one we actually use is in material.dart.
2015-10-28 07:34:11 -07:00
Adam Barth
4bbd3d543c Switch clients from ui.view to ui.window 2015-10-28 07:16:56 -07:00
Adam Barth
b7436de274 Rev pub packages 2015-10-27 20:15:58 -07:00
Adam Barth
5968c60e48 Re-host View on Window
After this patch View is just a shim on top of Window and can be removed
easily.
2015-10-27 17:55:07 -07:00
Adam Barth
02d75552c9 Start booting up the new binding system for window
Currently this code isn't completely wired up, but this patch is an incremental
step in that direction.
2015-10-27 16:53:52 -07:00
Chinmay Garde
921243f4c0 In the precompiler, add an explicit dependency to the target that generates dart_ui.dart 2015-10-27 16:41:02 -07:00
Chinmay Garde
33f8df16d1 Remove ios_active_arch and directly specify arm64 vs armv7 preference via target_cpu 2015-10-27 15:58:55 -07:00
krisgiesing
659b5c7067 Merge branch 'master' into tap-fix 2015-10-27 15:24:04 -07:00
Jason Simmons
7983d5f0c5 Fix a memory leak in CanvasImageDecoder
CanvasImageDecoder is instantiated with a callback into a Dart closure.
That closure was holding references to the ImageDecoder and the returned
Image.  The circular reference between the ImageDecoder and the callback
prevented the objects from being GCed, resulting in leakage of the image
buffer.

CanvasImageDecoder will now destroy the callback after it is invoked,
thus releasing its handle to the Dart closure.
2015-10-27 15:05:30 -07:00
Hans Muller
66d2fc33a3 Adds modal bottom sheets: showModalBottomSheet() 2015-10-27 14:57:18 -07:00
Kris Giesing
36023151e7 #1834 Reset tap state after successful tap 2015-10-27 14:47:09 -07:00
Hixie
e34aefbd8a Notification of metrics changes.
The Rendering layer binding now multiplexes the dart:ui metrics change
notification so that multiple consumers can all listen to the change.
2015-10-27 14:32:00 -07:00
Adam Barth
1e51daa530 Add the position at which drags start
Fixes #1807
2015-10-27 14:25:03 -07:00
Adam Barth
d25ff94259 Merge pull request #1832 from abarth/tap_position
Add a position to the onTap callback
2015-10-27 14:20:35 -07:00
Adam Barth
0d1e58072b Add a position to the onTap callback
Fixes #1807
2015-10-27 14:12:54 -07:00
Ian Hickson
4b56dd50a0 Track scroll position
- Change RouteArguments to pass the route's BuildContext rather than
  the Navigator. This caused the bulk of the examples/ and .../test/
  changes (those are mostly mechanical changes). It also meant I could
  simplify Navigator.of().

- Make initState() actually get called when the State's Element is in
  the tree, so you can use Foo.of() functions there. Added a test for
  this also.

- Provide a RouteWidget so that routes have a position in the Widget
  tree. The bulk of the route logic is still in a longer-lived Route
  object for now.

- Make Route.setState() only rebuild the actual route, not the whole
  navigator.

- Provided a Route.of().

- Provided a Route.writeState / Route.readState API that tries to
  identify the clients by their runtimeType, their key, and their
  ancestors keys, up to the nearest ancestor with a GlobalKey.

- Made scrollables hook into this API to track state. Added a test to
  make sure this works.

- Fix the debug output of GestureDetector and the hashCode of
  MixedViewport.

- Fixed ScrollableWidgetListState<T> to handle infinite lists.
2015-10-27 13:46:07 -07:00
Adam Barth
9c8196b4d1 Use VoidCallback in more places
We still use special-purpose typedefs in the gesture code for symmetry with
other gesture callbacks.

Fixes #1827
2015-10-27 11:19:44 -07:00
Adam Barth
b507577966 Merge pull request #1822 from abarth/custom_shifted_box
Add CustomOneChildLayout
2015-10-27 11:10:00 -07:00
Adam Barth
c8b9359b7d Merge pull request #1825 from abarth/tap_tracker
Make TapTracker and TapGesture private classes
2015-10-27 11:09:34 -07:00
Adam Barth
fbfbd57f65 Add CustomOneChildLayout
A CustomOneChildLayout is a widget that lets you perform a custom layout in the
simplified setting of sizing and positioning a single child.
2015-10-27 11:04:32 -07:00
Adam Barth
e448acb008 Use VoidCallback for onPressed and friends
Previous these callbacks were leaking the implementation detail that they were
triggered by taps. In a later patch, we're going to add a parameter to
GestureTapCallback that these callbacks won't have.

Related to #1807
2015-10-27 10:21:10 -07:00
Adam Barth
1099c7bcd4 Make TapTracker and TapGesture private classes
We don't want to expose these from the gesture package. This patch moves
DoubleTapGestureRecognizer into tap.dart so we can make TapTracker and
TapGesture private to that file.
2015-10-27 10:08:48 -07:00
Ian Hickson
5f2c17b1ff Merge pull request #1819 from Hixie/new-enabled-approach
Use the presence of handler to determine 'enabled'
2015-10-27 09:30:34 -07:00
Adam Barth
b5639a1959 Merge pull request #1814 from abarth/fix_right_align
Right-aligned text paints offscreen sometimes
2015-10-26 19:41:24 -07:00
Hixie
6e31784bf4 Use the presence of handler to determine 'enabled'
Instread of an explicit 'enabled' bool, this uses the presence of the
event handler to determine if a widget is enabled or not. This means
that if you've not passed a handler, your widget will be disabled, which
makes sense, since it wouldn't work anyway.

Adds this feature to checkbox, and ports raised button, flat button, and
radio buttons to this new model.

Adds a checkbox to card_collection that can be disabled.

Hide a (basically bogus) hint from the (soon to be disabled) strong hint
mode in the analyzer that this reveals.
2015-10-26 17:35:41 -07:00
Hixie
c0c7f9d412 Make ink wells animate their highlight. 2015-10-26 17:24:14 -07:00
Chinmay Garde
ee995e31a6 Merge pull request #1815 from chinmaygarde/master
On iOS, avoid the unnecessary dependency on sky_snapshot (which generates a script snapshot)
2015-10-26 17:02:09 -07:00
Chinmay Garde
47b52a4d1c On iOS, avoid the unnecessary dependency on sky_snapshot (which generates a script snapshot) 2015-10-26 17:01:48 -07:00
Adam Barth
96087ea239 Right-aligned text paints offscreen sometimes
We were assuming that the text extended from 0.0 to its max content width.
That's not correct for right-aligned text. Instead, we need to layout the text
again at the width we want it to occupy.
2015-10-26 15:49:47 -07:00
krisgiesing
e3f8f0959f Merge pull request #1809 from krisgiesing/event-fix
Handle mouseover events in pointer event conversion
2015-10-26 15:35:54 -07:00
Kris Giesing
b681670ed9 Handle mouseover events in pointer event conversion
Fixes #1806
2015-10-26 15:29:43 -07:00
Hixie
800ff311e7 Radio button 'disabled' state.
Also:
 - give card_collection an option to turn on or off the edit widgets
 - give card_collection an option to control text alignment (when not editing)
 - give card_collection a "dump" option to aid debugging
 - make the gesture detector report which gestures it is listening to
2015-10-26 14:49:58 -07:00
krisgiesing
ff77fbed1e Merge pull request #1799 from krisgiesing/tap-fix
Restore previous tap behaviors: no timeout, one pointer
2015-10-26 13:49:23 -07:00
Adam Barth
1fa881bed1 Merge pull request #1798 from abarth/inherit_text_style
Be explicit about whether text styles inherit
2015-10-26 13:42:01 -07:00
Kris Giesing
e6e77318d0 Restore previous tap behaviors: no timeout, one pointer
Don't use a timeout to cancel tap tracking. Track only one primary pointer
and ignore non-primary pointers. Update tests to reflect desired behaviors.

Fixes #1779, #1780, #1781.
2015-10-26 13:41:29 -07:00