DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
32,520 Commits 882 Branches 1,069 Tags
Commit Graph

24649 Commits

Author SHA1 Message Date
Matej Knopp
b2eced8b39 Reland: [web] Ensure handled key event is not propagated to IME (flutter/engine#47099) 
This PR relands https://github.com/flutter/engine/pull/46829, which got
reverted in https://github.com/flutter/engine/pull/47086 because of
https://github.com/flutter/flutter/issues/136857.

There are no changes in the PR compared to the reverted one. The issue
are missing `keyup` events in the integration test, which triggers
assertion in `KeyboardBindings` and which should be fixed by
https://github.com/flutter/flutter/pull/136874.

Changes:
- Raw keyboard event is handled during capture phase. This is to ensure
that the framework processes the event before reaching to IME text area
and raw keyboard can stop the propagation for handled events.
- `RawKeyboard` event handler is invoked from `KeyboardBinding` event
handler. This is to prevent race condition because both handlers now run
in capture phase and `KeyboardBinding` needs to process the event first.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-11-03 15:50:40 +01:00
skia-flutter-autoroll
ef663bd741 Roll Fuchsia Linux SDK from YS7vrarYI-cHvhuBT... to ho9FqsUD0hxh0b8to... (flutter/engine#47638) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-03 04:07:20 +00:00
skia-flutter-autoroll
ccd6910c4b Roll Skia from 5b6d295cc39b to 9f6022736b14 (1 revision) (flutter/engine#47633) 
https://skia.googlesource.com/skia.git/+log/5b6d295cc39b..9f6022736b14

2023-11-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 7c271ce5dd45 to d0d3db899486 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-03 02:16:16 +00:00
Jonah Williams
e914c1d207 [Impeller] Use specialization constant for blur pipelines decal feature. (flutter/engine#47617) 
Minor specialization constant cleanup
 2023-11-03 00:56:59 +00:00
skia-flutter-autoroll
da55f0c57d Roll Skia from 3b8e2b391d03 to 5b6d295cc39b (1 revision) (flutter/engine#47630) 
https://skia.googlesource.com/skia.git/+log/3b8e2b391d03..5b6d295cc39b

2023-11-02 bungeman@google.com Remove SkStream "synchronous" comment

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-03 00:29:09 +00:00
skia-flutter-autoroll
51c27f95b9 Roll Skia from 86d15e651ae0 to 3b8e2b391d03 (1 revision) (flutter/engine#47627) 
https://skia.googlesource.com/skia.git/+log/86d15e651ae0..3b8e2b391d03

2023-11-02 lovisolo@google.com Upgrade Skia repository to Go 1.19.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 23:34:30 +00:00
LongCatIsLooong
ef6aba043c Reland "Expose more methods on ui.Paragraph: lines" (#47584) (flutter/engine#47623) 
The diff is in [this commit](305d930fe1).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-02 23:16:16 +00:00
Jim Graham
80a1a1d5ec [Impeller] Deprecate the exposed Rect fields (flutter/engine#47592) 
The exposed Rect fields prevent future optimizations which will depend on changing the internal storage format.
 2023-11-02 22:00:58 +00:00
skia-flutter-autoroll
4c13e2a321 Manual roll Dart SDK from e6df03a57636 to 3c45f68cd7c2 (4 revisions) (flutter/engine#47620) 
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/e6df03a57636..3c45f68cd7c2

2023-11-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-91.0.dev
2023-11-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-90.0.dev
2023-11-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-89.0.dev
2023-11-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-88.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 21:51:04 +00:00
skia-flutter-autoroll
cc61e6c8a6 Roll Skia from 66e06117294e to 86d15e651ae0 (1 revision) (flutter/engine#47619) 
https://skia.googlesource.com/skia.git/+log/66e06117294e..86d15e651ae0

2023-11-02 kjlubick@google.com Remove deprecated SkFontID

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 21:38:48 +00:00
skia-flutter-autoroll
b860e7584d Roll Skia from 94000281b7d6 to 66e06117294e (1 revision) (flutter/engine#47616) 
https://skia.googlesource.com/skia.git/+log/94000281b7d6..66e06117294e

2023-11-02 johnstiles@google.com Fix fuzzer-discovered assertion with duplicate symbols.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 20:46:05 +00:00
skia-flutter-autoroll
6ffefaf1f0 Roll Skia from 306543797674 to 94000281b7d6 (1 revision) (flutter/engine#47614) 
https://skia.googlesource.com/skia.git/+log/306543797674..94000281b7d6

2023-11-02 lehoangquyen@chromium.org Graphite: calculate UBO/SSBO's binding size in DrawPass::writeUniforms.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 19:48:52 +00:00
godofredoc
835041d0ec Remove mirroring workflow from engine. (flutter/engine#47603) 
Master branch is about to be archived and there is no need to keep mirroring main branch to master.

Bug: https://github.com/flutter/flutter/issues/121564

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-02 18:59:26 +00:00
Alexander Thomas
c45478aba6 Add a temporary fallback to move run_binary_file_analysis.py (flutter/engine#47598) 
In https://dart-review.googlesource.com/c/sdk/+/332963, I'm merging the runtime/third_party directory into the SDK's top level third_party directory. This updates the script so that both the old and the new location are supported to avoid breaking the the rolls from Dart SDK to Flutter engine when the change above gets submitted.
 2023-11-02 18:49:01 +00:00
skia-flutter-autoroll
98d4718ee2 Roll Skia from 2b3472da9888 to 306543797674 (5 revisions) (flutter/engine#47610) 
https://skia.googlesource.com/skia.git/+log/2b3472da9888..306543797674

2023-11-02 borenet@google.com [infra] Add alias for Go
2023-11-02 nicolettep@google.com [graphite] Small misc. comment doc fixes
2023-11-02 kjlubick@google.com Revert "Decouple SVG from SkFontMgr::RefDefault()"
2023-11-02 jvanverth@google.com [graphite] Simplify PerEdgeAAQuadRenderStep frag shader and varyings.
2023-11-02 johnstiles@google.com Treat non-side-effecting prefix expressions as trivial.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 18:46:41 +00:00
Victoria Ashworth
0f94842122 Run tests on either macOS 12 or 13 (flutter/engine#47606) 
In preparation for migrating our fleet to macOS 13, we're updating tests to run on either macOS 12 or macOS 13.

I have run all tests on macOS 13: https://docs.google.com/spreadsheets/d/1-KOSOSF7uVA4KuqSMn9xz3IIJW78u8SXLYK2OAfe_Qg/edit?usp=sharing&resourcekey=0-df8Bj5PRS1IPBccPDdvRCQ

Note: I'm leaving subtests of `Linux linux_web_engine` on Mac-12 since they're currently incompatible with MacOS 13.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-02 18:37:10 +00:00
Dan Field
23b2847379 [Impeller] Skia gold for flutter_tester dart tests. (flutter/engine#47066) 
This removes skips for the golden tests in `//testing/dart/canvas_test.dart` and instead passes them up to Skia gold.

Adds a utility class for dealing with Skia gold from these tests, as well as the existing fuzzy identical image comparison for tests that just want to do in memory comparison of images generated from the same test.

Removes the old golden files that were in tree.

Part of https://github.com/flutter/flutter/issues/53784
 2023-11-02 17:48:28 +00:00
skia-flutter-autoroll
205f99e82f Roll Skia from 70634da5c783 to 2b3472da9888 (5 revisions) (flutter/engine#47608) 
https://skia.googlesource.com/skia.git/+log/70634da5c783..2b3472da9888

2023-11-02 hitawala@chromium.org Graphite: Store wgpu::TextureAspect and create plane WGPUTextureView
2023-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 7096daca8739 to 7c271ce5dd45 (1 revision)
2023-11-02 briansalomon@gmail.com Make Graphite-Dawn compile against emsdk.
2023-11-02 kjlubick@google.com Add SkFontMgr to SkFontConfigInterface::makeTypeface
2023-11-02 kjlubick@google.com Revert "Remove modules/skplaintexteditor"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 17:45:49 +00:00
Jonah Williams
c8d04e64dc [Impeller] add support for specialization constants. (flutter/engine#47432) 
Adds support for Specialization constants to Impeller for our usage in the engine. A motivating example has been added in the impeller markdown docs.

Fixes https://github.com/flutter/flutter/issues/136210
Fixes https://github.com/flutter/flutter/issues/119357
 2023-11-02 17:32:08 +00:00
skia-flutter-autoroll
d6b5a87f11 Roll Skia from 8299245af8a8 to 70634da5c783 (1 revision) (flutter/engine#47604) 
https://skia.googlesource.com/skia.git/+log/8299245af8a8..70634da5c783

2023-11-02 johnstiles@google.com Use WGSL select for trivial ternary expressions only.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 16:50:02 +00:00
Victoria Ashworth
88bfe1a6da Fix race condition in Platform View Scenario tests (flutter/engine#47575) 
Fixes race condition in Platform View Scenario tests, see https://github.com/flutter/flutter/issues/126627 for description of issue.

Fixes https://github.com/flutter/flutter/issues/137547 and https://github.com/flutter/flutter/issues/126627.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-02 15:16:46 +00:00
skia-flutter-autoroll
936eb5a66e Roll Fuchsia Linux SDK from pvAbHwPJtOuEpHJN7... to YS7vrarYI-cHvhuBT... (flutter/engine#47602) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 15:09:02 +00:00
Jason Simmons
cd32fb6c82 Update DisplayList tests to explicitly select the Roboto font (flutter/engine#47493) 
Skia is removing the API for constructing a default typeface (see https://issues.skia.org/issues/305780908)

Fixes https://github.com/flutter/flutter/issues/137565
 2023-11-02 14:42:00 +00:00
skia-flutter-autoroll
2abeacb556 Roll Skia from 54be0f6f205b to 8299245af8a8 (2 revisions) (flutter/engine#47601) 
https://skia.googlesource.com/skia.git/+log/54be0f6f205b..8299245af8a8

2023-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f2b199b522ce to c604e04c8136 (3 revisions)
2023-11-02 egdaniel@google.com [Graphite] Add query for resourceType to graphite Resources

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 14:34:56 +00:00
skia-flutter-autoroll
93f05eaa6a Roll Skia from ff5e220c57e4 to 54be0f6f205b (1 revision) (flutter/engine#47599) 
https://skia.googlesource.com/skia.git/+log/ff5e220c57e4..54be0f6f205b

2023-11-02 kjlubick@google.com Decouple SVG from SkFontMgr::RefDefault()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 13:50:05 +00:00
Jim Graham
049bac3249 Add some important comments to some of the FilteContents methods (flutter/engine#47567) 
Fixes https://github.com/flutter/flutter/issues/137703

Also clarified and fixed indentation on docstring comment for the public method `FilterContents::GetSourceCoverage`
 2023-11-02 05:30:51 +00:00
skia-flutter-autoroll
3da43ec90d Roll Skia from 39776c81d2b8 to 66bbeb412a59 (1 revision) (flutter/engine#47588) 
https://skia.googlesource.com/skia.git/+log/39776c81d2b8..66bbeb412a59

2023-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from dacb7ead0e0b to 7096daca8739 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 03:21:56 +00:00
Jim Graham
edba128d44 [Impeller] Move all remaining Rect construction to named factories (flutter/engine#47582) 
The named factories provide better readability and do not imply an internal storage format (which will be changing soon).
 2023-11-02 02:03:09 +00:00
skia-flutter-autoroll
3ead96c860 Roll Skia from 945284d57785 to 65b5bcd6c365 (12 revisions) (flutter/engine#47581) 
https://skia.googlesource.com/skia.git/+log/945284d57785..65b5bcd6c365

2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 95905c606f46 to 445a3a5c87f5
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 36b938f4bd91 to f97385e8c26a
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from d6a42e45bfea to 1747ffa9b114
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 1f541ad1b6bd to 8449ce1d6518
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 10d18c9f187d to dacb7ead0e0b (1 revision)
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from a536f59bdab0 to 95905c606f46
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 18d9396e0e23 to 36b938f4bd91
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from b842291db7bb to d6a42e45bfea
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from b8b6ef8feccd to 1f541ad1b6bd
2023-11-01 jamesgk@google.com [graphite] Put render step uniforms in storage buffer
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 59b3b32e331b to 10d18c9f187d (2 revisions)
2023-11-01 robertphillips@google.com [graphite] Add some Vulkan result checking

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 01:50:50 +00:00
auto-submit[bot]
03c46c6b49 Reverts "Expose more methods on ui.Paragraph: lines" (flutter/engine#47584) 
Reverts flutter/engine#46125
Initiated by: LongCatIsLooong
This change reverts the following previous change:
Original Description:

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-02 01:12:20 +00:00
LongCatIsLooong
b263241336 Expose more methods on ui.Paragraph: lines (flutter/engine#46125) 
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-02 00:39:36 +00:00
Gray Mackall
01700054b7 Change FTL test to high capacity device (flutter/engine#47579) 
Changes the FTL tests to use a high capacity device

Similar PR from packages repo: https://github.com/flutter/packages/pull/5224

The list of devices (and their capacity) is visible through the [3rd option here "Google APIs Explorer"](https://firebase.google.com/docs/test-lab/android/available-testing-devices), without a login to any project.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-02 00:18:12 +00:00
skia-flutter-autoroll
7eb0b18964 Roll Skia from 613abdf2c895 to 945284d57785 (1 revision) (flutter/engine#47564) 
https://skia.googlesource.com/skia.git/+log/613abdf2c895..945284d57785

2023-11-01 kjlubick@google.com Remove modules/skplaintexteditor

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-01 19:39:22 +00:00
skia-flutter-autoroll
e62a89e9db Roll Skia from 84e1dc3af49e to 613abdf2c895 (4 revisions) (flutter/engine#47560) 
https://skia.googlesource.com/skia.git/+log/84e1dc3af49e..613abdf2c895

2023-11-01 jvanverth@google.com [graphite] PerEdgeAAQuadRenderStep: remove unused and unneeded vars.
2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from a55ce4970dfd to 18d9396e0e23
2023-11-01 johnstiles@google.com Add placeholder skcms_Transform.h to skcms.
2023-11-01 egdaniel@google.com [Graphite] Add uniqueID to all Resources.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-01 17:53:55 +00:00
skia-flutter-autoroll
256e982e21 Roll Skia from 4594e2ef3ee8 to 84e1dc3af49e (1 revision) (flutter/engine#47558) 
https://skia.googlesource.com/skia.git/+log/4594e2ef3ee8..84e1dc3af49e

2023-11-01 jvanverth@google.com Reland "[graphite] Simplify vertex processing for PerEdgeAAQuadRenderStep."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-01 17:07:05 +00:00
Jason Simmons
cce2f9ced2 Consolidate all the copies of the OpenFixtureAsSkData testing helper function (flutter/engine#47491) 2023-11-01 17:03:05 +00:00
skia-flutter-autoroll
6bff1ecbfb Roll Skia from 8fabb1ce2065 to 816d41255105 (1 revision) (flutter/engine#47553) 
https://skia.googlesource.com/skia.git/+log/8fabb1ce2065..816d41255105

2023-11-01 brianosman@google.com Remove ColorStopOptimizer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-01 14:32:18 +00:00
skia-flutter-autoroll
378ba1156a Roll Fuchsia Linux SDK from _TyF0etsONe5aqCbM... to G6icdRMZm9dD9Oky1... (flutter/engine#47551) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-01 13:31:12 +00:00
skia-flutter-autoroll
daf9ad02af Roll Skia from 34ef20100acc to 83d6345dd3c2 (1 revision) (flutter/engine#47538) 
https://skia.googlesource.com/skia.git/+log/34ef20100acc..83d6345dd3c2

2023-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 61b4a8b2976d to 2c27f85a1e61 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-01 05:28:00 +00:00
skia-flutter-autoroll
4f0f03e58d Roll Dart SDK from 99fa0283f9d7 to 448293573e98 (1 revision) (flutter/engine#47534) 
https://dart.googlesource.com/sdk.git/+log/99fa0283f9d7..448293573e98

2023-11-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-84.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-01 02:19:18 +00:00
Brandon DeRosier
480a99ac7e [Impeller] Include cstdint everywhere that uint32_t is used. (flutter/engine#47533) 
Sprinkle cstdint everywhere that it's used. Unblocks the next impeller-cmake bump.

Ran into include issues during the build for the most recent impeller-cmake bump: https://github.com/bdero/impeller-cmake/pull/20

Going to add an optional libcxx STL build to help avoid stuff like this later (in the AAOS action items).
 2023-11-01 01:42:14 +00:00
Brandon DeRosier
7cf7fc7d1c [Impeller] Fix nullopt access and simplify coverage computation in GetSubpassCoverage. (flutter/engine#47347) 
Follow up for comments in https://github.com/flutter/engine/pull/46130.

This case shouldn't actually be possible today, but we should be able to
make this reasonably testable without goldens... added an issue to
follow-up here: https://github.com/flutter/flutter/issues/137356
This branch noise will also melt away with:
https://github.com/flutter/flutter/issues/137306
 2023-10-31 18:15:56 -07:00
Brandon DeRosier
849bb11c9e [Impeller] OpenGLES: Ensure frag/vert textures are bound with unique texture units. (flutter/engine#47218) 
The fragment shader texture bindings will smash into the texture units
used for the vertex shader bindings if the vertex and fragment shaders
both have textures.

Entities doesn't use any pipelines that tickle this case.
 2023-10-31 18:05:07 -07:00
skia-flutter-autoroll
61356479d0 Roll Fuchsia Linux SDK from LCfhx_lTRJI51G0zc... to _TyF0etsONe5aqCbM... (flutter/engine#47532) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-01 00:44:58 +00:00
Jonah Williams
a0b00f5fe3 [Impeller] stencil buffer record/replay instead of MSAA storage. (flutter/engine#47397) 
When restoring from a backdrop filter, replay the clip affecting cmds into a new stencil buffer instead of storing 4x MSAA stencil buffer.

Fixes https://github.com/flutter/flutter/issues/137561
Fixes https://github.com/flutter/flutter/issues/137448
Fixes https://github.com/flutter/flutter/issues/137302

Helps https://github.com/flutter/flutter/issues/137108
 2023-11-01 00:23:37 +00:00
Chris Bracken
44c1e92369 [macOS] Delete FlutterCompositor tests (flutter/engine#47527) 
The tests for FlutterCompositor are not useful. The current tests test two things:
1. That the mocks we set up behave the way we set them up to behave.
2. That the implementation of FlutterCompositor is the current implementation of FlutterCompositor.

As an example, consider FlutterCompositorTest.TestPresent: 70317028f2/shell/platform/darwin/macos/framework/Source/FlutterCompositorTest.mm (L107-L137)

Ostensibly, this test verifies that the onPresent callback configured in our fake FlutterViewProvider implementation is called when FlutterCompositor::Present() is called.

However, taking a look at the mocking setup:
70317028f2/shell/platform/darwin/macos/framework/Source/FlutterCompositorTest.mm (L47-L85)

We do the following:
1. Mock out FlutterSurfaceManager such that when a surface is requested, we hand back a mock surface. A little gross since we're relying on some knowledge of implementation details of the compositor, but let's take this as reasonable for now.
2. We mock out `FlutterSurface asFlutterMetalTexture` to return a mock texture. Again, we're getting a bit deep into implementation details that the test shouldn't know about, but let's assume this gets us somewhere.
3. We mock out `FlutterSurfaceManager present:notify:` to actually call the `onPresent` callback if it's passed in.

In effect, we're testing that:
1. We configured our mock for `FlutterSurfaceManager present:notify:` to call onPresent.
2. That `FlutterCompositor::Present` actually calls `FlutterSurfaceManager present:notify:` despite that being a simple implementation detail of that call.

This removes these tests. I have filed the following issue to track refactoring this class for testability and adding tests: https://github.com/flutter/flutter/issues/137648

Encountered these tests as part of deflaking and cleaning up memory allocations throughout the macOS desktop tests.

Issue: https://github.com/flutter/flutter/issues/137648
Issue: https://github.com/flutter/flutter/issues/104789
Issue: https://github.com/flutter/flutter/issues/127441
Issue: https://github.com/flutter/flutter/issues/124840

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-01 00:11:52 +00:00
Brandon DeRosier
483ca29940 [Impeller] Place Rect statics under the Rect template. (flutter/engine#47529) 
`Rect::Intersection(a, b)` instead of `Intersection(a, b)`, etc.

Make them usable with other Rect variants, although `RoundOut` is not useful for integer rectangles, for example.
 2023-10-31 23:57:58 +00:00
gaaclarke
b4647d2ef8 [Impeller] updated ios benchmark link (flutter/engine#47515) 
This md references `new_gallery_impeller_ios__transition_perf` which is
no longer updated.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-31 15:35:48 -07:00
gaaclarke
52fcefb32a Made clang tidy use arm64 if on an arm64 mac. (flutter/engine#47494) 
fixes https://github.com/flutter/flutter/issues/137260

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
 2023-10-31 15:35:36 -07:00
Brandon DeRosier
eb6c33cee1 [Impeller] Allow 3D scenes to render when MSAA is not supported. (flutter/engine#47217) 
Before, Impeller Scene would render nothing on the GLES backend when used through Aiks.
 2023-10-31 22:31:56 +00:00