dependabot[bot]
c15f2e9384
Bump github/codeql-action from 2.2.8 to 2.2.9 ( flutter/engine#40877 )
...
Bump github/codeql-action from 2.2.8 to 2.2.9
2023-04-03 09:43:26 +00:00
Yegor
e55fd93f5f
[web] remove obsolete object caches; simplify native object management ( flutter/engine#40862 )
...
[web] remove obsolete object caches; simplify native object management
2023-04-03 04:31:16 +00:00
Chinmay Garde
743b066d9f
[Impeller] Add a Stage 2 pass to the Vulkan shader compilation pipeline. ( flutter/engine#40873 )
...
[Impeller] Add a Stage 2 pass to the Vulkan shader compilation pipeline.
2023-04-03 00:23:04 +00:00
Kingtous
bcaa44592e
[Linux] fix: make textures thread-safe on linux ( flutter/engine#40478 )
...
Make textures GHashTable thread-safe
2023-04-03 11:30:04 +12:00
skia-flutter-autoroll
2129e53dda
Roll Skia from 47d56658e6bf to 51fa1d5813d3 (2 revisions) ( flutter/engine#40866 )
...
Roll Skia from 47d56658e6bf to 51fa1d5813d3 (2 revisions)
2023-04-02 06:26:36 +00:00
Casey Hillers
5a226729ad
Revert "[web] remove obsolete object caches; simplify native object management" ( flutter/engine#40861 )
...
Reverts flutter/engine#40617
See b/276167870. This is causing a build breakage to Google testing for
all web projects.
2023-04-01 18:55:02 -07:00
skia-flutter-autoroll
8aea49351b
Roll Skia from e3aa2ce8a38b to 47d56658e6bf (1 revision) ( flutter/engine#40858 )
...
Roll Skia from e3aa2ce8a38b to 47d56658e6bf (1 revision)
2023-04-01 22:18:35 +00:00
Chinmay Garde
fc7d1fbd95
[Impeller] Remove redundant TargetPlatformNeedsSL. ( flutter/engine#40857 )
...
TargetPlatformNeedsSL was true for all target platforms.
I believe we reworked this after we started embedding metadata in IPLR
files perhaps? In any case, this seemed unused and was making the code
harder to read. Just a cleanup that I didn't want to include in the
compiler rework for SPIRV.
2023-04-01 14:53:49 -07:00
Chinmay Garde
1a5b150113
[Impeller] Make validation logs non-fatal by default. ( flutter/engine#40855 )
...
[Impeller] Make validation logs non-fatal by default.
2023-04-01 19:13:11 +00:00
Chinmay Garde
a65edb5819
[Impeller] Apply binding base correction to all shader variants. ( flutter/engine#40854 )
...
[Impeller] Apply binding base correction to all shader variants.
2023-04-01 18:31:22 +00:00
Chinmay Garde
0f0507b570
[Impeller] Add external synchronization to Vulkan queues access. ( flutter/engine#40848 )
...
Fixes https://github.com/flutter/flutter/issues/123883
2023-04-01 11:26:33 -07:00
Jonah Williams
b48571cbea
[Impeller] convert filters to half precision ( flutter/engine#40832 )
...
[Impeller] convert filters to half precision
2023-04-01 05:21:17 +00:00
gaaclarke
8f385d6532
[Impeller] migrated more golden images ( flutter/engine#40835 )
...
issue: https://github.com/flutter/flutter/issues/123790
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-03-31 20:07:13 -07:00
Zachary Anderson
45e3c0920f
Revert "[web] Move text editing nodes outside of shadowDOM" ( flutter/engine#40847 )
...
Reverts flutter/engine#39688
Looks like this is causing the roll to the framework to fail. See
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_long_running_tests_4_5/34083/overview
```
00:03 [32m+1[0m[31m -1[0m: Hello World App enable accessibility [1m[31m[E][0m[0m
JavaScriptException (500): javascript error: Cannot read properties of null (reading 'querySelector')
(Session info: headless chrome=96.0.4664.0)
package:webdriver/src/handler/w3c/utils.dart 57:9 parseW3cResponse
package:webdriver/src/handler/w3c/core.dart 59:19 W3cCoreHandler.parseExecuteResponse
package:webdriver/src/async/web_driver.dart 260:37 WebDriver.execute.<fn>
package:webdriver/src/common/request_client.dart 96:32 AsyncRequestClient.send
===== asynchronous gap ===========================
test_driver/smoke_web_engine_test.dart 41:40 main.<fn>.<fn>
===== asynchronous gap ===========================
package:test_api/src/backend/declarer.dart 215:9 Declarer.test.<fn>.<fn>
===== asynchronous gap ===========================
package:test_api/src/backend/declarer.dart 213:7 Declarer.test.<fn>
===== asynchronous gap ===========================
package:test_api/src/backend/invoker.dart 258:9 Invoker._waitForOutstandingCallbacks.<fn>
00:03 [32m+1[0m[31m -1[0m: Hello World App (tearDownAll)[0m
```
2023-03-31 20:05:46 -07:00
Jonah Williams
6874163ca9
[Impeller] take advantage of native decal sampling, blend cleanups ( flutter/engine#40839 )
...
[Impeller] take advantage of native decal sampling, blend cleanups
2023-04-01 02:11:35 +00:00
Yegor
0d6952f097
Revert "[web] use callConstructor for FinalizationRegistry due to bug… ( flutter/engine#40841 )
...
… in dart2js (#40798 )"
This reverts commit 5281ec18556a4775594e81f456c2a8ab785fa322.
The original PR resulted in a silent failure.
2023-03-31 18:13:12 -07:00
Zachary Anderson
a9ee0142d5
Revert "Add ui_web to embedder.yaml so that the analyzer knows about it." ( flutter/engine#40840 )
2023-03-31 17:56:14 -07:00
Jonah Williams
513f3772b6
[Impeller] Migrate gaussian blur to half precision. ( flutter/engine#40800 )
...
[Impeller] Migrate gaussian blur to half precision.
2023-04-01 00:54:31 +00:00
skia-flutter-autoroll
a817cbaedf
Roll Skia from 33f80c07a09c to 4d1e9cabf0c8 (3 revisions) ( flutter/engine#40836 )
...
Roll Skia from 33f80c07a09c to 4d1e9cabf0c8 (3 revisions)
2023-03-31 23:18:46 +00:00
htoor3
c32816a82c
[web] Move text editing nodes outside of shadowDOM ( flutter/engine#39688 )
...
[web] Move text editing nodes outside of shadowDOM
2023-03-31 23:13:21 +00:00
Mouad Debbar
c8039e2544
[web] Fix canvasKitVariant test ( flutter/engine#40833 )
...
[web] Fix canvasKitVariant test
2023-03-31 23:06:33 +00:00
Yegor
5281ec1855
[web] use callConstructor for FinalizationRegistry due to bug in dart2js ( flutter/engine#40798 )
...
[web] use callConstructor for FinalizationRegistry due to bug in dart2js
2023-03-31 22:48:15 +00:00
godofredoc
793e8e5ebb
Remove ios-release-nobitcode from engine v2 builders. ( flutter/engine#40830 )
...
Remove ios-release-nobitcode from engine v2 builders.
2023-03-31 22:41:11 +00:00
Jackson Gardner
109dba62a1
Add ui_web to embedder.yaml so that the analyzer knows about it. ( flutter/engine#40827 )
...
Add ui_web to embedder.yaml so that the analyzer knows about it.
2023-03-31 21:30:17 +00:00
skia-flutter-autoroll
96f8457914
Roll Skia from 2b86c6d364d0 to 33f80c07a09c (1 revision) ( flutter/engine#40826 )
...
Roll Skia from 2b86c6d364d0 to 33f80c07a09c (1 revision)
2023-03-31 21:16:32 +00:00
Jonah Williams
f67fd036d6
[Impeller] Increase precision of texture coordinate input ( flutter/engine#40803 )
...
[Impeller] Increase precision of texture coordinate input
2023-03-31 20:56:01 +00:00
Zachary Anderson
284b13faae
Revert "[macOS] Change view ID to signed" ( flutter/engine#40829 )
...
Reverts flutter/engine#39958
Failing the roll to the framework starting with
https://github.com/flutter/flutter/pull/123893
One example:
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20dart_plugin_registry_test/21819/overview
2023-03-31 13:52:57 -07:00
Zachary Anderson
342f3ce824
Fix pretty list printer to handle nulls ( flutter/engine#40825 )
...
Fix pretty list printer to handle nulls
2023-03-31 20:20:04 +00:00
Jason Simmons
5735652166
[Impeller] Declare gradient shader inputs as high precision to avoid overflows. ( flutter/engine#40806 )
...
[Impeller] Declare gradient shader inputs as high precision to avoid overflows.
2023-03-31 20:08:54 +00:00
Harry Terkelsen
89f12f767f
Revert "Re-enable LTO and roll buildroot to enable sINLINING_LIMIT" ( flutter/engine#40822 )
...
Reverts flutter/engine#40808
Regresses benchmarks:
https://flutter-flutter-perf.skia.org/e/?numCommits=100&queries=test%3Dweb_benchmarks_canvaskit
2023-03-31 12:35:59 -07:00
Tong Mu
d3bbe5cb8a
[macOS] Change view ID to signed ( flutter/engine#39958 )
...
This PR makes view ID signed from unsigned int64.
Initially, I made view IDs unsigned because they were opaque anyway. As
I'm working deeper into multiview, I found some issues that made me
think signed is better:
* Unsigned integers are worse
* Sometimes you want negative values to represent special values.
* Unsigned integers are dangerous (if compared with signed ones by
mistake.)
* Unsigned integers are not needed
* We're very unlikely to reach that big anyway.
* Almost all other languages support only signed integers.
* Also JavaScript only supports up to 51 bits of integer.
Therefore I think it's better to change them to signed int64, especially
before these APIs are widely used by developers.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-03-31 12:11:49 -07:00
skia-flutter-autoroll
bd145d476a
Roll Skia from 5f965db93be3 to 2b86c6d364d0 (4 revisions) ( flutter/engine#40823 )
...
Roll Skia from 5f965db93be3 to 2b86c6d364d0 (4 revisions)
2023-03-31 18:46:09 +00:00
Loïc Sharma
f4f8988c2a
Complete the update semantics embedder API migration ( flutter/engine#40773 )
...
Complete the update semantics embedder API migration
2023-03-31 18:40:42 +00:00
skia-flutter-autoroll
5c20d020db
Roll Skia from 38cbca906011 to 5f965db93be3 (7 revisions) ( flutter/engine#40821 )
...
Roll Skia from 38cbca906011 to 5f965db93be3 (7 revisions)
2023-03-31 16:01:38 +00:00
Zachary Anderson
afe2be4024
Clean up gn script goma logic a bit ( flutter/engine#40817 )
2023-03-31 08:23:33 -07:00
Zachary Anderson
db6bf07686
Revert "[Impeller] Use Vulkan by default ( #40809 )" ( flutter/engine#40820 )
...
This reverts commit 35efb76a0606844593208ce0c6722aeb9c6b89cf.
Reverting for https://github.com/flutter/flutter/issues/123859
2023-03-31 08:05:36 -07:00
skia-flutter-autoroll
799576572a
Roll Skia from f6c1eefd4600 to 38cbca906011 (2 revisions) ( flutter/engine#40816 )
...
Roll Skia from f6c1eefd4600 to 38cbca906011 (2 revisions)
2023-03-31 14:08:22 +00:00
Dan Field
5e18c462d3
[Impeller] Reland move more files to core. ( flutter/engine#40812 )
...
[Impeller] Reland move more files to core.
2023-03-31 06:53:22 +00:00
Dan Field
6c649e4ba9
[Impeller] Skip TextRotated golden test. ( flutter/engine#40818 )
...
[Impeller] Skip TextRotated golden test.
2023-03-31 06:50:05 +00:00
Dan Field
35efb76a06
[Impeller] Use Vulkan by default ( flutter/engine#40809 )
...
[Impeller] Use Vulkan by default
2023-03-31 05:05:56 +00:00
Jackson Gardner
63dac880c4
Re-enable LTO and roll buildroot to enable sINLINING_LIMIT ( flutter/engine#40808 )
...
Re-enable LTO and roll buildroot to enable `sINLINING_LIMIT`
2023-03-31 04:09:55 +00:00
Brandon DeRosier
2b0d541321
[Impeller] iOS/macOS: Only wait for command scheduling prior to present ( flutter/engine#40781 )
2023-03-30 17:41:14 -07:00
skia-flutter-autoroll
f06d79cea2
Roll Skia from 9b2e538f1367 to f6c1eefd4600 (4 revisions) ( flutter/engine#40807 )
...
Roll Skia from 9b2e538f1367 to f6c1eefd4600 (4 revisions)
2023-03-31 00:38:24 +00:00
Dan Field
a77325dab9
Revert "[Impeller] move everything needed by the code gen template to core ( #40801 )" ( flutter/engine#40811 )
...
This reverts commit e31cf0690fe3fbb8f97bcaddeb3a953897869ce0.
2023-03-30 16:55:18 -07:00
Dan Field
81c86a261c
[Impeller] Delete dead code from reflector.cc ( flutter/engine#40805 )
2023-03-30 16:35:17 -07:00
Dan Field
e31cf0690f
[Impeller] move everything needed by the code gen template to core ( flutter/engine#40801 )
2023-03-30 16:35:02 -07:00
Jackson Gardner
1a59a35e3c
ui_web library (flutter/engine#40608 )
...
`ui_web` library
2023-03-30 23:14:18 +00:00
Jonah Williams
c44b7c1192
[Impeller] use native decal on metal and Vulkan backend ( flutter/engine#40723 )
...
[Impeller] use native decal on metal and Vulkan backend
2023-03-30 22:37:55 +00:00
gaaclarke
0407296be4
[Impeller] backfilled golden tests from playground tests in aiks_unittests. ( flutter/engine#40770 )
...
[Impeller] backfilled golden tests from playground tests in aiks_unittests.
2023-03-30 21:38:22 +00:00
dependabot[bot]
8c5378eb5e
Bump github/codeql-action from 2.2.7 to 2.2.8 ( flutter/engine#40661 )
...
Bump github/codeql-action from 2.2.7 to 2.2.8
2023-03-30 21:15:57 +00:00