Zachary Anderson
b2e44faca7
Revert "Reland: Roll clang and buildroot ( #33325 )" ( flutter/engine#33337 )
...
This reverts commit ca0e980e45b222e3e4534abe4c4e87631bf329ac.
2022-05-13 19:28:06 -07:00
Zachary Anderson
ca0e980e45
Reland: Roll clang and buildroot ( flutter/engine#33325 )
2022-05-13 18:58:18 -07:00
Zachary Anderson
1cd5517a29
Revert "Roll clang and buildroot ( #33284 )" ( flutter/engine#33311 )
...
This reverts commit da0f074eba63dddbe70d0fa597dcb662030168f4.
2022-05-12 22:23:50 -07:00
Zachary Anderson
da0f074eba
Roll clang and buildroot ( flutter/engine#33284 )
2022-05-12 17:09:24 -07:00
J-P Nurmi
f0703acbed
[Linux][A11y] use ATK_ROLE_PASSWORD_TEXT for obscured text ( flutter/engine#33179 )
2022-05-13 09:06:54 +12:00
J-P Nurmi
7c79154e8f
[Linux] read settings from XDG desktop portal if available ( flutter/engine#33100 )
...
* [Linux] read settings from XDG desktop portal if available
Fixes : flutter/flutter#101438
2022-05-13 09:06:29 +12:00
chunhtai
cad8336790
android accessibility bridge performSetText also removes string attributes ( flutter/engine#33217 )
2022-05-12 12:41:00 -07:00
Jami Couch
2397cf14a9
Add support for iOS UndoManager ( flutter/engine#31415 )
2022-05-11 12:09:06 -07:00
Chris Bracken
51d658b435
Assert Platform.executable non-empty in test ( flutter/engine#33221 )
...
When testing executable name for macOS Flutter apps, verify that it's
not the empty string. This was review feedback on
https://github.com/flutter/engine/pull/33128 which was labelled 'waiting
for tree to go green' but it was merged by the bot before I had a chance
to push the update.
Issue: https://github.com/flutter/flutter/issues/83921
2022-05-10 15:15:44 -07:00
J-P Nurmi
8a485f85fd
[Linux] add FlViewAccessible tests ( flutter/engine#32769 )
...
* [Linux] make FlViewAccessible testable
Add construct-only 'engine' property to make it possible to inject a
mock engine.
2022-05-11 09:16:10 +12:00
Justin McCandless
266615e0a2
Slightly more clean and efficient per comments on the PR ( flutter/engine#33174 )
...
Code style/efficiency cleanup on HasStrings Windows.
2022-05-10 13:34:28 -07:00
Jenn Magder
aa8857d2fc
Remove unused iOS and macOS podspecs ( flutter/engine#33115 )
2022-05-10 12:44:05 -07:00
Chris Bracken
f5a97aab99
[macOS] Set correct Platform.executable (argv[0]) ( flutter/engine#33128 )
2022-05-07 17:49:04 -07:00
Niklas Schulze
08b6b88e93
Windows: Fix regression introduced in external texture pixel format ( flutter/engine#33195 )
2022-05-07 16:58:55 -07:00
David Worsham
88c5519cfa
[fuchsia] Migrate unittests to CFv2 ( flutter/engine#32878 )
2022-05-06 18:54:05 -07:00
Chris Bracken
09285aac02
Use empty in place of size checks vs 0 ( flutter/engine#33151 )
2022-05-06 13:09:04 -07:00
Chris Bracken
1af24ccf62
Set Platform.executable on startup ( flutter/engine#33127 )
...
Previously, using Platform.executable (from dart:io) returned null (if
non-null-by-default was disabled) or threw an exception (if NNBD was
enabled) since we weren't setting it.
We now pass the executable name to Dart during VM startup based on the
first value in the FlutterProjectArgs::command_line_argv array passed to
FlutterEngineRun (or FlutterEngineInitialize) on startup. argv[0] (if
specified) is explicitly documented as being required to be the
executable name in embedder.h. In the case where no argv[0] is
specified, we instead set Platform.executable to "Flutter" in order to
avoid violating the (non-nullable) type annotation on
Platform.executable.
Note that dart::bin::SetExecutableName() does NOT make a copy of the
input string, so that value needs to be available for the entire lifetime
of the VM.
This also adds EmbedderConfigBuilder::SetExecutableName() to support
setting a fake executable name in unittests. By default, we continue to
set the name "embedder_unittest" unless overridden using this method.
See: https://api.flutter.dev/flutter/dart-io/Platform/executable.html
See: https://github.com/dart-lang/sdk/issues/48427
Issue: https://github.com/flutter/flutter/issues/83921
2022-05-05 11:14:16 -07:00
godofredoc
1df74f0938
Fix gtk targets for arm64 artifacts. ( flutter/engine#33130 )
2022-05-05 09:54:08 -07:00
godofredoc
af7fb4d98b
Move processing of flutter jars to gn. ( flutter/engine#33124 )
2022-05-04 19:59:05 -07:00
godofredoc
0c6e98ac5d
Move embedder jar file processing to GN. ( flutter/engine#33119 )
2022-05-04 18:44:06 -07:00
Chris Bracken
d19ef3092c
[embedder] Fix typo in EmbedderA11yTest ( flutter/engine#33120 )
2022-05-04 18:19:05 -07:00
Chris Bracken
418ea17248
[macOS] Fix test fixture identifier style ( flutter/engine#33118 )
...
Rename the C++ style can_composite_platform_views and native_callback
functions to the Dart-style identifiers canCompositePlatformViews and
nativeCallback in the macOS desktop test fixtures.
Also corrects the helper method identifier from CreateSimplePicture to
_createSimplePicture, thus making it library-private to help readers
understand it's a local helper.
Ref: [Flutter Style Guide](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#naming )
Ref: [Effective Dart](https://dart.dev/guides/language/effective-dart/style#do-name-other-identifiers-using-lowercamelcase )
2022-05-04 16:55:50 -07:00
Tong Mu
a1d38c5056
[Android, Keyboard] Extract KeyboardManager's external dependencies as ViewDelegate; Rework testing framework ( flutter/engine#32944 )
...
* Compilable
* Test pass
* recordChannelCallsTo
* respondToTextInputWith
* textInputPluginHasTheSecondHighestPrecedence
* All tests
* Docs
2022-05-04 13:37:09 -07:00
Justin McCandless
6caed82592
Windows HasStrings error when backgrounded ( flutter/engine#32038 )
...
Ignore errors from GetHasStrings when the app is backgrounded, as it's irrelevant then.
2022-05-03 11:12:20 -07:00
Chris Bracken
9bf86f9b6a
Win: Remove WinRT headers, Windows SDK, cppwinrt ( flutter/engine#33030 )
...
WinRT was only ever used by the Windows UWP embedder since the main
Windows embedder supports compatibility with Windows 7 and WinRT
requires a Windows SDK target version of at least 10.0.17134.0 (Windows
10, version 1803).
When, at some point, we drop support for versions of Windows earlier
than Windows 10, we'll almost certainly want to resurrect this and start
using WinRT in the main Windows embedder.
The Windows UWP embedder was removed in:
https://github.com/flutter/engine/pull/33019
Issue: flutter/flutter#102172
2022-04-30 12:08:18 -07:00
Niklas Schulze
fa609bd3fa
Windows: Add Direct3D texture interoperability support ( flutter/engine#26840 )
2022-04-30 14:13:39 +02:00
Jaeheon Yi
bcf1a7774a
Convert Gfx PlatformView to use modern TouchSource API ( flutter/engine#32877 )
2022-04-29 22:09:04 -07:00
Chris Bracken
0a84242538
WinUWP: Remove WinUWP sources, targets ( flutter/engine#33019 )
...
This removes:
* The Windows UWP emebedder sources and targets
* UWP-specific build targets
* UWP-specific code behind WINUWP #ifdefs
* UWP-specific TODOs.
* uwptool.exe sources and targets used for installing, uninstalling, and
launching UWP apps.
This is a straight removal patch, and does not land any refactorings
made possible by removal of UWP support. Those patches will land in
followup refactorings.
Tool support was removed in:
https://github.com/flutter/flutter/pull/102174
The CI target was removed in:
https://github.com/flutter/engine/pull/33012
The Recipe was removed in:
https://flutter-review.googlesource.com/c/recipes/+/29500
GN build support was removed in:
https://github.com/flutter/engine/pull/33016
Issue: https://github.com/flutter/flutter/issues/102172
2022-04-29 18:39:36 -07:00
Callum Moffat
86baf448e2
Mac trackpad gestures ( flutter/engine#31593 )
...
* Mac trackpad gestures
* Address feedback and add test
* Address feedback
* Punctuation
* Follow member naming scheme
2022-04-29 12:44:23 -07:00
Chris Yang
f6ec59fccb
iOS: A11y only disable during app resigning to background when voice over on ( flutter/engine#32820 )
2022-04-29 10:39:04 -07:00
utzcoz
acfe2ab302
Use Robolectric's Config#qualifiers to set locale for tests ( flutter/engine#32984 )
2022-04-29 09:29:04 -07:00
moko256
efd03ad7ee
Windows: Add SettingsPlugin to add theme change support in win32 ( flutter/engine#29303 )
...
* Windows: Add SettingsPlugin to separate sending and watching
* remove OnColorValuesChanged
* remove functions and test to handle brightness change from top-level window message
* add settings plugin test
* add files to licenses
* fix license
* use std::optional
* treat error
* fix comment based on code review
2022-04-29 01:10:24 -07:00
Tong Mu
e6f56a53ff
[Linux] Make unit tests abort on critical errors, and fix two such errors ( flutter/engine#32348 )
2022-04-28 15:24:05 -07:00
Naud Ghebre
ea8342fc2b
[dart_test_runner] Adapt the dart runner to implement the suite fidl protocol so that it can be used in the v2 testing framework. ( flutter/engine#32751 )
2022-04-28 12:55:55 -07:00
LongCatIsLooong
61e0edc391
[iOS] Add UITextInteraction only when inputDelegate is nil ( flutter/engine#32881 )
2022-04-28 09:44:04 -07:00
Kaushik Iska
fe2ff918ca
Only call make gl context current if not already current ( flutter/engine#32967 )
2022-04-28 12:07:31 -04:00
Emmanuel Garcia
327986ef9b
Fix SparseArray lookup in PlatformViewsController ( flutter/engine#32947 )
2022-04-27 10:19:02 -07:00
J-P Nurmi
ef3ff4212e
[Linux] add missing ATK_STATE_SENSITIVE flag ( flutter/engine#32487 )
...
Fixes : flutter/flutter#101500
2022-04-27 09:19:57 +12:00
Jason Simmons
d9de6d31cf
Disable the timeline in release mode on Android unless systrace is enabled ( flutter/engine#32909 )
2022-04-26 10:54:03 -07:00
J-P Nurmi
050055f52c
[Linux] fix and test light vs. dark theme detection ( flutter/engine#32618 )
2022-04-26 10:39:03 -07:00
Nayuta403
5f7d457e80
fix typo ( flutter/engine#32890 )
2022-04-24 21:24:04 -07:00
Jaeheon Yi
451c083982
[fuchsia] Remove spurious ERROR log ( flutter/engine#32870 )
2022-04-22 17:14:04 -07:00
lucasradaelli
58c3773f74
[fuchsia][a11y] Implements flow control for semantics. ( flutter/engine#32796 )
...
This change implements flow control mechanisms for the Accessibility
Bridge that communicates with the Fuchsia semantics services. This
ensures that Flutter acknowledges the pace in which the semantics
manager is consuming updates and only pushes more when they are ready to
be received.
This change avoids entirely touching on the problem of how to break
flutter semantic messages into batches that can fit in the FIDL
channels. This is left for a future change. All code that is related to
calculating size limits of FIDL messages is the same logic, only
changing location in the file.
Test: AccessibilityBridgeTest.BatchesLargeMessages
Bug: fxbug.dev/97596
2022-04-22 12:02:24 -07:00
Filip Filmar
34e4249037
[fuchsia] Rename the test component ime_service to text_manager ( flutter/engine#32824 )
...
This change is to reflect a rename that happened in the Fuchsia tree long ago,
and allows us to retire the name ime_service.
Issue: https://github.com/flutter/flutter/issues/102266
2022-04-21 16:32:56 -07:00
Dan Field
1431755360
Roll impeller, add impellerc and tessellator_shared to host builds ( flutter/engine#32819 )
...
* Roll to c833f7de604f5c4298216494fb7b7ff378353601
2022-04-21 13:10:11 -07:00
Ethan Wong
1da38af2ce
[macOS] Fix IME input issue caused on FlutterTextInputPlugin dealloc. ( flutter/engine#31879 )
2022-04-21 11:54:03 -07:00
Tong Mu
d5820083a5
[Linux, Keyboard] Derive keyboard layout using printable information from system ( flutter/engine#32665 )
...
* Workable layout deduction
* Compilable test
* Tests
* Remove print, format
* Use new way to pass logical key
* Use unique_ptr
* Format
* Fix matrix format
* Format
* Cleanup
* Remove duplicate
* Remove printf
* Update shell/platform/linux/fl_keyboard_manager.cc
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
2022-04-21 00:48:22 -07:00
Chris Bracken
a970f9766a
Minor unique_ptr initialization cleanup ( flutter/engine#32821 )
...
Cleans up a few cases of std::unique_ptr(new T) that could have been
using std::make_unique<T>(...).
2022-04-20 17:08:00 -07:00
William Wold
59fa2c79e1
Linux/GTK: Do not jump cursor to start on preedit change ( flutter/engine#32083 )
...
Fixes https://github.com/flutter/flutter/issues/97032
2022-04-20 10:34:03 -07:00
Greg Spencer
1be09fac9b
Add Menu.isPluginAvailable to allow query of whether menus are available on the platform. ( flutter/engine#32795 )
...
Added a "Menu.isPluginAvailable" call to allow the framework to query whether a plugin for creating platform menus is available on the current platform.
This will allow the framework MenuBar.adaptive constructor to determine, based on the availability on the platform of the plugin, whether or not to render platform menus. This replaces the old way, which was just to hard code which platforms support it (i.e. just macOS), but that won't work well if someone adds a plugin that supports a particular platform that isn't macOS.
2022-04-20 09:54:36 -07:00