1270 Commits

Author SHA1 Message Date
Yegor
f581f428e9
nullability clean-ups (#18880)
* nullability clean-ups
2020-06-08 10:55:24 -07:00
Yegor
ff6462e457
null-annotate remaining engine code (#18852)
* null-annotate remaining engine code
2020-06-05 21:00:07 -07:00
Harry Terkelsen
5741134bc0
Roll CanvasKit to 0.16.1 (#18618)
* Roll CanvasKit to 0.16.1

Fixes https://github.com/flutter/flutter/issues/58014
Fixes https://github.com/flutter/flutter/issues/56938

* Use multiple shared color arrays

* Use fresh color arrays for computeTonalColors

* Use drawColorInt

* Add TODO to use a flattened array when CanvasKit supports it
2020-06-05 14:51:44 -07:00
Yegor
2230d18612
add nullability annotations to lib/ui/painting.dart (#18374)
* add nullability annotations to lib/ui/painting.dart
2020-06-05 10:26:14 -07:00
Yegor
e87a05fbba
add nullability annotations to lib/web_ui painting.dart (#18395)
* add nullability annotations to lib/web_ui painting.dat
2020-06-05 08:20:55 -07:00
Yegor
612568c67b
add nullability annotations to ui/text.dart (#18400)
* add nullability annotations to ui/text.dart
2020-06-05 08:19:14 -07:00
Dan Field
7e38261e1a
Record path memory usage in SkPictures (#18827) 2020-06-04 15:48:25 -07:00
Yegor
fe80dff37b
null annotate window.dart (#18789) 2020-06-04 14:31:08 -07:00
nturgut
201dc00cb9
[web] Adding profile parameter to firefox (#18792)
* opening firefox with a given profile

* use .dart_tool for temporary directory. delete the directory if exits before creation
2020-06-04 13:22:13 -07:00
Yegor
4ce831e469
null-annotate semantics.dart (#18791) 2020-06-04 11:35:24 -07:00
Yegor
d30024829e
Minimize child DOM node moves in many-to-many update (#18648)
* minimize child DOM node moves in many-to-many update
2020-06-04 10:53:38 -07:00
Dan Field
343af33344
Live region announcements for iOS (#18798) 2020-06-03 19:13:04 -07:00
nturgut
895ef3375e
[web] Remove connection close on blur for desktop browsers (#18743)
* Do not close the text editing connection when an input text element is blurred (upon clicking another element on the page) on a desktop browser. keep the current behaviour for mobile browsers

* change the unit tests for blur

* refocus after blur so that the user can keep inputing text to the TextFormField

* skipping failing firefox check. active element didn't get updated in firefox in the automated test. manually checks working
2020-06-03 12:12:00 -07:00
Dan Field
25054fb470
Implement GetAllocationSize for Vertices (#18756)
* Implement GetAllocationSize for Vertices

* Reflect vertex buffer size in pictures
2020-06-03 10:35:14 -07:00
stuartmorgan
77617e47cf
Revert "null-annotate SemanticsUpdateBuilder.updateNode (#18552)" (#18785)
This reverts commit cc08940e6262ca6675eda145d7caf635e9774b4a.
2020-06-03 09:54:06 -07:00
Jason Simmons
33a1f1a4b9
Pin the analyzer version as a temporary workaround for https://github.com/dart-lang/sdk/issues/42163 (#18755)
A recent change to the analyzer package introduced an API incompatibility with
the build_resolvers package.  The analyzer package needs to be pinned to an
older version until this is resolved.
2020-06-02 16:15:15 -07:00
Dan Field
f46dde1f06
Make images contribute to Picture allocation size, more aggressively release references when dispose is called (#18706)
SkImage references get held by both our Image and Picture objects. The GC has no idea about this, and so sometimes pictures look very small when they're actually holding a reference to a large chunk of memory. This patch helps make sure that the GC can more adequately catch the real size impact of Picture objects, and combined with an upstream patch in Dart allows for much more aggressive collection of unused image related memory.
2020-06-02 15:12:06 -07:00
Chris Bracken
cc08940e62
null-annotate SemanticsUpdateBuilder.updateNode (#18552)
The underlying _updateNode call requires that all parameters be set
non-null. There's a single call site in the framework in
lib/src/semantics/semantics.dart in SemanticsNode.updateWith(). At that
call site, all parameters are either asserted non-null in the
constructor of SemanticsData or defaulted to null, with the sole
exception of textDirection.

The ergonomics of this method are currently pretty ugly and we should
consider migrating most of the defaulting and assertions that we apply
at the call site up to the definition in dart:ui. That work is filed as
https://github.com/flutter/flutter/issues/57720.
2020-06-02 14:42:36 -07:00
Chris Bracken
90eb48956c
null-annotate lib/ui/hooks.dart (#18555) 2020-06-02 09:49:50 -07:00
nturgut
6d169b8bbd
add driver for chrome 83 (#18722) 2020-06-01 19:07:25 -07:00
nturgut
ffe82a77a7
[web] runs ios unit tests (#18650)
* runs ios unit tests, if the simulator is already booted.

* address reviewer comments

* changing comments for the Safari desktop tests

* addressing reviewer comments. removing the timeout.

* change mobile browsers ver name for safari.dart

* removing then calback on browser exit, only leaving the exception callback
2020-06-01 16:52:27 -07:00
Dan Field
c9e51d074a
Make GetAllocationSize const (#18713) 2020-06-01 15:58:03 -07:00
Yegor
d501c49cce
do not lock petitparser (#18703) 2020-06-01 11:49:45 -07:00
Ferhat
cf899edecd
[web] Fix nineslice assertion (#18542)
* Fix nineslice assertion
2020-06-01 11:12:34 -07:00
Yegor
f49bd05014
implement SkPath.computeMetrics (#18667)
* implement SkPath.computeMetrics
2020-06-01 09:43:15 -07:00
Jason Simmons
175a92b467
Upgrade the meta package version for compatibility with petitparser-3.0.4 (#18700) 2020-06-01 09:36:22 -07:00
chenjianguang
89cf074d37
Setup default font manager after engine created, to improve startup performance (#18225) 2020-05-28 17:53:04 -07:00
Ferhat
506bd71415
[web] Fix child removal after reuse by other BitmapCanvas (#18604)
* Fix child removal after reuse by other BitmapCanvas
* Address review comments
2020-05-26 17:28:49 -07:00
Harry Terkelsen
1a8349888e
Revert "Update CanvasKit to 0.15.0 (#18570)" (#18600)
This reverts commit 1166a3543c86ce7ebc68b455feb0a3d927bf6583.

Reason: breaks dashboard
2020-05-26 09:51:07 -07:00
Harry Terkelsen
1166a3543c
Update CanvasKit to 0.15.0 (#18570)
Fixes https://github.com/flutter/flutter/issues/56938
2020-05-21 17:49:52 -07:00
Chris Bracken
9f4468602c
null-annotate semantics.dart (#18553)
Covers the remaining API surface of the semantics library.
2020-05-21 14:24:08 -07:00
Ferhat
7f69f0d7a9
[web] Fix arc rendering when it starts a new sub path. (#18535)
* Fix Path.addArc failure due to incorrect start position
2020-05-20 16:46:28 -07:00
Tong Mu
f3a38f0bb2
System mouse cursor: Web (#17718)
Adds system mouse cursor to the web engine.
2020-05-20 14:54:38 -07:00
Ferhat
4be3a031b6
[web] Reuse ImageElement(s) across frames (#18437)
* reuse images across frames
* Change implementation to CrossFrameCache at picture level
* Update licenses_flutter
2020-05-20 14:46:41 -07:00
Yegor
2cabca4405
compensate for DPR in canvas blur (#18484)
* compensate for DPR in canvas blur
2020-05-19 12:37:29 -07:00
Luigi Rosso
e5e843e9d4
Adding ImageShader support for CanvasKit (#18369)
* Adding ImageShader support for CanvasKit and fixing indices parameter for vertices.

* Removing trailing spaces.

* Using longer variable names.
2020-05-19 10:39:47 -07:00
Yegor
03b5f2cfd3
implement MaskFilter.blur as shadow on Safari (#18216)
* implement MaskFilter.blur as shadow on Safari
2020-05-18 11:58:49 -07:00
Yegor
cd4b83d3db
auto-pop pushed layers (#18451) 2020-05-18 10:01:37 -07:00
Yegor
570b474728
Implement local, locales, and onLocaleChanged for the web (#18137)
* implement `locale`, `locales`, and `onLocaleChanged` in the web version of `Window.

Co-authored-by: Simon Lightfoot <simon@devangels.london>
2020-05-16 10:10:32 -07:00
nturgut
c39f859f03
fix the issue in the test and remove them from the blacklist for chrome (#18441) 2020-05-15 17:47:51 -07:00
Yegor
f6847b1c17
sync ui geometry.dart into web_ui geometry.dart; add null safety annotations (#18356)
sync ui geometry.dart into web_ui geometry.dart; add null safety
2020-05-15 17:09:14 -07:00
Chris Bracken
af2b806700
null-annotate native calls in lib/ui/semantics.dart (#18436)
Also covers counterparts of these calls in web_ui.
2020-05-15 16:28:00 -07:00
Chris Bracken
fb21b34f02
null-annotate native calls in lib/ui/window.dart (#18430) 2020-05-15 15:38:57 -07:00
Chris Bracken
430a107e20
Delete unused web_ui RuntimeDelegate, Engine (#18429)
These were part of the old compositor but no longer referenced anywhere
in the web engine.
2020-05-15 14:11:56 -07:00
Ferhat
c2347aad5a [web] Implement setPreferredOrientation (#18432)
* Implement preferred orientation
* update comments
2020-05-15 13:48:20 -07:00
nturgut
cb71dcd377
Run integration tests on luci, use cipd package for Chrome (#18180)
* try to run integration tests on luci

* adds extra logs to check if chrome is on lUCI

* use the cipd chrome package for integration tests in LUCI

* add driver version for chrome 83.(cipd package has 83 now)

* no headless mode didn't worked on the bots. try the other option

* On LUCI also use chrome driver as a cipd package

* change the directory name to fit the cpid package

* adding blacklist functionality

* remove logs added for troubleshooting. remove the check that blocks int-test runs on LUCI

* add more comments to blacklists

* also use CIPD package chrome for unit tests

* addressing reviewer comments

* run integration tests first, upon reviewer request

* fix bug. keep running integration tests after unit tests

* update the logs for LUCI

* fix todo comments
2020-05-15 12:46:53 -07:00
Chris Bracken
dc7e24e15a
null-annotate lib/ui/natives.dart (#18349) 2020-05-15 09:33:11 -07:00
Jason Simmons
73e9ce878e
Manual Dart roll to 95e11bc2d30f7c1b9c49a4fc97a44c4b32fe66d8 (#18398) 2020-05-14 19:47:02 -07:00
Yegor
b37427eaaf
null-annotate compositing.dart (#18351) 2020-05-14 19:16:28 -07:00
Yegor
609519ec14
release previous canvas when picture is not painted (#18404) 2020-05-14 18:25:13 -07:00