280 Commits

Author SHA1 Message Date
Chinmay Garde
1405016707 Add a separate target for Dart coverter on FML types. (flutter/engine#14011)
The converters are still in a separate target that must be included manually. This allows targets that depend on FML but not Dart runtime not have to depend on the runtime.

Adds a test that includes this target and tests image decompression from assets. There is also a test for the standalone DartConvertor in shell_unittests but not in fml_unittests be cause FML uni-tests cannot yet launch a VM. I will work on adding fixtures for those.
2019-11-26 13:33:56 -08:00
David Worsham
5aa9e07326 Fix most fml tests on Fuchsia (flutter/engine#14007)
* Add fuchsia MessageLoopImpl; fix several tests
2019-11-25 14:16:50 -08:00
Amir Hardon
1575b8224f revert accidental change to MultipePlatformViewsTest (flutter/engine#13481) 2019-11-25 12:33:23 -08:00
Chinmay Garde
51da19b944 PR 2019-11-22 23:03:34 -08:00
Chinmay Garde
2866095b58 Setup a Metal test surface and add a new unit-test target that tests the testing utilities.
`//flutter/testing` now contains a lot of utilities used by other test targets.
This includes stuff like working with render targets that use either OpenGL or
Metal, fixtures for interacting with the Dart VM, test assertion predicates,
etc.. However, these utilities themselves are not tested as part of a standalone
test suite. Instead, only the test targets that include it exercise these
utilities. Since these are no longer trivial, a new test target has been added
that tests the testing utilities directly.
2019-11-22 23:03:34 -08:00
Jim Graham
c8ad84b60d Imagefilter wrapper object (flutter/engine#13711)
Make ImageFilter objects comparable and printable.

This will help in areas in the Widget and RenderObject trees which try to avoid marking objects for updates if a setter is called with the same value (previously all ImageFilter objects would compare as not equal and appear to be new values).
2019-11-19 13:43:06 -08:00
Todd Volkert
02a18868b3 Revert "RendererContextSwitch guard flutter's gl context rework. (#13812)" (flutter/engine#13906)
This reverts commit 7552e9370527aae8df06b43dcb6b313d9ebdb365.

This is being reverted because it caused flutter/flutter#45098
(images don't load on iOS).
2019-11-18 18:28:04 -08:00
Chris Yang
7552e93705 RendererContextSwitch guard flutter's gl context rework. (flutter/engine#13812) 2019-11-14 11:50:45 -08:00
chunhtai
7787960f0c reland add lifecycle enum (flutter/engine#13767)
This reverts commit 5e7e183369b3816650f776c767e241bb98a87276.
2019-11-13 11:26:25 -08:00
Chris Yang
590dc94eb8 Revert "Reland "Guarding EAGLContext used by Flutter #13314" (#13759)" (flutter/engine#13788)
This reverts commit 6390e62036d69c4923cc6cf2379b9eb9f25870ba.
2019-11-11 17:17:18 -08:00
Chris Yang
6390e62036 Reland "Guarding EAGLContext used by Flutter #13314" (flutter/engine#13759) 2019-11-08 20:09:18 -08:00
Chris Yang
68754a85f0 Revert "Reland "Guarding EAGLContext used by Flutter #13314" (#13755)" (flutter/engine#13757)
This reverts commit a4a346f317c867663a6d8a5d9c7909101d9b5cbd.
2019-11-08 13:44:29 -08:00
Chris Yang
a4a346f317 Reland "Guarding EAGLContext used by Flutter #13314" (flutter/engine#13755) 2019-11-08 12:26:48 -08:00
Greg Spencer
d7e49ecd5b Move TextRange from the framework to dart:ui. (flutter/engine#13747)
This removes TextRange from the framework and moves it to the engine, in preparation for using it to return text ranges from the text extent APIs, like Paragraph.getWordBoundary instead of a List<int>.

Also added new tests for TextRange.
2019-11-08 12:21:46 -08:00
Chris Yang
af43ff4a31 Revert "Always use IOSGLContextSwitch to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext (#13314)" (flutter/engine#13753) 2019-11-08 10:59:45 -08:00
Chris Yang
4953fbdd3f Always use IOSGLContextSwitch to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext (flutter/engine#13314) 2019-11-08 10:02:23 -08:00
Alexander Markov
01365aaf02 Cleanup obsolete --strong option of front-end server (flutter/engine#13735) 2019-11-07 13:34:55 -08:00
George Wright
04e239fc43 Package fml_unittests in a .far file for fml unit tests on Fuchsia (flutter/engine#13471)
Add fml_tests target for the fml unit tests on Fuchsia
2019-11-06 13:01:54 -08:00
chunhtai
5e7e183369 Revert "Issues/39832 reland (#13642)" (flutter/engine#13720)
This reverts commit a1824112a46ba1968217be011efd19d528330127.
2019-11-06 11:41:36 -08:00
chunhtai
a1824112a4 Issues/39832 reland (flutter/engine#13642)
* Reland "Added new lifecycle enum (#11913)"
2019-11-05 14:52:16 -08:00
chunhtai
2958712751 Revert "Added new lifecycle enum (#11913)" (flutter/engine#13632)
This reverts commit 583e1335bbf9842ff4dc349021c6c71e6141fffe.
2019-11-04 13:40:20 -08:00
chunhtai
583e1335bb Added new lifecycle enum (flutter/engine#11913) 2019-11-04 12:33:41 -08:00
gaaclarke
f2c70b20b4 Disabled GPUThreadMerger tests. (flutter/engine#13480)
* Disabled GPUThreadMerger tests.

* switched to a single gtest_filter argument
2019-11-01 15:20:45 -07:00
Dan Field
267c681b19 Print the output (flutter/engine#13479) 2019-11-01 14:45:17 -07:00
Dan Field
e471c4732f use check_output instead of check_call so that exceptions show the output. (flutter/engine#13478) 2019-11-01 11:17:15 -07:00
Amir Hardon
b9e04afb24 Fix stale platform view gr context on iOS (flutter/engine#13469)
When gr context is changed (this happens when sending the app to the background and then to the foreground) we need to update it for all the platform view overlay surfaces.

The update logic was caching the previous gr context to figure if it had to be updated, but after updating it for a given overlay we were updating the cached context. In apps with multiple platform views this will result in overlays with a stale gr context.

This fixes flutter/flutter#36437
And I believe it should fix flutter/flutter#36999 as well (though I don't have repro code to verify).
2019-10-31 16:51:11 -07:00
chunhtai
29b3675e23 Reland "fix fml_unittes is not run during presubmit (#13395)" (flutter/engine#13426) 2019-10-31 13:50:19 -07:00
Amir Hardon
c0be7a1bc1 Fix iOS crash when multiple platform views are in the scene (flutter/engine#13449)
Having 2 or more platform views simultaneously in the layer tree was crashing immediately on iOS with GL backend.

This regressed in #11070 which passed gl_context to a function in a loop using std::move (which meant on the second iteration the caller is no longer the owner of the field).

I added a scenarios_app test, though this test doesn't run on a physical device on CI so it would have only caught the problem when running locally (flutter/flutter#43852).
2019-10-31 10:30:15 -07:00
chunhtai
fac3f076eb Revert "fix fml_unittes is not run during presubmit (#13395)" (flutter/engine#13425)
This reverts commit e92c42f0aa4c481010e6e24106c19cd19a35754b.
2019-10-29 16:36:43 -07:00
chunhtai
e92c42f0aa fix fml_unittes is not run during presubmit (flutter/engine#13395) 2019-10-29 15:31:25 -07:00
Jason Simmons
2c61d2336b Reformat BUILD.gn files to comply with the format checker presubmit script (flutter/engine#13401) 2019-10-29 09:49:16 -07:00
George Wright
f99f00b0e3 Make flutter_tester support multithreaded testing, and run all Dart tests in both single and multithreaded configurations (flutter/engine#13273)
Make flutter_tester support multithreaded testing, and run all Dart tests in both single and multithreaded configurations

This also modifies Shell::GetUIIsolateLastError() and Shell::EngineHasLivePorts() so that they must be called from the UI task runner.
2019-10-22 14:10:57 -07:00
Jason Simmons
7f34c88350 Do not attempt to drain the SkiaUnrefQueue in the destructor (flutter/engine#13237)
SkiaUnrefQueue should be empty at destruction time.  If the queue is nonempty,
then there will be a pending drain task that will hold a reference to the
queue.  The queue can only be destructed after the drain completes and the
reference is dropped.

Drains must only be done on the queue's task runner thread, which may not be
the thread where the queue is destructed.
2019-10-21 14:14:18 -07:00
Chinmay Garde
395f1cda67 Remove incomplete static thread safety annotations. (flutter/engine#13151)
Fixes https://github.com/flutter/flutter/issues/42704.
2019-10-16 17:28:31 -07:00
Chinmay Garde
5b8089a3cc Use the fixtures mechanism for txt unit-tests and benchmarks. (flutter/engine#13180)
These tests and benchmarks can now be run without needing additional flags on the command line.
2019-10-16 16:29:55 -07:00
Matt Carroll
d632e81dd4 Move initialization into FlutterEngine (flutter/engine#12806) 2019-10-11 16:15:55 -07:00
sjindel-google
5ea9c249cd Remove use of the blobs snapshot format from unittests (flutter/engine#12563)
* Remove uses of the "blobs" snapshot format in Engine tests.

* Comments

* Rebasing against updated ELF loader API.
2019-10-10 14:03:42 +02:00
Dan Field
7fb9737129 Minimal test harness for iOS (flutter/engine#13029) 2019-10-09 21:16:11 -07:00
Chinmay Garde
1de602f0ad Ignore thread leaks from Dart VM in tsan instrumented builds. (flutter/engine#13049) 2019-10-09 18:12:57 -07:00
Dan Field
ad95a1aa04 dart analysis of tests, cleanup (flutter/engine#13033) 2019-10-09 15:13:29 -07:00
Greg Spencer
1adf6d2ed0 Add missing focusable testing info (flutter/engine#13013)
This adds a couple of instances of semantic node isFocusable info that were missing that the framework testing depends upon.
2019-10-09 09:00:24 -07:00
Chinmay Garde
3873eeabb6 Compile sanitizer suppressions list and file bugs as necessary. (flutter/engine#12991) 2019-10-08 11:33:26 -07:00
chunhtai
79ad29854f add windows embedding test (flutter/engine#12423) 2019-10-03 12:42:44 -07:00
Chris Yang
adbe301950 Remove unused imports in the scenario app (flutter/engine#12728) 2019-10-02 04:19:19 +08:00
Chris Yang
1365a37886 Reland "Add iOS platform view mutation XCUITests to the scenario app(#11652)" (flutter/engine#12707) 2019-10-02 01:51:31 +08:00
gaaclarke
d318cbd7da Resize channel buffers (flutter/engine#12402)
Made it so you can resize channel buffers by sending messages to them.
2019-10-01 10:31:25 -07:00
Chris Yang
97699cc609 Adding 'pub get' to the 'compile_xxxx.sh' in the Scenario app (flutter/engine#12699) 2019-10-01 04:10:11 +08:00
gaaclarke
2aea717b71 Started asserting the FlutterEngine is running before communicating over channels. (flutter/engine#12469)
Started asserting the FlutterEngine is running before communicating
over channels.  This changes a null pointer exception to an
NSException that will provide some meaningful data to clients
incorrectly using the engine in an add-to-app situations.
2019-09-27 15:18:45 -07:00
Jonah Williams
c341326d6a Add support for JIT release mode (flutter/engine#12446) 2019-09-27 11:20:54 -07:00
Gary Qian
2109f77212 Make kDoNotResizeDimension public so framework can use it directly (flutter/engine#12448) 2019-09-26 17:07:16 -04:00