skia-flutter-autoroll
b26ff455f5
Roll Fuchsia Linux SDK from le_-uFgRD5DjvvqgL... to PJBX8xxRnd5vCFnQM... ( flutter/engine#52376 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 23:21:29 +00:00
Jonah Williams
a9414aa74e
[Impeller] Remove additional shader bootstrap. ( flutter/engine#52368 )
...
Because these shaders must first acquire the prototype shader, it causes ContentContext creation to block. We can re-explore dealing with PSO generation in a different manner that isn't on the startup fast path.
https://github.com/flutter/flutter/issues/143540
2024-04-24 23:06:02 +00:00
Matan Lurey
b81845d228
Remove TODO I will never do: runIfNot is deprecated. ( flutter/engine#52308 )
...
🖖🏼
2024-04-24 15:40:57 -07:00
skia-flutter-autoroll
c9b48b4619
Roll Dart SDK from 38c43a01a51e to 9a0f141e9a67 (1 revision) ( flutter/engine#52373 )
...
https://dart.googlesource.com/sdk.git/+log/38c43a01a51e..9a0f141e9a67
2024-04-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-97.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 22:22:05 +00:00
Brandon DeRosier
524fc9e31b
[Impeller] Cleanup legacy StencilModes and document overdraw prevention. ( flutter/engine#52372 )
...
We don't need `kLegacyClipDecrement` or `kLegacyClipCompare` anymore, but we still need `kLegacyClipRestore` and `kLegacyClipIncrement`. So I renamed these to `kOverdrawPreventionRestore` and `kOverdrawPreventionIncrement` respectively and documented how they're used.
2024-04-24 21:58:59 +00:00
Jason Simmons
97993d97a3
Move zlib to //flutter/third_party ( flutter/engine#52366 )
...
Fixes https://github.com/flutter/flutter/issues/146598
2024-04-24 21:07:47 +00:00
Victoria Ashworth
f2c245f93e
Remove UIAccessibilityTraitKeyboardKey to fix touch typing ( flutter/engine#52333 )
...
`UIAccessibilityTraitKeyboardKey` was added in https://github.com/flutter/engine/pull/4575 so that `TextInputSemanticsObject` supported VoiceOver gestures for text editing features, such as pinch to select text, and up/down fling to move cursor. After experimenting with it, I found that those features were still available even after removing `UIAccessibilityTraitKeyboardKey`.
Fixes https://github.com/flutter/flutter/issues/94465 .
In Touch Typing Mode:
https://github.com/flutter/engine/assets/15619084/ccfe90ff-d3bc-427b-b1aa-9ec1242c0c89
In Standard Typing Mode:
https://github.com/flutter/engine/assets/15619084/c78b1fb0-0816-41fb-9dd5-ed8b8a4cda2d
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-24 21:05:13 +00:00
Brandon DeRosier
e8db04338d
[Impeller] Remove libtess2 from libflutter. ( flutter/engine#52357 )
...
- Move libtess-powered functionality into an `impeller::Tessellator` subclass called `impeller::TessellatorLibtess`.
- `impeller::Tessellator` now only contains `Tessellator::TessellateConvex` and utilities for fast circles/ellipses.
- Use `impeller::TessellatorLibtess` in geometry_benchmarks, renderer_unittests, and the C tessellator API implementation.
- Continue using `impeller::Tessellator` in Impeller, but without the libtess2 dependency.
2024-04-24 20:52:23 +00:00
skia-flutter-autoroll
5ec2bd8b2b
Roll Skia from 510b6766d907 to afcc1db27593 (2 revisions) ( flutter/engine#52367 )
...
https://skia.googlesource.com/skia.git/+log/510b6766d907..afcc1db27593
2024-04-24 egdaniel@google.com [Graphite] Add labels for buffer resources.
2024-04-24 robertphillips@google.com [graphite] Reduce shader variation due to LocalMatrixShaders
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 20:46:04 +00:00
Yegor
20e2de3a37
[web:tests] switch to new HTML DOM matcher ( flutter/engine#52354 )
...
Remove the over-architected and under-utilized `canonicalizeHtml` and `HtmlComparisonMode`. Replace with a new `hasHtml` matcher.
The new matcher produces considerably better error messages when matching fails (see `matchers_test.dart` for multiple examples). It also allows focusing on particular parts of the DOM rather than looking for a full match. This way a test can test just the functionality it cares about, and it can skip specifying what unrelated parts should look like (i.e. it prevents over-testing). For example, let's say you want to test that an `<flt-semantics>` element has an `aria-label` attribute. You can use a DOM pattern that specified just that:
```
expect(
element,
hasHtml('<flt-semantics aria-label="hello"></flt-semantics>'),
)
```
This will check for the existence of `<flt-semantics>` and `aria-label="hello"`. It will ignore everything else that's unrelated to ARIA labels. For example, the element may have its geometry specified in the `style` attribute, an `id` attribute, and many other things, but if the test doesn't care, it doesn't need to specify those things (it can, if needs to though). This also applies to `style` properties. See more examples in the `matchers_test.dart` file.
2024-04-24 20:40:06 +00:00
Jonah Williams
5360ab3084
[Impeller] use spec constant for gaussian shader, rename, and reuse vertex sources. ( flutter/engine#52361 )
...
Reduces shader count slightly, and reduces duplication of source code for vertex stages that are identical.
Part of https://github.com/flutter/flutter/issues/143540
2024-04-24 19:31:46 +00:00
Jonah Williams
6dca56fb0e
[Impeller] delete points compute shader. ( flutter/engine#52346 )
...
We only use this for drawPoints, a rarely used API. On local tests, this is just as fast with the CPU backend implementations.
While this was intended to be the first in a series of compute based rendering experiments, it hasn't really been worth the carrying cost. So lets shrink the complexity and and remove another shader to boot.
Fixes https://github.com/flutter/flutter/issues/147184
2024-04-24 18:24:06 +00:00
Byoungchan Lee
011c50a4c5
[darwin] Update pixel format handling in FlutterTexture ( flutter/engine#52326 )
...
CVPixelBuffers from the application can have arbitrary pixel formats. However, current implementation doesn't support all pixel formats. To address this, add a comment to the FlutterTexture class to clarify which pixel formats are supported. Also, reject unsupported pixel formats so that the application can handle them properly.
Fixes [#147242 ](https://github.com/flutter/flutter/issues/147242 ).
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-24 18:10:17 +00:00
Jonah Williams
15e063537f
[Impeller] make drawAtlas always use porterduff or vertices_uber shader ( flutter/engine#52348 )
...
The drawAtlas component of https://github.com/flutter/engine/pull/52345 . DrawAtlas did not have the same advanced blend/overlapping issues as draw vertices because of the sorting and generation of the sub-atlas, but given that the vertices uber shader exists we can just use that instead.
Will eventually allow deleting the other drawVertices special case shaders.
2024-04-24 17:58:08 +00:00
Jenn Magder
382620c0ef
Migrate ios_surface files to ARC ( flutter/engine#52139 )
...
Smart pointers support ARC as of https://github.com/flutter/engine/pull/47612 , and the unit tests were migrated in https://github.com/flutter/engine/pull/48162 .
Migrate `ios_surface` classes from MRC to ARC.
Decorate C functions that take or return Objective-C objects or structs containing Objective-C objects with [`cf_audited_transfer`](https://clang.llvm.org/docs/AutomaticReferenceCounting.html#auditing-of-c-retainable-pointer-interfaces ).
Part of https://github.com/flutter/flutter/issues/137801 .
2024-04-24 17:54:09 +00:00
skia-flutter-autoroll
79e3ae8c6f
Roll Skia from b5dd23bd29df to 510b6766d907 (16 revisions) ( flutter/engine#52364 )
...
https://skia.googlesource.com/skia.git/+log/b5dd23bd29df..510b6766d907
2024-04-24 michaelludwig@google.com [graphite] Move YUVATextureProxies logic into Image_YUVA
2024-04-24 jamesgk@google.com [graphite][cleanup] Remove unused kIgnoreMaskFilter flag
2024-04-24 jcgregorio@google.com Remove Pixel3 and Intel BayTrail devices.
2024-04-24 brianosman@google.com Reland "Reland "Restore affine bitmap procs""
2024-04-24 kjlubick@google.com Add define to signal Android FontMgr is available
2024-04-24 jamesgk@google.com [graphite] Precalculation for analytic circle blur
2024-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from cbf986e97789 to edc6a51fe9de
2024-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 24edbde4082b to e9508b902e1a
2024-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 822c202b73bc to b0e42fbd5e63
2024-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 453d00b44c6b to c9b24124977b
2024-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f231db78374b to 8ff7d8bf1899 (3 revisions)
2024-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b24132ef5cdf to 26741f478094
2024-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from eb81b28b0318 to b24132ef5cdf (11 revisions)
2024-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 9aec4b969291 to 76f7f8cfea80 (1 revision)
2024-04-24 armansito@google.com [graphite] compute-msaa8 atlas path rendering mode
2024-04-24 armansito@google.com [graphite][dawn] Ensure r8unorm storage usage is not advertised in WASM
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 17:48:05 +00:00
Jason Simmons
b84c057bfb
Fix some warnings reported by recent versions of clang-tidy ( flutter/engine#52349 )
...
* Invalid enum values in the embedder library
* Disable a check that warns about standard usage of GTK macros in the Linux embedder
2024-04-24 17:46:19 +00:00
skia-flutter-autoroll
608dcf5739
Roll Skia from e15464e6e982 to b5dd23bd29df (1 revision) ( flutter/engine#52353 )
...
https://skia.googlesource.com/skia.git/+log/e15464e6e982..b5dd23bd29df
2024-04-24 michaelludwig@google.com [graphite] Support one-time-only tasks in Recordings
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 15:50:21 +00:00
skia-flutter-autoroll
d0326c9d7d
Roll Dart SDK from 5227dc5103f6 to f470eaaf6e6d (1 revision) ( flutter/engine#52359 )
...
https://dart.googlesource.com/sdk.git/+log/5227dc5103f6..f470eaaf6e6d
2024-04-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-95.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 14:04:22 +00:00
skia-flutter-autoroll
83a95410b8
Roll Dart SDK from cf9144942ca1 to 60cb97ab64e6 (1 revision) ( flutter/engine#52351 )
...
https://dart.googlesource.com/sdk.git/+log/cf9144942ca1..60cb97ab64e6
2024-04-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-93.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 02:37:13 +00:00
Jonah Williams
c428e84a76
[Impeller] delete unused geometry API. ( flutter/engine#52347 )
...
We don't use this!
2024-04-24 00:23:17 +00:00
Zachary Anderson
f1ac2c5650
[et] Don't require the --verbose flag when requesting a ci/ build ( flutter/engine#52339 )
...
https://github.com/flutter/engine/pull/52021 introduced a bug where `ci`
build could only be specified when also passing the `--verbose` flag.
This PR fixes the issue so that by default the `help` message will only
show `ci` builds when `--verbose` is passed to `help`, but the `ci`
builds can be specified even without the `--verbose` flag.
2024-04-23 16:46:11 -07:00
Chris Bracken
b0c35a4aca
[macOS] Disable FlutterEngineTest.BackgroundColor ( flutter/engine#52341 )
...
This was re-enabled in https://github.com/flutter/flutter/issues/124677 after fixing leaks in https://github.com/flutter/engine/pull/50832 . Since this test involves an NSWindow, there are separate fixes that should be landed to reduce flakes related to lack of NSWindow close calls in the tests. See related AppKit bug report filed at http://www.openradar.me/FB13291861 .
Issue: https://github.com/flutter/flutter/issues/145728
Related issue: https://github.com/flutter/flutter/issues/124677
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-23 23:21:05 +00:00
skia-flutter-autoroll
e90ec7a9b0
Roll Skia from cdede8e2e18b to e15464e6e982 (2 revisions) ( flutter/engine#52344 )
...
https://skia.googlesource.com/skia.git/+log/cdede8e2e18b..e15464e6e982
2024-04-23 brianosman@google.com Add isArc to SkPath
2024-04-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 99fa81c4c166 to 822c202b73bc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 23:17:23 +00:00
skia-flutter-autoroll
61d1329e81
Roll Dart SDK from 6a670b60eb06 to cf9144942ca1 (1 revision) ( flutter/engine#52338 )
...
https://dart.googlesource.com/sdk.git/+log/6a670b60eb06..cf9144942ca1
2024-04-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-92.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 22:37:48 +00:00
Jonah Williams
feca43deaf
[Impeller] Reland: Compute UVs in vertex stage. ( flutter/engine#52303 )
...
Compute texture UVs in the vertex stage. Reland of https://github.com/flutter/engine/pull/52106 which was reverted to investigate golden failures during the x64 to arm64 mac switch.
2024-04-23 22:11:47 +00:00
Chinmay Garde
4d092e34c1
[Impeller] Add DriverInfoVK::IsEmulator and a log dumper for driver info. ( flutter/engine#52337 )
...
For https://github.com/flutter/engine/pull/52087
2024-04-23 22:10:50 +00:00
Chris Bracken
2929b70726
Add containsCommand matcher ( flutter/engine#52306 )
...
Adds a `Matcher` that can be used against a `List<ExecutedProcess>` to check if a command that matches a predicate was executed. Fails if no such command was found.
An alternative would be to take a single regex instead of a closure.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-23 21:23:05 +00:00
skia-flutter-autoroll
4722356522
Roll Skia from f09c6745031c to cdede8e2e18b (1 revision) ( flutter/engine#52335 )
...
https://skia.googlesource.com/skia.git/+log/f09c6745031c..cdede8e2e18b
2024-04-23 scroggo@google.com Do not create the image filter cache just to purge it
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 21:15:36 +00:00
Jackson Gardner
7b6f8eae5e
[skwasm] Fix sampling options for low filter quality to match CanvasKit. ( flutter/engine#52331 )
...
These sampling options didn't match up with what CanvasKit was using. I also changed the tests to render images in all four image qualities on a golden.
2024-04-23 19:58:17 +00:00
Chinmay Garde
257115c860
[Impeller] Fix Vulkan validation error on latest MoltenVK. ( flutter/engine#52332 )
...
Fixes https://github.com/flutter/flutter/issues/147254
2024-04-23 19:56:04 +00:00
skia-flutter-autoroll
066a0bd37a
Roll Skia from 21563606e32d to f9d6a2cf4179 (1 revision) ( flutter/engine#52330 )
...
https://skia.googlesource.com/skia.git/+log/21563606e32d..f9d6a2cf4179
2024-04-23 michaelludwig@google.com Add serially-executing CPU test category to DM
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 19:13:11 +00:00
skia-flutter-autoroll
ea14e284a1
Roll Fuchsia Linux SDK from L533ubzhjWwW7jxbc... to le_-uFgRD5DjvvqgL... ( flutter/engine#52329 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 19:01:02 +00:00
Jonah Williams
37cda8af05
[Impeller] only use framebuffer advanced blends if available. ( flutter/engine#52284 )
...
This reduces the shader bootstrap count by 15.
Instead of using the regular advanced blend filters for BlendFilters, start a render pass and use the framebuffer advanced blend.
part of https://github.com/flutter/flutter/issues/143540
2024-04-23 18:26:11 +00:00
Jonah Williams
970ea4c511
[Impeller] drawVertices uber shader. ( flutter/engine#52315 )
...
In order to land https://github.com/flutter/engine/pull/52303 , we need to finally fix the advanced blend draw vertices combo. Right now a ColorFilter is used for advanced blends which doesn't work if there are overlapping vertices.
See also: https://github.com/flutter/flutter/issues/145707
The issue was fixed for drawVertices/drawAtlas pipeline blends using the porterduff shader. This extends this to advanced blends, but since drawVertices/atlas with an advanced blend is uncommon and because we don't 15 new shader variants, just add one special uber shader.
Part of https://github.com/flutter/flutter/issues/131345
2024-04-23 18:20:54 +00:00
skia-flutter-autoroll
683f924dd6
Roll Dart SDK from acd54f86bdbb to 6a670b60eb06 (1 revision) ( flutter/engine#52327 )
...
https://dart.googlesource.com/sdk.git/+log/acd54f86bdbb..6a670b60eb06
2024-04-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-91.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 18:13:48 +00:00
gaaclarke
97c434c662
[Impeller] Cleanup PipelineVK::Create ( flutter/engine#52278 )
...
`PipelineVK::Create` was one giant function. Now its 3 smaller functions
and one less giant but still big function.
This is groundwork for trying to batch calls.
I tried to split out the creation of the
`vk::GraphicsPipelineCreateInfo` but it holds pointers to things on the
stack so it's hard to do.
test exempt: refactor, no new functionality
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-04-23 11:05:46 -07:00
John O'Neil
537a8cd839
Issue #146080 : Fix for incorrect STB based atlas glyph scaling ( flutter/engine#51882 )
...
Fixes issue [#146080 ](https://github.com/flutter/flutter/issues/146080 )
Co-authored-by: John O'Neil <johnoneil@google.com>
2024-04-23 11:03:36 -07:00
Jason Simmons
10c2ef8b40
[Impeller] Do not call std::forward on the serialized arguments in the canvas recorder ( flutter/engine#52307 )
...
std::forward has move semantics and can not safely be called twice on the same arguments.
Also fix CanvasRecorder's resolution of Canvas::Save, which has a default parameter value.
2024-04-23 17:24:19 +00:00
skia-flutter-autoroll
eb75c4337d
Roll Skia from 0756b4606e6f to 21563606e32d (2 revisions) ( flutter/engine#52325 )
...
https://skia.googlesource.com/skia.git/+log/0756b4606e6f..21563606e32d
2024-04-23 egdaniel@google.com Remove crashing Linux Graphite Dawn Vulkan perf task.
2024-04-23 nicolettep@google.com Transition magic numbers in VulkanSamplerYcbcrConversion to static values and add convenience method
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 16:32:13 +00:00
skia-flutter-autoroll
47035e2abd
Roll Skia from a373bf46bffb to 0756b4606e6f (3 revisions) ( flutter/engine#52323 )
...
https://skia.googlesource.com/skia.git/+log/a373bf46bffb..0756b4606e6f
2024-04-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from afa5f1b307bd to 99fa81c4c166
2024-04-23 michaelludwig@google.com [graphite] Handle failed buffer mappings in DrawWriter
2024-04-23 brianosman@google.com Revert "Reland "Restore affine bitmap procs""
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 15:37:59 +00:00
Jonah Williams
efbf913cc0
[Impeller] add test case for path that explicitly closes at origin. ( flutter/engine#52314 )
...
Follow up from https://github.com/flutter/engine/pull/52290#discussion_r1575451249
2024-04-23 15:01:15 +00:00
skia-flutter-autoroll
ac3c768679
Roll Dart SDK from b340d0f393b6 to acd54f86bdbb (1 revision) ( flutter/engine#52321 )
...
https://dart.googlesource.com/sdk.git/+log/b340d0f393b6..acd54f86bdbb
2024-04-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-90.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 14:08:31 +00:00
Jonny Wang
b6195c24e7
[fuchsia] Update Fuchsia API version to 17 ( flutter/engine#52266 )
...
Update Fuchsia API version to 17
b/328121174
Changes are tested on device and in google3 in cl/626319415.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-04-23 13:38:47 +01:00
Kaylee Lubick
17a78534c6
[skia] Remove no-op GN flag ( flutter/engine#52121 )
...
After <https://skia-review.googlesource.com/c/skia/+/826440 > this flag
does nothing.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-04-23 07:57:59 -04:00
dependabot[bot]
44991beb19
Bump actions/checkout from 4.1.2 to 4.1.3 ( flutter/engine#52318 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.2 to 4.1.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases ">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.1.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Update <code>actions/checkout</code> version in <code>update-main-version.yml</code> by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1650 ">actions/checkout#1650</a></li>
<li>Check git version before attempting to disable <code>sparse-checkout</code> by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1656 ">actions/checkout#1656</a></li>
<li>Add SSH user parameter by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1685 ">actions/checkout#1685</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.1.2...v4.1.3 ">https://github.com/actions/checkout/compare/v4.1.2...v4.1.3 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="1d96c772d1https://redirect.github.com/actions/checkout/issues/1685 ">#1685</a>)</li>
<li><a href="cd7d8d697ehttps://redirect.github.com/actions/checkout/issues/1656 ">#1656</a>)</li>
<li><a href="8410ad0602https://redirect.github.com/actions/checkout/issues/1650 ">#1650</a>)</li>
<li>See full diff in <a href="9bb56186c3...1d96c772d1https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=4.1.2&new-version=4.1.3 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-04-23 06:22:30 +00:00
dependabot[bot]
9cf0d27e56
Bump actions/upload-artifact from 4.3.1 to 4.3.3 ( flutter/engine#52319 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.1 to 4.3.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases ">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.3.3</h2>
<h2>What's Changed</h2>
<ul>
<li>updating <code>@actions/artifact</code> dependency to v2.1.6 by <a href="https://github.com/eggyhead "><code>@âeggyhead</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/565 ">actions/upload-artifact#565</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4.3.2...v4.3.3 ">https://github.com/actions/upload-artifact/compare/v4.3.2...v4.3.3 </a></p>
<h2>v4.3.2</h2>
<h2>What's Changed</h2>
<ul>
<li>Update release-new-action-version.yml by <a href="https://github.com/konradpabjan "><code>@âkonradpabjan</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/516 ">actions/upload-artifact#516</a></li>
<li>Minor fix to the migration readme by <a href="https://github.com/andrewakim "><code>@âandrewakim</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/523 ">actions/upload-artifact#523</a></li>
<li>Update readme with v3/v2/v1 deprecation notice by <a href="https://github.com/robherley "><code>@ârobherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/561 ">actions/upload-artifact#561</a></li>
<li>updating <code>@actions/artifact</code> dependency to v2.1.5 and <code>@actions/core</code> to v1.0.1 by <a href="https://github.com/eggyhead "><code>@âeggyhead</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/562 ">actions/upload-artifact#562</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/andrewakim "><code>@âandrewakim</code></a> made their first contribution in <a href="https://redirect.github.com/actions/upload-artifact/pull/523 ">actions/upload-artifact#523</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4.3.1...v4.3.2 ">https://github.com/actions/upload-artifact/compare/v4.3.1...v4.3.2 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="65462800fdc004fb4bf690aba496fcb06cde36fchttps://redirect.github.com/actions/upload-artifact/issues/563 ">#563</a> from actions/eggyhead/release-4.3.2</li>
<li><a href="1746f4ab6531685d04a018bf333cd2https://redirect.github.com/actions/upload-artifact/issues/562 ">#562</a> from actions/eggyhead/update-artifact-v215</li>
<li><a href="dac413befabb3b4a3cdb3e3da837d25d5d22a312...65462800fdhttps://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=4.3.1&new-version=4.3.3 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-04-23 06:19:23 +00:00
skia-flutter-autoroll
c66cffd767
Roll Skia from fe545a316f68 to a373bf46bffb (3 revisions) ( flutter/engine#52317 )
...
https://skia.googlesource.com/skia.git/+log/fe545a316f68..a373bf46bffb
2024-04-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from eb81b28b0318 to 6f21ddc207d7
2024-04-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b7e3beee69a5 to 91b20c9cf5fd (11 revisions)
2024-04-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b7cc986dba6d to eb81b28b0318 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 06:15:31 +00:00
skia-flutter-autoroll
0627f01acf
Roll Skia from db21ce8d0f28 to fe545a316f68 (1 revision) ( flutter/engine#52313 )
...
https://skia.googlesource.com/skia.git/+log/db21ce8d0f28..fe545a316f68
2024-04-23 johnstiles@google.com Fix signedness of format string.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 03:03:15 +00:00
skia-flutter-autoroll
c56d6c787e
Roll Dart SDK from 95f95b3118fe to 9f64eecc8cf3 (2 revisions) ( flutter/engine#52312 )
...
https://dart.googlesource.com/sdk.git/+log/95f95b3118fe..9f64eecc8cf3
2024-04-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-88.0.dev
2024-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-87.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 01:58:20 +00:00
