962 Commits

Author SHA1 Message Date
James Robinson
8dcf72f0d1 Only attempt to copy sky_viewer_library symbols on Linux and Android 2015-09-01 15:48:08 -07:00
Ian Hickson
28e097f489 Merge pull request #978 from Hixie/sync-removal
Still try to sync even if a node has been removed from the tree.
2015-09-01 14:08:23 -07:00
Ian Hickson
48a7506491 Merge pull request #992 from Hixie/skyanalyzer
Silence skyanalyzer's complaints about third-party packages.
2015-09-01 14:01:23 -07:00
Ian Fischer
051cf4b5f8 Log a warning when developers are using a dev build of the sky package. 2015-09-01 13:42:00 -07:00
Ian Fischer
c938128873 Merge pull request #990 from iansf/remove_required_arg
Don't require -p for ios_sim commands
2015-09-01 13:39:51 -07:00
Hixie
8f580207f8 Still try to sync even if a node has been removed from the tree.
This should handle a case like a stateful component inside a Container
inside another Container having one of those Containers removed while
still keeping that stateful component around with its state.

The problem of how to handle the Container then being reinserted is a
separate issue not handled by this patch.
2015-09-01 13:32:28 -07:00
Hixie
d96b1e84ca Silence skyanalyzer's complaints about third-party packages. 2015-09-01 13:22:44 -07:00
Adam Barth
e70448c179 Merge pull request #979 from abarth/render_object_docs
Add dartdocs for RenderObject
2015-09-01 12:25:04 -07:00
Adam Barth
dc671f272a Add dartdocs for RenderObject
... and other code in object.dart.
2015-09-01 12:24:27 -07:00
Ian Fischer
07c2379338 Don’t require specifying -p in ios_sim commands under normal circumstances. 2015-09-01 11:26:46 -07:00
Ian Fischer
33470ab2e7 Refactor sky_tool install slightly and fix non-local builds. 2015-09-01 10:37:27 -07:00
Ian Fischer
63763ab0e8 Fix missing paren 2015-09-01 10:07:20 -07:00
Etienne Membrives
0b96a64a8a Merge pull request #954 from emembrives/upload_symbols
Upload sky_viewer symbols to Google Storage.
2015-09-01 18:31:02 +02:00
Etienne Membrives
83209d65a5 Upload sky_viewer symbols to Google Storage.
With this change, each time sky_viewer.mojo is uploaded to Google
Storage (both for Linux and Android), debugging symbols are also
uploaded in a symbols/ subdirectory.
2015-09-01 18:07:59 +02:00
Ian Fischer
23958b15e1 Make it possible to download trace files on rooted devices using sky_tool stop_trace 2015-08-31 17:12:09 -07:00
Ian Fischer
2956f669e7 Merge pull request #976 from domokit/iansf-update-readme-install
Update README.md to reflect removal of --install flag.
2015-08-31 16:55:46 -07:00
Ian Fischer
8f96a4efff Update README.md to reflect removal of --install flag. 2015-08-31 16:48:16 -07:00
Hans Muller
3a25de84c6 Merge pull request #974 from HansMuller/dismissable-uses-gestures
Convert Dismissable to use gestures

Convert Dismissable to use the ScrollStart, ScrollUpdate, and ScrollEnd gestures. Support for fling gestures is TBD.

Included a basic unit test that checks that one item can be dismissed with a press-drag-release gesture.

Fixed the scroll gesture recognizer: if the last pointer goes up and candidate recognizers still exist, then reject the gesture.
2015-08-31 16:46:26 -07:00
Hans Muller
7d6119c2de Convert Dismissable to use gestures
Convert Dismissable to use the ScrollStart, ScrollUpdate, and ScrollEnd gestures. Support for fling gestures is TBD.

Included a basic unit test that checks that one item can be dismissed with a press-drag-release gesture.

Fixed the scroll gesture recognizer: if the last pointer goes up and candidate recognizers still exist, then reject the gesture.
2015-08-31 16:44:25 -07:00
Adam Barth
0c15b35045 Merge pull request #972 from abarth/parent_data_madness
Positioned 'remembers' things it shouldn't
2015-08-31 16:41:36 -07:00
Adam Barth
1119f36040 Positioned 'remembers' things it shouldn't
This patch makes ParentDataNode less general purpose and instead teaches Flex
and Stack how to program the parent data for their children. We used to have
this general system because parent data used to carry CSS styling, but we don't
need it anymore.

Fixes #957
2015-08-31 16:41:14 -07:00
Hixie
c01bb264c7 Remove the inner SizeObserver from ScrollableWidgetList.
Adds a HomogeneousViewport class that works like MixedViewport but
handles only children that have all the same height.

Converts ScrollableWidgetList to use that, so that we don't waste a
frame looking at the size of the contents each time we change size.

This allows a number of seemingly pointless double-pumps in the tests
to be removed.

Other changes that were necessary to support the above:

 - RenderBlock now supports minExtent (think 'min-height' in CSS)
 - RenderBlock now supports itemExtent (forces the height of each
   child to be the same, so that the itemExtent passed to the fixed-
   height scrollables are all authoritative instead of a source of
   bugs when they don't match)
 - RenderBlockViewport now supports horizontal scrolling
 - improved the style of the isInfinite assert in box.dart
 - fixed the position of a comment in mixed_viewport.dart
 - added a test
 - made the logic for how many items to show be more precise
2015-08-31 15:57:45 -07:00
Adam Barth
d57e9ca53c Make these constants private
These constants aren't useful outside these files and are cause noise in the
dartdoc.
2015-08-31 15:53:33 -07:00
Andrew Wilson
87f6405e34 Merge pull request #970 from apwilson/persist
Persist immersiveness.
2015-08-31 14:32:07 -07:00
Andrew Wilson
38be8f6e8d Persist immersiveness. 2015-08-31 14:31:25 -07:00
Ian Fischer
ede7233afc Merge pull request #969 from iansf/extract_install
Extract install from StartSky
2015-08-31 14:30:29 -07:00
Ian Fischer
c1315e5bb2 Extract install into its own sky_tool command. 2015-08-31 14:20:18 -07:00
Adam Barth
696372a293 Basic widgets should validate their parameters with asserts
Also fixes #937.
2015-08-31 13:34:30 -07:00
Adam Barth
187146e841 Merge pull request #961 from abarth/transform_origin
Add an origin parameter to transforms
2015-08-31 13:22:01 -07:00
Adam Barth
aa778b3190 Add an origin parameter to transforms
This parameter makes it easier to do math when you don't want to center your
tranform at (0, 0).
2015-08-31 13:21:26 -07:00
Chinmay Garde
f5a896e3bc Merge pull request #967 from chinmaygarde/master
Implement platform VSyncProvider for iOS
2015-08-31 12:43:31 -07:00
Chinmay Garde
d726d4f822 Implement platform VSyncProvider for iOS 2015-08-31 12:30:11 -07:00
Ian Fischer
12d82fdef2 Merge pull request #960 from iansf/fix_ios_deploy_crashes
Avoid crashing when an iOS device isn't connected
2015-08-31 10:43:23 -07:00
Ian Fischer
1dfcbbd76d Avoid crashing when an iOS device isn’t connected. 2015-08-31 10:41:52 -07:00
Ian Hickson
c36ddfe008 Merge pull request #897 from Hixie/sync-children
Provide a fast path for MultiChildRenderObjectWrapper.syncRenderObject() when the children lists are identical.
2015-08-31 10:36:28 -07:00
Adam Barth
9f43b5a490 Merge pull request #953 from abarth/painting_docs
Add dartdoc for the painting code
2015-08-31 09:37:10 -07:00
Adam Barth
e2638c189d Add dartdoc for the painting code 2015-08-31 09:36:35 -07:00
Adam Barth
bb427e08e1 Merge pull request #952 from abarth/lerp
Move lerp for the engine types into dart:sky
2015-08-31 09:25:35 -07:00
Adam Barth
96e203329c Move lerp for the engine types into dart:sky
This patch just adds them to dart:sky. A future patch will actually use them in
the framework once we've published an updated sky_engine package. Also, add
dartdoc to the classes touched in this patch.
2015-08-31 09:25:22 -07:00
Adam Barth
c6c4c5d26a onPressed not called when in a Positioned Flex
We were setting the main axis extent to zero because we had a sign error.

Fixes #918
2015-08-31 09:12:40 -07:00
Adam Barth
088958e8f6 Unbreak link when deployed 2015-08-30 18:43:17 -07:00
Ian Hickson
969dfe5273 Add gestures/ to README.md prose 2015-08-30 16:30:59 -07:00
Ian Hickson
9152f4643f Add gestures/ to README.md diagram 2015-08-30 16:29:48 -07:00
Adam Barth
bd01a89958 Update skydoc.py now that dartdoc is in the Dart SDK
Now that dartdoc is part of the Dart SDK, we can use the SDK version directly.
2015-08-30 13:38:54 -07:00
Adam Barth
92857ceef8 Add dartdoc for base 2015-08-30 13:03:03 -07:00
Adam Barth
bffdcf84f5 Update box_painter.dart 2015-08-30 11:03:00 -07:00
Adam Barth
0d3c62ef72 Merge pull request #946 from abarth/infinite_border_radius
BoxDecoration's borderRadius should be able to handle a value of double.INFINITY
2015-08-29 22:34:30 -07:00
Adam Barth
2dd8365201 Scrolls should start immediately when possible
If there are no other gestures in the arena, we should kick off the scroll
gesture right away. This change pulled a refactoring of how we dispatch events
to Widgets. Now we dispatch events to Widgets interleaved with their associated
RenderObjects. (Previously we dispatched to all of the RenderObjects first.)
2015-08-29 22:30:49 -07:00
Adam Barth
8d0a2426a6 Rename ParagraphPainter to TextPainter
Also, add asserts that the text has layout before being painted.
2015-08-29 11:41:20 -07:00
Adam Barth
acec6d0171 BoxDecoration's borderRadius should be able to handle a value of double.INIFINITY
We just need to enforce some finite clamp and Skia will do the rest.

Fixes #939
2015-08-28 20:58:34 -07:00