6881 Commits

Author SHA1 Message Date
Mikkel Nygaard Ravn
b04b89ac95
Clarify documented semantics of StatefulWidget (#12880) 2017-11-08 20:39:05 +01:00
Ulf Sauer
7837fe6ebb Fix duplicate word in documentation (#12874) 2017-11-08 11:24:16 -08:00
Yegor
d4830fcf1b
smoke test VM service connection before returning VMService object (#12914) 2017-11-08 10:43:47 -08:00
Hans Muller
c4cdbf86eb
Transform Widget alignment is AlignmentGeometry (#12870)
* a => an
2017-11-07 14:43:57 -08:00
Todd Volkert
16c363ac07
Clarify docs in FlutterDriver.requestData() (#12909) 2017-11-07 14:43:41 -08:00
xster
8f79643680
Error message for unregistered phone (#12911) 2017-11-07 13:23:43 -08:00
Ryan Macnak
cc5902b9d8
Fix some tests to be happy with proper microtask scheduling. (#12900)
(I suspect this accounts the sets of microtasks from scheduleWarmUpFrame now running separately.)

Issue https://github.com/flutter/flutter/issues/9998
2017-11-07 09:26:45 -08:00
Sebastiano Poggi
dfd1ffa7c5 Surface elevation shadow colour on Material (#12881)
* Surface shadowColor from RenderPhysicalModel to Material

* Fix typo in material_test

* Add nullability info to documentation

* Add support for animating elevation shadow color

* Add shadowColor to Material's debugFillProperties()

* Add missing default value for elevation in Material debugFillProperties()

* Add missing non-null asserts for animate flags in AnimatedPhysicalModel

* Add test for shadow color animating smoothly
2017-11-06 17:40:13 -08:00
Yegor
91bd9bc4f8
delay taking screenshot to allow GPU thread to render the frame (#12896)
* delay taking screenshot to allow GPU thread to render the frame

* address comments
2017-11-06 17:33:48 -08:00
amirh
700d7b9da6
Typo fix (ImageProvider) (#12887) 2017-11-06 10:55:01 -08:00
Chris Bracken
4e2e69797a
Eliminate MethodCall hashCode and equals (#12277)
Since MethodCall equality checks are limited to test scenarios, this
patch replaces them with an equivalent test matcher. At present
MethodCalls are always used in scenarios where indentity-based
equality/hashing is appropriate.

This change avoids an assertion failure when MethodCall args are
Iterable (possible since args are of type dyanmic), and hashValue() from
dart:ui asserts that its input is not an Iterable.

The alternative of implementing support for deep equality in dart:ui was
rejected on the basis that if we're to encourage performant code,
expensive checks should be obviously-expensive to the author.
2017-11-06 09:52:57 -08:00
Mikkel Nygaard Ravn
354ab0ce7b
Add missing word in dartdoc for StatelessWidget (#12879) 2017-11-06 17:16:18 +01:00
Ian Hickson
e064d6cbc9
RenderFlex with MainAxisSize.min RTL (#12875)
There was a left-bias when MainAxisSize.min couldn't be honoured.
2017-11-03 17:50:11 -07:00
Ian Hickson
fa6f9a0341
Various documentation improvements (#12855) 2017-11-03 10:55:26 -07:00
xster
c17099f474
Leave a version tag when creating project (#12846)
* Leave a version tag when creating project

* Generalize .version to .metadata
2017-11-03 10:07:57 -07:00
Jason Simmons
b865b0eb2f
Use TextPainter.preferredLineHeight to estimate line height for Cupertino selection handles (#12833)
Fixes https://github.com/flutter/flutter/issues/12046
2017-11-03 09:47:46 -07:00
xster
89405002bc
Add an iOS style demo to the gallery (#12651)
* Built first tab

* Small additions

* started tab 3

* Need color arithmetics

* tab 2 built

* finalize

* lint and tests

* review

* Reapply docs after rebase

* use color.computeLuminance

* linter

* nit
2017-11-03 08:50:29 -07:00
xster
015c738318
Remove extracted luminance calculations from Material (#12718)
* remove extracted methods

* lint
2017-11-03 06:14:40 -07:00
amirh
616a2ad6da
Move semantics stuff from rendering to a top-level semantics/ library (#12793) 2017-11-02 17:38:28 -07:00
Greg Spencer
79862a7262
Fixing assumption that baseStyle is a complete style. (#12836)
This fixes the assumption that InputDecorator had where it expected baseStyle to be a complete style. Now it merges the baseStyle with the subhead style instead of substituting it entirely.

This fixes #12832.
2017-11-02 16:42:02 -07:00
Michael Goderbauer
67ed7807d4
Add new line after "see also" (#12850) 2017-11-02 15:48:10 -07:00
Ian Hickson
c13ed90c87
TextStyle is not an enum (fixes crash with InputDecorator.toString) (#12835) 2017-11-02 12:19:58 -07:00
Ian Hickson
d402d40aa6
Up a timeout to reduce the number of flakes. (#12837) 2017-11-02 12:19:43 -07:00
Michael Goderbauer
1d4607ff04
Identify text fields as such to a11y (#12804)
* Identify text fields as such to a11y

* focus

* make travis happy

* review comments
2017-11-02 10:08:56 -07:00
Mikkel Nygaard Ravn
005a8e4c8e
Add backend texture support (eg video, camera) (#12525) 2017-11-02 14:23:28 +01:00
Adam Barth
3914214641
Fix analyzer warnings (#12840) 2017-11-01 22:31:29 -07:00
5u3it
c608e666ad Material scaffold to have simultaneous left-and-right drawers (#12686)
Adds `Scaffold#endDrawer` property to supply a second drawer to a Scaffold.
2017-11-01 21:35:28 -07:00
Greg Spencer
05e10633f2
Adding proper accommodation for textScaleFactor in chips, and StadiumBorder border. (#12533)
In order to allow chips to be properly drawn when they expand in size (without
using IntrinsicHeight), I needed a BoxDecoration shape that would be dependent
upon the rendered height of the widget. This seemed to be pretty generally
useful, so I added a new ShapeDecoration called StadiumBorder. It uses the
minimum dimension to adjust the BorderRadius of a rounded rect in the shape
decoration.

I also converted some uses of BoxShape to be case statements, updated the
chips to use the StadiumBorder decoration, and updated some of the metrics to match
the Material spec, as well as implementing lerping to and from StadiumBorder.
2017-11-01 19:37:02 -07:00
Michael Goderbauer
e023e89b8e
Add sample code for describeSemanticsConfiguration (#12830) 2017-11-01 15:49:28 -07:00
Chris Bracken
83df7bdd0f
Update Dart package dependencies (#12829) 2017-11-01 15:28:46 -07:00
Ian Hickson
8fd20b5deb
Text Painting Fuzzer (#12813)
Various improvements (in particular a new painting fuzzer) to the text manual test.

Some additional documentation.

A fix to Stack to remove an LTR bias: make unpositioned children apply "alignment".

Some more debugging information on RichText and Text.

A fix to the flutter tool to not crash when an RPC call throws an exception.
2017-11-01 15:04:43 -07:00
Yegor
f4b0ccd9fd
Use alwaysUse24HourFormat when formatting time of day (#12517)
* alwaysUse24HourFormat in MediaQuery and time picker

* docs; dead code

* address some comments

* MaterialLocalizations.timeOfDayFormat is the single source of 24-hour-formattedness

* Make TimePickerDialog private again

* wire up MediaQueryData.fromWindow to Window
2017-11-01 14:52:28 -07:00
Michael Goderbauer
15f0146866
Add missing dart docs to semantics-realted members. (#12821)
Other missing dart docs have been added in https://github.com/flutter/flutter/pull/12813.
2017-11-01 12:55:06 -07:00
Roberto Scaramuzzi
80e159d469
Add acceptNotification parameter to RefreshIndicator and OverscrollIn… (#12716)
* Add acceptNotification parameter to RefreshIndicator and OverscrollIndicator

* Various fixes suggested by reviewer

* Fixed lint errors
2017-11-01 10:29:37 -07:00
Hans Muller
7987dfe965
Revised the English translation definitions (#12812) 2017-11-01 10:19:43 -07:00
amirh
6161d54eb6
Move AbstractNode to lib/foundation. (#12789)
(in preparation for moving the semantics stuff out of rendering)
2017-11-01 09:24:30 -07:00
Yegor
41bd66f210
remove locale "sd" (not supported by ICU/CLDR); unify localizations script options (#12803)
* remove locale "sd" (not supported by ICU/CLDR); unify localizations scripts CLI

* address comments
2017-10-31 20:23:58 -07:00
Michael Goderbauer
9184dfba14
Support value announcement for increase/decrease (#12741)
* Support value announcment for increase/decrease

* ++

* review comments about docs
2017-10-31 14:22:33 -07:00
Ian Hickson
e1174eb0f2
TextPainter RTL (#12791) 2017-10-31 10:39:34 -07:00
Yegor
19227a9988
fix miscellaneous typos in dartdocs (#12801)
* fix miscellaneous typos in dartdocs

* moar typos
2017-10-31 09:17:16 -07:00
Jason Simmons
cb2cfac0eb
Check for presence of an asset directory before accessing it (#12790)
Fixes https://github.com/flutter/flutter/issues/12460
2017-10-30 17:04:30 -07:00
Jason Simmons
1affb4237a
Remove the diagnostic server from flutter_tools (#12771) 2017-10-30 15:53:04 -07:00
Adam Barth
21145144e9
Don't collect usage data during Fuchsia build (#12780)
Previously, the usage analytics would generate a write to the user's
HOME directory during the Fuchsia build. We're tightening down the
environment in which we run the Fuchsia build, and these writes are now
more obvious.

This patch removes the usage analytics during the Fuchsia build,
avoiding the write to the user's HOME directory.
2017-10-30 12:28:31 -07:00
Michael Thomsen
50db9478e3
Clarify how to unconfigure with flutter config (#12733) 2017-10-30 11:12:12 +01:00
Chris Bracken
acdbe45670
Report error on iOS non-release archive builds (#12773)
Archive builds for upload to iTunes Connect should always be built in
release mode, not doing so results in crash on startup.

Bug: https://github.com/flutter/flutter/issues/12086
2017-10-27 18:23:50 -07:00
Yegor
9b5d663efa Upgrade intl: use the new API for locale data and localized numerals (#12736)
* upgrade intl data; use local numerals in date picker

* use the shiny new public intl API

* address comments
2017-10-26 13:42:49 -07:00
Yegor
89a4a1384c unpin linter version, skip the broken 0.1.37 version (#12737) 2017-10-26 12:39:07 -07:00
Yegor
154f2e5402 Reapply #12700 but keep linter pinned at 0.1.35 (#12735)
* Revert "Revert "fix --force-upgrade script; upgrade to the latest package versions (#12700)" (#12729)"

This reverts commit 7f0d4f4caae30d20670a8f3272fa1c70170ace8a.

* keep linter pinned at 0.1.35
2017-10-26 09:55:36 -07:00
Michael Goderbauer
e3327af22a Add option for custom actions to Semantics widget (#12695)
* Add option for custom actions to Semantics widget

* review comments

* review comment
2017-10-25 22:14:12 -07:00
Ian Hickson
311b57be42 Revert "Revert "nav bar font styles are special, do not inherit (#12578)"" (#12679)
* Revert "roll engine (#12660)"

This reverts commit 048bc5e0f6fe96d07bc7777792e31f96f855d5da.

* Revert "FittedBox RTL (#12662)"

This reverts commit 05a22fe0ab2e74635db6628a7fc125e1a1f20203.

* Revert "Revert "nav bar font styles are special, do not inherit (#12578)" (#12661)"

This reverts commit 662b66848562df022dcf95134b61e9958a5a74f4.
2017-10-25 17:52:18 -07:00