Robert Ancell
afefd5da0b
[beta] Cherry pick fix GTK redraw call being called from non-GTK thread ( #173667 )
...
Cherry pick of https://github.com/flutter/flutter/pull/173602
Impacted users: All Linux users of Flutter
Impact Description: Due to calling gtk_window_redraw on a Flutter thread a lock up may occur. The Flutter app will then become unresponsive.
Workaround: No workaround
Risk: Low - fix is to run the GTK call on the GTK thread which is what the correct behaviour should be.
Test coverage: Rendering covered by existing tests, use of thread not explicitly tested, but https://github.com/flutter/flutter/issues/173660 opened to add this in future.
Validation Steps: Run test program in https://github.com/flutter/flutter/issues/173447 which generates many frames and maximizes the chance of a lock up.
2025-08-13 16:06:05 +00:00
Camille Simon
1ddd180d85
Update Dart revision for 3.35 stable release ( #173582 )
...
Updates Dart has for 3.35 stable release to Dart 3.9 hash -- https://dart.googlesource.com/sdk/+/54588cb8088890ea08fe1a31b95efe478a4609b5 .
Steps I took:
1. Updated hash to desired version.
2. Run `engine/src/tools/dart/create_updated_flutter_deps.py -f DEPS` to update any Dart dependencies if needed (none updated).
3. Updated `engine/src/flutter/ci/licenses_golden/licenses_dart` with diff produced in error from https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_license/36032/overview build failure.
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
2025-08-12 00:45:44 +00:00
flutteractionsbot
659d9553df
[CP-beta][web] ClickDebouncer workaround for iOS Safari click behavior ( #173072 )
...
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request )
### Issue Link:
What is the link to the issue this cherry-pick is addressing?
https://github.com/flutter/flutter/issues/172180
### Changelog Description:
Fix a bug that causes the web engine to double report taps on dropdown menu items on iOS Safari.
### Impact Description:
It breaks Flutter Web apps that use dropdown menus with semantics enabled on iOS Safari.
### Workaround:
Is there a workaround for this issue?
No.
### Risk:
What is the risk level of this cherry-pick?
### Test Coverage:
Are you confident that your fix is well-tested by automated tests?
### Validation Steps:
What are the steps to validate that this fix works?
Follow repro steps in https://github.com/flutter/flutter/issues/172180
2025-08-06 19:44:18 +00:00
flutteractionsbot
52cc75c624
[CP-beta][web] Text editing test accepts both behaviors in Firefox ( #173053 )
...
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request )
### Issue Link:
https://github.com/flutter/flutter/issues/172713
### Changelog Description:
Fix web engine unit tests to work on multiple versions of Firefox.
### Impact Description:
Without this fix, some unit tests fail fairly regularly on Firefox.
### Workaround:
This does not affect end-users, so no workaround necessary.
### Risk:
Low
### Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Yes
### Validation Steps:
Run CI.
2025-07-31 20:23:08 +00:00
flutteractionsbot
789c3e3431
[CP-beta]Revert #160653 Fix view removal process for AutofillContextAction.cancel ( #172675 )
...
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request )
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
### Issue Link:
What is the link to the issue this cherry-pick is addressing?
#172250
### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md ) for examples
Fixes a bug where `TextInput.hide` call incorrect clears the text in the active text field.
### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
If an app calls `TextInput.hide` to hide the software keyboard, the user input in the current active text field will also be erased. It impacts the production app.
The framework itself doesn't seem to call `TextInput.hide` in a way that would affect the user.
### Workaround:
Is there a workaround for this issue?
Yes, in theory, developers can store and restore the `TextEditingValue`, when they need to call `TextInput.hide`, to undo the clear. However I suspect the reverted PR may also [break voiceover](https://github.com/flutter/flutter/issues/145681#issuecomment-3110985123 ).
### Risk:
What is the risk level of this cherry-pick?
This is a revert of #160653 . The reverted PR was merged in February, and the previous implementation was [introduced in 2021](https://github.com/flutter/engine/pull/23776 ).
### Test Coverage:
Are you confident that your fix is well-tested by automated tests?
- [] No
This change is a revert so the added test will also get reverted.
### Validation Steps:
What are the steps to validate that this fix works?
To verify the fix on master (it has already landed on master), run this app:
```dart
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
debugShowCheckedModeBanner: false,
theme: ThemeData(
colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
useMaterial3: true,
),
home: const MyHomePage(),
);
}
}
class MyHomePage extends StatelessWidget {
const MyHomePage({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: SizedBox(
child: ListView(
children: [
TextButton(
child: Text('hide keyboard'),
onPressed: () =>
SystemChannels.textInput.invokeListMethod("TextInput.hide"),
),
TextField(
controller: TextEditingController(text: '️a' * 20),
maxLines: 1,
),
],
),
),
),
);
}
}
```
focus the text field and then click the hide keyboard button. The text "aaaaaa..." should remain after the button is clicked.
2025-07-25 18:51:53 +00:00
flutteractionsbot
1c9c20e7c3
[CP-beta]Remove emoji from ci.yaml, because we still live with CP1252 for some silly reason ( #172263 )
...
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request )
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
### Issue Link:
What is the link to the issue this cherry-pick is addressing?
https://github.com/flutter/flutter/issues/172257
### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md ) for examples
N/A
### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
Cannot release (Windows builder fails)
### Workaround:
Is there a workaround for this issue?
No
### Risk:
What is the risk level of this cherry-pick?
### Test Coverage:
Are you confident that your fix is well-tested by automated tests?
### Validation Steps:
What are the steps to validate that this fix works?
Try publishing another release
2025-07-18 16:37:15 +00:00
Kaylee Lubick
81e1d5ec26
[skia] Add missing param to makeRasterImage calls ( #172122 )
...
Skia's makeRasterImage takes a (now required) `GrDirectContext` param.
This updates Flutter to provide something there - either nullptr or a
context that seemed to be related.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-15 22:16:00 +00:00
engine-flutter-autoroll
40cbea246d
Roll Skia from 8ffff8c8e01b to fec78c0da2e6 (6 revisions) ( #172178 )
...
https://skia.googlesource.com/skia.git/+log/8ffff8c8e01b..fec78c0da2e6
2025-07-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 4e8bc564952b to dd4d30b3bfd0 (2 revisions)
2025-07-15 kjlubick@google.com Build skottie-final without Bazel
2025-07-15 borenet@google.com [cdn] Use cdn.skia.org instead of
gs://skia-world-readable
2025-07-15 michaelludwig@google.com [graphite] Add more stat tracking to
insertRecording
2025-07-15 nicolettep@google.com Promote Vulkan min version check from
debug --> fatal
2025-07-15 nicolettep@google.com [graphite] Add build flag to enable
trace events for pipeline + RP labels
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-15 20:42:09 +00:00
engine-flutter-autoroll
edf47581fb
Roll Skia from 2f4ad5d83704 to 8ffff8c8e01b (7 revisions) ( #172169 )
...
https://skia.googlesource.com/skia.git/+log/2f4ad5d83704..8ffff8c8e01b
2025-07-15 lukasza@google.com Revert "[rust png] Gracefully handle input
stream that shrinks over time."
2025-07-15 lukasza@chromium.org [rust png] Gracefully handle input
stream that shrinks over time.
2025-07-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from a18894e3915b to f26a853e1821 (8 revisions)
2025-07-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from c1f7fbbec4e1 to 65b2c4777e5f (1 revision)
2025-07-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 9c310928b8c1 to 4e8bc564952b (16 revisions)
2025-07-14 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com
Update SKP version
2025-07-14
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-15 18:16:37 +00:00
John "codefu" McDole
cc3110c590
feat: Tag Fuchsia artifacts by content hash ( #172132 )
...
After the fuchsia build process, be sure to tag uploaded artifacts with
`content_aware_hash:` if configured.
fixes #171985
This was a bit of a rabbit hole, with some "magic parameters" that
control uploading / tagging. I'm not sure cipd supports two tags with
the say keys; but I wouldn't want the content hash having the key
"git_revision".
Pre-submits: Not affected since --engine-version is always '' which is
read as "do not upload"
Post-submits: Reads the `linux_fuchsia.json` builder to look for flags.
> Note: This needs to land before the tool can be updated to download
the content_aware_hash tag.
Tested: locally, on linux, after building all the x64 targets. With and
without engine-version, with and without linux_fuchsia.json flags.
```shell
$ src/flutter/tools/fuchsia/merge_and_upload_debug_symbols.py --target-arch x64 --engine 'abcd' --upload --out-dir tmp --symbol-dirs out/ci/fuchsia_debug_x64/.build-id out/ci/fuchsia_release_x64/.build-id out/ci/fuchsia_profile_x64/.build-id
Using content hash 2201006225127f112f6576fcf73dd00671b2012e for engine version
['cipd', 'create', '-pkg-def', '/usr/local/google/home/codefu/src/flutter/engine/tmp/debug_symbols.cipd.yaml', '-ref', 'latest', '-tag', 'git_revision:abcd', '-verification-timeout', '10m0s', '-tag', 'content_aware_hash:2201006225127f112f6576fcf73dd00671b2012e']
```
```
$ python3 src/flutter/tools/fuchsia/build_fuchsia_artifacts.py --archs x64 --engine 'abc' --cipd-dry-run --upload
Using content hash 2201006225127f112f6576fcf73dd00671b2012e for engine version
codefu: ['cipd', 'create', '-pkg-def', 'fuchsia.cipd.yaml', '-ref', 'latest', '-tag', 'git_revision:abc', '-tag', 'content_aware_hash:2201006225127f112f6576fcf73dd00671b2012e']
```
2025-07-15 16:55:02 +00:00
Chinmay Garde
50feb5a078
[Impeller] libImpeller: Correctly release mappings created using the C++ API wrapper. ( #172136 )
...
Fixes https://github.com/flutter/flutter/issues/170388
Converted `InteropPlaygroundTest::CanDrawImage` to use the C++ API too.
2025-07-14 21:46:30 +00:00
engine-flutter-autoroll
8c99a8cf09
Roll Skia from 5f7adef2ac25 to 2f4ad5d83704 (3 revisions) ( #172134 )
...
https://skia.googlesource.com/skia.git/+log/5f7adef2ac25..2f4ad5d83704
2025-07-14 kylechar@google.com Check if resource label is unchanged
2025-07-14 kjlubick@google.com Reland "Delete GN support for building
for fuchsia"
2025-07-14 danieldilan@google.com Add color_wheel.avif to
resources/images
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com ,jlavrova@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-14 21:40:20 +00:00
Kaylee Lubick
fa53d33068
Use granular skparagraph targets ( #161676 )
...
Skia would like to clean up the SkParagraph GNI lists (see
http://review.skia.org/931916 ). Because Flutter uses paragraph's test
utilities, we should make that an explicit target rather than bundling
it into the main Skia target.
See https://skia-review.googlesource.com/c/skia/+/938120 which needs to
land and roll first
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-14 20:06:05 +00:00
engine-flutter-autoroll
98b9ca1767
Roll Skia from e95c92d867b5 to 5f7adef2ac25 (8 revisions) ( #172123 )
...
https://skia.googlesource.com/skia.git/+log/e95c92d867b5..5f7adef2ac25
2025-07-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 68fa81690837 to 03356f06b92c (4 revisions)
2025-07-14 alecmouri@google.com Write correct sBIT for 10-bit BGRA
2025-07-14 robertphillips@google.com [graphite] Encapsulate Android's
PrecompileSettings
2025-07-14 michaelludwig@google.com [graphite] Refactor visitClipStack
to use DrawShape helper
2025-07-14
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-07-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 59d3a3511b5d to a18894e3915b (5 revisions)
2025-07-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 2748c19e00fd to 81e90f7fd7f3 (23 revisions)
2025-07-14 kainino@chromium.org [graphite] Clean up old
WGPU_BREAKING_CHANGE_* guards
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com ,jlavrova@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-14 19:32:08 +00:00
Kaylee Lubick
129867ec6d
[skia] Set GN flags explicitly for fuchsia build ( #172104 )
...
In https://skia-review.googlesource.com/c/skia/+/1017296 , Skia removes
support for Fuchsia. In #171800 and #171874 , I'd set some of those
removed flags, but missed these. I've been able to run the Fuchsia tests
locally now to confirm it works and we should be good to re-land that
Skia change once this lands.
One thing to ponder for the future - is Flutter depending on Skia's
gn/skia.gni helpful or a hindrance? Should Flutter decouple that part
into its own BUILD.gn rules for Skia and only depend on the filegroups?
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-14 18:30:54 +00:00
Jason Simmons
d18e28d855
Apply superellipse clipping to iOS platform views using an approximated round rect ( #172033 )
...
Fixes https://github.com/flutter/flutter/issues/171966
2025-07-14 18:08:00 +00:00
Chinmay Garde
c845f06094
[Impeller] Fix broken image links in documentation. ( #171465 )
2025-07-14 18:06:03 +00:00
Mohellebi abdessalem
8a0a36af64
remove x86 in CI builder linux_android_emulator ( #170964 )
...
based on [this
comment](https://github.com/flutter/flutter/pull/170191#pullrequestreview-2910139454 )
Towards #170142
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] All existing and new tests are passing.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-14 18:06:02 +00:00
Mohellebi abdessalem
fa9dff55e6
remove x86 in flutter_gdb ( #170966 )
...
based on [this
comment](https://github.com/flutter/flutter/pull/170191#pullrequestreview-2910139454 )
Towards #170142
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] All existing and new tests are passing.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-14 18:06:01 +00:00
engine-flutter-autoroll
ee4a35d22a
Roll Fuchsia Linux SDK from qw0YTtPhosk3-rr4h... to tQAtsLtpc0oBIqRwC... ( #172116 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-14 17:38:17 +00:00
Harry Terkelsen
f58c4cf385
[web] Delete unused files in the engine ( #172035 )
...
Delete unused files.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-14 17:10:41 +00:00
engine-flutter-autoroll
63f471185f
Roll Fuchsia Linux SDK from xQlbHCUI33kDvkew8... to qw0YTtPhosk3-rr4h... ( #172076 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-13 12:12:37 +00:00
Alexander Aprelev
1e85c8f7cc
Roll dart sdk to 3.9.0-333.0.dev ( #172052 )
...
Changes since last dart roll:
```
3ad640094c3 (tag: 3.9.0-333.0.dev) Version 3.9.0-333.0.dev
a706ea8a9b5 Remove left-over debugging code that saved files to disk.
c47a8b0adaa [vm/shared] Restore fast-path for RunWithStoppedMutators.
3e462c1343f [vm,dyn_modules] Support external/native methods in bytecode
e69b7eafcaa [co19] Roll co19 to a5d7b62b78dd9278c30a44cb2d22b8870b360a0e
cb5aed532f1 (tag: 3.9.0-332.0.dev) Version 3.9.0-332.0.dev
15a00898af8 Add the ability to copy pipes using File.Copy
08e5a2d5281 (tag: 3.9.0-331.0.dev) Version 3.9.0-331.0.dev
c87169ef1a2 Remove InfoDeclarationStore.
d6c4707b938 Elements. Remove InterfaceElementImpl.lookUpInheritedMethod()
279b379ef92 Elements. Replace FragmentImpl.nameOffset with firstTokenOffset.
14bb2be360d [ddc] Optimize building type environments at runtime
7e4fca78a87 [changelog] Clean up recent changelog entries
f3d9d5e6868 (tag: 3.9.0-330.0.dev) Version 3.9.0-330.0.dev
313fd866d1f [deps] rev http, i18n, tools, web
895413f982f [analyzer] Add special case for bool.fromEnvironment('dart.library.js_interop')
5ce3cd24d20 [ddc] Fix hot reload test runner ternary.
9737e0c8530 analyzer: Simplify the sealed supertype check
3220f9b511f (tag: 3.9.0-329.0.dev) Version 3.9.0-329.0.dev
b207705bd58 [dart2wasm] Update interop specializers to live in library with specialized member.
83d862217e5 Bump pub to c3e50919d11896f014cb971e1776d00a0e2d18b3
```
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-13 04:04:34 +00:00
engine-flutter-autoroll
35f197f1e5
Roll Fuchsia Linux SDK from 8aoEy1hp2a9HI1pt-... to xQlbHCUI33kDvkew8... ( #172060 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-12 10:18:38 +00:00
Tong Mu
dcae0c4ca0
Add RSuperellipse support to Web (global cache) ( #171489 )
...
This PR adds `RSuperellipse` support to Web, so that these ops will
actually draw `RSuperellipse`s instead of falling back to `RRect`s,
except for platform views.
* (I was told in some earlier comments that RSuperellipses should fall
back to RRects for platform views but I can't remember where for now. If
reviewers think otherwise I can implement them right away or make this a
TODO in the future.)
The `RSuperellipse`s are drawn after being converted to paths. The
algorithm is nothing new, but already used in
`round_superellipse_param.cc`.
For performance optimization, `RSuperellipse`s that have uniform radii
will have their paths cached in a global cache after offset
normalization.
This PR does not add any new public APIs. (Although, I'm planning to
also implement this to the main `dart:ui` in the future to support
non-Impeller-nor-Web platforms, which will need
`RSuperellipse.toPathOffset` public.)
Fixes https://github.com/flutter/flutter/issues/163718
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-12 05:43:32 +00:00
engine-flutter-autoroll
789a4be32a
Roll Skia from 2ea2ba09ef85 to 92354f64e37f (1 revision) ( #172039 )
...
https://skia.googlesource.com/skia.git/+log/2ea2ba09ef85..92354f64e37f
2025-07-11 michaelludwig@google.com [graphite] Add more
resource/recorder tracking for 407062399
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com ,kjlubick@google.com,thomsmit@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-11 23:55:19 +00:00
gaaclarke
f351ac4ec0
adds gemini.md to engine and licenses_cpp ( #172022 )
...
Adds gemini.md files for the engine and the license checker.
I've checked that this unlocks gemini cli development loops for the
license checker. We'll see how this will scale across such a huge
project.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-11 21:10:48 +00:00
Loïc Sharma
595bf3fd08
[Web] Implement disabling interactive selection ( #171935 )
...
This updates Flutter Web to ignore copy/paste/selections if
`enableInteractiveSelection` is `false` in a text field.
Part of https://github.com/flutter/flutter/issues/157611
## Scenarios tested
1. Click/tap on text: cursor should not move.
2. Double click/tap on text: text should not be selected
3. Triple click/tap on text: text should not be selected
4. Move cursor back (`Left arrow`): cursor should move back
5. Move cursor forward (`Right arrow`): cursor should move forward
8. Select previous word (`Shift+Left arrow`): text should not be
selected, cursor moves to previous word
9. Select previous word (`Shift+Right arrow`): text should not be
selected, cursor moves the next word
7. Select all shortcut (`Ctrl+A` or `Apple+A`): text should not be
selected. ⚠️ With this fix, Flutter Web moves the cursor to the end of
the text field.
8. Copy shortcut (`Ctrl+C` or `Apple+C`): clipboard should not be
updated
9. Paste shortcut (`Ctrl+V` or `Apple+V`): clipboard should not be
pasted
10. Right-click > Copy: clipboard should not be updated
11. Right-click > Paste: clipboard should not be pasted
## Browsers tested
macOS: Chrome, Firefox, Safari
## Example app
```dart
import 'package:flutter/material.dart';
void main() {
runApp(
MaterialApp(
home: Scaffold(
body: SafeArea(
child: TextField(
enableInteractiveSelection: false,
),
),
),
),
);
}
```
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-11 20:45:59 +00:00
gaaclarke
95d5dc37db
License cpp 710 ( #171989 )
...
No big code changes, just data updates. We are down to about 100 missing
copyrights.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-11 20:35:38 +00:00
ash2moon
00724d194a
add content description to tooltip-only nodes for android ( #171541 )
...
Fixes [171071](https://github.com/flutter/flutter/issues/171071 )
This PR conditionally adds the content description to nodes that rely on
tooltips to convey meaningful information. Some nodes such as Calendar
Date Picker's chevron left and right icons to change months do not
announce the text because the only meaningful semantic information is
the tooltip. On platforms other than Android, "Button, Next Month" is
properly announced. On Android, this is not announced on the focus
event. This PR adds the content description to replicate the logic used
in other platforms only if the developer did not set a special content
description ahead of time.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-11 20:30:25 +00:00
Hannah Jin
2a3b048a53
[Web a11y]Update table cell to use LabelRepresentation.sizedSpan ( #172013 )
...
fix: https://github.com/flutter/flutter/issues/171991
for a table cell leaf node
LabelRepresentation.ariaLabel will be ignored,
LabelRepresentation.domText can focus on the text but the rect is wrong,
LabelRepresentation.sizedSpan works very well,
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-11 19:46:17 +00:00
Victoria Ashworth
23b81a714d
Run tests on either macOS 14 or 15 ( #171076 )
...
In preparation of upgrading the remaining bots to macOS 15, allow tests
to use any version of macOS 14 or 15.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-11 18:21:08 +00:00
engine-flutter-autoroll
43161d4b95
Roll Skia from db1a5550c848 to 2ea2ba09ef85 (1 revision) ( #172017 )
...
https://skia.googlesource.com/skia.git/+log/db1a5550c848..2ea2ba09ef85
2025-07-11 michaelludwig@google.com [graphite] Add option to simulate
errors during InsertRecording
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com ,kjlubick@google.com,thomsmit@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-11 18:03:24 +00:00
Jason Simmons
2c7ab86ea6
Detach the resource context from the IO thread only if the shell's IO manager is no longer being used by any other spawned shells ( #171554 )
...
The shell had been calling PlatformView::ReleaseResourceContext every
time a shell instance shuts down in order to clear the EGL context from
the IO thread.
But there may be other spawned shells that are also using the same IO
manager and IO task runner. If the task that calls
ReleaseResourceContext runs after the other shells call
CreateResourceContext, then the IO thread will be left without an EGL
context. That will cause errors in operations like image decoding that
need to invoke OpenGL ES APIs on the IO thread.
See https://github.com/flutter/flutter/issues/171213
2025-07-11 16:48:09 +00:00
gaaclarke
3e9ab91e39
Started querying the app state for the gpu disabled sync switch ( #171785 )
...
Started querying the app state for the gpu disabled sync switch when
starting an engine without a view controller
fixes https://github.com/flutter/flutter/issues/166668
Testing: Integration test is not possible since it would require
manipulation of the operating system and killing / restoring the app.
Unit tests would require executing in the background or mocking out
background detection which is pretty contrived and will complicate
engine initialization. The simple cases will be covered with integration
tests like the wide gamut devicelab tests which loads an image at
startup and grabs a screenshot of it.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-11 16:03:42 +00:00
gaaclarke
cb4bedd58e
License_cpp 7/02 ( #171558 )
...
A lot of data updates. The big change here is allowing more than one
license to hit in a LICENSE file as long as they don't overlap.
After this change we are at 957 LICENSE copyrights, 943 LICENSE_CPP
copyrights. There seems to be 175 missing copyrights still from
LICENSE_CPP.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-11 16:02:50 +00:00
Kostia Sokolovskyi
fa4a2c1098
[web] Refactor clipboard. ( #171427 )
...
Closes https://github.com/flutter/flutter/issues/48581
Closes https://github.com/flutter/flutter/issues/157484
### Description
This PR refactors the clipboard implementation in the web engine.
- Enables `ClipboardAPI*` strategies for all browsers
- Adds check for `format` in `getDataMethodCall` to match
implementations on other platforms
975f6d8bef/engine/src/flutter/shell/platform/android/io/flutter/plugin/platform/PlatformPlugin.java (L554)975f6d8bef/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformPlugin.mm (L410)https://flutter-clipboard-playground.web.app
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-11 15:48:32 +00:00
engine-flutter-autoroll
4e2ccf4fe8
Roll Skia from 26571c3b1771 to da7e3eae7c2b (2 revisions) ( #171997 )
...
https://skia.googlesource.com/skia.git/+log/26571c3b1771..da7e3eae7c2b
2025-07-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from c4debb111e10 to 59d3a3511b5d (11 revisions)
2025-07-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 3e4d34bfa361 to 5e97ca13797b (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com ,kjlubick@google.com,thomsmit@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-11 08:24:27 +00:00
engine-flutter-autoroll
dfe7a2a97d
Roll Fuchsia Linux SDK from lO64ePNEGrGzs-MFC... to 8aoEy1hp2a9HI1pt-... ( #171993 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-11 05:22:07 +00:00
Jing Shao
cc968cae8b
[iOS] Add Live Text option to system context menu ( #170969 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
**Live Text (OCR) button disappeared from text field menus on iOS after
the Secure Paste M2 update. This PR adds it back.**
**Fixes #169781**
Note: This is a draft PR for initial review. Still need to add tests or
split to framework and engine
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-10 22:32:31 +00:00
engine-flutter-autoroll
464373078d
Roll Skia from dc3da09ca905 to 34a40032ff0a (1 revision) ( #171982 )
...
https://skia.googlesource.com/skia.git/+log/dc3da09ca905..34a40032ff0a
2025-07-10 fmalita@google.com [pathbuilder] Faster assignment (and
SkPath constructor)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com ,kjlubick@google.com,thomsmit@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-10 21:14:28 +00:00
Jason Simmons
ad3ac3b02d
Manual roll Dart SDK from 8d69b07b9d9d to 07ea3aaaadf0 (32 revisions) ( #171969 )
...
https://dart.googlesource.com/sdk.git/+log/8d69b07b9d9d..07ea3aaaadf0
2025-07-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-327.0.dev
2025-07-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-326.0.dev
2025-07-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-325.0.dev
2025-07-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-324.0.dev
2025-07-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-323.0.dev
2025-07-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-322.0.dev
2025-07-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-321.0.dev
2025-07-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-320.0.dev
2025-07-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-319.0.dev
2025-07-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-318.0.dev
2025-07-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-317.0.dev
2025-07-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-316.0.dev
2025-07-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-315.0.dev
2025-07-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-314.0.dev
2025-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-313.0.dev
2025-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-312.0.dev
2025-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-311.0.dev
2025-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-310.0.dev
2025-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-309.0.dev
2025-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-308.0.dev
2025-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-307.0.dev
2025-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-306.0.dev
2025-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-305.0.dev
2025-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-304.0.dev
2025-07-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-303.0.dev
2025-07-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-302.0.dev
2025-07-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-301.0.dev
2025-07-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-300.0.dev
2025-07-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-299.0.dev
2025-07-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-298.0.dev
2025-07-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-297.0.dev
2025-07-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-296.0.dev
2025-07-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-295.0.dev
2025-07-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-294.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert
to ensure that a human is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
---------
Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
2025-07-10 18:50:41 +00:00
engine-flutter-autoroll
d78fc7d940
Roll Skia from bdb8bfcde7f3 to dc3da09ca905 (3 revisions) ( #171971 )
...
https://skia.googlesource.com/skia.git/+log/bdb8bfcde7f3..dc3da09ca905
2025-07-10 kjlubick@google.com Fix compile errors in Graphite's Vello
code
2025-07-10 robertphillips@google.com [graphite] Remove trampoline
functions from Precompilation tests
2025-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 9af2a11b445f to 3e4d34bfa361 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com ,kjlubick@google.com,thomsmit@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-10 18:16:09 +00:00
engine-flutter-autoroll
b948aa1350
Roll Skia from 0fef076beec3 to bdb8bfcde7f3 (34 revisions) ( #171964 )
...
Roll Skia from 0fef076beec3 to bdb8bfcde7f3 (34 revisions)
https://skia.googlesource.com/skia.git/+log/0fef076beec3..bdb8bfcde7f3
2025-07-10 michaelludwig@google.com [graphite] Improve no-op scissor
handling
2025-07-10 kjlubick@google.com Revert "Delete GN support for building
for fuchsia"
2025-07-10 lehoangquyen@chromium.org GraphiteDawn: Use
@interpolate(flat, either) for BlitWithDraw pipeline
2025-07-10 nicolettep@google.com [graphite] DrawShadow optimizations
2025-07-10 kjlubick@google.com Temporarily remove Radeon Macbook Pro
Tests from CQ
2025-07-10 kjlubick@google.com Enforce IWYU on more graphite files
2025-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from ce289330b0b8 to ec2a04cc9535 (11 revisions)
2025-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from be6ed66fa563 to c1f7fbbec4e1 (1 revision)
2025-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 86bd00388c3e to c4debb111e10 (7 revisions)
2025-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from de887f5d1721 to ba8b1ec2a10a (20 revisions)
2025-07-10
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c91d04c5a3ae to 9af2a11b445f (8 revisions)
2025-07-10 thomsmit@google.com Add upper limit to Triangulator contour
counts
2025-07-09 michaelludwig@google.com [graphite] Add Shape::isFloodFill()
helper
2025-07-09 robertphillips@google.com [graphite] Upstream Android
Mourimap changes
2025-07-09 fmalita@google.com Remove SkClipStack use in GrAppliedClip.h
2025-07-09 kjlubick@google.com Remove old flags in skia.gni
2025-07-09 kjlubick@google.com Remove uses of deprecated no-args
makeRasterImage
2025-07-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from e573f4bc7407 to c91d04c5a3ae (4 revisions)
2025-07-09
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-07-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 825b40622cf2 to ce289330b0b8 (5 revisions)
2025-07-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 743562b36d09 to 86bd00388c3e (15 revisions)
2025-07-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from d7b31b22748d to de887f5d1721 (17 revisions)
2025-07-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 242b87cc5bcc to e573f4bc7407 (6 revisions)
2025-07-08 borenet@google.com [infra] skia-cdn has moved to
skia-world-readable
2025-07-08 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 0275c582a080 to d7b31b22748d (11 revisions)
2025-07-08 michaelludwig@google.com [graphite] Define inner bounds for
draws when combing with clip stack
2025-07-08 xing.xu@intel.com GraphiteDawn: Use dawn partial resolve
feature on D3D11
2025-07-08 robertphillips@google.com [graphite] Add a PaintOptions
Builder
2025-07-08
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-07-08 michaelludwig@google.com [graphite] Add debugging members for
ResourceCache usage
2025-07-08 kjlubick@google.com Delete GN support for building for
fuchsia
2025-07-08 kjlubick@google.com Generate graphite.gni from BUILD.bazel
2025-07-08 thomsmit@google.com [graphite] Add more DrawAtlas test
coverage
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com ,kjlubick@google.com,thomsmit@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
...
2025-07-10 16:02:40 +00:00
Kostia Sokolovskyi
43657f3baa
[web] Add frame number support. ( #171592 )
...
Fixes https://github.com/flutter/flutter/issues/170972
### Description
- Adds `frameData` with `frameNumber` value to `FrameService`
- Adds non-mock `frameData` to `EngineFlutterWindow` and
`EnginePlatformDispatcher`
- Adds `frameNumber` value to `FrameTimingRecorder`'s recorded timings
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-10 12:43:30 +00:00
engine-flutter-autoroll
9a016fb924
Roll Fuchsia Linux SDK from 0-xqmXWc4cXzw3tfe... to lO64ePNEGrGzs-MFC... ( #171937 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-10 03:15:40 +00:00
Robert Ancell
78e111f5a0
Refactor compositor classes ( #171414 )
...
Present frames directly to each view, which maintains its own
compositor.
This simplifies the compositor so it doesn't need to maintain a map from
views to buffers.
2025-07-10 02:55:07 +00:00
gaaclarke
01f7007a3f
Adds a MCP server for working with the engine ( #171738 )
...
WIP this just adds a few commands and sets up the work for others to
build off of.
Blatant omissions:
1) ~~integration with the engine dart monorepo workspace~~
1) ~~brings in `mcp_dart` dependency (it has an MIT license but is very
new)~~
1) CI testing integration (unless there is some magic that crawls
through the repo and calls them)
1) provide progress notifications and compilation errors to the client
when building
1) `et run`
1) `et test`
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-09 23:38:22 +00:00
Matt Boetger
189a5db70b
Use Async SurfaceHolder Callback to remove need for setting alpha workaround ( #171398 )
...
We can rely on the SurfaceHolder.Callback2 method,
surfaceRedrawNeededAsync to properly signal the below Surface that
rendering of the frame is done, and the Surface can be finished drawing.
This removes the need to set the alpha to prevent the blank surface from
being rendered before the engine is done.
Fixes : #140246
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
2025-07-09 23:02:11 +00:00
John "codefu" McDole
4336d5c417
feat: new builders for size experiment ( #171886 )
...
These builders are experimental and should not be used in production.
copied from ddm experiment
2025-07-09 21:24:46 +00:00
