DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
815 Commits 882 Branches 1,069 Tags
Commit Graph

2 Commits

Author SHA1 Message Date
Elliott Sprehn
bb7f5d05bf Improve custom-elements/generated-constructor.sky test. 
We should inherit from HTMLElement, Sky (and blink) don't currently
enforce this but they probably should. We should also explicitly
check that the prototype is what we expect.

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/809183002
 2014-12-17 15:01:17 -08:00
Elliott Sprehn
4a9e21a78c Custom elements should have class side inheritance. 
We were not setting the __proto__ property of the generated constructor
so the generated class didn't inherit from the passed class which meant
that statics were not available.

This patch adds the missing call to setPrototype (which sets __proto__).

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/814683002
 2014-12-17 14:24:34 -08:00