skia-flutter-autoroll
af32a56ff8
Roll Dart SDK from c0709fb4a1a3 to 601c7a96ef5d (1 revision) ( flutter/engine#52898 )
...
https://dart.googlesource.com/sdk.git/+log/c0709fb4a1a3..601c7a96ef5d
2024-05-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-166.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-17 10:41:29 +00:00
skia-flutter-autoroll
d0bf851079
Roll Skia from 071cbd93d0a4 to a251e7836a5c (1 revision) ( flutter/engine#52897 )
...
https://skia.googlesource.com/skia.git/+log/071cbd93d0a4..a251e7836a5c
2024-05-17 drott@chromium.org [Fontations-backend] Hook up Skrifa hinting support
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-17 09:50:24 +00:00
skia-flutter-autoroll
b7e2db667b
Roll Skia from 4af5313185d7 to 071cbd93d0a4 (2 revisions) ( flutter/engine#52896 )
...
https://skia.googlesource.com/skia.git/+log/4af5313185d7..071cbd93d0a4
2024-05-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 6da3279dd380 to 3d1e84a14ec4
2024-05-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from e9be917b1b0d to 6da3279dd380 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-17 06:44:34 +00:00
skia-flutter-autoroll
36a4f64ec7
Roll Dart SDK from ecc0d32e29cd to c0709fb4a1a3 (1 revision) ( flutter/engine#52895 )
...
https://dart.googlesource.com/sdk.git/+log/ecc0d32e29cd..c0709fb4a1a3
2024-05-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-165.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-17 06:36:26 +00:00
skia-flutter-autoroll
04dc622fbd
Roll Dart SDK from a68a3967e3d9 to ecc0d32e29cd (1 revision) ( flutter/engine#52893 )
...
https://dart.googlesource.com/sdk.git/+log/a68a3967e3d9..ecc0d32e29cd
2024-05-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-164.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-17 02:36:29 +00:00
Jonah Williams
709848e589
[Impeller] grow glyph atlas instead of resizing when rect packer is full. ( flutter/engine#52849 )
...
Fixes https://github.com/flutter/flutter/issues/138798
As far as I can tell, this gets us about as good as Skia, modulo the actual cost of rasterizing one of these glyphs is much more expensive for us.
The basic strategy is:
1. If the existing atlas texture has room (defined by the rect packer addRect call succeeding) append as many glyphs as we can to the old texture.
2. Check if there were any remaining glyphs. If not return.
3. Otherwise, double the size of the texture and create a new rect packer that represents only the increased area. So for example if you doubled a 100x100 texture to 100x200, then you'd create another 100x100 rect packer, assuming the old one is full.
4. Grow this size until all remaining glyphs fit. Store the new rect packer and the "height adjustment", which basically tells you where along the y-axis the rect packer offset starts.
5. Allocate this new texture, clear it, and then blit the contents of the old texture into the top left corner. Append all additional glyphs. The allows us to recycle all previously rendered glyphs and keep them in the texture, reducing the amount of software rasterization per frame.
6. Note; if the max atlas size would be exceeded, throw it away and start again.
2024-05-17 02:20:21 +00:00
Jonah Williams
20ea92ce6f
[Impeller] use smaller SkFont size for determining glyph bounds. ( flutter/engine#52868 )
...
Applies the fix that @jason-simmons previously suggested in https://github.com/flutter/flutter/issues/128624#issuecomment-1846473830
I'm not sure if these results are better or not ... but I think we try and make this change to see if things are improved anyway? Leaving up golden diffs for others to look at.
2024-05-16 22:55:19 +00:00
skia-flutter-autoroll
e1b5e2c1d2
Roll Skia from 7536d3b590b8 to 5f094e6de863 (2 revisions) ( flutter/engine#52891 )
...
https://skia.googlesource.com/skia.git/+log/7536d3b590b8..5f094e6de863
2024-05-16 bungeman@google.com Reland "Add PostScript name to generated fonts"
2024-05-16 jvanverth@google.com Move kDistanceAdjustLumShift into DistanceFieldAdjustTable.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-16 22:47:24 +00:00
skia-flutter-autoroll
d94c1b59a9
Roll Dart SDK from d174ead78d98 to a68a3967e3d9 (1 revision) ( flutter/engine#52889 )
...
https://dart.googlesource.com/sdk.git/+log/d174ead78d98..a68a3967e3d9
2024-05-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-163.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-16 22:22:17 +00:00
auto-submit[bot]
ea811b97ba
Reverts "Manual roll of Clang from 725656bdd885 to 145176dc0c93 ( #52823 )" ( flutter/engine#52890 )
...
Reverts: flutter/engine#52823
Initiated by: zanderso
Reason for reverting: Engine crashes on framework CI following this roll https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20flutter_gallery__transition_perf_with_semantics/12126/overview
Original PR Author: jason-simmons
Reviewed By: {zanderso}
This change reverts the following previous change:
See https://github.com/flutter/flutter/issues/143178
2024-05-16 22:01:38 +00:00
skia-flutter-autoroll
74d5011ee9
Roll Skia from 530fa373b797 to bb1572a681eb (2 revisions) ( flutter/engine#52886 )
...
https://skia.googlesource.com/skia.git/+log/530fa373b797..bb1572a681eb
2024-05-16 bungeman@google.com Add PostScript name to generated fonts
2024-05-16 armansito@google.com Reland "[graphite] Tweaks to atlas path renderer selection"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-16 20:31:17 +00:00
skia-flutter-autoroll
114afcf5d5
Roll Fuchsia Linux SDK from Ftw7GopnudHydGS1y... to ywxGmpIdjxBl2i7s2... ( flutter/engine#52882 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-16 19:08:10 +00:00
skia-flutter-autoroll
080abd7f9f
Roll Dart SDK from b64b487c9967 to d174ead78d98 (1 revision) ( flutter/engine#52878 )
...
https://dart.googlesource.com/sdk.git/+log/b64b487c9967..d174ead78d98
2024-05-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-162.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-16 18:15:11 +00:00
skia-flutter-autoroll
3fd64fd9d3
Roll Skia from 320b00b025b8 to ac4aa1dbd268 (2 revisions) ( flutter/engine#52877 )
...
https://skia.googlesource.com/skia.git/+log/320b00b025b8..ac4aa1dbd268
2024-05-16 lehoangquyen@chromium.org GraphiteDawn: use future version of CreateRenderPipelineAsync
2024-05-16 kjlubick@google.com Use image deserial proc in debugger
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-16 18:09:02 +00:00
Jason Simmons
31d7cb2870
Manual roll of Clang from 725656bdd885 to 145176dc0c93 ( flutter/engine#52823 )
...
See https://github.com/flutter/flutter/issues/143178
2024-05-16 17:16:21 +00:00
skia-flutter-autoroll
0d2b0cd0ed
Roll Skia from dafbdcc7f1fd to 320b00b025b8 (2 revisions) ( flutter/engine#52876 )
...
https://skia.googlesource.com/skia.git/+log/dafbdcc7f1fd..320b00b025b8
2024-05-16 jvanverth@google.com [graphite] Hook up gamma adjustment for SDF text.
2024-05-16 ccameron@chromium.org SkJpegEncoder: Specify metadata segments explicitly
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-16 16:40:04 +00:00
skia-flutter-autoroll
3a468e8e7c
Roll Dart SDK from 1600c3bae731 to b64b487c9967 (1 revision) ( flutter/engine#52874 )
...
https://dart.googlesource.com/sdk.git/+log/1600c3bae731..b64b487c9967
2024-05-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-161.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-16 14:03:26 +00:00
skia-flutter-autoroll
b6cebe9c92
Roll Skia from a01d9bb9d4b3 to 9c3b296f7b58 (1 revision) ( flutter/engine#52872 )
...
https://skia.googlesource.com/skia.git/+log/a01d9bb9d4b3..9c3b296f7b58
2024-05-16 bungeman@google.com Test effect of sbix originOffset fields
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-16 08:28:07 +00:00
skia-flutter-autoroll
f73d4a934f
Roll Skia from 91527e447923 to 5a9402854577 (1 revision) ( flutter/engine#52869 )
...
https://skia.googlesource.com/skia.git/+log/91527e447923..5a9402854577
2024-05-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from c8e24928e2f9 to e9be917b1b0d (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-16 06:01:28 +00:00
Matan Lurey
b0e791fce3
et generates {out}/{buildName} if missing on et {build|test|query} (flutter/engine#52866 )
...
Closes https://github.com/flutter/flutter/issues/148442 .
This restores functionality that existed prior in https://github.com/flutter/engine/pull/52832 :
- Splits `runGn` to `ensureBuildDir`, which is in practice what it does.
2024-05-16 04:03:21 +00:00
auto-submit[bot]
d810c59879
Reverts "Revamp the engine style guide, remove always_specify_types. ( #52859 )" ( flutter/engine#52867 )
...
Reverts: flutter/engine#52859
Initiated by: zanderso
Reason for reverting: This sort of change *is* in scope for a discussion at the Dash forum.
Original PR Author: matanlurey
Reviewed By: {cbracken, gaaclarke, johnmccutchan}
This change reverts the following previous change:
Based on the (internal) discussion around converging on using the official Dart style guide, with the exception of the code that gets published under `dart:ui`, as that is user-facing, and we'd like to evolve the code style in conjunction with the framework.
I also took the opportunity to specify more about our style guide use in general, mostly to make it easier to understand our conventions, and also call out known problem areas (notably, our over-use of `shared_ptr` and `auto` in some cases). I am happy to split those up, but it was easier to make the markdown changes at once.
I also took @cbracken and folks advice and clarified directly that explicit types in Dart are _not_ bad (with examples).
2024-05-16 02:51:50 +00:00
Matan Lurey
eafc52c37d
Include stdout on a failed gn desc call, and test for it. ( flutter/engine#52863 )
...
Fixes https://github.com/flutter/flutter/issues/148431 , in that full error output is now shown.
I also filed an additional issue for how we could do better: https://github.com/flutter/flutter/issues/148442 .
2024-05-16 01:09:13 +00:00
Matan Lurey
706817bd67
Revamp the engine style guide, remove always_specify_types. ( flutter/engine#52859 )
...
Based on the (internal) discussion around converging on using the official Dart style guide, with the exception of the code that gets published under `dart:ui`, as that is user-facing, and we'd like to evolve the code style in conjunction with the framework.
I also took the opportunity to specify more about our style guide use in general, mostly to make it easier to understand our conventions, and also call out known problem areas (notably, our over-use of `shared_ptr` and `auto` in some cases). I am happy to split those up, but it was easier to make the markdown changes at once.
I also took @cbracken and folks advice and clarified directly that explicit types in Dart are _not_ bad (with examples).
2024-05-16 01:07:17 +00:00
skia-flutter-autoroll
56a25633d8
Roll Skia from bbe06eb4a8e9 to 91527e447923 (1 revision) ( flutter/engine#52864 )
...
https://skia.googlesource.com/skia.git/+log/bbe06eb4a8e9..91527e447923
2024-05-15 ccameron@chromium.org Reland 2: Add ISO 21496-1 gainmap parsing
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-16 01:01:33 +00:00
skia-flutter-autoroll
1468c42281
Roll Skia from 2d0d1f7833bb to bbe06eb4a8e9 (1 revision) ( flutter/engine#52862 )
...
https://skia.googlesource.com/skia.git/+log/2d0d1f7833bb..bbe06eb4a8e9
2024-05-15 sunnyps@chromium.org Reland "graphite: Do not call virtual setBackendLabel in Resource constructor"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 23:59:05 +00:00
skia-flutter-autoroll
e6a093d286
Roll Dart SDK from f773d45634ed to a9651de827d8 (1 revision) ( flutter/engine#52861 )
...
https://dart.googlesource.com/sdk.git/+log/f773d45634ed..a9651de827d8
2024-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-159.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 22:02:54 +00:00
skia-flutter-autoroll
31b463c760
Roll Skia from 0f737206b709 to 2d0d1f7833bb (1 revision) ( flutter/engine#52860 )
...
https://skia.googlesource.com/skia.git/+log/0f737206b709..2d0d1f7833bb
2024-05-15 brianosman@google.com Revert "SkJpegEncoder: Specify metadata segments explicitly"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 21:48:24 +00:00
skia-flutter-autoroll
253f91bd76
Roll Skia from b9a304eb05d2 to 0f737206b709 (3 revisions) ( flutter/engine#52858 )
...
https://skia.googlesource.com/skia.git/+log/b9a304eb05d2..0f737206b709
2024-05-15 jvanverth@google.com [graphite] Add caching to ComputePathAtlas.
2024-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e127b96b4799 to 48e47a7bb90c (2 revisions)
2024-05-15 nathanasanchez@google.com Made a change.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 20:40:20 +00:00
Matan Lurey
cb19eac08e
Short-circuit crawling all targets in et {build|test|query} ( flutter/engine#52832 )
...
Closes https://github.com/flutter/flutter/issues/147666 .
This is a large change, I'd be happy to either review synchronously or
change commands one at a time, but I think this is overall the right
approach. I also didn't see any reason to reuse the `BuildRunner` code
for these commands, the flow is basically:
```mermaid
graph LR
A[et targetsOrPatterns] --> B[gn desc --format=json]
B --> C[existing code that runs ninja/workers]
```
Quick summary of changes:
- Introduced a [`Label` and `TargetPattern`][1] type to avoid awkward
string parsing/manipulation all over
- Replaced `gn_utils` (i.e. `targetsFromCommandLine` and friends) with
[an invocation of `gn desc`][2]
- Some tests were brittle in terms of expected output, I mostly left
them alone and wrote TODOs where applicable
Here is the fun part, results (and some manual integration tests):
```sh
# build, previously was 10-15s, is now ~3s
flutter % time et build -c host_debug_unopt_arm64 //flutter/impeller:impeller_unittests
[2024-05-14T19:05:55.163][macos/host_debug_unopt_arm64: GN]: OK
[2024-05-14T19:05:56.119][macos/host_debug_unopt_arm64: RBE startup]: Proxy started successfully.
[macos/host_debug_unopt_arm64: ninja] 0.0% (0/1) Regenerating ninja files[2024-05-14T19:05:57.309][macos/host_debug_unopt_arm64: ninja]: OK
[2024-05-14T19:05:57.573][macos/host_debug_unopt_arm64: RBE shutdown]: Actions completed: 0
$ENGINE/flutter/bin/et build -c host_debug_unopt_arm64 3.20s user 0.87s system 107% cpu 3.776 total
# test, also benefits from speedup, but I didn't time it
flutter % et test -c host_debug_unopt_arm64 //flutter/fml:fml_unittests
[2024-05-14T19:07:01.843][macos/host_debug_unopt_arm64: GN]: OK
[2024-05-14T19:07:02.707][macos/host_debug_unopt_arm64: RBE startup]: Proxy started successfully.
[2024-05-14T19:07:07.400][macos/host_debug_unopt_arm64: ninja]: 100.0% (3/3) LINK ./fml_unittests
[2024-05-14T19:07:07.404][macos/host_debug_unopt_arm64: ninja]: OK
[2024-05-14T19:07:07.748][macos/host_debug_unopt_arm64: RBE shutdown]: Actions completed: 1 (1 racing local)
OKAY: 7s.95ms //flutter/fml:fml_unittests
# query, also benefits from speedup
flutter % time et query targets -c host_debug_unopt_arm64
//flutter/display_list:display_list_benchmarks
//flutter/display_list:display_list_builder_benchmarks
# ... many targets omitted ...
$ENGINE/flutter/bin/et query targets -c host_debug_unopt_arm64 1.27s user 0.18s system 147% cpu 0.978 total
```
In other words, ~5x improvement on `et build` and `et query` is _much_
faster as well.
[1]:
https://github.com/flutter/engine/compare/main...matanlurey:engine:gn-label?expand=1#diff-ac008475ce9e209f4ecf6594b0cd48d12d86a1ffa0aa7d555375ff43b983eb2b
[2]:
https://github.com/flutter/engine/compare/main...matanlurey:engine:gn-label?expand=1#diff-ad116b8504dd0a500bf758a327c7052e5733a2b465d3295e35b74458d483276f
2024-05-15 12:57:02 -07:00
skia-flutter-autoroll
33592ed533
Roll Skia from 475559da107d to b9a304eb05d2 (1 revision) ( flutter/engine#52857 )
...
https://skia.googlesource.com/skia.git/+log/475559da107d..b9a304eb05d2
2024-05-15 ccameron@chromium.org SkJpegEncoder: Specify metadata segments explicitly
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 19:26:23 +00:00
Jenn Magder
bae1009cd1
Migrate TextInputSemanticsObject to ARC ( flutter/engine#52785 )
...
1. Migrate TextInputSemanticsObject to ARC
2. Rename the Objective-C-only `accessibility_text_entry.*` files to `TextInputSemanticsObject.*`
3. Move `FlutterInactiveTextInput` interface from the header file into the implementation, the only place it's used.
Blocked on `SemanticsObject` ARC migration https://github.com/flutter/engine/pull/52824
Part of https://github.com/flutter/flutter/issues/137801 .
2024-05-15 19:10:24 +00:00
skia-flutter-autoroll
9e404f6bd7
Roll Fuchsia Linux SDK from NbCi2ETfLHPLLB-JV... to Ftw7GopnudHydGS1y... ( flutter/engine#52853 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 18:03:58 +00:00
skia-flutter-autoroll
f2d50e7941
Roll Dart SDK from 7d9de0c0b231 to f773d45634ed (2 revisions) ( flutter/engine#52854 )
...
https://dart.googlesource.com/sdk.git/+log/7d9de0c0b231..f773d45634ed
2024-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-158.0.dev
2024-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-157.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 18:00:40 +00:00
skia-flutter-autoroll
062a439821
Roll Skia from 4a7419d662d5 to 475559da107d (5 revisions) ( flutter/engine#52848 )
...
https://skia.googlesource.com/skia.git/+log/4a7419d662d5..475559da107d
2024-05-15 egdaniel@google.com [Graphite] Don't set DawnTexture label if we only have a view.
2024-05-15 kjlubick@google.com Update Windows P400s to Windows 22H2 and latest driver
2024-05-15 armansito@google.com Revert "Reland: Add ISO 21496-1 gainmap parsing"
2024-05-15 armansito@google.com Revert "graphite: Do not call virtual setBackendLabel in Resource constructor"
2024-05-15 kjlubick@google.com [bazel] Add target for svg_writer
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 15:43:04 +00:00
skia-flutter-autoroll
a3b2d046b0
Roll Skia from a9ba7411d4b2 to 4a7419d662d5 (1 revision) ( flutter/engine#52844 )
...
https://skia.googlesource.com/skia.git/+log/a9ba7411d4b2..4a7419d662d5
2024-05-15 robertphillips@google.com [graphite] Make MatrixConvolutionImageFilter stably keyed (take 2)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 13:47:24 +00:00
skia-flutter-autoroll
774167c78d
Roll Skia from b3aadd56d187 to a9ba7411d4b2 (1 revision) ( flutter/engine#52839 )
...
https://skia.googlesource.com/skia.git/+log/b3aadd56d187..a9ba7411d4b2
2024-05-15 ccameron@chromium.org Reland: Add ISO 21496-1 gainmap parsing
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 08:42:10 +00:00
skia-flutter-autoroll
ea8caf4958
Roll Skia from c0caf10486ce to b3aadd56d187 (3 revisions) ( flutter/engine#52837 )
...
https://skia.googlesource.com/skia.git/+log/c0caf10486ce..b3aadd56d187
2024-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 724dbf0e90cb to e127b96b4799 (6 revisions)
2024-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from c8e24928e2f9 to a21a77992dab
2024-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b43af3a7d497 to c8e24928e2f9 (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 07:08:34 +00:00
Jenn Magder
a4dc4d92ba
Migrate SemanticsObject and FlutterSemanticsScrollView to ARC ( flutter/engine#52824 )
...
On top of the `SemanticsObject` refactor https://github.com/flutter/engine/pull/52729 migrate `SemanticsObject` and `FlutterSemanticsScrollView` to ARC.
Part of https://github.com/flutter/flutter/issues/137801 .
2024-05-15 04:23:25 +00:00
skia-flutter-autoroll
91a74353b4
Roll Dart SDK from 0b77fbab8cf5 to 1eec9de2f9c6 (1 revision) ( flutter/engine#52833 )
...
https://dart.googlesource.com/sdk.git/+log/0b77fbab8cf5..1eec9de2f9c6
2024-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-155.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 03:09:23 +00:00
skia-flutter-autoroll
da5f8f0ac9
Roll Skia from d0d87c26b489 to fad584324d85 (1 revision) ( flutter/engine#52831 )
...
https://skia.googlesource.com/skia.git/+log/d0d87c26b489..fad584324d85
2024-05-15 sunnyps@chromium.org graphite: Do not call virtual setBackendLabel in Resource constructor
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 02:06:26 +00:00
Matan Lurey
8ef64aea97
Re-add MipFilter::kBase, but keep kNearest as the default. ( flutter/engine#52779 )
...
Closes https://github.com/flutter/flutter/issues/147259 .
Changes:
- Make sure the default of `kNearest` is used consistently
- Partial revert of https://github.com/flutter/engine/pull/40491 , re-adding `kBase`
- Added some documentation about relevant enums, and why the default is `kNearest`
- Wired up `kBase` in the Metal, Vulkan, and OpenGLES backends
Expecting an update to the `dart_ui_filter_quality_none` golden file:
> 
For breadcrumbs around the mapping, see https://github.com/flutter/flutter/issues/148253 .
2024-05-15 01:38:05 +00:00
Jonah Williams
3be5ba1920
[Impeller] make default glyph atlas size much bigger. ( flutter/engine#52787 )
...
Now that we no longer have a full CPU copy of the glyph atlas, it should be cheaper to make a larger initial atlas to reduce churn from resizing seen in applications like https://github.com/flutter/flutter/issues/138798
Requires https://github.com/flutter/engine/pull/52746
2024-05-15 01:22:04 +00:00
Jonah Williams
b322ce3a58
[Impeller] immediately encode blit commands for Vulkan. ( flutter/engine#52794 )
...
No reason to defer encoding. Just like cmd buffers, we can immediately encode this. Reduce heap allocation of command objects, which were additionally stored in unique ptrs for extra memory inefficiency.
2024-05-14 23:50:09 +00:00
Gray Mackall
b6bb39ad2d
Fix non-vd android platform view input event offsets ( flutter/engine#52532 )
...
Fixes https://github.com/flutter/flutter/issues/146570 , which tracks a regression from https://github.com/flutter/engine/pull/49268 regarding platform view inputs in some specific cases.
This PR translates the input event location to be the same as the location we calculated before https://github.com/flutter/engine/pull/49268 , returning to the previous behavior, while maintaining the input event's verified status (I checked this manually with the `InputManager`).
Tested manually with the reproduction in the linked issue.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-14 23:07:53 +00:00
skia-flutter-autoroll
98713e6aa6
Roll Dart SDK from 0380354e2448 to 0b77fbab8cf5 (1 revision) ( flutter/engine#52827 )
...
https://dart.googlesource.com/sdk.git/+log/0380354e2448..0b77fbab8cf5
2024-05-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-154.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 23:00:06 +00:00
Jonah Williams
ff5ea29080
[Impeller] reland: directly encode blit commands for Metal. ( flutter/engine#52819 )
...
Fixes bad interaction with render pass clear patch, which potentially created an active blit and render pass encoder at the same time. Make sure that we start/finish the render pass before we start the blit pass.
2024-05-14 22:32:19 +00:00
skia-flutter-autoroll
c16a2409e5
Roll Skia from 81ba2eea7b42 to d0d87c26b489 (2 revisions) ( flutter/engine#52825 )
...
https://skia.googlesource.com/skia.git/+log/81ba2eea7b42..d0d87c26b489
2024-05-14 michaelludwig@google.com [graphite] Default to approx fit textures for layers/filters
2024-05-14 michaelludwig@google.com [graphite] Include proxy label in assert
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 22:19:49 +00:00
Chris Bracken
e210669748
[docs] Suggest using same Xcode version as bots ( flutter/engine#52821 )
...
Document that when using RBE, users should ensure the locally installed Xcode toolchain version matches that of the bots, otherwise they're likely to experience slow builds due to cache misses.
Ideally, we should also check the value automatically against the `sdk_version` specified in the relevant `et` build config itself.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-14 21:37:09 +00:00
Zachary Anderson
cd9cf6d62b
[et] Print reproxy stats when RBE shuts down ( flutter/engine#52818 )
...
```
$ bin/et build -c ci/android_release_arm64 ─╯
[2024-05-14T11:28:40.856][ci/android_release_arm64: GN]: OK
[2024-05-14T11:28:42.527][ci/android_release_arm64: RBE startup]: Proxy started successfully.
[2024-05-14T11:31:14.869][ci/android_release_arm64: ninja]: 100.0% (1096/1096) STAMP obj/flutter/lib/snapshot/snapshot.stamp
[2024-05-14T11:31:14.871][ci/android_release_arm64: ninja]: OK
[2024-05-14T11:31:15.182][ci/android_release_arm64: RBE shutdown]: Actions completed: 1021 (569 racing locals, 452 racing remotes)
```
2024-05-14 14:15:10 -07:00
skia-flutter-autoroll
fadafad193
Roll Skia from e26aee36345f to 81ba2eea7b42 (3 revisions) ( flutter/engine#52820 )
...
https://skia.googlesource.com/skia.git/+log/e26aee36345f..81ba2eea7b42
2024-05-14 scroggo@google.com Change CtsEnforcement for ImageAsyncReadPixels
2024-05-14 armansito@google.com Fix CanvasKit WebGPU build
2024-05-14 kjlubick@google.com Add WebGPU build to the CQ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 21:07:04 +00:00
