8044 Commits

Author SHA1 Message Date
Mouad Debbar
add5ddd86c [web] Fix selectable text rendering (flutter/engine#13802) 2019-11-14 00:12:56 -08:00
Matt Carroll
be849d1363 Add support for --dart-flags in FlutterShellArgs. (#44855) (flutter/engine#13855) 2019-11-14 04:09:08 +00:00
Jason Simmons
91ec75170b Use Skia's matchStyleCSS3 to find bundled asset typefaces matching a font style (flutter/engine#13848)
This will improve font matching in SkParagraph for fonts that are bundled as
assets within the app.  Libtxt was using Minikin's FontFamily class to select
the closest matching font, but SkParagraph will rely on the matchStyle
implementation in the asset font manager.
2019-11-13 17:44:25 -08:00
Jim Graham
c36b203a4e Avoid GL calls when compiling for Fuchsia. (flutter/engine#13847)
* Avoid GL calls when compiling for Fuchsia.
2019-11-13 16:41:03 -08:00
Kaushik Iska
85e7580127 [build] Make --engine-version flag optional (flutter/engine#13803) 2019-11-13 14:34:22 -08:00
Kaushik Iska
01327cfff1 Disable LTO on Fuchsia (flutter/engine#13842) 2019-11-13 14:33:21 -08:00
Todd Volkert
16ebe4633a Remove unused import (flutter/engine#13832) 2019-11-13 14:12:46 -08:00
xster
50e84b5bb6 add recent packages to javadoc list (flutter/engine#13789) 2019-11-13 14:10:38 -08:00
Ferhat
ce9826e1bf [web] Fix blendmode for images (flutter/engine#13809)
* Fix blendmode for images
2019-11-13 13:09:16 -08:00
chunhtai
7787960f0c reland add lifecycle enum (flutter/engine#13767)
This reverts commit 5e7e183369b3816650f776c767e241bb98a87276.
2019-11-13 11:26:25 -08:00
Gary Qian
d4a5a15200 Remove extra shadows from Web Engine EngineParagraphStyle (flutter/engine#13805) 2019-11-13 11:13:46 -08:00
Kaushik Iska
24bf127ba8 [dart_runner] Initialize logging and tracing (flutter/engine#13829)
Remove !defined(FUCHSIA_SDK) bits to start using the SDK
apis to initialize logging and trace events for dart runners.
2019-11-13 10:02:09 -08:00
Kaushik Iska
1c8fb6612e Revert "Roll src/third_party/skia d860a78fd60c..581108137b46 (13 commits) (#13800)" (flutter/engine#13828)
This reverts commit 2d34550cb365c9167929bf4693492b5f12974a1e.
2019-11-13 07:22:42 -08:00
George Wright
47f1a8028a Create a WeakPtrFactory for use on the UI thread in VsyncWaiter (flutter/engine#13781) 2019-11-12 15:46:07 -08:00
skia-flutter-autoroll
2d34550cb3 Roll src/third_party/skia d860a78fd60c..581108137b46 (13 commits) (flutter/engine#13800)
https://skia.googlesource.com/skia.git/+log/d860a78fd60c..581108137b46

git log d860a78fd60c..581108137b46 --date=short --no-merges --format='%ad %ae %s'
2019-11-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-12 csmartdalton@google.com Add 'numRasterSamples' and 'isMixedSampled' to GrProgramInfo
2019-11-12 ccross@android.com [SkQP/Android] Replace -Weverything with -Wextra
2019-11-12 robertphillips@google.com Use a priori knowledge about the number of stencil bits in Dawn, Metal and Vulkan backends
2019-11-12 senorblanco@chromium.org Dawn: implement dynamic primitive processor texture handling.
2019-11-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 31edef751a8d..9da287fd0264 (6 commits)
2019-11-12 jvanverth@google.com Detect whether trying to blit a Metal swapchain texture, and fail if so.
2019-11-12 senorblanco@chromium.org Dawn: fix bug in stencil handling.
2019-11-12 nigeltao@google.com Free SkWuffsCodec frame-count decoder earlier
2019-11-12 bungeman@google.com Track and force opsz axis on Mac.
2019-11-12 herb@google.com Make metrics const on SkStrike
2019-11-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@581108137b46

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC halcanary@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=halcanary@google.com
2019-11-12 18:45:58 -05:00
Chinmay Garde
2d7d114126 Document the coordinate space of points in FlutterPointerEvent. (flutter/engine#13782) 2019-11-12 12:21:50 -08:00
Yegor
0aec3787c7 implement radial gradient in canvaskit backend (flutter/engine#13796) 2019-11-12 10:56:07 -08:00
Clement Skau
f3b15f82c9 Adds missing comma in EngineParagraphStyle.toString() (flutter/engine#13795) 2019-11-12 17:00:54 +01:00
skia-flutter-autoroll
e8235212c8 Roll src/third_party/skia ad21d47cfa8d..d860a78fd60c (2 commits) (flutter/engine#13794)
https://skia.googlesource.com/skia.git/+log/ad21d47cfa8d..d860a78fd60c

git log ad21d47cfa8d..d860a78fd60c --date=short --no-merges --format='%ad %ae %s'
2019-11-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 012d15196023..e33c1582b4bc (6 commits)
2019-11-12 herb@google.com WS: SkStrike

Created with:
  gclient setdep -r src/third_party/skia@d860a78fd60c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC halcanary@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=halcanary@google.com
2019-11-12 10:29:49 -05:00
Ferhat
054875d7ab [web] Implement TextStyle.shadows (flutter/engine#13769)
* Add shadows to Engine classes
* add text shadow test
* update golden locks file, update ui.ParagraphStyle, fix issues
* Change maxDiffRate for mac clients
2019-11-12 00:05:00 -08:00
Matt Carroll
6bf82e4675 Expose asset lookup from plugin binding. (#42019) (flutter/engine#13743) 2019-11-12 07:14:27 +00:00
skia-flutter-autoroll
0025068f23 Roll src/third_party/skia 3de645cbca78..ad21d47cfa8d (15 commits) (flutter/engine#13790)
https://skia.googlesource.com/skia.git/+log/3de645cbca78..ad21d47cfa8d

git log 3de645cbca78..ad21d47cfa8d --date=short --no-merges --format='%ad %ae %s'
2019-11-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-11 bsalomon@google.com Clamp RGB outputs of GrYUVtoRGBEffect.
2019-11-11 herb@google.com Remove belongsToCache from SkStrike
2019-11-11 jlavrova@google.com Correct cluster index
2019-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms e51ca8b81987..0e5f77218153 (1 commits)
2019-11-11 sgilhuly@chromium.org Roll Dawn, fix build issues in Skia Dawn
2019-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms b118cb0ef477..e51ca8b81987 (1 commits)
2019-11-11 robertphillips@google.com Remove GrProgramDesc's need for the GrGpu
2019-11-11 mtklein@google.com add int3, vptest, jc
2019-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 652dbfc63e70..012d15196023 (9 commits)
2019-11-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2019-11-11 mtklein@google.com add assert_true()
2019-11-11 bsalomon@google.com C++17
2019-11-11 mtklein@google.com don't allocate an interpreter register for stores
2019-11-11 rosasco@google.com Staging for Chromium to accept Skia-GL changes to come.

Created with:
  gclient setdep -r src/third_party/skia@ad21d47cfa8d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC halcanary@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=halcanary@google.com
2019-11-12 01:24:36 -05:00
Ferhat
e26e220a6f Move Path and PathMetrics from canvas.dart into their own files. No delta (flutter/engine#13772)
* Move Path and PathMetrics into their own files. No delta
* update file list in licenses_flutter
2019-11-11 21:27:15 -08:00
Harry Terkelsen
fc817859be Take devicePixelRatio into account when drawing shadows (flutter/engine#13786)
* Take devicePixelRatio into account when drawing shadows

This fixes a bug where shadows were offset in CanvasKit

* Respond to review comments
2019-11-11 18:20:08 -08:00
Harry Terkelsen
9899996132 Add ImageFilter and BackdropFilter to CanvasKit backend (flutter/engine#13768)
* Implement ImageFilter.blur and BackdropFilter

* update licenses file

* Respond to review comments
2019-11-11 17:20:45 -08:00
Chris Yang
590dc94eb8 Revert "Reland "Guarding EAGLContext used by Flutter #13314" (#13759)" (flutter/engine#13788)
This reverts commit 6390e62036d69c4923cc6cf2379b9eb9f25870ba.
2019-11-11 17:17:18 -08:00
Harry Terkelsen
e64b455a3f Add Helvetica and sans-serif as fallback font families (flutter/engine#13784)
* Add Helvetica and sans-serif as fallback font families

This prevents us from using an ugly serif default font when the
requested font isn't available.

* Use Arial when not on iOS
2019-11-11 16:54:28 -08:00
skia-flutter-autoroll
28335b9648 Roll src/third_party/skia 0fd4f01b9b83..3de645cbca78 (1 commits) (flutter/engine#13776)
https://skia.googlesource.com/skia.git/+log/0fd4f01b9b83..3de645cbca78

git log 0fd4f01b9b83..3de645cbca78 --date=short --no-merges --format='%ad %ae %s'
2019-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d9ed1c2732ba..31edef751a8d (3 commits)

Created with:
  gclient setdep -r src/third_party/skia@3de645cbca78

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC halcanary@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=halcanary@google.com
2019-11-11 19:45:43 -05:00
Greg Spencer
a853b5a14b Add line boundary information to LineMetrics. (flutter/engine#13727)
This exposes the line boundary information a line by adding getLineBoundary to return the indices corresponding to a line around a TextPosition. The information is already calculated when calculating line metrics, so that we can enable moving the selection/cursor to the beginning/end of a line in a text field.
2019-11-11 16:42:40 -08:00
Jason Simmons
1ae8f8880f Fix RendererContextSwitch result check in Rasterizer::MakeRasterSnapshot (flutter/engine#13785)
Fixes https://github.com/flutter/flutter/issues/31355
2019-11-11 15:46:26 -08:00
Ferhat
19cec525aa [web] Fix path to svg for drrect (flutter/engine#13779) 2019-11-11 15:38:30 -08:00
skia-flutter-autoroll
5c9b0db7ba Roll src/third_party/skia 4135cf0b57c2..0fd4f01b9b83 (1 commits) (flutter/engine#13770)
https://skia.googlesource.com/skia.git/+log/4135cf0b57c2..0fd4f01b9b83

git log 4135cf0b57c2..0fd4f01b9b83 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@0fd4f01b9b83

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-08 23:54:39 -05:00
Chris Yang
6390e62036 Reland "Guarding EAGLContext used by Flutter #13314" (flutter/engine#13759) 2019-11-08 20:09:18 -08:00
Matt Carroll
98d25e5bf3 Point old plugin registry accessors to new embedding plugin accessors. (#44225) (flutter/engine#13739) 2019-11-09 01:55:59 +00:00
Filip Filmar
2572d5b375 Revert "[fuchsia] Temporarily disable intl provider (#13696)" (flutter/engine#13721)
This reverts commit 8cb106f91850a9e9984d4bb39fc524710e51755c.

The reverted code was not the root cause of the issues with rolling
flutter into fuchsia, so adding it back.

In addition, lowering the severity of the connection error at the outset
to WARNING; since it is not a hard failure.
2019-11-08 17:34:04 -08:00
Michael Klimushyn
24ba26f80c Turn on RasterCache based on view hierarchy (flutter/engine#13762)
This is a duplicate of flutter/engine#13360 with the test switched to use the software backend instead of the GL backend.

After some debugging and testing on another GL embedder I think the issue with the test is some bug having to do with the GL implementation in the test harness specifically. 

Fixes flutter/flutter#38903
2019-11-08 17:14:50 -08:00
gabeschine
616a2ce26c Remove usage of fuchsia.modular.Clipboard. (flutter/engine#13763)
It is deprecated and will go away.
2019-11-08 17:13:17 -08:00
Greg Spencer
4b6b7f6e96 Change wordBoundary to take dynamic temporarily (flutter/engine#13765)
Converting the argument to Paragraph.wordBoundary to dynamic temporarily until the framework code is converted to send a TextPosition instead of an int.

I'll submit this, then update the framework side to send a TextPosition, and expect a TextRange
or a List<int>, and then submit that, then I'll change this code to send a TextRange and take a TextPostion only, removing the dynamic here. Once that's done, I'll remove the code in the framework that expects a TextRange or a List<int>, and have it just expect a TextRange.

This is so that we can change the API without breaking the builds.

Landing on red to kick the engine builds.
2019-11-08 16:27:00 -08:00
skia-flutter-autoroll
67dbea1c87 Roll src/third_party/skia c88d1774ed50..4135cf0b57c2 (13 commits) (flutter/engine#13764)
https://skia.googlesource.com/skia.git/+log/c88d1774ed50..4135cf0b57c2

git log c88d1774ed50..4135cf0b57c2 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 mtklein@google.com use round() instead of trunc() to f32->unorm
2019-11-08 jlavrova@google.com Yet another build fix
2019-11-08 mtklein@google.com rename to_i32 -> trunc, and add round
2019-11-08 mtklein@google.com avoid redundant clamps
2019-11-08 mtklein@google.com don't clamp alpha, it's already [0,1]
2019-11-08 mtklein@google.com native f32 min/max
2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-08 mtklein@google.com convert SkVMBlitter over to floats
2019-11-08 csmartdalton@google.com Always attach stencil buffers with exact sample count matches
2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-08 jlavrova@google.com Fixing no icu situation
2019-11-08 reed@google.com add flatten test to SkFont
2019-11-08 csmartdalton@google.com Defer stencil attachment until opsTask execution

Created with:
  gclient setdep -r src/third_party/skia@4135cf0b57c2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-08 19:11:35 -05:00
Harry Terkelsen
3efc91706b Implement Path.computeMetrics in the CanvasKit backend (flutter/engine#13760)
* Implement Path.computeMetrics in the CanvasKit backend

* Add license for path_metrics.dart
2019-11-08 15:53:42 -08:00
Jason Simmons
b374cbe299 libtxt: pass an RTL bool flag instead of a bidiFlags enum to measureText (flutter/engine#13736)
Fixes https://github.com/flutter/flutter/issues/41086
2019-11-08 15:18:06 -08:00
Chris Yang
68754a85f0 Revert "Reland "Guarding EAGLContext used by Flutter #13314" (#13755)" (flutter/engine#13757)
This reverts commit a4a346f317c867663a6d8a5d9c7909101d9b5cbd.
2019-11-08 13:44:29 -08:00
Ferhat
1f2d6ce8f8 [web] Support gif/webp animations, Speed up image drawing in BitmapCanvas. (flutter/engine#13748)
* Add draw image test
* Optimize drawImageScaled
* optimize cloning in HtmlImage, implement drawImageRect using image tag
2019-11-08 12:52:01 -08:00
Chris Yang
a4a346f317 Reland "Guarding EAGLContext used by Flutter #13314" (flutter/engine#13755) 2019-11-08 12:26:48 -08:00
Greg Spencer
d7e49ecd5b Move TextRange from the framework to dart:ui. (flutter/engine#13747)
This removes TextRange from the framework and moves it to the engine, in preparation for using it to return text ranges from the text extent APIs, like Paragraph.getWordBoundary instead of a List<int>.

Also added new tests for TextRange.
2019-11-08 12:21:46 -08:00
skia-flutter-autoroll
591957f3ca Roll src/third_party/skia 8c1e265f6f81..c88d1774ed50 (7 commits) (flutter/engine#13754)
https://skia.googlesource.com/skia.git/+log/8c1e265f6f81..c88d1774ed50

git log 8c1e265f6f81..c88d1774ed50 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-08 mtklein@google.com add SkColorTypeIsNormalized()
2019-11-08 jlavrova@google.com Font resolution: all unit tests working
2019-11-08 kjlubick@google.com [canvaskit] Expand SkAnimatedImage
2019-11-08 kjlubick@google.com [canvaskit] Fix null dereference when GrContext cannot be made
2019-11-08 egdaniel@google.com Handle failure to create VkRenderPasses in vulkan backend.
2019-11-08 mtklein@google.com Pre-flight SkTLS_pthread changes for C++17

Created with:
  gclient setdep -r src/third_party/skia@c88d1774ed50

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-08 15:16:52 -05:00
Chris Yang
af43ff4a31 Revert "Always use IOSGLContextSwitch to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext (#13314)" (flutter/engine#13753) 2019-11-08 10:59:45 -08:00
Chris Yang
4953fbdd3f Always use IOSGLContextSwitch to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext (flutter/engine#13314) 2019-11-08 10:02:23 -08:00
skia-flutter-autoroll
118a07c1de Roll src/third_party/skia 99b558b594a1..8c1e265f6f81 (1 commits) (flutter/engine#13751)
https://skia.googlesource.com/skia.git/+log/99b558b594a1..8c1e265f6f81

git log 99b558b594a1..8c1e265f6f81 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 mtklein@google.com remove redundant comparison ops

Created with:
  gclient setdep -r src/third_party/skia@8c1e265f6f81

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-08 10:04:30 -05:00
skia-flutter-autoroll
aaeab00d4f Roll src/third_party/skia 3fd426d19df3..99b558b594a1 (1 commits) (flutter/engine#13749)
https://skia.googlesource.com/skia.git/+log/3fd426d19df3..99b558b594a1

git log 3fd426d19df3..99b558b594a1 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cc0919dcb64b..652dbfc63e70 (7 commits)

Created with:
  gclient setdep -r src/third_party/skia@99b558b594a1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-08 04:51:31 -05:00