1625 Commits

Author SHA1 Message Date
Anatoly Pulyaevskiy
bb59993ac6
Expose 3 new methods with text metrics in RenderParagraph (#65150) 2020-09-09 15:45:03 -07:00
Michael Goderbauer
127e67902e
Revert "Nnbd widgets (#64672)" (#65488)
This reverts commit e682ec711a8c05fe78157595240b392de339fa32.
2020-09-09 15:18:54 -07:00
Alexandre Ardhuin
e682ec711a
Nnbd widgets (#64672)
* migrate widget to nullsafety

* remove double blank line after license

* address review comments in actions.dart

* nullable ObjectKey.value

* use local variable oldElement

* make State.build non-nullable

* make State.context non-nullable

* newline at eof

* make ProxyWidget.child non-nullable

* make _InactiveElements.debugContains non-nullable

* make Element.depth non-nullable

* make ProxyElement.build non-nullable

* make StatefulElement.state non-nullable

* remove 'Notice that'

* avoid cast of list in RenderObjectElement.updateChildren

* make IndexedSlot.value non-nullable

* avoid cast of list in MultiChildRenderObjectElement.mount

* make some WidgetsApp parameters non-nullable

* hitTest take non-nullable position

* make ScrollableState.position non-nullable

* use _pixels instead of pixels

* make ViewportOffset.pixels non-nullable

* make param and return type of IndexedWidgetBuilder non-nullable

* unused_import

* make context param non-nullable for Builder in animated_list.dart

* make ScrollMetrics.viewportDimension non-nullable

* make ScrollMetrics.{min,max}ScrollExtent non-nullable

* make _Location.file non-nullable

* _WidgetForTypeTests.createElement throw UnimplementedError

* update _NullWidget.build error message

* make _ShortcutsState.manager non-nullable

* Fix childCount issues for NNBD

* fix childCount computation on web

* increase max value on js side to compute childCount

* make aspect parameter of dependOnInheritedWidgetOfExactType nullable

* merge has{min,max}ScrollExtent into hasScrollExtents

* update focus_manager.dart

* address review comments in icon.dart

* address review comments in image.dart

* address review comments in routes.dart

* address review comments in scroll_activity.dart

* update doc comments

* make UserScrollNotification.direction non-nullable and required

* rename hasScrollExtents to hasContentDimensions

* unnecessary late

Co-authored-by: Ian Hickson <ian@hixie.ch>
2020-09-09 10:52:27 +02:00
Pedro Massango
38834d36d3
Improve API docs (#65394) 2020-09-09 07:47:17 +08:00
Ian Hickson
1a010de89f
Make Container always clip a decoration if it has a clip edge (#64840)
This allows us to rationalize the nullability of some of our APIs.
Prior to this we'd end up in a situation where Container assumed that
getClipPath would be non-null but Decoration was ok with return null.
2020-09-08 12:06:28 -07:00
Kate Lovett
20936eeac4
Allow for arbitrary placement in SliverGrid (#64750) 2020-09-03 11:20:04 -07:00
Jonah Williams
09a9671ed3
[semantics] avoid sync* and excessive list copies (#64879)
Previous benchmarks have established the performance of sync*. Additionally, why allocate a list when you don't need to? Since these APIs are private, they can be re-arranged a bit to avoid creating as many lists. Will probably not have a large effect on benchmarks
2020-08-31 12:15:26 -07:00
LongCatIsLooong
fe55dc2b13
Reland "Prevent viewport.showOnScreen from scrolling the viewport if the specified Rect is already visible. (#56413)" reverted in #64091 (#64513) 2020-08-28 22:13:04 -07:00
gaowanqiu
619eccd2e3
Fix negative usableCrossAxisExtent in release mode (#64441) 2020-08-28 16:13:05 -07:00
Ian Hickson
8a6a76a334
migrate rendering to nullsafety (#64621) 2020-08-27 16:38:10 -07:00
LongCatIsLooong
6536f65048
Revert "Warns when single line text fields overflow (#63639)" (#64573)
This reverts commit 0ab5ecc86b1f13854ecc0cb4a89fbdc9938c5212.
2020-08-25 11:11:15 -07:00
chunhtai
39d7a019c1
Reland "fix wrap intrinsic height calculation (#63420)" (#64276) 2020-08-25 10:01:07 -07:00
LongCatIsLooong
0ab5ecc86b
Warns when single line text fields overflow (#63639) 2020-08-24 18:16:05 -07:00
LongCatIsLooong
7d6ffc7cc9
Add rect logic to getOffsetToReveal when onlySlivers is true (#64295) 2020-08-24 12:36:04 -07:00
Ian Hickson
93395b4890
Add null safety migration annotations. (#64227) 2020-08-21 11:21:04 -07:00
Tong Mu
fb0b982324
Change MouseTracker's interface for clarity. Simplify MouseRegion's implementation. (#64119)
* Redesigns the interface between MouseTracker and RendererBinding&RenderView.
* Simplifies the structure of RenderMouseRegion.
* Extracts the common utility code between mouse_tracker_test and mouse_tracker_cursor_test.
2020-08-19 18:51:56 -07:00
Jonah Williams
38e0c25823
[flutter_tools] reland: enable --null-assertions for flutter framework tests (#64120)
Reland of acdb909 with fixes to semantics.dart

#61042
2020-08-19 13:25:42 -07:00
Mehmet Fidanboylu
bd6252eb3a
Revert "Prevent viewport.showOnScreen from scrolling the viewport if the specified Rect is already visible. (#56413)" (#64091)
This reverts commit 64d76f2fb7ed5eb785c660084b18ed5a51fd926b.
2020-08-18 13:55:33 -07:00
Mehmet Fidanboylu
473744df2c
Revert "fix wrap intrinsic height calculation (#63420)" (#64046)
This reverts commit 72619b86421bfdbf4ef7b98cb893b168b89c8677.
2020-08-18 08:07:14 -07:00
Andre
9e0ad9b6b5
Fix FittedBox BoxFit.scaleDown sizing (#63668) 2020-08-17 22:36:02 -07:00
chenjianguang
f45cdd57e2
Add debug flag debugProfileLayoutsEnabled. (#63652) 2020-08-17 10:36:03 -07:00
LongCatIsLooong
64d76f2fb7
Prevent viewport.showOnScreen from scrolling the viewport if the specified Rect is already visible. (#56413) 2020-08-14 16:41:03 -07:00
Nolan Scobie
ede1b15b76
Add viewport documentation breadcrumbs (#63192) 2020-08-14 15:56:02 -07:00
chunhtai
72619b8642
fix wrap intrinsic height calculation (#63420) 2020-08-12 15:21:07 -07:00
chunhtai
58e839223d
reland fix intrinsic height and width for widget span #61485 (#63118) 2020-08-07 21:01:03 -07:00
Nolan Scobie
43c1b34cf5
Add punctuation for unterminated sentences in doc comments (#62755)
* Add punctuation for unterminated sentences in doc comments

* Addressing review nit
2020-08-06 19:18:52 -04:00
Kate Lovett
79146fd0a6
Fix SliverList scrollOffsetCorrection 0 case (#62615) 2020-08-06 16:11:16 -07:00
chunhtai
8663b3c4bf
Reland "remove usage to applyTextScaleFactorToWidgetSpan" (#62587)
This reverts commit 561735ad89a14c63597f9acb77d447c7e0ed4fec.
2020-07-31 10:18:20 -07:00
Tong Mu
5398f5c566
Add tests for platform views' hover behavior (#61667) 2020-07-29 14:47:06 -07:00
Michael Goderbauer
88a7d83a32
fix unresolved doc references in widgets - part 2 (#62499) 2020-07-29 14:27:12 -07:00
Michael Goderbauer
81087ef2b6
Fix "unresolved doc reference" in widgets layer - part 1 (#62452) 2020-07-28 19:55:16 -07:00
Michael Goderbauer
f4e10b4fb5
Make dartdoc warnings fatal (& cleanup of warnings) (#62367) 2020-07-28 16:11:04 -07:00
Michael Goderbauer
fe05cfbe6c
Fix "unresolved doc reference" in rendering layer (#62443) 2020-07-28 15:13:55 -07:00
Pragya
c867a1ed23
Updated 'CustomClipper.shouldReclip' doc (#62101) 2020-07-28 10:51:06 -07:00
Darren Austin
c14e328c26
Updated references to the old button classes to the new ones in comments and documentation for classes in the widgets, services and rendering libraries. (#62099) 2020-07-28 10:46:10 -07:00
Kate Lovett
9bf1793a10
Fix crossSize for baseline (#62074) 2020-07-28 10:36:15 -07:00
Kate Lovett
d1411a1626
Remove unused FlutterErrorDetails subclasses (#61579) 2020-07-24 15:36:08 -07:00
chunhtai
561735ad89
Revert "remove usage to applyTextScaleFactorToWidgetSpan (#61636)" (#62144)
This reverts commit c816fabd0af48a861afdeb78bb6ebe4b7cbd3707.
2020-07-23 10:35:21 -07:00
LongCatIsLooong
64173f75c3
Check if a double is NaN before converting to it int (#61940) 2020-07-23 08:31:08 -07:00
Michael Goderbauer
8e58c51d1a
Update viewport dimensions when scrollDirection changes (#61973) 2020-07-23 08:30:26 -07:00
Michael Goderbauer
4b4287ba78
Make it an error to break macros in docs (and fix existing broken macros) (#62071) 2020-07-23 08:29:46 -07:00
chunhtai
c816fabd0a
remove usage to applyTextScaleFactorToWidgetSpan (#61636) 2020-07-22 18:41:06 -07:00
chunhtai
c44e5a32b5
Revert "InkDecoration do not paint if it's part of the tree doesn't get painted (#61216)" (#61963)
This reverts commit fdf87edd2fadb3ba3219d23792f0210384533e1b.
2020-07-21 09:35:40 -07:00
Pierre-Louis
5d854f63a0
Implement customizable cursor height (#61714) 2020-07-21 07:36:03 -07:00
xubaolin
fdf87edd2f
InkDecoration do not paint if it's part of the tree doesn't get painted (#61216) 2020-07-20 18:56:04 -07:00
chunhtai
3577da53ff
Revert "fix intrinsic height and width for widget span (#61485)" (#61876)
This reverts commit fc09119d0af589ade9c7e0609777a46ed773f5d7.
2020-07-20 09:54:50 -07:00
Chris Yang
30e556ddc5
Add no-op callbacks to platform view gesture recognizer when necessary (#61671)
After #31935, Some one sequence gesture recognizers requires at least one callback to be able to compete in the arena. This PR adds the a no-op callback in the gesture recognizer in the platform view when the gesture recognizer does not have any callbacks. This way, all the gesture recognizers in the platform view can compete in the arena.
2020-07-17 12:13:22 -07:00
Todd Volkert
5587ca17e8
Add assert in PictureLayer.addToScene() (#61655)
SceneBuilder.addPicture() is implemented in C++, and if `picture`
is null, it will seg-fault. This catches the problem before that
happens.
2020-07-16 23:14:56 -07:00
chunhtai
fc09119d0a
fix intrinsic height and width for widget span (#61485) 2020-07-16 09:36:09 -07:00
Todd Volkert
9e665e1d88
Update documentation for IntrinsicWidth & IntrinsicHeight (#61502)
https://github.com/flutter/flutter/issues/61496
2020-07-15 11:54:32 -07:00