DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
264 Commits 882 Branches 1,069 Tags
Commit Graph

14 Commits

Author SHA1 Message Date
Ojan Vafai
aae0aab814 Delete unused methods/arguments from RenderBlockFlow. 
No change in behavior. Just deleting dead code.
Removes hit testing and paint phase for floats. They
bottomed out into empty functions.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/706953003
 2014-11-06 11:17:20 -08:00
Ojan Vafai
4ecaa91c6c Remove margin collapsing. 
Margin collapsing is a document-oriented feature. For applications
it just causes confusion and slowness.

margins.sky has failure output because offsetTop is returning the
wrong values. That's not new with this patch though. When I look
at it visually in skydb, everything seems to be in the right place.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/700743002
 2014-11-03 21:30:40 -08:00
Ojan Vafai
29ff7e21fd Remove more float machinery. 
Also removed the clear property since it's only purpose was
to clear floats.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/700703002
 2014-11-03 17:00:27 -08:00
Ojan Vafai
ab8e1f98d5 Remove more support for floats from RenderBlockFlow. 
This doesn't change any behavior. Floats were already removed.
This is just removing effectively noop code.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/692563004
 2014-11-03 12:40:09 -08:00
Ojan Vafai
7d3feb3952 Remove line breaking to avoid window. 
Now that we don't have multi-column or pagination, this
is dead code. This also means we don't need to call
layoutBlockFlow in a loop.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/697713002
 2014-10-31 12:41:40 -07:00
Ojan Vafai
20dd8466c7 Remove border-fit. 
This just lets you size an element to it's content. We should
do this in a more generic way or let you override layout
and do it yourself.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/698613002
 2014-10-31 10:59:40 -07:00
Ojan Vafai
21bde7479d Remove final instances of WritingMode in Sky. 
After this patch, the only instance of WritingMode is in a comment.
No change in behavior.

TBR=esprehn@chromium.org

Review URL: https://codereview.chromium.org/674073005
 2014-10-29 19:58:14 -07:00
Ojan Vafai
86ed666dc2 Get rid of isWritingModeRoot. 
This function always returns false now that we don't have writing modes.

TBR=esprehn@chromium.org

Remove flipForWritingMode.

It's a noop now that we don't have writing modes.

Review URL: https://codereview.chromium.org/688223002
 2014-10-29 19:53:05 -07:00
Ojan Vafai
afa0148e0b First pass at removing dead vertical writing mode code. 
This just removes a random subset of vertical writing mode bits
that I grepped for. There's a ton more to do, but it seems best to
do it in chunks.

The key things for understanding this patch, isWritingModeRoot is
always false and isHorizontalWritingMode is always true. Also,
we're never flipped* modes of any kind, so we can undo any flipping.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/688213002
 2014-10-29 19:06:59 -07:00
Elliott Sprehn
7c0366d891 Remove most of FloatingObject. 
This leaves some uses of FloatingObject*, but it doesn't
leave the impl of the class so it's all dead code passing
around null pointers. I'll remove that in a future patch.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/689733003
 2014-10-29 15:04:40 -07:00
Elliott Sprehn
e47b2bdb5f Remove a lot of floats related code. 
R=eseidel@chromium.org, ojan@chromium.org

Review URL: https://codereview.chromium.org/678113005
 2014-10-29 14:08:55 -07:00
Ojan Vafai
ce9aa787cb Remove more frame-level scrolling machinery. 
This is all dead code. No change in behavior.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/678193005
 2014-10-28 19:27:52 -07:00
Eric Seidel
64b5cb61a1 Remove all oilpan transitional types 
I used do-webcore-rename from Blink/WebKit
which is very good at doing this kind
of search-replace.

Also removed toRefPrtNativeArray after
conversion since it previously had two
separate flavors.  Both versions are no longer
used so I've removed the code until we
need one again.

https://www.irccloud.com/pastebin/5C16p5cE
is the diff I used to do-webcore-rename

TBR=abarth@chromium.org
 2014-10-27 14:13:01 -07:00
Adam Barth
ae72930937 Open the Sky 2014-10-23 11:17:19 -07:00