Polina Cherkasova
0f2618ff4f
Fix or except leaks. ( #141081 )
...
Contributes to https://github.com/flutter/devtools/issues/6909 .
2024-01-10 00:17:33 +00:00
Polina Cherkasova
baf739c8e6
Remove usage of testWidgetsWithLeakTracking. ( #140239 )
2023-12-15 14:13:31 -08:00
Taha Tesser
e8c2bb1356
Reland "Update framework_test.dart to remove ButtonBar usage and remove references from other clases ( #137550 ) ( #137753 )
...
This PR removes `ButtonBar` usage from `framework_test.dart` class and update other references in preparation for `ButtonBar` deprecation
related to https://github.com/flutter/flutter/issues/127955
reland https://github.com/flutter/flutter/pull/137550
2023-11-14 17:55:05 +00:00
Alex Isaienko
b5fb6652d6
InheritedElement.removeDependent() ( #129210 )
...
Call the `dependency.removeDependent(this)` instead of `dependency._dependents.remove(this)` inside the `Element.deactivate()`. This allows `InheritedElements` to know when they can release resources associated with a given dependent `Element`.
Fixes #129207
2023-11-03 23:27:21 +00:00
auto-submit[bot]
b47e4c4acb
Reverts "Update framework_test.dart to remove ButtonBar usage and remove references from other clases" ( #137731 )
...
Reverts flutter/flutter#137550
Initiated by: Piinks
This change reverts the following previous change:
Original Description:
This PR removes `ButtonBar` usage from `framework_test.dart` class and update other references in preparation for `ButtonBar` deprecation
related to https://github.com/flutter/flutter/issues/127955
2023-11-01 22:58:19 +00:00
Taha Tesser
b1f5d96a82
Update framework_test.dart to remove ButtonBar usage and remove references from other clases ( #137550 )
...
This PR removes `ButtonBar` usage from `framework_test.dart` class and update other references in preparation for `ButtonBar` deprecation
related to https://github.com/flutter/flutter/issues/127955
2023-11-01 22:03:54 +00:00
Kostia Sokolovskyi
95eae5f967
Cover more test/widgets tests with leak tracking #12 . ( #135385 )
2023-09-29 17:47:04 -07:00
Polina Cherkasova
49e16867a3
TabController should dispatch creation in constructor. ( #133952 )
2023-09-22 15:27:05 -07:00
Kostia Sokolovskyi
ff10c52ad6
Cover more test/widgets tests with leak tracking #3 ( #134576 )
2023-09-14 12:26:41 -07:00
Polina Cherkasova
bff6b93683
Next attempt to make inspector weakly referencing the inspected objects. ( #129962 )
2023-07-06 12:19:18 -07:00
Michael Goderbauer
6221d5c709
Refactor tests ( #128371 )
...
To make them a little more resilient to changes in the tree shape as the tree will be changing a little bit for multi view.
2023-06-07 03:02:55 +00:00
Michael Goderbauer
7f41ab25c9
Fix (insert|move|remove)RenderObjectChild methods in base class ( #123276 )
2023-03-23 12:34:26 -07:00
yim
c4d40cc152
Modify the updateChildren method deep copy _children ( #120773 )
...
* Modify the updateChildren method deep copy _children
* add test
* fix some small nits
* Simplified newChildren declaration in updateChildren
2023-02-17 18:29:02 +00:00
Michael Goderbauer
bb73121cb4
Remove unnecessary null checks in flutter/test ( #118905 )
2023-01-20 22:09:06 +00:00
Michael Goderbauer
81bc54be75
Enable use_colored_box lint ( #117370 )
2022-12-20 14:09:55 -08:00
Michael Goderbauer
bf5fdb9f96
Reland "Inject current FlutterView into tree and make available via View.of(context) ( #116924 )" ( #117244 )
...
* Reland "Inject current `FlutterView` into tree and make available via `View.of(context)` (#116924 )"
This reverts commit 9102f2fe0bd26db6074ac4a17785296cd341ecb9.
* remove window placeholder
2022-12-17 06:14:19 +00:00
Casey Hillers
9102f2fe0b
Revert "Inject current FlutterView into tree and make available via View.of(context) ( #116924 )" ( #117214 )
...
This reverts commit a34e41948461de77bdec3dcc884900cd4544abb1.
2022-12-16 17:48:23 +00:00
Michael Goderbauer
a34e419484
Inject current FlutterView into tree and make available via View.of(context) ( #116924 )
...
* enable View.of
* tests
* ++
* greg review
* rewording
* hide view from public
2022-12-16 00:13:56 +00:00
Michael Goderbauer
2b9beda0d0
Reland "Keep dirty manipulations private to Element base class ( #109401 )" ( #109562 )
2022-08-15 19:59:13 +00:00
Greg Spencer
7887ca5bb5
Revert "Keep dirty manipulations private to Element base class ( #109401 )" ( #109481 )
...
Landing on red to green the build.
2022-08-12 18:28:24 -07:00
Michael Goderbauer
a624cb71b3
Keep dirty manipulations private to Element base class ( #109401 )
2022-08-12 12:54:03 -07:00
Ian Hickson
7ded3d91da
API documentation cleanup ( #108500 )
2022-08-10 22:03:20 +00:00
Michael Goderbauer
ed0c8d77f8
Remove some outdated ignores from framework ( #108915 )
2022-08-03 22:42:06 +00:00
Kenzie Davisson
1b2ee411aa
Sort diagnostics node dependencies so that order is stable ( #105319 )
...
* Sort diagnostics node dependencies so that order is stable
* use toDescription
* use toStringShort when possible
* sort InheritedElements
2022-06-06 07:55:09 -07:00
gaaclarke
18713e0c5d
Made Directionality forego dependency tracking for better performance. ( #102336 )
2022-04-25 15:39:05 -07:00
Michael Goderbauer
51bcdb9407
super parameters for framework ( #100905 )
2022-04-13 22:38:40 -07:00
Ian Hickson
ab89ce285f
Clean up the bindings APIs. ( #89451 )
2022-02-03 14:55:15 -08:00
chunhtai
28ca7bd789
Allow current leader of layerlink to detach before the previous leade… ( #96810 )
2022-01-24 11:50:11 -08:00
Jonah Williams
dafda50c6a
[framework] remove hashcode override for Element ( #96644 )
2022-01-14 15:45:18 -08:00
Anis Alibegić
a753d09cc9
Fixed several typos ( #89485 )
2021-09-07 14:56:04 -07:00
Darren Austin
e2fb5cc318
Updated skipped tests for widgets directory. ( #87879 )
2021-08-09 15:05:44 -07:00
Ren You
3dea9f0251
Revert "Clean up the bindings APIs ( #86438 )" ( #86484 )
...
This reverts commit d056500bfe6a712cdace450d06c4a8fb2290e63a.
2021-07-15 09:29:16 -07:00
Ian Hickson
d056500bfe
Clean up the bindings APIs ( #86438 )
2021-07-14 14:41:24 -07:00
Zachary Anderson
7f741e9181
Revert "Clean up the bindings APIs ( #86388 )" ( #86404 )
...
This reverts commit 31de052e3fddb4909ff88172a6937db7f3dc49db.
2021-07-13 21:32:29 -07:00
Ian Hickson
31de052e3f
Clean up the bindings APIs ( #86388 )
2021-07-13 18:31:11 -07:00
Ian Hickson
c800b9c3e4
Revert "Clean up the bindings APIs ( #83843 )" ( #86386 )
...
This reverts commit e2490f2906060d0aaecbbe34a9240ca3d54ef998.
2021-07-13 15:47:40 -07:00
Ian Hickson
e2490f2906
Clean up the bindings APIs ( #83843 )
2021-07-13 12:41:03 -07:00
Ahmed Ashour
a3dc90c4f5
Add space before curly parentheses. ( #85306 )
2021-07-01 13:51:05 -07:00
Greg Spencer
1ac209c222
Turn on avoid_dynamic_calls lint, make appropriate changes. ( #84478 )
2021-06-23 16:36:03 -07:00
Dan Field
c1fe2bd1e0
Reland "Dispose render objects when owning element is unmounted. ( #82883 )" ( #83790 ) ( #83920 )
2021-06-07 18:39:02 -07:00
Dan Field
bcc8f083a2
Forbid calling findRenderObject on an unmounted element ( #83962 )
2021-06-07 16:37:55 -07:00
Ren You
63c49c3d83
Revert "Dispose render objects when owning element is unmounted. ( #82883 )" ( #83790 )
...
This reverts commit c75edc268ca336c66a103f1c0d82c4dff140fca0.
2021-06-02 07:54:19 -07:00
Dan Field
c75edc268c
Dispose render objects when owning element is unmounted. ( #82883 )
2021-06-01 22:29:02 -07:00
Michael Goderbauer
7b9a175557
Assert when duplicated keys are introduced in subsequent build ( #81850 ) ( #82201 )
2021-05-11 09:41:02 -07:00
Michael Goderbauer
b8a2456737
Enable library_private_types_in_public_api lint ( #81578 )
2021-05-10 16:26:16 -07:00
Hans Muller
dbc8826816
Revert "Assert when duplicated keys are introduced in subsequent build ( #81850 )" ( #82039 )
...
This reverts commit 3ab799bbc934e5f6d032557cdcb1486ce6b93c4b.
2021-05-07 10:19:47 -07:00
Michael Goderbauer
3ab799bbc9
Assert when duplicated keys are introduced in subsequent build ( #81850 )
2021-05-06 19:49:02 -07:00
Todd Volkert
efc079657b
Allow reuse of NavigatorObserver in Navigator.observers ( #81601 )
2021-05-06 19:39:03 -07:00
Alexandre Ardhuin
1a3af88ced
add missing trailing commas ( #81362 )
2021-04-28 10:54:05 -07:00
Phil Quitslund
61c30c41b2
fix sort_directives violations ( #80817 )
2021-04-21 13:49:03 -07:00
