Kostia Sokolovskyi
e36a868beb
TrainHoppingAnimation should dispatch creation and disposal events. ( #141635 )
2024-01-16 19:13:58 -08:00
Polina Cherkasova
a8e699249b
Ignore or fix leaks. ( #141468 )
2024-01-16 09:44:49 -08:00
Polina Cherkasova
0f2618ff4f
Fix or except leaks. ( #141081 )
...
Contributes to https://github.com/flutter/devtools/issues/6909 .
2024-01-10 00:17:33 +00:00
Polina Cherkasova
baf739c8e6
Remove usage of testWidgetsWithLeakTracking. ( #140239 )
2023-12-15 14:13:31 -08:00
Taha Tesser
fc917c7184
[Reland] Introduce AnimationStyle ( #138721 )
...
This PR introduces `AnimationStyle`, it is used to override default
animation curves and durations in several widgets.
fixes [Add the ability to customize MaterialApp theme animation
duration](https://github.com/flutter/flutter/issues/78372 )
fixes [Allow customization of showMenu transition animation curves and
duration](https://github.com/flutter/flutter/issues/135638 )
fixes [`AnimationStyle.noAnimation` needs to replace `AnimatedTheme`
with just `Theme` in the
`MaterialApp`](https://github.com/flutter/flutter/issues/138618 )
Here is an example where popup menu curve and transition duration is
overridden:
```dart
popUpAnimationStyle: AnimationStyle(
curve: Easing.emphasizedAccelerate,
duration: Durations.medium4,
),
```
Set `AnimationStyle.noAnimation` to disable animation.
```dart
return MaterialApp(
themeAnimationStyle: AnimationStyle.noAnimation,
```
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-11-20 15:24:41 -08:00
Kostia Sokolovskyi
aeb500a060
AnimationController should dispatch creation in constructor. ( #134839 )
2023-10-26 16:23:33 -07:00
Kostia Sokolovskyi
22f593e578
GoldenFileComparators should dispose created Image objects. ( #136716 )
2023-10-17 15:25:52 -07:00
Polina Cherkasova
9f512d7037
Mark leak in NativeCodec.getNextFrame. ( #136514 )
2023-10-13 11:57:57 -07:00
Tong Mu
e66ec8e0b0
Dispose AnimationSheetRecorder to avoid leaks ( #133365 )
...
This PR adds `AnimationSheetRecorder.dispose`, which disposes all the images generated by the recorder, eliminating leaks.
Fixes https://github.com/flutter/flutter/issues/133071 .
2023-09-05 20:49:05 +00:00
Polina Cherkasova
2afded6170
Add test to mark recording as leaking. ( #133073 )
2023-08-23 00:06:05 +00:00
Polina Cherkasova
a7b69b069f
Unpin leak_tracker and handle breaking changes in API. ( #132352 )
2023-08-14 10:05:20 -07:00
Zachary Anderson
f4c25bbb35
Revert "Handle breaking changes in leak_tracker." ( #132223 )
...
Reverts flutter/flutter#131998
Reverting for https://github.com/flutter/flutter/issues/132222
2023-08-09 08:14:39 -07:00
Polina Cherkasova
acd636f7ba
Handle breaking changes in leak_tracker. ( #131998 )
2023-08-08 09:39:19 -07:00
Kate Lovett
b3a4decda6
Assert against infinite values of control points in CatmullRomSpline ( #131820 )
...
When providing infinite values for the control points of CatmullRomSpline, a StackOverflowError occurs. This asserts against that and provides a helpful error message.
Fixes https://github.com/flutter/flutter/issues/131246
2023-08-03 00:18:13 +00:00
pdblasi-google
af09b57e20
Removes deprecated APIs from AnimationBuilder ( #129657 )
...
Removes deprecated APIs from AnimationBuilder.
Resolves #129653
2023-06-28 20:12:19 +00:00
Michael Goderbauer
9b230d239a
Fix leaks ( #126144 )
...
Fixes https://github.com/flutter/flutter/issues/126096 .
Fixes https://github.com/flutter/flutter/issues/126097 .
Fixes https://github.com/flutter/flutter/issues/126102 .
Fixes https://github.com/flutter/flutter/issues/126098 .
Fixes https://github.com/flutter/flutter/issues/126147 .
Work towards https://github.com/flutter/flutter/issues/126100 .
Does not fix the OverlyEntry/ModalRoute leak (https://github.com/flutter/flutter/issues/126100 ).
2023-05-08 09:11:23 +00:00
Polina Cherkasova
5a80f8d637
Define testWidgetsWithLeakTracking. ( #125063 )
2023-05-04 12:09:41 -07:00
Michael Goderbauer
b308555ed1
Enable dangling_library_doc_comments and library_annotations lints ( #117365 )
2022-12-20 16:03:21 -08:00
Jonah Williams
8f0981c048
[framework] Animatable.fromCallback and code snippet ( #108661 )
2022-08-09 21:48:04 +00:00
Jonah Williams
40940de636
[framework] create animation from value listenable ( #108644 )
2022-07-30 00:41:04 +00:00
Alexandre Ardhuin
552c50e67c
more const immutable classes ( #104988 )
...
* more const immutable classes
* more const constructors in dev/ and examples/
2022-05-31 21:56:24 +02:00
Alexandre Ardhuin
d40ee2149c
remove unnecessary .toString() ( #103226 )
2022-05-06 16:04:13 -07:00
Michael Goderbauer
51bcdb9407
super parameters for framework ( #100905 )
2022-04-13 22:38:40 -07:00
Michael Goderbauer
7f2c1cd772
Use PlatformDispatcher.instance over window where possible ( #99496 )
2022-03-03 14:46:16 -08:00
Ian Hickson
ab89ce285f
Clean up the bindings APIs. ( #89451 )
2022-02-03 14:55:15 -08:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint ( #91409 ) ( #91462 )
2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint ( #91409 )" ( #91461 )
...
This reverts commit 5fd259be244244e14ff87fee9b6a721625f952cd.
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint ( #91409 )
2021-10-07 20:13:02 -07:00
Kate Lovett
616f9bcffa
Add tag support for executing reduced test sets ( #86821 )
2021-08-30 15:41:02 -07:00
Swiftaxe
fe337dcaf5
Animation controller test ( #88251 )
...
Co-authored-by: Alexander Dahlberg <alexander.dahlberg@sigma.se>
Fixes test/animation/animation_controller_test.dart in #85160
Problem:
The test 'animateTo can deal with duration == Duration.Zero' was failing with the following error:
Expected: <0>
Actual: <5>
Expected no animation.
package:test_api expect
package:flutter_test/src/widget_tester.dart 484:3 expect
test/animation/animation_controller_test.dart 511:5 main.
Following line finds 5 transientCallbacks scheduled, while expecting zero, if shuffled with seed 123:
expect(SchedulerBinding.instance!.transientCallbackCount, equals(0), reason: 'Expected no animation.');
This is caused by some other test leaving transientCallbacks scheduled.
Fix:
By disposing the AnimationController after each test, the transientCallbacks get cleaned up.
I chose to dispose all controllers in every test, to make sure there is no risk of leaks.
2021-08-16 09:28:11 -07:00
Kate Lovett
1a76a01f0f
Skip flaky test ( #87589 )
2021-08-03 14:35:03 -07:00
Tong Mu
884158a6e3
Reland 3: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests ( #87239 )
...
* Revert "Revert "Reland 2: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests (#86912 )" (#87233 )"
This reverts commit 5b80d32a8430e1c44d052307dcee3c4f9fee4874.
* Record tap positions
2021-07-29 15:11:26 -07:00
Tong Mu
5b80d32a84
Revert "Reland 2: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests ( #86912 )" ( #87233 )
...
This reverts commit b50991d6833e6551bef6e06c48ff959b9d1c5d07.
2021-07-28 15:44:09 -07:00
Tong Mu
b50991d683
Reland 2: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests ( #86912 )
2021-07-27 14:44:03 -07:00
Greg Spencer
738ce43d97
Randomize tests, exclude tests that fail with randomization. ( #86793 )
...
* Randomize tests, exclude tests that fail with randomization.
* Disable some more tool tests
2021-07-26 23:40:49 -07:00
Darren Austin
152c2ed3e4
Skip test audit for animation tests. ( #87063 )
2021-07-26 12:42:55 -07:00
Tong Mu
24ad608bd8
Revert "Reland: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests ( #86739 )" ( #86823 )
...
This reverts commit cf3d9409b311b64b35c2596a4c1b98b55e08089c.
2021-07-21 16:13:10 -07:00
Tong Mu
cf3d9409b3
Reland: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests ( #86739 )
...
This PR fixes several bugs related to live tests, adds more tests, and completes the documentation of several methods related to pointer events.
2021-07-21 12:49:26 -07:00
Kate Lovett
8802e325a0
Revert "Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests ( #86449 )" ( #86730 )
...
This reverts commit cd78190b0caec337a7ed51506d93f9ba20cefa29.
2021-07-20 14:56:50 -04:00
Tong Mu
cd78190b0c
Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests ( #86449 )
...
This PR fixes several bugs related to live tests, adds more tests, and completes the documentation of several methods related to pointer events.
2021-07-19 14:54:24 -07:00
Ren You
3dea9f0251
Revert "Clean up the bindings APIs ( #86438 )" ( #86484 )
...
This reverts commit d056500bfe6a712cdace450d06c4a8fb2290e63a.
2021-07-15 09:29:16 -07:00
Ian Hickson
d056500bfe
Clean up the bindings APIs ( #86438 )
2021-07-14 14:41:24 -07:00
Zachary Anderson
7f741e9181
Revert "Clean up the bindings APIs ( #86388 )" ( #86404 )
...
This reverts commit 31de052e3fddb4909ff88172a6937db7f3dc49db.
2021-07-13 21:32:29 -07:00
Ian Hickson
31de052e3f
Clean up the bindings APIs ( #86388 )
2021-07-13 18:31:11 -07:00
Ian Hickson
c800b9c3e4
Revert "Clean up the bindings APIs ( #83843 )" ( #86386 )
...
This reverts commit e2490f2906060d0aaecbbe34a9240ca3d54ef998.
2021-07-13 15:47:40 -07:00
Ian Hickson
e2490f2906
Clean up the bindings APIs ( #83843 )
2021-07-13 12:41:03 -07:00
Greg Spencer
6adea05276
Revert "Randomize Framework tests, opt out some tests that currently fail. ( #85159 )" ( #85673 )
...
This reverts commit b5f9612 because it is taking about 40% longer to run the tests, which is causing timeouts.
2021-06-30 19:38:09 -07:00
Greg Spencer
b5f9612cac
Randomize Framework tests, opt out some tests that currently fail. ( #85159 )
...
This turns on order shuffling for all tests that don't fail with it on, marking those tests that do fail with a tag so that they will be run without shuffling on.
To determine which tests fail with it on, I ran all the tests 100 times with different random shuffle seeds, and then also ran it with the date seeds from today until the end of July, and tagged all of the test suites (files) that fail, with a seed that caused them to fail.
2021-06-29 13:46:13 -07:00
Andrew Wilson
78ccced805
Fix leak of CurvedAnimations in long-lived ImplicitlyAnimatedWidgets. ( #84785 )
2021-06-18 17:14:02 -07:00
Sam Rawlins
da9b11ec24
Remove "unnecessary" imports. ( #83959 )
2021-06-04 10:54:05 -07:00
