104 Commits

Author SHA1 Message Date
Michael Goderbauer
a8ea6bd4af Mention Goma for Googlers in CONTRIBUTING.md (flutter/engine#3946)
* Mention Goma for Googlers in CONTRIBUTING.md

* review comments
2017-08-02 13:49:27 -07:00
Abhishek Amit
5ec8f6d9f2 Fix android-cpu flag reference (flutter/engine#3943) 2017-08-01 14:02:28 -07:00
Michael Goderbauer
370fdd56a7 Add Windows support to CONTRIBUTING.md (flutter/engine#3825) 2017-06-23 17:58:57 -07:00
gspencergoog
1b33b0f50b Removed 'pub get' from the instructions (flutter/engine#3774)
* Removed 'pub get' from the instructions

According to Hixie, 'pub get' is abstracted into flutter packages upgrade, and so there shouldn't be a need to run pub get directly.

* Removed pub get lines entirely.
2017-06-14 16:28:21 -07:00
xster
7b2e3b2609 Link to lldb page in tip (flutter/engine#3593) 2017-04-18 10:48:46 -07:00
xster
3f70cb283a Add instructions for debugging engine with xcode (flutter/engine#3411) 2017-02-10 13:56:02 -08:00
xster
cceefabcb1 Add CONTRIBUTING instructions for simulator (flutter/engine#3407) 2017-02-09 23:06:11 -08:00
xster
04d16b0303 Document the need to sync the engine repo to avoid #8005 (flutter/engine#3403)
* Document the need to sync the engine repo to avoid #8005

* Flit gclient sync and git pull
2017-02-09 12:08:37 -08:00
xster
1d95ca0ba0 Some tweaks to the contributing doc (flutter/engine#3402) 2017-02-08 18:29:11 -08:00
Michael Thomsen
b194ed3b5e Update editor recommendation (flutter/engine#3317)
Fixes https://github.com/flutter/flutter/issues/7294
2016-12-22 21:41:15 +01:00
Chinmay Garde
f1486c2ca0 Fix typo in README regarding --unopt builds on host. (flutter/engine#3308) 2016-12-12 16:04:57 -08:00
Ian Hickson
1ac8083795 Mention updating the buildroot git remotes (flutter/engine#3285)
* Mention updating the buildroot git remotes

I always forget how to do this...

* Update CONTRIBUTING.md
2016-11-30 20:33:19 -08:00
Philippe Ombredanne
13ee233052 Add unzip as a requirement in the contributing documentation. (flutter/engine#3273)
unzip is missing from documentation and is required to run 
"gclient sync"  successfully. Unzip does not come installed by default
on every Linux installations.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
2016-11-29 11:03:34 -08:00
Ian Hickson
d0de04bfa7 Update CONTRIBUTING.md (flutter/engine#3203)
At some point recently we started putting a JSON file in the out/ directory and this broke this suggested build script.
This patch makes the script more resilient to such files.
2016-11-04 14:36:27 -07:00
Chinmay Garde
70e14cacb6 Run the download_android_tools.py in a gclient hook. (flutter/engine#3050)
Originally, this was a step that had to be carried out manually. Presumably because we did not want developers to download the Android SDK and NDK if they were not targetting Android. In practice, this is rarely the case. Even the buildbots unconditionally run the script (though they don’t need Android artifacts on the Mac since there is no Mac to Android builder).
2016-09-21 12:05:02 -07:00
Ian Hickson
1ac1e37f63 Update CONTRIBUTING.md (flutter/engine#3028)
Have the sample build script exit after the first failed build.
2016-09-14 10:30:36 -07:00
Ian Hickson
b134c83830 Make the script rebase the right repository (flutter/engine#3025) 2016-09-13 23:40:50 -07:00
Ian Hickson
b51f7f0926 Update CONTRIBUTING.md (flutter/engine#2895) 2016-08-09 15:30:51 -07:00
Adam Barth
2a17639878 Update CONTRIBUTING.md to account for buildroot (flutter/engine#2893) 2016-08-09 14:14:10 -07:00
Chinmay Garde
0c30ca0d8d Update CONTRIBUTING.md to add iOS engine development instructions. (flutter/engine#2844) 2016-07-29 16:22:35 -07:00
Eric Seidel
e362c35d6c Better explain how to use a local engine
Added a section which explains how to get `dart:ui` changes.
2016-07-06 15:28:40 -07:00
Todd Volkert
4a7cbc0246 Remove instructions to add engine's dart-sdk to user's path. (#2736) 2016-06-07 14:16:32 -07:00
Adam Barth
1e8a040c70 Update docs about command line flags (#2725) 2016-05-31 10:19:52 -07:00
Adam Barth
946e248675 Revert "Remove vendored dart-sdk (#2688)"
We still need this for the observatory build.

This reverts commit 716e82edd8fa7b354d6cb5e16a218e8dcbd095fd.
2016-05-16 10:54:49 -07:00
Adam Barth
716e82edd8 Remove vendored dart-sdk (flutter/engine#2688)
The engine.git repo doesn't need a copy of the Dart SDK anymore.

Fixes https://github.com/flutter/flutter/issues/2618
2016-05-16 08:09:00 -07:00
Ian Hickson
8295deb1ec Updating CONTRIBUTING.md to mention latest paths (flutter/engine#2676)
* Updating CONTRIBUTING.md to mention latest paths

* Update CONTRIBUTING.md
2016-05-11 11:23:57 -07:00
Yegor
e3eaaedf95 provide link to instructions for building for iOS
Fixes #https://github.com/flutter/flutter/issues/3689
2016-05-03 07:32:14 -07:00
Adam Barth
5f5448137a Update CONTRIBUTING.md 2016-03-29 08:39:43 -07:00
Adam Barth
6f83ffe462 Update flutter start to flutter run
These commands are the same, but `run` is the new hotness.
2016-03-28 14:52:35 -07:00
Ian Hickson
95872c3e06 Mention android:debuggable in CONTRIBUTING.md 2016-03-17 13:54:14 -07:00
Ian Hickson
3e01645c36 Update CONTRIBUTING.md
Mention the waterfall and conventions around it.
2016-03-03 22:56:03 -08:00
Hixie
b76eb19567 Move style guide to website.
Depends on https://github.com/flutter/website/pull/177
2016-02-23 09:03:52 -08:00
yjbanov
8e85105e69 tell people to submit code after LGTM 2016-02-02 12:20:08 -08:00
yjbanov
5053f22f25 add section on submitting code in CONTRIBUTING.md 2016-02-02 11:25:43 -08:00
Brett Morgan
0ba75b89e1 Trailing full stop is confusing
Sample code is not differentiated enough to disambiguate the full stop at the end of the line.
2015-12-03 14:38:07 +11:00
Ian Hickson
19fdb15e09 Update CONTRIBUTING.md 2015-11-21 16:15:47 -08:00
Seth Ladd
fec8bce555 Fix link to flutter CONTRIBUTING.md 2015-11-20 10:33:00 -08:00
Ian Hickson
ed546fdd04 Update CONTRIBUTING.md 2015-11-09 09:35:08 -08:00
Adam Barth
b896b14329 Update CONTRIBUTING.md to account for flutter.git 2015-11-08 21:56:42 -08:00
Florian Loitsch
cf90d0c297 Fix typo. 2015-11-05 16:19:18 -08:00
krisgiesing
b5483c25aa Update CONTRIBUTING.md 2015-11-04 13:36:44 -08:00
Michael Xia
f48fffcc34 Corrected wording in the Desktop section
Bullet #3 was referencing "Android".
2015-10-29 15:47:12 -07:00
Todd Volkert
cf48f145d5 Update 'Getting the code and configuring your environment' to have
the user run download_android_tools.py before adding platform-tools
to their path so they don't fret over the platform-tools folder
not existing yet.
2015-10-23 15:08:53 -07:00
Collin Jackson
6c25e9c637 Update CONTRIBUTING.md 2015-10-20 10:56:53 -07:00
Adam Barth
7ad7790a92 Update CONTRIBUTING.md 2015-10-20 08:45:19 -07:00
Ian Hickson
789f21e038 Update CONTRIBUTING.md 2015-10-20 08:25:28 -07:00
Ian Hickson
6e0075d30f Update CONTRIBUTING.md 2015-10-20 08:24:30 -07:00
Ian Hickson
5f3db0c9e9 Update CONTRIBUTING.md 2015-10-20 08:23:31 -07:00
Ian Hickson
1bf269d547 Revamp of CONTRIBUTING.md to reflect everything I learnt installing it at home. 2015-10-20 08:22:52 -07:00
Ian Hickson
fda699f8e2 Update CONTRIBUTING.md 2015-10-20 07:52:10 -07:00