Sam Rawlins
454926a720
Flutter-Cherrypick-Process.md - Spell cherry-pick consistently ( #172697 )
2025-07-24 20:05:49 +00:00
Matan Lurey
a738ae5c84
Bringup linux_web_engine_tests; failing 4+ times in a row ( #172714 )
...
See https://github.com/flutter/flutter/issues/172713 .
2025-07-24 19:43:10 +00:00
engine-flutter-autoroll
20788c07fc
Roll Packages from 9c85e5e72e7b to 963550c6c297 (4 revisions) ( #172696 )
...
9c85e5e72e...963550c6c2stuartmorgan@google.com [google_sign_in] Add more
serverClientId info to README (flutter/packages#9629 )
2025-07-23 engine-flutter-autoroll@skia.org Roll Flutter from
ee0cc6652be7 to afba7d75b391 (10 revisions) (flutter/packages#9665 )
2025-07-23 robert.odrowaz@leancode.pl [camera_avfoundation]
Implementation swift migration - part 9 (flutter/packages#9645 )
2025-07-22 engine-flutter-autoroll@skia.org Roll Flutter from
70cdc0c933d6 to ee0cc6652be7 (29 revisions) (flutter/packages#9662 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-24 15:45:35 +00:00
Kostia Sokolovskyi
79d77a1387
Add missing deprecations to CupertinoDynamicColor. ( #171160 )
...
Closes https://github.com/flutter/flutter/issues/171059
### Description
- Adds missing deprecations to `CupertinoDynamicColor`
- Adds dart fixes for some of the deprecations
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-07-24 08:24:27 +00:00
engine-flutter-autoroll
0c43fe476c
Roll Dart SDK from a181fe571dc8 to 26dece893751 (2 revisions) ( #172683 )
...
https://dart.googlesource.com/sdk.git/+log/a181fe571dc8..26dece893751
2025-07-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-25.0.dev
2025-07-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-24.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-24 06:15:14 +00:00
Jamil Saadeh
3fb8d8245c
Migrate to null aware elements - Part 1 ( #172198 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Replace null checks with null aware elements
Part of #172188
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-24 06:13:09 +00:00
gaaclarke
25e4744237
licenses_cpp: implements extracting regions from matched text ( #172655 )
...
fixes https://github.com/flutter/flutter/issues/172570
Matches logic in old license checker:
f277865a8e/engine/src/flutter/tools/licenses/lib/main.dart (L458)https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-24 00:54:13 +00:00
flutter-pub-roller-bot
11e75ea82d
Roll pub packages ( #172677 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2025-07-24 00:54:12 +00:00
Flutter GitHub Bot
6b640a95a9
Marks Mac_ios keyboard_hot_restart_ios to be unflaky ( #168053 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_ios keyboard_hot_restart_ios"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20keyboard_hot_restart_ios%22 ).
This test can be marked as unflaky.
2025-07-24 00:04:02 +00:00
Jason Simmons
dd302cbe49
Roll Abseil and remove a workaround for a Fuchsia target that was unable to build Abseil ( #172665 )
...
Flutter was avoiding dependencies on Abseil's flat_hash_map library on
Fuchsia because it brought in a time zone library that required the
Fuchsia SDK. This PR rolls Abseil to a commit that fixes the path to the
Fuchsia SDK.
2025-07-24 00:02:09 +00:00
Arindam Karmakar
2fbe9398bd
Add automaticallyImplyActions property to AppBar ( #171113 )
...
## Summary
- This PR adds a new boolean property `automaticallyImplyActions` to the
`AppBar` widget.
- It provides fine-grained control over whether an automatic menu icon
(`Icons.menu`) is added when an `endDrawer` is present and `actions` are
null or empty.
## Details
### Background
In the current behavior of `AppBar`, if:
- The `Scaffold` has a non-null `endDrawer`, and
- The `AppBar.actions` is either `null` or an empty list `[]`
Then Flutter **automatically inserts** a trailing menu icon
(`Icons.menu`) into the `actions` list, which opens the `endDrawer`.
### New Behavior
This PR introduces:
```dart
final bool automaticallyImplyActions; // default: true
```
Developers can now control this behavior:
- `automaticallyImplyActions: true` (default):\
The menu icon is automatically inserted when appropriate, as before.
- `automaticallyImplyActions: false`:\
The `AppBar` will **not** add the automatic trailing menu icon, even if
an `endDrawer` is present and `actions` are null or empty.
### All Possible Scenarios
| `endDrawer` | `actions` | `automaticallyImplyActions` | Result |
| ----------- | ----------------- | --------------------------- |
----------------------------------- |
| ✅ present | `null` or `[]` | `true` (default) | Automatic menu icon is
added |
| ✅ present | `null` or `[]` | `false` | No menu icon is added |
| ✅ present | `[customWidgets]` | `true` / `false` | Custom actions
shown, no menu added |
| ❌ absent | any value | any value | No menu icon is added |
This provides predictable, developer-controlled behavior while
maintaining backward compatibility.
---
## Use Case
This change benefits developers who:
- Want to **prevent automatic UI behaviors** when building custom app
bars.
- Need full control over the trailing icons without modifying internal
logic.
- Encounter issues where the menu icon appears unintentionally in
minimal `AppBar` configurations.
---
## Default Behavior (No Breaking Change)
- The default value is `true`, so existing applications are **not
affected**.
- The new behavior is **opt-in** by setting `automaticallyImplyActions:
false`.
---
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-24 00:02:06 +00:00
Koji Wakamiya
49c300a999
fix: TabBar fontFamily inheritance with custom label styles ( #171699 )
...
fix #127787
When `labelStyle` or `unselectedLabelStyle` is specified, the
`defaults.labelStyle` is ignored.
Merge `defaults` to make `labelStyle` and `TabBarTheme.labelStyle` apply
default text styles.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Mitchell Goodwin <58190796+MitchellGoodwin@users.noreply.github.com>
2025-07-24 00:02:06 +00:00
Flutter GitHub Bot
4782cb0742
Marks Linux_mokey new_gallery__crane_perf to be unflaky ( #167633 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_mokey new_gallery__crane_perf"
}
-->
The issue https://github.com/flutter/flutter/issues/165963 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_mokey%20new_gallery__crane_perf%22 ).
This test can be marked as unflaky.
2025-07-23 23:58:55 +00:00
Gray Mackall
df99f53bc0
[android] Fix broken --android-skip-build-dependency-validation flag ( #172581 )
...
The way I was parsing the boolean previously was just not working. This
works.
Also restores a set of tests that was deleted in
https://github.com/flutter/flutter/pull/171776 that I don't think should
have been (missed this in review), and adds a test case for the fix.
Added as bringup because the name is changed, but I ran the tests
locally and they pass.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2025-07-23 23:57:50 +00:00
Pedro Massango
5d00045ad2
Fix: Ensure Text widget locale is included in semantics language tag ( #172034 )
...
Fixes https://github.com/flutter/flutter/issues/162324
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
2025-07-23 23:56:48 +00:00
Hannah Jin
2b72e9cf34
[Web][a11y] Update selected chips semantics ( #172660 )
...
internal: b/430166300
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-23 23:56:47 +00:00
engine-flutter-autoroll
2505565964
Roll Skia from eea1c33fbe84 to 094ac350125f (29 revisions) ( #172664 )
...
https://skia.googlesource.com/skia.git/+log/eea1c33fbe84..094ac350125f
2025-07-23 michaelludwig@google.com Revert "[graphite] Fix draw/clip
contains priority"
2025-07-23 mike@reedtribe.org Make IsA and Convexity tracking match
SkPath
2025-07-23 mike@reedtribe.org Add defaults for path enums, declare as
8-bit
2025-07-23 nicolettep@google.com [graphite] Check support for
AHardwareBuffer VkFormat when deciding whether to import as external
format
2025-07-23 robertphillips@google.com Fix race condition in
lin_proPhoto_to_XYZ_D50's initialization
2025-07-23 jmbetancourt@google.com [skcapture] add initial plumbing for
getting SkCapture data from clients
2025-07-23 kjlubick@google.com Fix make_image_tag.sh
2025-07-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 15642e374bb9 to 0b8bda098b9a (1 revision)
2025-07-23
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-07-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 239763d96a4b to 1c245d908ff3 (11 revisions)
2025-07-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 084f9893520c to b347398f5e86 (1 revision)
2025-07-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from a898e8056b2f to 25c0effab214 (12 revisions)
2025-07-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 6492a9924110 to 6ac8346974d5 (12 revisions)
2025-07-23 michaelludwig@google.com [graphite] Visit proxies after
prepareResources
2025-07-22 michaelludwig@google.com [graphite] Remove resource memory
dump debugging code
2025-07-22 michaelludwig@google.com Revert "[graphite] Increase area
required for inner fill"
2025-07-22 kjlubick@google.com Update GN build of CanvasKit
2025-07-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 0830f159cb89 to 15642e374bb9 (5 revisions)
2025-07-22 faijur.rahman@imagination.corp-partner.google.com Add DDK
version check
2025-07-22 michaelludwig@google.com [graphite] Guard clip/draw
intersections with precision check
2025-07-22 kjlubick@google.com Change tag of Docker images to be
git-[hash]
2025-07-22 mike@reedtribe.org use value_or if we don't check invert()
success
2025-07-22
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-07-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from faf1bb4b3e72 to 239763d96a4b (8 revisions)
2025-07-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from af70cb4dfd93 to 0830f159cb89 (4 revisions)
2025-07-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 65b2c4777e5f to 084f9893520c (3 revisions)
2025-07-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 4a7db687eea1 to a898e8056b2f (11 revisions)
2025-07-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 2502261c4d1a to 6492a9924110 (20 revisions)
2025-07-22
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-23 23:55:05 +00:00
Flutter GitHub Bot
027c6a7e69
Marks Mac_arm64_ios imitation_game_flutter to be unflaky ( #168052 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_arm64_ios imitation_game_flutter"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64_ios%20imitation_game_flutter%22 ).
This test can be marked as unflaky.
2025-07-23 23:55:05 +00:00
engine-flutter-autoroll
b6a4fda18b
Roll Dart SDK from a31774a3d049 to a181fe571dc8 (2 revisions) ( #172667 )
...
https://dart.googlesource.com/sdk.git/+log/a31774a3d049..a181fe571dc8
2025-07-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-23.0.dev
2025-07-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-22.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-23 23:55:04 +00:00
Elijah Okoroh
fdc1b5cd29
Adapt xcresult parser for Xcode 16 changes ( #172596 )
...
This PR updates the iOS build process to support breaking changes in
Xcode 16's xcresulttool. The xcresulttool get command, which Flutter
uses to parse native build issues, is deprecated and replaced by the new
xcresulttool get build-results command. This new command also introduces
a completely new, flatter JSON output format.
To address this while maintaining backwards compatibility, this change
introduces a two-part solution:
- The XCResultGenerator now detects the Xcode version and conditionally
calls the appropriate command (get build-results for Xcode 16+ and get
for older versions).
- The XCResult parser has been refactored to be "bilingual," meaning it
can intelligently detect the JSON structure and parse both the old
(nested) and new (flat) formats correctly.
- This ensures that native iOS build errors and warnings continue to be
correctly parsed and displayed to the user on all supported Xcode
versions.
Fixes #151502
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-23 23:14:52 +00:00
Jason Simmons
8aeaf7247e
Update excluded_files to match the current output of the old license checker ( #172670 )
2025-07-23 22:33:53 +00:00
Siva
fa80cbcbdb
Manual Roll of Dart SDK from da9e0299c120 to a31774a3d049 ( #172616 )
...
https://dart.googlesource.com/sdk.git/+log/da9e0299c120..a31774a3d049
2025-07-22
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.10.0-21.0.dev
2025-07-22
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.10.0-20.0.dev
2025-07-22
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.10.0-19.0.dev
2025-07-22
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.10.0-18.0.dev
2025-07-21
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.10.0-17.0.dev
2025-07-21
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.10.0-16.0.dev
2025-07-23 18:02:59 +00:00
Gray Mackall
b46957fb06
[FGP] Small restructuring of Android Studio native flutter dependency support ( #172651 )
...
I asked for this in this comment
https://github.com/flutter/flutter/pull/167332#discussion_r2096361980
but the request may have been unclear, as the PR landed without the
change. Following up to structure based on my comment.
I want to avoid the configuration that is specific to this one use case
creeping out across the FGP and wider flutter tool if it doesn't need
to.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Co-authored-by: Gray Mackall <mackall@google.com>
2025-07-23 17:35:08 +00:00
gaaclarke
1dc7352479
revert: Replaces legacy licenses check with licenses_cpp ( #172568 )
...
fixes https://github.com/flutter/flutter/issues/172567
There were 2 reasons for this:
1) the above listed issue where g3 wanted a specific long form license,
that needs to be investigated
1) autorollers are relying on the old tooling to autosubmit changes to
the license file
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-23 17:21:09 +00:00
John "codefu" McDole
f277865a8e
fix: size-exp naming ( #172647 )
...
@jason-simmons found the reason the `-size-exp` doesn't build
luci build: https://ci.chromium.org/b/8708539853637018417
2025-07-23 16:56:43 +00:00
engine-flutter-autoroll
c16c43f010
Roll Fuchsia Test Scripts from MnFlN7VWM_7h7EmBV... to BWj3yYC74ud58QhN0... ( #172646 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-flutter
Please CC chrome-fuchsia-engprod@google.com ,jsimmons@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-23 16:30:08 +00:00
Jim Graham
3deedd23cd
[DisplayList] implement shadow bounds without relying on Skia utilities ( #172572 )
...
Right now DisplayList defers to Skia to compute the bounds of shadow
operations, but we really need to own this code now that we are doing
our own rendering so I ported it over and simplified it to just deal
with the cases we care about.
Eliminates a bullet item in
https://github.com/flutter/flutter/issues/161456
2025-07-23 15:20:31 +00:00
Matan Lurey
0a2ee25955
Update dev/bots/post_process_docs.dart to use flutter.version.json ( #172601 )
...
Towards https://github.com/flutter/flutter/issues/171900 .
The "legacy" (`//version`) file has been "legacy" for years. This PR
allows deprecating and removing it in the near future.
Example of `//bin/cache/flutter.version.json`:
```json
{
"frameworkVersion": "3.33.0-1.0.pre-1070",
"channel": "master",
"repositoryUrl": "unknown source",
"frameworkRevision": "be9526fbaaaab9474e95d196b70c41297eeda2d0",
"frameworkCommitDate": "2025-07-22 11:34:11 -0700",
"engineRevision": "be9526fbaaaab9474e95d196b70c41297eeda2d0",
"engineCommitDate": "2025-07-22 18:34:11.000Z",
"engineContentHash": "70fb28dde094789120421d4e807a9c37a0131296",
"engineBuildDate": "2025-07-22 11:47:42.829",
"dartSdkVersion": "3.10.0 (build 3.10.0-15.0.dev)",
"devToolsVersion": "2.48.0",
"flutterVersion": "3.33.0-1.0.pre-1070"
}
```
Example of `//version`:
```txt
3.33.0-1.0.pre-1070
```
2025-07-23 14:46:09 +00:00
Matan Lurey
1e84cbef10
Emit a warning on --[no-]disable-dds, preferring --no-dds ( #172595 )
...
Towards https://github.com/flutter/flutter/issues/150279 .
I'll CP this into 3.35, and then we can remove support for the flag on
`master`.
(IIRC this only still existed because of google3)
2025-07-23 14:36:35 +00:00
Robert Ancell
afba7d75b3
Remove GtkGLArea and render directly into GtkDrawingArea ( #172343 )
...
This simplifies the OpenGL/software case and allows us more control over
the buffering.
2025-07-23 02:04:50 +00:00
Matan Lurey
fb80c976c5
Prefix generated Dart plugin imports for registerWith ( #172511 )
...
Closes https://github.com/flutter/flutter/issues/100421 .
2025-07-23 00:11:21 +00:00
Matan Lurey
7f92ee28ef
Remove stale references to .packages in tool tests ( #172582 )
...
Closes https://github.com/flutter/flutter/issues/106210 .
2025-07-23 00:09:00 +00:00
Matan Lurey
6fd30fd25a
Wraps all git executions in a Git(...).*, use *=noglob on Windows ( #172495 )
...
Closes https://github.com/flutter/flutter/issues/74165 .
The original issue called for, on Windows, telling `CYGWIN` to use
`=noglob`, to work around some git operation errors that happen when
using non-native Git. There ... was no great way to do this with the
existing codebase without, IMO, adding lots of confusing code.
So, I refactored all the calls of:
- before: `processUtils.<method>(['git', ...args], ...params)`
- after: `git.<method>([...args], ...params)`
... and implicitly add the new environment variables, if
`Platform.isWindows`.
Did some minor test cleanup and process execution cleanup while I was at
it.
2025-07-23 00:03:32 +00:00
Matan Lurey
6d62770d08
Omit instruction to cd . after flutter create ( #172513 )
...
Closes https://github.com/flutter/flutter/issues/100588 .
2025-07-22 22:45:14 +00:00
Alex Talebi
c45a67e4ac
Improve assertion message in AlignmentDirectional.resolve ( #172096 )
...
Replaces the generic assertion in `AlignmentDirectional.resolve` and
`_MixedAlignment.resolve` with
`debugCheckCanResolveTextDirection`.
This change provides a more helpful and descriptive error message when
the `TextDirection` is null, improving the developer experience by
clearly stating why the resolution failed and how to fix it.
Fixes : #171813 , Fixes : #171814 , also fixes : #171812
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-22 22:11:01 +00:00
jesswrd
e12d263d3d
Update warnGradleVersion to 8.7.0 ( #172576 )
...
When using a lower Gradle version, a warning to update to at least 8.7.2
is shown, but 8.7.2 is not a valid version. Changed warnGradleVersion
from 8.7.2 to 8.7.0.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-22 21:20:08 +00:00
Matan Lurey
3038239932
Use a fake representation of cache/artifacts/gradle_wrapper ( #172503 )
...
... so that it doesn't require downloading cache artifacts to run
`general.shard/project_test.dart`.
Closes https://github.com/flutter/flutter/issues/83275 .
2025-07-22 21:13:03 +00:00
LongCatIsLooong
be9526fbaa
Revert #160653 Fix view removal process for AutofillContextAction.cancel ( #172490 )
...
Between #145681 (autofill save prompt shows up for password fields when
you dismiss the keyboard) and #172250 (calling `TextInput.hide` causes
the current active text field to lose its text) the latter seems to be
the worse bug. The framework `EditableText` implementation only calls
`TextInput.hide` when switching input controls, so #172250 typically
does not affect flutter text fields itself, but becomes a problem if the
app wishes to add UI (similar to the iOS down-arrow button that would
show up above the keyboard when you're filling out a form) to dismiss
the keyboard.
This reopens #145681 . See
https://github.com/flutter/flutter/issues/145681#issuecomment-3098865633
@koji-1009 does reverting sound ok to you?
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-22 18:34:11 +00:00
Michael Goderbauer
6b7d92852c
Bump meta to 0.17.0 ( #172541 )
...
Unclear why the bot didn't bump this.
2025-07-22 17:51:20 +00:00
gaaclarke
ee0cc6652b
Licenses cpp ignore whitespace ( #172512 )
...
2 big changes:
1) \s+ is assumed for any whitespace in the source matcher
1) trailing space is no longer captured in matched text
I didn't change any of the data files, so that can be done in a more
controlled pr.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-22 17:39:19 +00:00
John "codefu" McDole
ff983d3598
feat: start using the content aware hash for downloading artifacts ( #172552 )
...
reland of https://github.com/flutter/flutter/pull/171927
towards https://github.com/flutter/flutter/issues/171790
Use the content aware hash when downloading engine artifacts. These are
currently produced when changes to DEPs, engine/, or the release file
are changed in a not-seen-before way.
We can eventually remove engine.version being tracked in release
branches as an optimization.
FLUTTER_PREBUILT_ENGINE_VERSION will stay for overriding the
engine.version for testing. Though Cocoon does not need to actually set
it for framework only PRs anymore.
fxies post submit tests for content_hash download:
SHARD=framework_tests SUBSHARD=misc dart --enable-asserts
dev/bots/test.dart
SHARD=tool_host_cross_arch_tests dart --enable-asserts
dev/bots/test.dart
```
╔═╡ERROR https://github.com/flutter/flutter/pull/1╞════════════════════════════════════════════════════════════════════
║ Expected "Flutter Engine Version: 45b085ab2118f30441ae6e2daab4b8eb3e4a063c", but found "Flutter Engine Version: 407c051ec9
2025-07-22 17:35:26 +00:00
nakanoh
404fb3f14f
fix: correct typo in analysis_options.yaml comment (disabeling -> disabling) ( #170206 )
...
This PR fixes a typo in the comment of `analysis_options.yaml`, changing
'disabeling' to 'disabling'. This is a simple typo fix in a comment that
improves code readability.
No issue is required as this is a trivial typo fix in a comment.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide].
- [x] I signed the [CLA].
2025-07-22 14:59:28 +00:00
Matan Lurey
d16e5b9971
Hide flutter assemble unless --verbose ( #172508 )
...
Towards https://github.com/flutter/flutter/issues/97505 .
2025-07-22 05:34:22 +00:00
Huy
db38e71bfc
Fix PopupMenuButton crashes when being hidden immediately ( #171970 )
...
- Fix https://github.com/flutter/flutter/issues/171422 (and maybe also
https://github.com/flutter/flutter/issues/167180 , and
https://github.com/flutter/flutter/issues/163477 )
- Investigation: Per discussion in
https://github.com/flutter/flutter/issues/171422 , the issue is probably
happening due to accessing inherited widgets via `context` in
`positionBuilder`(like `PopupMenuTheme`) when PopupMenu's State is
inactive. This PR proposed a fix by caching the necessary objects in
`didChangeDependencies` method. Some of `RenderBox` are also cached to
avoid another exception like _Cannot get renderObject of inactive
element._.This solution can also be seen at another widget like
`CalendarDatePicker`:
d6b2a95215/packages/flutter/lib/src/material/calendar_date_picker.dart (L225-L232)https://github.com/user-attachments/assets/2af0a4cb-216c-4033-bdd6-d288338bdf6b "/>
| <video
src="https://github.com/user-attachments/assets/c3e46f9c-9ead-4060-9df7-208bee7be740 "/>
</details>
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Signed-off-by: huycozy <huy@nevercode.io>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-07-22 03:16:48 +00:00
Victor Sanni
6a3ebfe3f3
Add hitTestChildren to baseline-aligned stack ( #172485 )
...
Fixes http://github.com/flutter/flutter/issues/171510
2025-07-22 03:13:06 +00:00
engine-flutter-autoroll
3ceb2e0a48
Roll Skia from 4aba494b8108 to eea1c33fbe84 (11 revisions) ( #172515 )
...
https://skia.googlesource.com/skia.git/+log/4aba494b8108..eea1c33fbe84
2025-07-21 kjlubick@google.com Remove IWYU build logic from Bazel
2025-07-21
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-07-21 michaelludwig@google.com [graphite] Tighter bounds for
stroked [r]rects
2025-07-21 michaelludwig@google.com [graphite] Check for scissor before
converting to clear/discard op
2025-07-21 michaelludwig@google.com [graphite] Fix paint_depends_on_dst
logic
2025-07-21 kjlubick@google.com Remove old Bazel docker files
2025-07-21 michaelludwig@google.com [graphite] Fix draw/clip contains
priority
2025-07-21
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-07-21 michaelludwig@google.com [graphite] Don't allow clip/draw
intersections to produce subpixel draws
2025-07-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c8bd17b0ce68 to af70cb4dfd93 (3 revisions)
2025-07-21 lukasza@chromium.org [rust png] Verify `IHDR` dimensions
*before* constructing encoded info.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-22 02:25:37 +00:00
gaaclarke
f63b38f275
Replaces legacy licenses check with licenses_cpp ( #172486 )
...
Successful run example:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_license/35497/overview
The output of licenses_cpp was verified by comparing it's output with
`//flutter/tools/license_file_compare`. All copyrights from the old tool
exist in the new tool.
major differences:
1) runtime - 30s locally
1) macos compatibility
1) there are no more checked-in goldens, instead the log from the run is
used to audit
design doc:
https://docs.google.com/document/d/1TldHod_Ske3llv26l4eIyt64bg8TeDc7Jk7u9L7gnvM/edit?tab=t.0#heading=h.17wg41voij6q
work left:
1) delete old license checker
1) clean up the handling of licenses that exist across multiple comments
(boost license)
1) clean up the data directory so that whitespace between words is
ignored. (remove `\s+` usage)
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-22 00:43:09 +00:00
Matan Lurey
359b29382a
Omit w (widget tree), t (render tree) from flutter run --profile h ( #172506 )
...
Closes https://github.com/flutter/flutter/issues/91690 .
2025-07-22 00:41:09 +00:00
Matan Lurey
ffd1baa342
Refactor checks for --machine ( #172504 )
...
Was already fixed in https://github.com/flutter/flutter/pull/150138 , so
removes duplicate flag.
Already tested by existing test suite.
2025-07-22 00:41:08 +00:00
Ricardo Dalarme
f95c68ec14
feat(IconButton): add property to specify a states controller ( #169821 )
...
## Description
Enable specifying a custom statesController to the IconButton widget.
This increase consistency since other widgets expose this property as
well.
## Related Issues
- Closes https://github.com/flutter/flutter/issues/139372
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-07-22 00:33:25 +00:00
