Ayyoub Kouadir
c82cf49b6c
Fix ListTile overwriting parent IconButtonTheme for its children ( #167727 ) ( #168480 )
...
### Description
ListTile was recreating its own IconButtonThemeData—discarding any
styles inherited from an existing IconButtonTheme above it. This change
makes ListTile merge its theme data with the inherited one instead of
replacing it, so child IconButtons now correctly pick up parent styling
issue: https://github.com/flutter/flutter/issues/167727
---
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-09 17:23:34 +00:00
engine-flutter-autoroll
5e64293590
Roll Skia from efccaeb08b8d to 0d16b74f74a5 (6 revisions) ( #168569 )
...
https://skia.googlesource.com/skia.git/+log/efccaeb08b8d..0d16b74f74a5
2025-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
skottie-base from 375561920728 to 6f141efaf8cb
2025-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
jsfiddle-base from 552d94229577 to 85c7d3d4b62f
2025-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
debugger-app-base from 7f477239b384 to f4f588b1198d
2025-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
shaders-base from 3a63c1930823 to 1cdf37f3bad8
2025-05-08 robertphillips@google.com Revert "[Fontations] Avoid
redundant path retrieval"
2025-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
ANGLE from df8a704788de to c03307f471f4 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-09 16:58:05 +00:00
Kevin Moore
4cad7a78e8
[web] more cleanup of unused APIs ( #168524 )
...
One API only existed for tests.
Also removed an unused class
2025-05-09 16:56:05 +00:00
engine-flutter-autoroll
dc170241dc
Roll Fuchsia Linux SDK from mqhX1OP8ezmialgqA... to F2xwL6WosfD7ETcPm... ( #168587 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-09 16:56:04 +00:00
engine-flutter-autoroll
f394cc9b17
Roll Packages from ab44c26de098 to 7814fabbfb7a (4 revisions) ( #168597 )
...
ab44c26de0...7814fabbfb
2025-05-08 40433176+KevynSM@users.noreply.github.com [go_router] Fix
requestFocus propagation to Navigator (flutter/packages#9177 )
2025-05-08 65381000+raju8000@users.noreply.github.com
[go_router_builder] Fixes an deprecated warning for using
withNullability (flutter/packages#9158 )
2025-05-08 engine-flutter-autoroll@skia.org Roll Flutter from
b0f5c8ce03e2 to 02d8c1aceb75 (19 revisions) (flutter/packages#9230 )
2025-05-08 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Fix camera preview rotation for landscape
oriented devices (flutter/packages#9097 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-09 16:56:04 +00:00
Elliott Brooks
83082c19b7
[Widget Inspector] Clean-up changes in PR #167677 ( #168488 )
...
Follow-up to https://github.com/flutter/flutter/pull/167677
Addresses clean-up comments in cherry-pick:
https://github.com/flutter/flutter/pull/168386
2025-05-08 22:54:18 +00:00
gaaclarke
67ef841cae
Increased the limit where we start chopping off the end of blurs ( #168109 )
...
issue: https://github.com/flutter/flutter/issues/165422
Here is the before/after screenshots at sigma = 30
https://github.com/user-attachments/assets/d85f51f6-676e-48e8-ae3e-c887f69f2cbd
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-08 22:21:31 +00:00
Alexander Aprelev
201893ed94
Roll to Dart SDK 3.9 Beta 1 ( #168559 )
...
Roll to dart sdk 3.9 beta 1 plus the fix for native resolver not having
an isolate
3.33.0-0.0.pre
2025-05-08 20:56:07 +00:00
Chris Bracken
b0ad252b7a
Rename apple -> darwin across our buildroot ( #168558 )
...
As part of unifying our iOS and macOS build config, toolchain, and
scripts, I named some of these `apple_sdk.py`, `toolchain/apple`, etc.
for consistency with the chromium toolchain. This renames these `darwin`
for consistency with other parts of our build.
Issue: https://github.com/flutter/flutter/issues/167592
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-08 20:52:08 +00:00
jesswrd
f8b544a7ff
Update Engine to Android 16 (API 36) ( #166796 )
...
Following the directions
[here](https://github.com/flutter/flutter/blob/main/docs/platforms/android/Upgrading-Engine's-Android-API-version.md )
to update engine to android 16.
1. Uploaded api 36 SDK to CIPD using the script from the above docs
2. Updates in Engine to use api 36
- Updated buildroot
- Updated SDK CIPD package in `DEPS`
- Updated android build tools
- Updated `targetsdk` and `compilesdk`
3. Confirm the engine sucessfully builds. I ran `et build -c
android_debug_unopt_arm64`
4. Bumped the gradle version in this PR due to seeing this warning
[here](https://github.com/flutter/flutter/blob/master/docs/platforms/android/New-Android-version.md#:~:text=Update%20Gradle/AGP%20support ).
Note: Post mono-repo merge, we can now update buildroot and `DEPS` in
the same PR 🎊 !!! Also, updated the Clang path due to use of a new Clang
version in the bumped ndk.
Partially Addresses #166950
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-08 19:46:59 +00:00
engine-flutter-autoroll
5041a592c8
Roll Skia from 43ae814d2d95 to efccaeb08b8d (5 revisions) ( #168554 )
...
https://skia.googlesource.com/skia.git/+log/43ae814d2d95..efccaeb08b8d
2025-05-08 zengyonghust@gmail.com Fixed precision-loss-induced errors in
path primitive simplification algorithm
2025-05-08 thomsmit@google.com [graphite] Remove vertex buffer bind
tracking logic from metal and vulkan.
2025-05-08 robertphillips@google.com [graphite] Expand coverage of
AndroidPrecompileTest
2025-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from b373892b9d96 to df8a704788de (10 revisions)
2025-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 093b4d82a49a to 930d46d31b5d (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-08 18:23:12 +00:00
Chris Bracken
02d8c1aceb
iOS,macOS: Unify iOS,macOS build configs ( #168517 )
...
Merges:
* //build/config/ios:compiler
* //build/config/mac:compiler
Into:
* //build/config/apple:compiler
Merges:
* //flutter/shell/platform/darwin/ios:config_ios
* //flutter/shell/platform/darwin/mac:config_macos
Into:
* //flutter/shell/platform/darwin/common:config
Merges:
* //flutter/shell/platform/darwin/ios:config_ios_test
* //flutter/shell/platform/darwin/mac:config_macos_test
Into:
* //flutter/shell/platform/darwin/common:test_config
This avoids the duplication between iOS and macOS build configs used for
building Swift and Objective-C that depends on Swift, and avoids further
duplication when we add Swift to //flutter/shell/platform/darwin/common
in a followup patch.
Issue: https://github.com/flutter/flutter/issues/167592
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-08 18:11:10 +00:00
engine-flutter-autoroll
041bbeb882
Roll Packages from b2ce3b02a27b to ab44c26de098 (3 revisions) ( #168548 )
...
b2ce3b02a2...ab44c26de0
2025-05-08 31216074+gentlemanxzh@users.noreply.github.com
[google_maps_flutter] Fix for memory leak impacting all platforms due to
subscriptions not getting cleaned up (flutter/packages#8972 )
2025-05-08 engine-flutter-autoroll@skia.org Roll Flutter from
cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) (flutter/packages#9223 )
2025-05-08 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Fixes support for ad tag URLs that do not
contain a query (flutter/packages#9176 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-08 15:58:23 +00:00
zhongliugo
76747c0ece
Remove unnecessary setAriaRole('dialog') fallback in SemanticRoute class ( #168345 )
...
**Description**
This pull request removes the unnecessary setAriaRole('dialog') fallback
in the SemanticRoute class within the Flutter web engine. This line was
an old fallback and is no longer needed
**Before**
https://dialog-0505-before.web.app/
**After**
https://dialog-050502-after.web.app/
**Issue Fixed**
This PR addresses GitHub Issue #168247 , which proposes reconsidering the
application of role="dialog" to arbitrary routes.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-05-08 08:02:19 +00:00
engine-flutter-autoroll
71c847e8b0
Roll Skia from 4d617bb1bb7d to 43ae814d2d95 (1 revision) ( #168526 )
...
https://skia.googlesource.com/skia.git/+log/4d617bb1bb7d..43ae814d2d95
2025-05-08 michaelludwig@google.com [graphite] Fix device-space blur
mask filters with non-uniform scale
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-08 07:24:33 +00:00
engine-flutter-autoroll
fc939098d4
Roll Fuchsia Linux SDK from _GJje-N2Jk51qtBs6... to mqhX1OP8ezmialgqA... ( #168525 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-08 07:18:12 +00:00
Qun Cheng
194fb17d2a
Make MergeSemantics be able to merge customAction ( #168414 )
...
Fixes https://github.com/flutter/flutter/issues/166588
When merging semantics, an empty customSemanticsActions was always used
instead of using the `_customSemanticsActions` of the current semantics
node.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-05-08 03:28:23 +00:00
engine-flutter-autoroll
68dff95515
Roll Skia from d787c26f873a to 4d617bb1bb7d (1 revision) ( #168514 )
...
https://skia.googlesource.com/skia.git/+log/d787c26f873a..4d617bb1bb7d
2025-05-07 cairno@google.com [Ganesh] Allow rect preserving view
matrices in the rrect blur fast path
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-08 01:30:26 +00:00
flutter-pub-roller-bot
35bd0b1393
Roll pub packages ( #168509 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2025-05-08 00:50:25 +00:00
Flutter GitHub Bot
e5b3fc3aa0
Marks Mac_arm64_ios imitation_game_swiftui to be unflaky ( #163114 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_arm64_ios imitation_game_swiftui"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64_ios%20imitation_game_swiftui%22 ).
This test can be marked as unflaky.
2025-05-07 23:49:13 +00:00
Mohamed Amara
930d21504a
Add option to hide trailing icon in DropdownMenu ( #167782 )
...
This PR adds support for hiding the trailing icon in `DropdownMenu`
widget. Currently, there's no built-in option to remove it.
The change is non-breaking, as the trailing icon remains visible by
default unless `showTrailingIcon` is explicitly set to `false`. The
`showTrailingIcon` parameter follows a similar pattern to its use in the
`ExpansionTile` widget.
Fixes #164908
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
2025-05-07 23:43:06 +00:00
engine-flutter-autoroll
3a1c297206
Roll Skia from 1ea3ec8e7863 to d787c26f873a (6 revisions) ( #168505 )
...
https://skia.googlesource.com/skia.git/+log/1ea3ec8e7863..d787c26f873a
2025-05-07 nicolettep@google.com [graphite] Use hardware blending for
advanced blend modes when supported
2025-05-07 vigneshv@google.com gn_to_bp: Remove libheif from Android
deps
2025-05-07
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-05-07 drott@chromium.org [Fontations] Avoid redundant path
retrieval
2025-05-07 bungeman@google.com Allow generateMetrics to also generate
path
2025-05-07 michaelludwig@google.com [graphite] Use 1/2px for hairline
radius in numRadialSegmentsPerRadian
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-07 22:58:11 +00:00
Kevin Moore
3ff039415e
[web] drop more use of deprecated JS functions ( #166157 )
2025-05-07 22:06:26 +00:00
nailahsall0
d582b35809
docs: Fixed broken links in WidgetStateProperty documentations ( #168191 )
...
This PR fixes the dead links for the Widget State properties in the
following documentation:
https://api.flutter.dev/flutter/widgets/WidgetStatesController-class.html
https://api.flutter.dev/flutter/widgets/WidgetStateProperty-class.html
Issues fixed in this PR:
https://github.com/flutter/flutter/issues/164478
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-05-07 18:36:08 +00:00
engine-flutter-autoroll
06fa7d91f2
Roll Skia from 14f3e3209b73 to 1ea3ec8e7863 (2 revisions) ( #168489 )
...
https://skia.googlesource.com/skia.git/+log/14f3e3209b73..1ea3ec8e7863
2025-05-07 thomsmit@google.com [graphite] Split BindDrawBuffers command,
allowing binding of individual buffers.
2025-05-07 robertphillips@google.com [graphite] Add
AndroidPrecompileTest
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-07 18:34:36 +00:00
Matan Lurey
806057be59
Use config: enable-swift-...: false, remove disable-swift-...: true. ( #168433 )
...
This PR moves project-specific configuration from:
```yaml
flutter:
disable-swift-package-manager: true
```
to:
```yaml
flutter:
config:
enable-swift-package-manager: false
```
2025-05-07 18:28:22 +00:00
Kostia Sokolovskyi
bc74369513
Replace MediaQuery.sizeOf with heightOf and widthOf. ( #168479 )
...
Closes https://github.com/flutter/flutter/issues/168478
### Description
- Replaces `MediaQuery.sizeOf(context).height` with
`MediaQuery.heightOf(context)`
- Replaces `MediaQuery.sizeOf(context).width` with
`MediaQuery.widthOf(context)`
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-07 18:12:26 +00:00
Robert Ancell
9d8e5e0b2f
Fix stencil buffer leak ( #168448 )
...
Most noticable when rendering to secondary views, one leak per frame.
Introduced for Impeller in 3af706d1887a26410cb82a9aa61da6c773d132f2
2025-05-07 17:57:08 +00:00
Robert Ancell
b3f6925fda
Fix framebuffer leak rendering to secondary views. ( #168447 )
...
Each frame would be leaked. This doesn't occur for single window.
2025-05-07 17:56:28 +00:00
Robert Ancell
f9fb8906c7
Fix uninitalized fields in FlutterWindowMetricsEvent ( #168446 )
...
Specifically physical_view_* were not set and thus had random values.
When they were negative this would cause Flutter to reject the event.
2025-05-07 17:55:45 +00:00
Kishan Rathore
b0f5c8ce03
Feat: Animate fill for material app bar ( #163913 )
...
Feat: Animate fill for material app bar
fixes : #162988
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-05-07 16:52:38 +00:00
engine-flutter-autoroll
708c0eb185
Roll Packages from e800da7bccd9 to b2ce3b02a27b (3 revisions) ( #168483 )
...
e800da7bcc...b2ce3b02a2
2025-05-07 davidmartos96@gmail.com [camera_android] Wait for creating
capture session when initializing (flutter/packages#8894 )
2025-05-07 stuartmorgan@google.com [various] Delete discontinued
packages (flutter/packages#9215 )
2025-05-07 robert.odrowaz@leancode.pl [camera_avfoundation]
Implementation swift migration - part 3 (flutter/packages#9182 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-07 16:00:41 +00:00
Victoria Ashworth
a3e9379a87
Allow iOS devicelab tests to run on macOS 15.1 ( #168234 )
...
New devicelab bots were added to the pools:
https://github.com/flutter/flutter/issues/163002 . However, they are on
macOS 15.1. Allow these bots to be used by allowing macOS 15 to be used.
Specifying macOS 15.1 specifically because we plan to upgrade to newer
version of macOS 15 in the future:
https://github.com/flutter/flutter/issues/167676
I verified all bots are good to go:
- [x]
[flutter-devicelab-mac-50](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-50 )
- https://ci.chromium.org/b/8715949123404093697
- [x]
[flutter-devicelab-mac-51](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-51 )
- https://ci.chromium.org/b/8715948996142121377
- [x]
[flutter-devicelab-mac-52](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-52 )
- https://ci.chromium.org/b/8715948941926665041
- [x]
[flutter-devicelab-mac-53](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-53 )
- https://ci.chromium.org/b/8715948864280336145
- [x]
[flutter-devicelab-mac-54](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-54 )
- https://ci.chromium.org/b/8715944668313575425
- [x]
[flutter-devicelab-mac-55](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-55 )
- https://ci.chromium.org/b/8715948803357927393
- [x]
[flutter-devicelab-mac-56](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-56 )
- https://ci.chromium.org/b/8715943235735747409
- [x]
[flutter-devicelab-mac-57](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-57 )
- https://ci.chromium.org/b/8715702195501017153
- [x]
[flutter-devicelab-mac-58](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-58 )
- https://ci.chromium.org/b/8715702188356676017
- [x]
[flutter-devicelab-mac-59](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-59 )
- https://ci.chromium.org/b/8715702172189573265
- [x]
[flutter-devicelab-mac-60](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-60 )
- https://ci.chromium.org/b/8715702160439712753
- [x]
[flutter-devicelab-mac-61](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-61 )
- https://ci.chromium.org/b/8715702148815570433
- [x]
[flutter-devicelab-mac-62](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-62 )
- https://ci.chromium.org/b/8715702138014731537
- [x]
[flutter-devicelab-mac-63](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-63 )
- https://ci.chromium.org/b/8715948441393524945
- [x]
[flutter-devicelab-mac-64](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-64 )
- https://ci.chromium.org/b/8715702120175999281
- [x]
[flutter-devicelab-mac-65](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-65 )
- https://ci.chromium.org/b/8715702108188863617
- [x]
[flutter-devicelab-mac-66](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-66 )
- https://ci.chromium.org/b/8715688828119260401
- [x]
[flutter-devicelab-mac-67](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-67 )
- https://ci.chromium.org/b/8715702082037082849
- [x]
[flutter-devicelab-mac-68](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-68 )
- https://ci.chromium.org/b/8715702070384265201
- [x]
[flutter-devicelab-mac-69](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-69 )
- https://ci.chromium.org/b/8715702058744115521
- [x]
[flutter-devicelab-mac-70](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-70 )
- https://ci.chromium.org/b/8715702046612264657
- [x]
[flutter-devicelab-mac-71](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-71 )
- https://ci.chromium.org/b/8715702036987261777
- [x]
[flutter-devicelab-mac-72](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-72 )
- https://ci.chromium.org/b/8715688823094725361
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-07 15:14:08 +00:00
engine-flutter-autoroll
3a71fefdca
Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) ( #168477 )
...
https://skia.googlesource.com/skia.git/+log/c8f54c1bc565..14f3e3209b73
2025-05-07
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-07 12:44:34 +00:00
engine-flutter-autoroll
664e1a2eb9
Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) ( #168452 )
...
https://skia.googlesource.com/skia.git/+log/55d98def951d..c8f54c1bc565
2025-05-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 3540a326ec84 to b373892b9d96 (13 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-07 09:34:44 +00:00
engine-flutter-autoroll
3acb8ca027
Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... ( #168444 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-flutter
Please CC chrome-fuchsia-engprod@google.com ,jimgraham@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-07 07:08:26 +00:00
engine-flutter-autoroll
838d2ddaba
Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) ( #168440 )
...
https://skia.googlesource.com/skia.git/+log/32591be9cd3b..55d98def951d
2025-05-07
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-05-07
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-07 05:39:09 +00:00
Chris Bracken
4af869e8d3
macOS: trailing closures for FlutterRunLoop.perform* ( #168415 )
...
Support trailing closure syntax in FlutterRunLoop perform methods. This
allows us to write Swift code like:
```
FlutterRunLoop.mainLoop.perform(withDelay: delay) {
// code.
}
```
This also matches the ordering used in NSRunLoop/RunLoop:
*
https://developer.apple.com/documentation/foundation/runloop/perform(inmodes:block:)?language=objc
*
https://developer.apple.com/documentation/foundation/runloop/perform(inmodes:block:)
Follow-up to flutter/flutter#168174 .
No tests since this is just a method rename.
Issue: https://github.com/flutter/flutter/issues/144791
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-07 04:27:30 +00:00
engine-flutter-autoroll
1d9bec83d7
Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... ( #168434 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-07 02:56:27 +00:00
Chris Bracken
e89c3927c2
iOS/macOS: Consistent Flutter copyright headers ( #168390 )
...
A long time ago, back after the fork from Chromium, we updated all
Chromium BSD copyright notices to Flutter. We did this in the engine,
but not in the buildroot. After the monorepo merge, we've now got a mix.
This corrects Chromium copyright notices for iOS/macOS files only, and
adds a missing copyright header.
No test changes since this touches only comments, and introduces no
functional changes.
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-07 00:09:28 +00:00
Jason Simmons
dce18b6fd9
Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test ( #168411 )
...
See https://github.com/flutter/flutter/issues/168405
2025-05-06 23:43:07 +00:00
MarkZ
7aa6e1b86f
Extending timeouts for DDC macrobenchmarks ( #168409 )
...
Dart2JS runs these benchmarks in ~12 min, so it's unsurprising that DDC
takes ~3x longer. It turns out the tests just take forever to run on the
test infra (minutes locally on Macbook Pro). One benchmark in particular
takes 8+ minutes (`bench_material3_components`).
2025-05-06 23:41:08 +00:00
engine-flutter-autoroll
eed2d77269
Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) ( #168421 )
...
https://skia.googlesource.com/skia.git/+log/36d1445ad00b..32591be9cd3b
2025-05-06 nicolettep@google.com [graphite] Perform flush when going
from using texture copies to reading as input
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-06 23:36:54 +00:00
Justin McCandless
cdc7ed506b
Ignore pointer on the outgoing route ( #168425 )
...
When going back with FadeForwardsPageTransition, this PR makes it
possible to interact with the incoming page before the transition has
finished.
| Before | After |
| --- | --- |
| <video
src="https://github.com/user-attachments/assets/fc2b18cf-b0a3-4be8-9360-361bcfe4a7e0 "
/> |<video
src="https://github.com/user-attachments/assets/faaa42fb-9d7a-48df-9012-e99569244db3 "
/> |
Fixes https://github.com/flutter/flutter/issues/168424
2025-05-06 23:36:52 +00:00
Jackson Gardner
51ff96b9ac
[skwasm] Dispose underlying picture recorder when ending recording. ( #168384 )
...
The picture recorder doesn't have an explicit disposal function, so
instead we should dispose it when `endRecording` is called.
This addresses https://github.com/flutter/flutter/issues/168190
2025-05-06 22:30:24 +00:00
Chinmay Garde
acae343489
[Impeller] libImpeller: Expose access to conservative path bounds. ( #168402 )
...
Fixes https://github.com/flutter/flutter/issues/165909
2025-05-06 20:36:09 +00:00
engine-flutter-autoroll
949286ea89
Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) ( #168401 )
...
https://skia.googlesource.com/skia.git/+log/5cf5d0ff46d9..36d1445ad00b
2025-05-06 dloehr@google.com Make sure inline static symbols in headers
are visible
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-06 20:32:20 +00:00
Kostia Sokolovskyi
c781b31320
Add height and width aspects to MediaQuery. ( #167829 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Closes https://github.com/flutter/flutter/issues/167828
### Description
- Adds `widthOf`, `maybeWidthOf`, `heightOf`, `maybeHeightOf` functions
to `MediaQuery`
- Adds tests for newly added functions
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-06 19:35:13 +00:00
engine-flutter-autoroll
ed447e5868
Roll Packages from e064b0400657 to e800da7bccd9 (2 revisions) ( #168392 )
...
e064b04006...e800da7bcc
2025-05-06 43054281+camsim99@users.noreply.github.com
[video_player_android] Modify to use `handlesCropAndRotation` to detect
the `SurfaceTexture` Impeller backend (flutter/packages#9107 )
2025-05-06 stuartmorgan@google.com [various] Update READMEs of
discontinued packages (flutter/packages#9203 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-06 19:05:47 +00:00
Matan Lurey
a401c5ddde
Add bin/internal/last_engine_commit.sh and tests. ( #168387 )
...
Towards https://github.com/flutter/flutter/issues/168273 .
Once merged, the recipes branch (specifically `release_packager.py`) can
use this as a lint.
/cc @reidbaker
2025-05-06 19:04:18 +00:00